[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers updated this revision to Diff 351956. nickdesaulniers added a comment. - add -disable-llvm-passes to unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104253/new/ https://reviews.llvm.org/D104253 Files: clang/lib/CodeGen/Co

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan updated this revision to Diff 351957. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_linux.cpp compiler-rt/lib/hwasan/hwasan_thread.cpp compiler-rt/li

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse mcgrathr wrote: > Most of this code can

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

void added a comment. What are your thoughts on adding a `noprofile` function attribute in the FE? @MaskRay suggested filing a bug with gcov (below) to get their take on it. https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=__open__&component=gcov-profile&list_id=304970&product=gcc Reposi

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan marked an inline comment as not done. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse --

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers updated this revision to Diff 351960. nickdesaulniers added a comment. - rename new test from fprofile-generate.c to fprofile-instrument.c; -fprofile-generate is the driver opt, -fprofile-instrument is the frontend opt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

leonardchan updated this revision to Diff 351961. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103845/new/ https://reviews.llvm.org/D103845 Files: compiler-rt/lib/hwasan/hwasan_report.cpp Index:

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

melver added a comment. In D104253#2817673 , @void wrote: > What are your thoughts on adding a `noprofile` function attribute in the FE? > @MaskRay suggested filing a bug with gcov (below) to get their take on it. > > > https://gcc.gnu.org/bugzilla/bu

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

MaskRay added a comment. `__attribute__((no_instrument_function))` seems specific to `-finstrument-functions`. Somehow `gcc -pg` uses it as well. The name may not be generic, so it may be odd to exclude various instrumentations under this generic attribute. clang -fprofile-instr-generate (fro

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

rnk added a comment. If we look back at the original intention of our MSVC compatibility work, we tried to accept as much invalid code as necessary to parse "system headers". System headers were widely interpreted to bethe MSVC STL, ATL, and the Windows SDK. So, even if MSVC defaults to delayed

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

ABataev created this revision. ABataev added reviewers: lebedev.ri, jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to capture locals in aligned clauses for the combined direc

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

lebedev.ri added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104258/new/ https://reviews.llvm.org/D104258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

erichkeane added a comment. Just a couple of nits here, basically see how much we can put in the 'cheap to check' branch. Comment at: clang/lib/CodeGen/CGExpr.cpp:1944 +llvm::Value *Idx = LV.getMatrixIdx(); +const auto MatTy = LV.getType()->getAs(); +llvm::MatrixBu

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

HazardyKnusperkeks added a comment. Could you split this into two diffs? Or are those two changes in any way related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242 _

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We allow branches to join where one holds a managed lock but the other doesn't, but we c

[PATCH] D98068: Exampt asserts for recursive lambdas about LocalInstantiationScope

rsmith added a comment. I think this is the wrong solution; I think the assertion is correct and is observing a problem elsewhere. Imagine if we had something like: template void f() { auto a = [] (auto recurse, auto x) { auto b = [] (auto) { refer to local decl in a

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:868 ThreadSafetyHandler &Handler) const override { -if (!managed() && !asserted() && !negative() && !isUniversal()) { +if (!asserted() && !negative() && !i

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

feg208 added a comment. In D104242#2817815 , @HazardyKnusperkeks wrote: > Could you split this into two diffs? Or are those two changes in any way > related? I can if you'd like. They are related in the sense that the dead code yielded warnings in the

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

feg208 updated this revision to Diff 351982. feg208 added a comment. Looks like the dead code is removed in main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242 Files: clang/test/Format/struct-array-ini

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

jsji added a comment. Done in https://reviews.llvm.org/D103707? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99483/new/ https://reviews.llvm.org/D99483 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 00dbf8c - Adding some of the documents for C11.

Author: Aaron Ballman Date: 2021-06-14T16:43:44-04:00 New Revision: 00dbf8c83218829633b9f2ec1ee94a1f3b8dd29c URL: https://github.com/llvm/llvm-project/commit/00dbf8c83218829633b9f2ec1ee94a1f3b8dd29c DIFF: https://github.com/llvm/llvm-project/commit/00dbf8c83218829633b9f2ec1ee94a1f3b8dd29c.diff

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 351989. NeHuang added a comment. Rebased the patch with changes in https://reviews.llvm.org/D104125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 Files: clang/inc

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers added a comment. In D104253#2817695 , @MaskRay wrote: > `__attribute__((no_instrument_function))` seems specific to > `-finstrument-functions`. Somehow `gcc -pg` uses it as well. > > The name may not be generic, so it may be odd to exclu

[PATCH] D98068: Exampt asserts for recursive lambdas about LocalInstantiationScope

yaxunl updated this revision to Diff 351990. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Richard's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98068/new/ https://reviews.llvm.org/D98068 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.c

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103845/new/ https://reviews.llvm.org/D103845 ___ cfe-c

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104258/new/ https://reviews.llvm.org/D104258 ___

[clang] 0577f4b - [Hexagon] Add HVX and control register names to Hexagon target

Author: Krzysztof Parzyszek Date: 2021-06-14T17:14:37-05:00 New Revision: 0577f4b1789eff410f5b28434a4f7854a50dc639 URL: https://github.com/llvm/llvm-project/commit/0577f4b1789eff410f5b28434a4f7854a50dc639 DIFF: https://github.com/llvm/llvm-project/commit/0577f4b1789eff410f5b28434a4f7854a50dc639

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. In D99696#2817126 , @rjmccall wrote: > When `__block` variables get moved to the heap, they're supposed to be moved > if possible, not copied. It looks like PerformMoveOrCopyInitialization > requires NRVO info to be passed in t

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 352007. ellis added a comment. MIP does not support windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td clang/inclu

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 352010. AndreyChurbanov added a comment. Fixed backwards compatibility problem introduced by previous version of the patch. That is restored the size of task dependence flag to 8 bits in clang, and instead changed the size of the flag in the library

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri added a subscriber: MaskRay. lebedev.ri added a comment. In D104099#2815531 , @wenlei wrote: > In D104099#2814167 , @davidxl wrote: > >> Adding Wei to help measure performance impact on our internal wor

Re: [PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a subscriber: MaskRay. > lebedev.ri added a comment. > > In D104099#2815531 , @wenlei > wrote: > > > In D104099#2814167

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan updated this revision to Diff 352015. leonardchan marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_linux.cpp compile

Re: [PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li wrote: > > > On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < > revi...@reviews.llvm.org> wrote: > >> lebedev.ri added a subscriber: MaskRay. >> lebedev.ri added a comment. >> >> In D104099#2815531

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak added a comment. C++ non-virtual thunks and global initialization functions (`_GLOBAL__sub_I_*`) have only linkage names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/ https://reviews.llvm.org/D104082

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rG312011899ac3: [compiler-rt][hwasan] Add newline between record_addr lines on frame record… (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] b8919fb - [NFC][sanitizer] clang-format some code

Author: Vitaly Buka Date: 2021-06-14T18:05:22-07:00 New Revision: b8919fb0eac15d13c5f56d3d30ce378a588dd78c URL: https://github.com/llvm/llvm-project/commit/b8919fb0eac15d13c5f56d3d30ce378a588dd78c DIFF: https://github.com/llvm/llvm-project/commit/b8919fb0eac15d13c5f56d3d30ce378a588dd78c.diff L

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL; I think for non-strict DWAR

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

vitalybuka added inline comments. Comment at: clang/test/Format/struct-array-initializer.cpp:5 +// RUN: grep -Ev "// *[A-Z-]+:" %s \ +// RUN: | clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Left}" %s \ +// RUN: | FileCheck -strict-whitespace -check-prefix

[PATCH] D104275: [compiler-rt][hwasan] Add SHADOW_OFFSET macro

leonardchan created this revision. leonardchan added reviewers: vitalybuka, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Similar to `SHADOW_OFFSET` on asan, we can use thi

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added inline comments. Comment at: clang/test/Format/struct-array-initializer.cpp:5 +// RUN: grep -Ev "// *[A-Z-]+:" %s \ +// RUN: | clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Left}" %s \ +// RUN: | FileCheck -strict-whitespace -check-prefix=CHE

[clang] 79f9cfb - Do not merge LocalInstantiationScope for template specialization

Author: Yaxun (Sam) Liu Date: 2021-06-14T23:28:04-04:00 New Revision: 79f9cfbc21e02555258523ea77c3dd389891cfb3 URL: https://github.com/llvm/llvm-project/commit/79f9cfbc21e02555258523ea77c3dd389891cfb3 DIFF: https://github.com/llvm/llvm-project/commit/79f9cfbc21e02555258523ea77c3dd389891cfb3.dif

[PATCH] D98068: Do not merge LocalInstantiationScope for template specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f9cfbc21e0: Do not merge LocalInstantiationScope for template specialization (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:207 + +const auto PtrVal = C.getSValBuilder().conjureSymbolVal( +Call.getOriginExpr(), C.getLocationContext(), Can you do a `getConjuredHeapSymbolVal()` inst

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:777 static bool classof(const ProgramPointTag *T) { return T->getTagKind() == &Kind; } vsavchenko wrote: > NoQ wrote: > > NoQ wrote: > > > It soun

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103644/new/ https://reviews.llvm.org/D103644 ___

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

vitalybuka created this revision. Herald added subscribers: phosek, jfb, fedor.sergeev, hiraditya, krytarowski, mgorny. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG L

[PATCH] D103961: [analyzer] Extract InlinedFunctionCallHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103961/new/ https://reviews.llvm.org/D103961 ___ cfe-

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1299 + } else if (SI.Value.isUndef()) { +OS << "uninitialized value"; +

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

dblaikie added inline comments. Comment at: llvm/test/Linker/warn-stack-frame.ll:6 + +; CHECK-MISMATCH: error: linking module flags 'warn-stack-size': IDs have conflicting values + If you like, you could make this a function attribute instead, that way it'd be

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks correct, thanks! I think there are some weird rules with respect to `[[no_unique_address]]` on two consecutive fields when there's only one other field in the structure, eg. struct S {

[PATCH] D104275: [compiler-rt][hwasan] Add SHADOW_OFFSET macro

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:57 extern uptr kAliasRegionStart; Maybe the following to minimize code which compiles only on limited set of platforms? ``` inline uptr GetShadowOffset() { return SANIT

[PATCH] D104242: Alters a lit test to simplify and avoid a buildbot error

feg208 added a comment. I don’t have commit rights currently. Could I get someone to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242 __

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

sberg added a comment. (In a build prior to https://reviews.llvm.org/rGc60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 "Revert '[clang] NRVO: Improvements and handling of more cases.'") I see the following (reduced from https://git.libreoffice.org/core/+/649313625b94e6b879848fc19b607b74375100bf/o3tl/

<    1   2