[PATCH] D103849: Fix undeduced type when instanciating template member

2021-06-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I think this is reasonable, but I'd like to hear from @rsmith before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-com

[clang] f2cc042 - [HIP] Fix --hip-version flag with 0 as component

2021-06-11 Thread Aaron En Ye Shi via cfe-commits
Author: Aaron En Ye Shi Date: 2021-06-11T16:25:03Z New Revision: f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9 URL: https://github.com/llvm/llvm-project/commit/f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9 DIFF: https://github.com/llvm/llvm-project/commit/f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9.diff LO

[PATCH] D104062: [HIP] Fix --hip-version flag with 0 as component

2021-06-11 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf2cc0427b13e: [HIP] Fix --hip-version flag with 0 as component (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

2021-06-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. A new nits but I'd say it was pretty good. Comment at: clang/lib/Format/Format.cpp:1356 Style.PointerAlignment = FormatStyle::PAS_Left; + Style.ReferenceAlignment = FormatStyle::RAS_Pointer; Style.SpaceBeforeCpp11BracedList = true; ---

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-11 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD updated this revision to Diff 351485. RedDocMD added a comment. Removed un-necessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModel

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

2021-06-11 Thread Darwin Xu via Phabricator via cfe-commits
darwin added a comment. In D104044#2813491 , @MyDeveloperDay wrote: > Devils advocate how is this any different from > > class Foo { > > class Bar {} ; > } > > }; > > This would become > > class Foo { > class Bar {}; > }; > > i.e.

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

2021-06-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. Some backends don't run SimplifyCFG, e.g. X86. I believe the pass was originally created specifically for X86 (the header has some X86 examples) and may or may not extend to other targets (I'm not very familiar with the pass itself). I'm not opposed to landing this an

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

2021-06-11 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D104099#2813713 , @aeubanks wrote: > Some backends don't run SimplifyCFG, e.g. X86. I believe the pass was > originally created specifically for X86 (the header has some X86 examples) > and may or may not extend to other t

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

2021-06-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. FWIW, it was pointed out to me that the commit message doesn't precisely match the actual attribute name. The actual attribute name is `warn-stack-size`, but the commit message uses `-warn-frame-size`. Oh well. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D101479: [Driver] Support libc++ in MSVC

2021-06-11 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1014

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

2021-06-11 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx updated this revision to Diff 351491. chrish_ericsson_atx added a comment. Corrected APSInt.toString() usage to comply with intervening change 61cdaf66fe22be2b5 Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

2021-06-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. Which pass that comes after SpeculateAroundPHIs in the X86 pipeline (either in the optimization or codegen) would undo its effects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D10409

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-06-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D103184#2804241 , @jcai19 wrote: > In D103184#2803768 , @thakis wrote: > >> FWIW the failure goes away locally if I revert this change here, so it's >> definitely due to this change her

[clang] ce44fe1 - [Sema] Address-space sensitive check for unbounded arrays (v2)

2021-06-11 Thread via cfe-commits
Author: eahcmrh Date: 2021-06-11T19:34:03+02:00 New Revision: ce44fe199bbfd4b5a44764b678c431fdc117116a URL: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a DIFF: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a.diff LOG:

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

2021-06-11 Thread Chris Hamilton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce44fe199bbf: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorep

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

2021-06-11 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D104099#2813743 , @aeubanks wrote: > Which pass that comes after SpeculateAroundPHIs in the X86 pipeline (either > in the optimization or codegen) would undo its effects? As i have wrote in some other review, the pass i sa

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

2021-06-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. My point being there is inconsistency between how different types of blocks of code are handled, and rather than trying to fix another corner case maybe we should take a more holistic approach, all these KeepEmptyLines and EmptyLineAfterXXX options and what you'l

[PATCH] D101479: [Driver] Support libc++ in MSVC

2021-06-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D101479#2813724 , @mstorsjo wrote: > Couldn’t this commit have been kept in, and just reverting the one for using > it in the fuchsia cmake cache? (I’m not using this particular commit myself, > just observing.) The problem i

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

2021-06-11 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

2021-06-11 Thread Kevin Athey via Phabricator via cfe-commits
kda updated this revision to Diff 351505. kda marked 9 inline comments as done. kda added a comment. - fixed up conflicting command line parameters. - only emit asan_stack_malloc calls when needed. - trimmed namespace ('llvm'). - improved tests. - Changed default parameters from Never to Runtime.

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

2021-06-11 Thread Kevin Athey via Phabricator via cfe-commits
kda added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2973 IRBuilder<> IRB(*C); - switch (ClUseAfterReturn) { - case AsanDetectStackUseAfterReturnMode::Always: -for (int i = 0; i <= kMaxAsanStackMallocSizeClass; i++) { - std

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

2021-06-11 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

2021-06-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. Ah, sorry I missed where you mentioned LSR. If this pass is causing regressions in multiple places, even on X86, then I think it does make sense to remove it. I've added some people that m

[PATCH] D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers.

2021-06-11 Thread Felix Berger via Phabricator via cfe-commits
flx added a comment. In D103087#2793673 , @ymandel wrote: > I have some concerns about the cost of this checks as it used matching over > entire contexts quite extensively. At this point, the facilities involved > seem quite close to doing dataflow ana

[PATCH] D101479: [Driver] Support libc++ in MSVC

2021-06-11 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D101479#2813797 , @phosek wrote: > In D101479#2813724 , @mstorsjo > wrote: > >> Couldn’t this commit have been kept in, and just reverting the one for using >> it in the fuchsia cmak

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

2021-06-11 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 351510. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/l

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

2021-06-11 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + +uptr kHighMemEnd; +uptr kHighMemBeg; mcgrathr wrote: > These need comments about what they are and why they need to exist as runtime > variables at all. `kHighMemEnd`

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:201-202 +const TypedValueRegion *TVR = llvm::dyn_cast(ThisRegion); +assert(TVR && "expected std::make_unique to return a std::unique_ptr " + "object (which is ty

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

2021-06-11 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 351512. vsavchenko marked 2 inline comments as done. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103644/new/ https://reviews.llvm.org/D103644 Files: clang/

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

2021-06-11 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 351515. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104046/new/ https://reviews.llvm.org/D104046 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

2021-06-11 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D104082#2812088 , @ahatanak wrote: > Also, is it okay to emit the `linkageName`, but not the `name` for the helper > functions? It seems okay to me, but I'm not sure. Not 100% sure - perhaps @aprantl can weigh in on this. If

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

2021-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:777 static bool classof(const ProgramPointTag *T) { return T->getTagKind() == &Kind; } It sounds like `NoteTag` `isn't` despite inheriting from it

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

2021-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression... +

[PATCH] D103131: support debug info for alias variable

2021-06-11 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D103131#2811969 , @kamleshbhalui wrote: > In D103131#2811220 , @dblaikie > wrote: > >> Any idea if the GDB test suite covers this functionality? I'd hope so, but >> maybe it doesn't

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

2021-06-11 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Going the full way, to fix the number of empty lines after/before/between elements would be real nice. But even nicer would be if you can state a range. But I think all those proposed options should not be added in one go. In D104044#2812399

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

2021-06-11 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx added a comment. I'm aware that this commit triggers one failure in ASan/Windows -- I have posted a patch for review to address that here: https://reviews.llvm.org/D104141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

2021-06-11 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D103888#2813236 , @RKSimon wrote: > In D103888#2811305 , @dblaikie > wrote: > >> Sounds OK. >> >> I wouldn't mind the places that can use op<< to use that - not sure >> preserving th

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

2021-06-11 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Can you also add tests with the alignment of declarations? We already have such for pointers. Comment at: clang/include/clang/Format/Format.h:2706 + /// references). + ReferenceAlignmentStyle ReferenceAlignment; + Please m

[clang] e0b469f - [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

2021-06-11 Thread Kevin Athey via cfe-commits
Author: Kevin Athey Date: 2021-06-11T12:07:35-07:00 New Revision: e0b469ffa142353fc90bfc6eadb638a805ebed75 URL: https://github.com/llvm/llvm-project/commit/e0b469ffa142353fc90bfc6eadb638a805ebed75 DIFF: https://github.com/llvm/llvm-project/commit/e0b469ffa142353fc90bfc6eadb638a805ebed75.diff L

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

2021-06-11 Thread Kevin Athey via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b469ffa142: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang. (authored by kda). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

2021-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. P.S. I like this design! I'm trying to remember why we needed a factory in the first place. I think a lot of tags work just fine as static variables. In case of D104136

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-06-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D103184#2813748 , @thakis wrote: > In D103184#2804241 , @jcai19 wrote: > >> In D103184#2803768 , @thakis wrote: >> >>> FWIW the failure

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

2021-06-11 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. Adding Wei to help measure performance impact on our internal workloads. Also add Wenlei to help measure impact with FB's workloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D1040

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

2021-06-11 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D104135#2814081 , @NoQ wrote: > P.S. I like this design! > > I'm trying to remember why we needed a factory in the first place. Who's gonna carry your callbacks for ya, huh? > I think a lot of tags work just fine as static

[clang] 22dea69 - [clang][ObjC] allow the use of NSAttributedString * argument type with format attribute

2021-06-11 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2021-06-11T13:24:32-07:00 New Revision: 22dea6923155b18d172db64e5dab4b71afe19e6e URL: https://github.com/llvm/llvm-project/commit/22dea6923155b18d172db64e5dab4b71afe19e6e DIFF: https://github.com/llvm/llvm-project/commit/22dea6923155b18d172db64e5dab4b71afe19e6e.diff L

[PATCH] D104138: Create install targets for scan-build-py.

2021-06-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104138/new/ https://reviews.llvm.org/D104138 ___

[PATCH] D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

2021-06-11 Thread Michael Benfield via Phabricator via cfe-commits
mbenfield updated this revision to Diff 351563. mbenfield added a comment. rebase and rerun builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103623/new/ https://reviews.llvm.org/D103623 Files: clang/test/Sema/warn-unused-but-set-variables.c

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-11 Thread Kevin Athey via Phabricator via cfe-commits
kda created this revision. kda added a reviewer: vitalybuka. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. for issue: https://github.com/google/sanitizers/issues/1394 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: clang/docs/AddressSanitizer.rst:18 +* Use-after-return (clang flag `-fsanitize-address-use-after-return=(always|runtime|never)` default: runtime) + * Add runtime flag `ASAN_OPTIONS=detect_stack_use_after_return=1` to enable when co

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-11 Thread Kevin Athey via Phabricator via cfe-commits
kda updated this revision to Diff 351571. kda marked an inline comment as done. kda added a comment. - Revised according to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clang/docs/Ad

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

2021-06-11 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added a comment. Usually we like to split changes up into separate small changes for the pure refactoring, and then changes that purely add new Fuchsia-specific code. I'll do an initial review round of the Fuchsia code here since you've sent it. But then I think this review should be t

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

2021-06-11 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + +uptr kHighMemEnd; +uptr kHighMemBeg; leonardchan wrote: > mcgrathr wrote: > > These need comments about what they are and why they need to exist as > > runtime variables

[PATCH] D103131: support debug info for alias variable

2021-06-11 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui added a comment. In D103131#2814015 , @dblaikie wrote: > In D103131#2811969 , @kamleshbhalui > wrote: > >> In D103131#2811220 , @dblaikie >> wrote: >> >>>

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

2021-06-11 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth added a comment. This patch was reverted a while back because a couple DirectoryWatcher tests routinely timed out on build bots even though they work when run in isolation. I believe the problem is that, on a machine busy doing a build, the startup of the watcher thread is delayed (eit

[PATCH] D104088: Add clang frontend flags for MIP

2021-06-11 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 351604. ellis added a comment. Move llvm-strip logic into its own commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td

[PATCH] D98618: [clang-tidy] Add --skip-headers, part 1

2021-06-11 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 351615. chh added a comment. Herald added a subscriber: cfe-commits. sync with latest clang/llvm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98618/new/ https://reviews.llvm.org/D98618 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1

2021-06-11 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 351616. chh retitled this revision from "WIP; clang-tidy skip-headers; Alt#2; need more changes" to "[clang-tidy] Add --skip-headers, part 1". chh edited the summary of this revision. chh added a comment. Herald added subscribers: cfe-commits, xazax.hun. sync wit

[PATCH] D98709: [clang-tidy] Add --skip-headers, part 1

2021-06-11 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 351617. chh retitled this revision from "clang-tidy skip-headers; Alt#1; fewer changes" to "[clang-tidy] Add --skip-headers, part 1". chh edited the summary of this revision. chh added a comment. Herald added subscribers: cfe-commits, xazax.hun. sync with latest

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/AddressSanitizer.rst:17 * Use-after-free -* Use-after-return (runtime flag `ASAN_OPTIONS=detect_stack_use_after_return=1`) +* Use-after-return (clang flag `-fsanitize-address-use-after-return=(always|runtime|never)` default

[PATCH] D98618: [clang-tidy] Add --skip-headers, part 1 (with TopLevelDecl bit)

2021-06-11 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh added a comment. Please review https://reviews.llvm.org/D98710, which uses get/setTraversalScope instead of adding a TopLevelDecl bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98618/new/ https://reviews.llvm.org/D98618 ___ cfe-commi

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-11 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD updated this revision to Diff 351628. RedDocMD added a comment. Fixed up technique used to find inner pointer type, put TODO's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/S

<    1   2