[PATCH] D104088: Add clang frontend flags for MIP

jhenderson added inline comments. Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:59 + StringRef(Sec.Name).startswith(".zdebug") || + Sec.Name == ".gdb_index" || Sec.Name == "__llvm_mipmap"; } This doesn't look like it belongs as part of t

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 351349. RedDocMD added a comment. Put changes discussed in the meeting, tests to come in next revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski created this revision. skirkovski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a roll-forward of D90238 originally implemented by @mrexodia and @catskul This introduces `ReferenceAli

[clang] 0d5af7a - Revert "[CMake] Don't use libc++ by default on Windows yet"

Author: Petr Hosek Date: 2021-06-11T00:45:49-07:00 New Revision: 0d5af7a4caaf19ff97ca90e9ca7f2b78a858ab07 URL: https://github.com/llvm/llvm-project/commit/0d5af7a4caaf19ff97ca90e9ca7f2b78a858ab07 DIFF: https://github.com/llvm/llvm-project/commit/0d5af7a4caaf19ff97ca90e9ca7f2b78a858ab07.diff LO

[clang] 22f1949 - Revert "[Driver] Support libc++ in MSVC"

Author: Petr Hosek Date: 2021-06-11T00:45:56-07:00 New Revision: 22f194909ae24aed817976fb54b759550e90db36 URL: https://github.com/llvm/llvm-project/commit/22f194909ae24aed817976fb54b759550e90db36 DIFF: https://github.com/llvm/llvm-project/commit/22f194909ae24aed817976fb54b759550e90db36.diff LO

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 351356. RedDocMD added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp clang

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

hokein added a comment. In D104071#2811827 , @sammccall wrote: > This includes both the traversal change and the clangd changes to adapt to > it, since there ended up being few. > > I chickened out of the idea of changing the behavior of > TranslationUn

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. Just so I'm clear are you proposing that a newlines should always be added or that single blank lines should be ignored? I can't tell if the bug is that the line isn't being removed or sometimes not being added, either way there will be someone who wants it the o

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. How do I set the C++ standard while running a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 ___ cfe-commits mailing list cfe-c

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

teemperor added a comment. In D103750#2812613 , @RedDocMD wrote: > How do I set the C++ standard while running a test? If I understand your language correctly, then see my inline comment. Comment at: clang/test/Analysis/smart-ptr-text

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

jubnzv created this revision. jubnzv added reviewers: steakhal, NoQ, vsavchenko, Szelethus, xazax.hun, balazske. jubnzv added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. jubnzv req

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

RKSimon added a comment. I don't know much about target feature inheritance - does this guarantee that the entire sse/avx/avx512 level chain is correctly disabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2047 + +// TODO: get rid of it. +const DeclStmt *DS = nullptr; NoQ wrote: > WDYM? > > Also maybe downscope it? I meant that the only client for it is unde

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

sammccall updated this revision to Diff 351365. sammccall marked an inline comment as done. sammccall added a comment. Expand/clarify comments and variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104071/new/ https://reviews.llvm.org/D10

[clang-tools-extra] 47d138c - [clang-tidy] LIT test fix for Remark diagnostic

Author: Ivan Murashko Date: 2021-06-11T02:02:36-07:00 New Revision: 47d138c93992f779a5dd0810b0e7402e043df61d URL: https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d DIFF: https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d.diff

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic (authored by ivanmurashko, committed by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri created this revision. lebedev.ri added reviewers: thopre, bjope, nikic, chandlerc, aeubanks. lebedev.ri added a project: LLVM. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya. lebedev.ri requested review of this revision. Herald added a project: clang. Herald added a subs

[clang] ca964b4 - [OpenCL][NFC] Reorganize ClangOpenCLBuiltinEmitter comments

Author: Sven van Haastregt Date: 2021-06-11T10:22:59+01:00 New Revision: ca964b40e6e5d20fb658f2d36238b46a35dd860f URL: https://github.com/llvm/llvm-project/commit/ca964b40e6e5d20fb658f2d36238b46a35dd860f DIFF: https://github.com/llvm/llvm-project/commit/ca964b40e6e5d20fb658f2d36238b46a35dd860f.

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. In D104044#2812612 , @MyDeveloperDay wrote: > Just so I'm clear are you proposing that a newlines should always be added or > that single blank lines should be ignored? I can't tell if the bug is that > the line isn't being remo

[clang] 56d5c46 - [X86] Support __tile_stream_loadd intrinsic for new AMX interface

Author: Bing1 Yu Date: 2021-06-11T17:28:43+08:00 New Revision: 56d5c46b494d2232792a46e9b95de40b082f4164 URL: https://github.com/llvm/llvm-project/commit/56d5c46b494d2232792a46e9b95de40b082f4164 DIFF: https://github.com/llvm/llvm-project/commit/56d5c46b494d2232792a46e9b95de40b082f4164.diff LOG:

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56d5c46b494d: [X86] Support __tile_stream_loadd intrinsic for new AMX interface (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103677: [analyzer] Extract ControlDependencyHandler

vsavchenko updated this revision to Diff 351374. vsavchenko marked an inline comment as done. vsavchenko added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103677/new/ https://reviews.llvm.org/D103677 Files: clang/lib/Sta

[PATCH] D104101: clang-format: [JS] don't sort named imports if off.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst requested review of this revision. Herald added a project: clang. The previous implementation would accidentally still sort the individual named imports, even if the module reference was in a clang-format off block. Repos

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 351376. RedDocMD added a comment. Fixed up tests, now also runnning on C++20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/Checke

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:4 // RUN: -analyzer-config cplusplus.SmartPtrModeling:ModelSmartPtrDereference=true\ // RUN: -analyzer-output=text -std=c++11 %s -verify=expec

[clang] 0cc3100 - [analyzer] Introduce a new interface for tracking

Author: Valeriy Savchenko Date: 2021-06-11T12:49:03+03:00 New Revision: 0cc3100bf8d126ce080c0075cf25784b45e5f990 URL: https://github.com/llvm/llvm-project/commit/0cc3100bf8d126ce080c0075cf25784b45e5f990 DIFF: https://github.com/llvm/llvm-project/commit/0cc3100bf8d126ce080c0075cf25784b45e5f990.d

[clang] 967c06b - [analyzer] Reimplement trackExpressionValue as ExpressionHandler

Author: Valeriy Savchenko Date: 2021-06-11T12:49:03+03:00 New Revision: 967c06b3e95ba776fb06ad0ea5aa699cf2e1b59a URL: https://github.com/llvm/llvm-project/commit/967c06b3e95ba776fb06ad0ea5aa699cf2e1b59a DIFF: https://github.com/llvm/llvm-project/commit/967c06b3e95ba776fb06ad0ea5aa699cf2e1b59a.d

[clang] b6bcf95 - [analyzer] Change FindLastStoreBRVisitor to use Tracker

Author: Valeriy Savchenko Date: 2021-06-11T12:49:03+03:00 New Revision: b6bcf953220db7880f2bb508f6f5c02b41078b2c URL: https://github.com/llvm/llvm-project/commit/b6bcf953220db7880f2bb508f6f5c02b41078b2c DIFF: https://github.com/llvm/llvm-project/commit/b6bcf953220db7880f2bb508f6f5c02b41078b2c.d

[clang] 87a5c4d - [analyzer] Hide and rename FindLastStoreBRVisitor

Author: Valeriy Savchenko Date: 2021-06-11T12:49:03+03:00 New Revision: 87a5c4d3745a06ec0594fa3f7aaf7f58a53315ec URL: https://github.com/llvm/llvm-project/commit/87a5c4d3745a06ec0594fa3f7aaf7f58a53315ec DIFF: https://github.com/llvm/llvm-project/commit/87a5c4d3745a06ec0594fa3f7aaf7f58a53315ec.d

[clang] f853d26 - [analyzer] Turn ReturnVisitor into a tracking visitor

Author: Valeriy Savchenko Date: 2021-06-11T12:49:03+03:00 New Revision: f853d2601abd4f6ab789ca1513ae8b59ba5d38b7 URL: https://github.com/llvm/llvm-project/commit/f853d2601abd4f6ab789ca1513ae8b59ba5d38b7 DIFF: https://github.com/llvm/llvm-project/commit/f853d2601abd4f6ab789ca1513ae8b59ba5d38b7.d

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cc3100bf8d1: [analyzer] Introduce a new interface for tracking (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3fc8d94 - [analyzer] Refactor trackRValueExpression into ExpressionHandler

Author: Valeriy Savchenko Date: 2021-06-11T12:49:04+03:00 New Revision: 3fc8d943c360f801a428ff24569d2dd53a2afe0f URL: https://github.com/llvm/llvm-project/commit/3fc8d943c360f801a428ff24569d2dd53a2afe0f DIFF: https://github.com/llvm/llvm-project/commit/3fc8d943c360f801a428ff24569d2dd53a2afe0f.d

[clang] 51d4704 - [analyzer] Turn TrackControlDependencyCond into a tracking visitor

Author: Valeriy Savchenko Date: 2021-06-11T12:49:04+03:00 New Revision: 51d4704d5ec9b8e4e5e445ee69c56a58250e370e URL: https://github.com/llvm/llvm-project/commit/51d4704d5ec9b8e4e5e445ee69c56a58250e370e DIFF: https://github.com/llvm/llvm-project/commit/51d4704d5ec9b8e4e5e445ee69c56a58250e370e.d

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rG967c06b3e95b: [analyzer] Reimplement trackExpressionValue as ExpressionHandler (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103616?vs=351121&id=351378#toc Repository:

[clang] 57006d2 - [analyzer] Refactor trackExpressionValue to accept TrackingOptions

Author: Valeriy Savchenko Date: 2021-06-11T12:49:04+03:00 New Revision: 57006d2f6d96d8a6836ae901218ed615071b3b8e URL: https://github.com/llvm/llvm-project/commit/57006d2f6d96d8a6836ae901218ed615071b3b8e DIFF: https://github.com/llvm/llvm-project/commit/57006d2f6d96d8a6836ae901218ed615071b3b8e.d

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6bcf953220d: [analyzer] Change FindLastStoreBRVisitor to use Tracker (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D103624: [analyzer] Hide and rename FindLastStoreBRVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG87a5c4d3745a: [analyzer] Hide and rename FindLastStoreBRVisitor (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103624?vs=349654&id=351380#toc Repository: rG LLVM Github

[PATCH] D103628: [analyzer] Turn ReturnVisitor into a tracking visitor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf853d2601abd: [analyzer] Turn ReturnVisitor into a tracking visitor (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fc8d943c360: [analyzer] Refactor trackRValueExpression into ExpressionHandler (authored by vsavchenko). Changed prior to commit: https://reviews.

[PATCH] D103631: [analyzer] Turn TrackControlDependencyCond into a tracking visitor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51d4704d5ec9: [analyzer] Turn TrackControlDependencyCond into a tracking visitor (authored by vsavchenko). Repository: rG LLVM Github Monorepo CH

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57006d2f6d96: [analyzer] Refactor trackExpressionValue to accept TrackingOptions (authored by vsavchenko). Changed prior to commit: https://review

[clang] 63042d4 - clang-format: [JS] don't sort named imports if off.

Author: Martin Probst Date: 2021-06-11T12:02:33+02:00 New Revision: 63042d46bb0c2481a8b7aa1c324405c2720b3603 URL: https://github.com/llvm/llvm-project/commit/63042d46bb0c2481a8b7aa1c324405c2720b3603 DIFF: https://github.com/llvm/llvm-project/commit/63042d46bb0c2481a8b7aa1c324405c2720b3603.diff

[PATCH] D100829: [analyzer][docs] Highlight some differences between ArrayBound and V2

Szelethus requested changes to this revision. Szelethus added inline comments. This revision now requires changes to proceed. Herald added a subscriber: manas. Comment at: clang/docs/analyzer/checkers.rst:2107 - // note: requires unix.Malloc or - // alpha.unix.MallocWithAnnotat

[PATCH] D104101: clang-format: [JS] don't sort named imports if off.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63042d46bb0c: clang-format: [JS] don't sort named imports if off. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] b102e68 - [OpenCL] Fix overloading resolution of addrspace constructors

Author: Ole Strohm Date: 2021-06-11T11:12:33+01:00 New Revision: b102e6880ab06654f945284a520f68c099732f44 URL: https://github.com/llvm/llvm-project/commit/b102e6880ab06654f945284a520f68c099732f44 DIFF: https://github.com/llvm/llvm-project/commit/b102e6880ab06654f945284a520f68c099732f44.diff LO

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rGb102e6880ab0: [OpenCL] Fix overloading resolution of addrspace constructors (authored by olestrohm). Changed prior to commit: https://reviews.llvm.org/D102850?vs=351165&id=351388#toc Repository: rG L

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Per https://reviews.llvm.org/harbormaster/unit/view/779496/, window test seems to be failing... Thanks! I think we should probably document this RAV behavior change in the release note. Rep

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

nikic added a comment. Looks like phase ordering tests need an update. Comment at: llvm/lib/Passes/PassBuilder.cpp:1449 - // inserting redundancies into the program. This even includes SimplifyCFG. - OptimizePM.addPass(SpeculateAroundPHIsPass()); - As it has

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1449 - // inserting redundancies into the program. This even includes SimplifyCFG. - OptimizePM.addPass(SpeculateAroundPHIsPass()); - nikic wrote: > As it has been in-tree for a while

[PATCH] D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There's no need to pass `DependencyOutputOptions` to each call of `handleFileDe

[PATCH] D104106: [clang][deps] NFC: Stop using moved-from object

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanning worker uses `std::move` to "reset" `DependencyOutputOpt

[clang] 691ba0f - [clang][NFC] Avoid assignment in condition

Author: Nathan Sidwell Date: 2021-06-11T03:53:55-07:00 New Revision: 691ba0f8acb511f7da1e78c59fe9560b64c47f3a URL: https://github.com/llvm/llvm-project/commit/691ba0f8acb511f7da1e78c59fe9560b64c47f3a DIFF: https://github.com/llvm/llvm-project/commit/691ba0f8acb511f7da1e78c59fe9560b64c47f3a.diff

[PATCH] D104039: Avoid assignment in conditional

This revision was automatically updated to reflect the committed changes. Closed by commit rG691ba0f8acb5: [clang][NFC] Avoid assignment in condition (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 1a53fb0 - [clang-tidy] NarrowingConversionsCheck should support inhibiting conversions of

Author: Haojian Wu Date: 2021-06-11T13:02:48+02:00 New Revision: 1a53fb0596abf4a8a9d5b4633cd5a8dc04f5e602 URL: https://github.com/llvm/llvm-project/commit/1a53fb0596abf4a8a9d5b4633cd5a8dc04f5e602 DIFF: https://github.com/llvm/llvm-project/commit/1a53fb0596abf4a8a9d5b4633cd5a8dc04f5e602.diff LO

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a53fb0596ab: [clang-tidy] NarrowingConversionsCheck should support inhibiting conversions of (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D103894?vs=351030&id=351400#toc Rep

[PATCH] D101816: [clangd] don't rename if the triggering loc is not actually being renamed.

hokein updated this revision to Diff 351408. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101816/new/ https://reviews.llvm.org/D101816 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-ex

[clang-tools-extra] d30c202 - [clangd] don't rename if the triggering loc is not actually being renamed.

Author: Haojian Wu Date: 2021-06-11T13:51:50+02:00 New Revision: d30c202d276db86d741734954d1957e7dbbf123c URL: https://github.com/llvm/llvm-project/commit/d30c202d276db86d741734954d1957e7dbbf123c DIFF: https://github.com/llvm/llvm-project/commit/d30c202d276db86d741734954d1957e7dbbf123c.diff LO

[PATCH] D101816: [clangd] don't rename if the triggering loc is not actually being renamed.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked 3 inline comments as done. Closed by commit rGd30c202d276d: [clangd] don't rename if the triggering loc is not actually being renamed. (authored by hokein

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

teemperor added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:164 + const auto *MethodDecl = dyn_cast_or_null(Call.getDecl()); + if (!MethodDecl || !MethodDecl->getParent()) +return {}; `getParent()` will assert when th

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

DNS320 created this revision. DNS320 added reviewers: aaron.ballman, njames93, alexfh. DNS320 added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. DNS320 requested review of this revision. Herald added a subscriber: cfe-commits. This check tr

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

sammccall added a comment. This seems correct but it also seems like it makes setting all the args of a CallExpr into a quadratic operation. e.g. ConvertArgumentForCall and BuildResolvedCallExpr in SemaExpr seem to do this (not just missing/changed args) and are probably on common code paths. It

[clang-tools-extra] 61cdaf6 - [ADT] Remove APInt/APSInt toString() std::string variants

Author: Simon Pilgrim Date: 2021-06-11T13:19:15+01:00 New Revision: 61cdaf66fe22be2b5942ddee4f46a998b4f3ee29 URL: https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29 DIFF: https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29.diff

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61cdaf66fe22: [ADT] Remove APInt/APSInt toString() std::string variants (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

sammccall added a comment. In D104071#2812870 , @hokein wrote: > Per https://reviews.llvm.org/harbormaster/unit/view/779496/, window test > seems to be failing... Oops, there was a test I forgot to update (failed on all platforms). Fixed. > Thanks! I t

[clang] 6aca603 - [AST] Include the TranslationUnitDecl when traversing with TraversalScope

Author: Sam McCall Date: 2021-06-11T14:29:45+02:00 New Revision: 6aca6032c5b62b5d26999da5f55779a1b08ec6a2 URL: https://github.com/llvm/llvm-project/commit/6aca6032c5b62b5d26999da5f55779a1b08ec6a2 DIFF: https://github.com/llvm/llvm-project/commit/6aca6032c5b62b5d26999da5f55779a1b08ec6a2.diff LO

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aca6032c5b6: [AST] Include the TranslationUnitDecl when traversing with TraversalScope (authored by sammccall). Changed prior to commit: https://

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

jubnzv updated this revision to Diff 351423. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104097/new/ https://reviews.llvm.org/D104097 Files: clang/lib/StaticAnalyzer/Checkers/PaddingChecker.cpp clang/test/Analysis/padding_no_unique_address.cpp Index: clang/test/Analysis/padding_n

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx updated this revision to Diff 351425. flx marked an inline comment as not done. flx added a comment. Use more efficient method to check for local variable declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.ll

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

thopre added a comment. +1 for this change but being a downstream target only I prefer to let someone else approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 __

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx marked an inline comment as done. flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode(&InitializingVar .bi

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

bjope added a comment. Kind of the same take on this as @thopre . I wrote https://bugs.llvm.org/show_bug.cgi?id=48821 , and proposed https://reviews.llvm.org/D95789 , when I noticed that this pass caused troubles for two reasons: 1. to avoid that others would stumble upon the same problem (get

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

bjope added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1449 - // inserting redundancies into the program. This even includes SimplifyCFG. - OptimizePM.addPass(SpeculateAroundPHIsPass()); - lebedev.ri wrote: > nikic wrote: > > As it has been in

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon added a comment. In D103888#2811305 , @dblaikie wrote: > Sounds OK. > > I wouldn't mind the places that can use op<< to use that - not sure > preserving the explicit radix argument is super high value. (I think people > would generally assume th

[clang] f7bc9db - Fix Wdocumentation missing parameter warnings. NFCI.

Author: Simon Pilgrim Date: 2021-06-11T14:32:35+01:00 New Revision: f7bc9db95aba77157f10b627a4dea32c3174e148 URL: https://github.com/llvm/llvm-project/commit/f7bc9db95aba77157f10b627a4dea32c3174e148 DIFF: https://github.com/llvm/llvm-project/commit/f7bc9db95aba77157f10b627a4dea32c3174e148.diff

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidInitDefaultConstructorsCheck.h:28 + bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { +return LangOpts.CPlusPlus; + } Shouldn'

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

Eugene.Zelenko added a comment. What about bit filed members - their initialization is supported only in C++20. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104112/new/ https://reviews.llvm.org/D104112

[clang] 150f7ce - Referencing a static function defined in an opnemp clause, is

Author: Zahira Ammarguellat Date: 2021-06-11T06:56:01-07:00 New Revision: 150f7cedfb2e072804f4a0887d14c97a7fe3f374 URL: https://github.com/llvm/llvm-project/commit/150f7cedfb2e072804f4a0887d14c97a7fe3f374 DIFF: https://github.com/llvm/llvm-project/commit/150f7cedfb2e072804f4a0887d14c97a7fe3f374

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Objective-C lets you u

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart created this revision. stuart added reviewers: Anastasia, keith.walker.arm, svenvh, aprantl, SouraVX, shchenz, jzzheng22. Herald added subscribers: ldrumm, yaxunl. stuart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri updated this revision to Diff 351444. lebedev.ri added a comment. Herald added a subscriber: zzheng. Update a few more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 Files: clang/test

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri updated this revision to Diff 351445. lebedev.ri added a comment. ... and upload the right patch this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 Files: clang/test/CodeGen/thinlto-d

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart added a comment. Note: there is currently no DWARF language code defined for //C++ for OpenCL//, so we must use DW_LANG_C_plus_plus* if we wish to be able to determine whether output has been generated from //C++ for OpenCL// source or from //OpenCL C// source. I have raised DWARF issue

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart updated this revision to Diff 351454. stuart added a comment. Add missing trailing commas to CHECK lines of FileCheck test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 Files: clang/lib/CodeGe

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

morehouse updated this revision to Diff 351459. morehouse added a comment. - Fix clang test failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102901/new/ https://reviews.llvm.org/D102901 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0867edfc6438: [HWASan] Add basic stack tagging support for LAM. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] e42a347 - [Sema] Address-space sensitive check for unbounded arrays (v2)

Author: eahcmrh Date: 2021-06-11T17:36:16+02:00 New Revision: e42a347b74400b7212ceaaea6d39562a0435df42 URL: https://github.com/llvm/llvm-project/commit/e42a347b74400b7212ceaaea6d39562a0435df42 DIFF: https://github.com/llvm/llvm-project/commit/e42a347b74400b7212ceaaea6d39562a0435df42.diff LOG:

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe42a347b7440: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Changed prior to commit: https://r

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov reopened this revision. mizvekov added a comment. This revision is now accepted and ready to land. Thank you @stella.stamenova and @aeubanks for reporting and reverting this. Turns out was a silly mistake where we were not digging down through AttributedType nodes in order to get the fu

[clang] 7e9822c - Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)"

Author: eahcmrh Date: 2021-06-11T17:44:06+02:00 New Revision: 7e9822cc55065b7c450dda254340765794e11fe3 URL: https://github.com/llvm/llvm-project/commit/7e9822cc55065b7c450dda254340765794e11fe3 DIFF: https://github.com/llvm/llvm-project/commit/7e9822cc55065b7c450dda254340765794e11fe3.diff LOG:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 351462. mizvekov added a comment. Look through AttributedType when obtaining FunctionDecl return type. Adds a couple more test cases to cover this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ htt

[PATCH] D104124: [IR] Simplify createReplacementInstr

foad created this revision. Herald added subscribers: dexonsmith, hiraditya. foad requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. NFCI, although the test change shows that ConstantExpr::getAsInstruction is better than the

[PATCH] D104124: [IR] Simplify createReplacementInstr

foad added reviewers: yaxunl, robertlytton. foad added a comment. Given how simple createReplacementInstr is now, this does make me wonder if it was really worth creating ReplaceConstant.{cpp,h} in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. Devils advocate how is this any different from class Foo { class Bar {} ; } }; This would become class Foo { class Bar {}; }; i.e. its going to remove the extra lines, just asking so we can understand if the removal of the line is the err

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp added a comment. In D103615#2799498 , @bmahjour wrote: > As far as I can see, there is no good reason for the special treatment of > vector bool/pixel going forward. Could we drop this special treatment, or at > least change the default to use s

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] Moving the definition of the defineXLCompatMacros function from the header file clang/lib/Basic

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. Do we need a set options for when we want to insert/retain/add a newline after various constructs? frankly I've been mulling over the concept of adding a NewLinesBetweenFunctions: 1 I personally don't like code written like this as I find it hard to read, I'd

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. We should have perhaps though about this when we added ```EmptyLineAfterAccessModifier ``` and ```EmptyLineBeforeAccessModifier ``` Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104044/new/ https://reviews.llvm.org/D

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 351467. stefanp added a comment. Updated the name of the option to vector-compare compat. Added clang test lines to the test cases. Added deprecation warnings to the current default behaviour of vector bool and vector pixel. Repository: rG LLVM Github Mono

[clang] 82a3b60 - Update the C status page somewhat.

Author: Aaron Ballman Date: 2021-06-11T12:06:50-04:00 New Revision: 82a3b606b01d2da23a40785222f3f7d15401dda0 URL: https://github.com/llvm/llvm-project/commit/82a3b606b01d2da23a40785222f3f7d15401dda0 DIFF: https://github.com/llvm/llvm-project/commit/82a3b606b01d2da23a40785222f3f7d15401dda0.diff

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx reopened this revision. chrish_ericsson_atx added a comment. This revision is now accepted and ready to land. Reverted commit due to buildbot failures -- will update shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/ne

  1   2   >