[PATCH] D103461: [clang][deps] NFC: Do not adjust the original action

dexonsmith added a comment. Is there (or could there be) a mode where `clang-scan-deps` prints out the command-lines it sends to the dependency scanning action (maybe instead of actually scanning), so this could be tested? Comment at: clang/tools/clang-scan-deps/ClangScanDeps

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl updated this revision to Diff 349052. yaxunl retitled this revision from "[HIP] Change default lang std to c++14" to "[CUDA][HIP] Change default lang std to c++14". yaxunl edited the summary of this revision. yaxunl added a comment. revised by Artem's comments, and fix tests CHANGES SINC

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:196-197 // CUDA LANGSTANDARD(cuda, "cuda", CUDA, "NVIDIA CUDA(tm)", LineComment | CPlusPlus | Digraphs) tra wrote: > I

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103108/new/ https://reviews.llvm.org/D103108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Will do on Thursday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2789493 , @probinson wrote: >> Mixed feelings - somewhat in favor of "do the thing that's probably already >> fairly tested/known to work" (GCC's thing). But open to the idea that that >> approach has problems, for s

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

tra added a comment. LGTM. I would like to test the patch on our code first. Please wait a bit before landing the patch. I should be able to have the results tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103108/new/ https://reviews.llvm.org/D103108 _

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14921 + verifyFormat("unsigned int *a;\n" + "int*b;\n" "unsigned int Const *c;\n" I seem to remember in the past there was

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. Hello, this patch introduces a regression in one of our codebases. The compilation of several TUs fails with the following callstack: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. The following was found by a customer and is accepted by the other primary C++ compilers, but fails to compile in Clang

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

tra added inline comments. Comment at: clang/test/SemaCUDA/asm_delayed_diags.cu:31 static __device__ __host__ double t3(double x) { - register long double result; + register long double result; // expected-warning {{'register' storage class specifier is deprecated and incompa

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; thanks for you patience. I've been a bit paralyzed, thinking about whether we could/should add a remark, something like `-Rtemp-file` or `-Routput-file`, which could be triggered

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

dexonsmith added a comment. @zahen , what author information should I use for the Git commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101775/new/ https://reviews.llvm.org/D101775 ___ cfe-commits ma

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

erichkeane added a comment. The patch looks fine to me, though I don't particularly get the test changes that move a diagnostic by 1 line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103485/new/ https://reviews.llvm.org/D103485

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen added a comment. In D101775#2791938 , @dexonsmith wrote: > @zahen , what author information should I use for the Git commit? Zachary Henkel, za...@microsoft.com (GitHub username ZacharyHenkel) Thanks Duncan! Repository: rG LLVM Github Monorep

[clang] c138f3c - [clang] Fix ICE with typeid & polymorphic class (pr50497)

Author: Nathan Sidwell Date: 2021-06-01T12:55:29-07:00 New Revision: c138f3ce5c70ff87a35d77e11f77a77d9d539b49 URL: https://github.com/llvm/llvm-project/commit/c138f3ce5c70ff87a35d77e11f77a77d9d539b49 DIFF: https://github.com/llvm/llvm-project/commit/c138f3ce5c70ff87a35d77e11f77a77d9d539b49.diff

[PATCH] D103258: [clang] Fix ICE with typeid & polymorphic class (pr50497)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc138f3ce5c70: [clang] Fix ICE with typeid & polymorphic class (pr50497) (authored by urnathan). Herald added a project: clang. Herald added a subscri

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman added a comment. In D103485#2791940 , @erichkeane wrote: > The patch looks fine to me, though I don't particularly get the test changes > that move a diagnostic by 1 line? The `global-vs-module.cpp` test had a line removed from it for the

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ah! Thats what I missed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103485/new/ https://reviews.llvm.org/D103485 __

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

bruno added inline comments. Comment at: clang/lib/Lex/HeaderMap.cpp:265 + } + return ReverseMap.lookup(DestPath); +} How about something along the lines of: ``` ... StringRef Key; for (unsigned i = 0; i != NumBuckets; ++i) { HMapBucket B = getBucket(i);

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl updated this revision to Diff 349080. yaxunl marked an inline comment as done. yaxunl added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103221/new/ https://reviews.llvm.org/D103221 Files: clang/include/clang/Basic/LangStandards.def clang/test/Parser/cud

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/asm_delayed_diags.cu:31 static __device__ __host__ double t3(double x) { - register long double result; + register long double result; // expected-warning {{'register' storag

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2791734 , @tra wrote: > In D101630#2787714 , @yaxunl wrote: > >> How does nvcc --genco behave when there are multiple GPU arch's? Does it >> output a fat binary containing multi

[PATCH] D90188: Add support for attribute 'using_if_exists'

ldionne updated this revision to Diff 349087. ldionne added a comment. Fix CI issues (hopefully - at least everything runs locally). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files: clang/include/cl

[PATCH] D102507: [HIP] Support in device code

rsmith added a comment. @ldionne How should we go about establishing whether libc++ would be prepared to officially support CUDA? Right now, Clang's CUDA support is patching in attributes onto libc++ functions from the outside, which doesn't seem like a sustainable model. CHANGES SINCE LAST A

[PATCH] D103491: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

nikic created this revision. nikic added reviewers: lattner, RKSimon. Herald added subscribers: foad, dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, sha

[PATCH] D103477: [Fuchsia] Add compat multilibs to cache file

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103477/new/ https://reviews.llvm.org/D103477 ___

[clang] d7f846f - Fix a Clang diagnostic to start with a lowercase letter; NFC

Author: Aaron Ballman Date: 2021-06-01T17:03:31-04:00 New Revision: d7f846fc6be14539fb0f5223eb08cb2235759897 URL: https://github.com/llvm/llvm-project/commit/d7f846fc6be14539fb0f5223eb08cb2235759897 DIFF: https://github.com/llvm/llvm-project/commit/d7f846fc6be14539fb0f5223eb08cb2235759897.diff

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. Thanks for the comments. Please see my replies inlined. In D103184#2790486 , @DavidSpickett wrote: > Thanks for taking this up! I never got the time for it. > > I'd like to see the test check that there are no unused argument war

[PATCH] D103131: support debug info for alias variable

probinson added a comment. In D103131#2791881 , @dblaikie wrote: > In D103131#2789493 , @probinson > wrote: > >>> Mixed feelings - somewhat in favor of "do the thing that's probably already >>> fairly tested/kno

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2792052 , @yaxunl wrote: > I think for intermediate outputs e.g. preprocessor expansion, IR, and > assembly, probably it makes sense not to bundle by default. Agreed. > However, for default action (emitting object), we n

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/aarch64-target-as-march.s:4 + +/// The last -march wins, and is handled before -Wa,march. All the values of -Wa,march options are added. +// RUN: %clang --target=aarch64-linux-gnueabi -### -c -Wa,-march=armv8.1

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

MyDeveloperDay added a comment. It maybe that others think that the PAS_Right IS that option. If thats is the case I'm fine with that too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I'm done with testing. The patch does not seem to break anything obvious. Tensorflow builds and works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103108/new/ https://reviews.llvm.org/D1

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14921 + verifyFormat("unsigned int *a;\n" + "int*b;\n" "unsigned int Const *c;\n" MyDeveloperDay wrote: > I seem to re

[PATCH] D103477: [Fuchsia] Add compat multilibs to cache file

This revision was automatically updated to reflect the committed changes. Closed by commit rGda1db4940965: [Fuchsia] Add compat multilibs to cache file (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103477/new/ https://revi

[clang] da1db49 - [Fuchsia] Add compat multilibs to cache file

Author: Leonard Chan Date: 2021-06-01T15:14:56-07:00 New Revision: da1db49409657d5212185ab9952ee35d99b773d4 URL: https://github.com/llvm/llvm-project/commit/da1db49409657d5212185ab9952ee35d99b773d4 DIFF: https://github.com/llvm/llvm-project/commit/da1db49409657d5212185ab9952ee35d99b773d4.diff

[clang] cf49cae - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Author: Michael Benfield Date: 2021-06-01T15:38:48-07:00 New Revision: cf49cae278b4e972cd2547d72f9ee7d9d69a3af4 URL: https://github.com/llvm/llvm-project/commit/cf49cae278b4e972cd2547d72f9ee7d9d69a3af4 DIFF: https://github.com/llvm/llvm-project/commit/cf49cae278b4e972cd2547d72f9ee7d9d69a3af4.di

[clang] e6f88dc - [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

Author: Leonard Chan Date: 2021-06-01T15:46:09-07:00 New Revision: e6f88dc01a7208b6f4671c4fcb5d9e68d0808a34 URL: https://github.com/llvm/llvm-project/commit/e6f88dc01a7208b6f4671c4fcb5d9e68d0808a34 DIFF: https://github.com/llvm/llvm-project/commit/e6f88dc01a7208b6f4671c4fcb5d9e68d0808a34.diff

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6f88dc01a72: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia (authored by leonardchan). Repository: rG LLVM Github Monorepo CHA

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2792159 , @probinson wrote: > In D103131#2791881 , @dblaikie > wrote: > >> In D103131#2789493 , @probinson >> wrote: >> Mixed f

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

wolfgangp created this revision. wolfgangp added reviewers: rnk, jyu2. wolfgangp requested review of this revision. Commit c19f4f8069 caused some ordered dynamic initialization of static member variables to be

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames updated this revision to Diff 349139. arames added a comment. Use `llvm::MD5`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h clang/include/clang

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

crr0004 added a comment. Whoops. Hit close without adding this comment. Okay thank you for that @sammccall and @kadirect. Ultimately shared this patch was I found it useful but wasn't sure if it would fit with the project. Is there somewhere I can read about project direction/decisions? Like th

[clang] 7daa182 - Fix tmp files being left on Windows builds.

Author: Amy Huang Date: 2021-06-01T17:09:08-07:00 New Revision: 7daa18215905c831e130c7542f17619e9d936dfc URL: https://github.com/llvm/llvm-project/commit/7daa18215905c831e130c7542f17619e9d936dfc DIFF: https://github.com/llvm/llvm-project/commit/7daa18215905c831e130c7542f17619e9d936dfc.diff LOG

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.h:81 + template void updateHash(HashT &Hash) const { +Hash.updateRange(&maskLoToHigh[0], &maskLoToHigh[0] + kNumElem); An alternative to having those in class would be to have

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames updated this revision to Diff 349141. arames added a comment. Fix detail namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h clang/include/

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. Thanks for taking a look, @rjmccall - I really appreciate it! Sorry I'm doing a bad job describing (admittedly I'm pretty confused about all this, which is most of the issue) the issue - I'll try to clarify as best I can. In D98799#2781200

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin added a comment. Yes, a CMake option is a good idea for this. I'll update this change to add a new CMake option for who don't want all the headers (default OFF to follow exist behavior) . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103080

[PATCH] D100391: [RISCV][Clang] Add RVV miscellaneous intrinsic functions.

pshung added a comment. @khchen This patch doesn't generate the overloaded APIs for "vreinterpret". Any concern? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100391/new/ https://reviews.llvm.org/D100391 __

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGf7e87dd6ff0c: [CUDA][HIP] Change default lang std to c++14 (authored by yaxunl). Herald added a project: cla

[clang] f7e87dd - [CUDA][HIP] Change default lang std to c++14

Author: Yaxun (Sam) Liu Date: 2021-06-01T20:45:10-04:00 New Revision: f7e87dd6ff0c1c4a41a6b654d2460557ae97ab8d URL: https://github.com/llvm/llvm-project/commit/f7e87dd6ff0c1c4a41a6b654d2460557ae97ab8d DIFF: https://github.com/llvm/llvm-project/commit/f7e87dd6ff0c1c4a41a6b654d2460557ae97ab8d.dif

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 updated this revision to Diff 349150. jcai19 added a comment. Limit the change to assembler files, and add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 Files: clang/lib/Driver/Tool

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang/test/Driver/aarch64-target-as-march.s:4 + +/// The last -march wins, and is handled before -Wa,march. All the values of -Wa,march options are added. +// RUN: %clang --target=aarch64-linux-gn

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04caa7c3e02f: [CUDA][HIP] Promote const variables to constant (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mono

[clang] 04caa7c - [CUDA][HIP] Promote const variables to constant

Author: Yaxun (Sam) Liu Date: 2021-06-01T21:28:41-04:00 New Revision: 04caa7c3e02f0e2f96881b2b9b5ae5fec6e59aa9 URL: https://github.com/llvm/llvm-project/commit/04caa7c3e02f0e2f96881b2b9b5ae5fec6e59aa9 DIFF: https://github.com/llvm/llvm-project/commit/04caa7c3e02f0e2f96881b2b9b5ae5fec6e59aa9.dif

[PATCH] D103457: [analyzer] Add forwarding `addVisitor` method

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Excellent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103457/new/ https://reviews.llvm.org/D103457 ___

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail created this revision. lkail added reviewers: nemanjai, jsji, xingxue, hubert.reinterpretcast, cebowleratibm, PowerPC. Herald added subscribers: jfb, kbarton. Herald added a reviewer: jfb. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[clang] 20797b1 - Revert "Fix tmp files being left on Windows builds." for now;

Author: Amy Huang Date: 2021-06-01T19:51:47-07:00 New Revision: 20797b129f844d4b12ffb2b12cf33baa2d42985c URL: https://github.com/llvm/llvm-project/commit/20797b129f844d4b12ffb2b12cf33baa2d42985c DIFF: https://github.com/llvm/llvm-project/commit/20797b129f844d4b12ffb2b12cf33baa2d42985c.diff LOG

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

xazax.hun added inline comments. Comment at: clang/test/Analysis/constant-folding.c:265 +if (a > INT_MAX) { + clang_analyzer_eval((a + b) <= 0); // expected-warning{{FALSE}} + clang_analyzer_eval((a + b) > 0); // expected-warning{{FALSE}} Since both

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:95 + /// This method is run once the \ref Stop method is called. + virtual void OnStop(const ExplodedNode *Curr, BugReporterContext &BRC, +

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

NoQ added a comment. Our pre-commit testing shows that the new tests fail, eg.: https://buildkite.com/llvm-project/premerge-checks/builds/41391#b557c86c-0587-4aee-a06b-8a4de6d771c4 Failed Tests (1): Clang :: Analysis/constant-folding.c Did you figure out how to *run* the tests locally? Te

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

RedDocMD added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:95 + /// This method is run once the \ref Stop method is called. + virtual void OnStop(const ExplodedNode *Curr, BugReporterContext &BRC, +

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. @NoQ I figured out the tests but while testing against Z3, I mixed up constraints. I am changing those. Comment at: clang/test/Analysis/constant-folding.c:265 +if (a > INT_MAX) { + clang_analyzer_eval((a + b) <= 0); // expected-warning{{FALSE}}

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/test/Analysis/constant-folding.c:282 + if (a == UINT_MAX && b == UINT_MAX) { +clang_analyzer_eval((a + b) >= 0); // expected-warning{{FALSE}} + } manas wrote: > xazax.hun wrote: > > I think `UINT_MAX + UINT_MAX

<    1   2