[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

tksuoran added a comment. I would like to use exactly the same formatting (really exactly one initializer (and nother else) per line). Some comments: - Keep `ConstructorInitializerAllOnOneLineOrOnePerLine` so that the change does not break any existing behavior - Default value for `Constructor

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Looks good, nice and simple. Thanks @benshi001 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 __

[PATCH] D103286: [clang-format] Add PPIndentWidth option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3447 + style); +} + can you add a test ``` #ifdef X void foo() { ... } #endif ``` its unclear if PPIndentWidth affects code in #ifdef or just # pr

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

MyDeveloperDay added a comment. We can't rename options without giving some form of backwards compatibility, personally, I think we need to start again with this review if its still of interest, this one is 6 years old. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added a comment. In D101191#2783570 , @rupprecht wrote: > In D101191#2782963 , @rupprecht > wrote: > >> The issue I'm seeing seems more directly caused by SLP vectorization, as it >> goes away with `-fno-

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

crr0004 created this revision. crr0004 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. crr0004 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This adds a new option t

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partially implement P0315R4. This patch allow lambda in unevaluated context. It does not implement temp.deduct/9. This is a rewrite of https://review

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 348693. cor3ntin added a comment. Code formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/SemaExpr.c

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

cor3ntin added a comment. Given the lack of activity, I made another PR for the same feature https://reviews.llvm.org/D103380 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66481/new/ https://reviews.llvm.org/D66481 __

[clang-tools-extra] be6b9e8 - Revert "[clang-tidy] Simplify static assert check"

Author: Roman Lebedev Date: 2021-05-30T16:44:31+03:00 New Revision: be6b9e8ae71768d2e09ec14619ca4ecfdef553fa URL: https://github.com/llvm/llvm-project/commit/be6b9e8ae71768d2e09ec14619ca4ecfdef553fa DIFF: https://github.com/llvm/llvm-project/commit/be6b9e8ae71768d2e09ec14619ca4ecfdef553fa.diff

[PATCH] D96223: [clang-tidy] Simplify static assert check

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. Reverted in be6b9e8ae71768d2e09ec14619ca4ecfdef553fa - https://godbolt.

[clang] c1ee4fb - [clang][AVR] Add avr-libc/include to clang system include paths

Author: Ben Shi Date: 2021-05-30T22:39:07+08:00 New Revision: c1ee4fb5af49af5911ad7dc7932d975073030ec3 URL: https://github.com/llvm/llvm-project/commit/c1ee4fb5af49af5911ad7dc7932d975073030ec3 DIFF: https://github.com/llvm/llvm-project/commit/c1ee4fb5af49af5911ad7dc7932d975073030ec3.diff LOG:

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1ee4fb5af49: [clang][AVR] Add avr-libc/include to clang system include paths (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D96223: [clang-tidy] Simplify static assert check

aaron.ballman added a comment. In D96223#2788681 , @lebedev.ri wrote: > Reverted in be6b9e8ae71768d2e09ec14619ca4ecfdef553fa > - > https://godbolt.org/z/3zdqvbfxj > While there, please

[PATCH] D96223: [clang-tidy] Simplify static assert check

xbolva00 added a comment. In D96223#2788712 , @aaron.ballman wrote: > In D96223#2788681 , @lebedev.ri > wrote: > >> Reverted in be6b9e8ae71768d2e09ec14619ca4ecfdef553fa >>

[PATCH] D103383: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-series

justinlatimer created this revision. Herald added subscribers: Jim, hiraditya, dylanmckay. justinlatimer requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-series Rep

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer updated this revision to Diff 348707. justinlatimer added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add devices into the clang AVR target constant list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb requested changes to this revision. cjdb added a comment. This revision now requires changes to proceed. Thanks for working on this, it'll be a huge win for testing in libc++, methinks! Could we get a few more tests please? I'd like to know what happens when we put a lambda directly inside:

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

jwtowner created this revision. jwtowner added reviewers: alexfh, aaron.ballman, hokein. Herald added a subscriber: xazax.hun. jwtowner requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Many concepts emulation libraries, such as t

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

jwtowner added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp:83 + hasType(isEnableIf()), + anyOf(hasDescendant(cxxBoolLiteral()), +hasDescendant(cxxNullPtrLiteralE

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf created this revision. qiucf added reviewers: PowerPC, jsji, nemanjai. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D102148: [clangd] Type hints for variables with 'auto' type

nridge updated this revision to Diff 348727. nridge marked 8 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102148/new/ https://reviews.llvm.org/D102148 Files: clang-tools-e

[PATCH] D102148: [clangd] Type hints for variables with 'auto' type

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:33 +TypeHintPolicy.SuppressScope = true; // keep type names short +TypeHintPolicy.AnonymousTagLocations = +false; // do not print lambda locations sammccall wrote: >

[clang-tools-extra] e972068 - [clangd] Move gtest include to TestTU.cpp from TestTU.h

Author: Kadir Cetinkaya Date: 2021-05-31T07:56:56+02:00 New Revision: e972068840710a8c832d21603b8409692604b865 URL: https://github.com/llvm/llvm-project/commit/e972068840710a8c832d21603b8409692604b865 DIFF: https://github.com/llvm/llvm-project/commit/e972068840710a8c832d21603b8409692604b865.dif

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

FStefanni added a comment. Hi, in case of any doubt: yet it is of interest. 6 years old means only that it has not been "fixed" in the meanwhile... Please consider that there are not many code formatters for C++, since it is quite a complex language (and a lot of different formatting convention

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Ignored diagnostics were only c

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 348733. kadircet added a comment. Exit after introducing cleanup function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/ https://reviews.llvm.org/D103387 Files: clang-tools-extra/clangd/Diagnosti