njames93 added a comment.
Is it worth using regex to ignore some operators:
`*::operator bool` to ignore all bool conversions etc.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-explicit-constructor-and-conversion.rst:12-14
+This check implements `C.46
gergap marked 4 inline comments as done.
gergap added inline comments.
Comment at: clang/lib/Format/WhitespaceManager.cpp:369
assert(Shift >= 0);
+if (Shift == 0)
+ continue;
HazardyKnusperkeks wrote:
> This is unrelated, isn't it?
>
> If it is, I
TH3CHARLie created this revision.
TH3CHARLie added a reviewer: NoQ.
Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp,
donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware,
xazax.hun.
TH3CHARLie requested review of this revision.
Herald added a pro
gergap marked an inline comment as done.
gergap added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:15045
+ // PAS_RIGHT
EXPECT_EQ("void SomeFunction(int parameter = 0) {\n"
" int const i = 1;\n"
gergap wrote:
> HazardyKnu
HazardyKnusperkeks added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:14884
Alignment.AlignConsecutiveDeclarations = FormatStyle::ACS_None;
+ Alignment.PointerAlignment = FormatStyle::PAS_Right;
verifyFormat("float const a = 5;\n"
ger
gergap added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:15045
+ // PAS_RIGHT
EXPECT_EQ("void SomeFunction(int parameter = 0) {\n"
" int const i = 1;\n"
gergap wrote:
> gergap wrote:
> > HazardyKnusperkeks wrote:
> > > I
gergap updated this revision to Diff 348625.
gergap added a comment.
fix review findings
- fix case of comments
- rename for loop variable name
- use preincrement instead of postincrement
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103245/new/
h
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM. But please wait for @hazardyknusperkeks to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103245/new/
https://reviews.llvm.org/D1
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfae3534b3056: [analyzer] Use Optional as a return type of
StoreManager::castRegion (authored by ASDenysPetrov).
Repository:
rG LLVM Github Monore
Author: Denys Petrov
Date: 2021-05-29T15:16:56+03:00
New Revision: fae3534b3056bb96d26a6d1b6e7d6a2ccaf4fab1
URL:
https://github.com/llvm/llvm-project/commit/fae3534b3056bb96d26a6d1b6e7d6a2ccaf4fab1
DIFF:
https://github.com/llvm/llvm-project/commit/fae3534b3056bb96d26a6d1b6e7d6a2ccaf4fab1.diff
Author: mydeveloperday
Date: 2021-05-29T16:43:55+01:00
New Revision: ffb48d48e45c72ed81dda4983ccb06e800cdbbd0
URL:
https://github.com/llvm/llvm-project/commit/ffb48d48e45c72ed81dda4983ccb06e800cdbbd0
DIFF:
https://github.com/llvm/llvm-project/commit/ffb48d48e45c72ed81dda4983ccb06e800cdbbd0.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGffb48d48e45c: [clang-format] successive C# attributes cause
line breaking issues (authored by MyDeveloperDay).
Changed prior to commit:
https://reviews.llvm.org/D103307?vs=348495&id=348634#toc
Reposito
HazardyKnusperkeks added a comment.
Please just check `continue`, I would like to make it a separate commit,
because it seems unrelated to me. Otherwise this is good.
Comment at: clang/lib/Format/WhitespaceManager.cpp:369
assert(Shift >= 0);
+if (Shift == 0)
+ co
HazardyKnusperkeks requested changes to this revision.
HazardyKnusperkeks added a comment.
This revision now requires changes to proceed.
Love it!
But this will result in unexpected (one might say breaking) behaviour, if
someone set `IndentWidth` to a different value than his base style and upda
HazardyKnusperkeks added inline comments.
Comment at: clang/include/clang/Format/Format.h:2336
+ /// \endcode
+ unsigned PPIndentWidth;
+
I prefer alphabetical sorting, I know there are some entries which aren't
sorted.
Repository:
rG LLVM Github Monorepo
ASDenysPetrov added a comment.
@NoQ
> I guess another option is to put `loc::MemRegionVal()` inside `castRegion()`.
> This way the return type `Optional` unambigously tells
> that the region is always non-null if present (protected by the assertion in
> the constructor of `loc::MemRegionVal`).
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Amazing, perfect, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103358/new/
https://reviews.llvm.org/D103358
Author: Xuanda Yang
Date: 2021-05-30T09:51:41+08:00
New Revision: 620cef91207bbeb570a529328976040e658a60ee
URL:
https://github.com/llvm/llvm-project/commit/620cef91207bbeb570a529328976040e658a60ee
DIFF:
https://github.com/llvm/llvm-project/commit/620cef91207bbeb570a529328976040e658a60ee.diff
L
This revision was automatically updated to reflect the committed changes.
Closed by commit rG620cef91207b: [analyzer] MallocSizeof: sizeof pointer type
is compatible with void* (authored by TH3CHARLie).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
hubert.reinterpretcast added a comment.
This change is causing failures when the build is done from a working directory
that has symlinks:
https://lab.llvm.org/staging/#/builders/126/builds/529/steps/5/logs/FAIL__Clang__hip-include-path_hip
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
20 matches
Mail list logo
