[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

2021-05-27 Thread Marco Elver via Phabricator via cfe-commits
melver added a comment. In D103159#2784926 , @aaron.ballman wrote: > In D103159#2784845 , @melver wrote: > >> Ping. > > FWIW, the usual practice is to ping after no activity on the review for about > a week. > >

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

2021-05-27 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D101566#2734948 , @dblaikie wrote: > Makes it hard to justify the complexity in the compiler if it's hard to > justify/support the value of the warning. The complexity for `-Wweak-template-vtables` is just 10 lines of co

Re: [PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

2021-05-27 Thread Delesley Hutchins via cfe-commits
> - The `assert_capability` attribute is also a bit of a backdoor. Instead > of statically propagating through the code that a mutex is held, we can > just get that fact "out of thin air". > Assert_capability is not a back door. It is supposed to be used only on a function which does a run-time c

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

2021-05-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D101566#2785190 , @aaronpuchert wrote: > In D101566#2734948 , @dblaikie > wrote: > >> Makes it hard to justify the complexity in the compiler if it's hard to >> justify/support the

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

2021-05-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. It sounds like you indeed solved a lot of problems that prevented us from enabling `SymbolCast`. But this still requires //massive// testing, a lot more than a typical constraint solver patch; extraordinary claims require extraordinary evidence. If it works out though, it m

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 348332. quinnp added a comment. Addressing the last comments made by @nemanjai. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/Buil

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-05-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. A brief summary of an offline discussion we recently had. (1) Basically we figured out that it's still necessary to do something like I originally suggested: In D97183#2598806 , @NoQ wrote: > We could, for instance, teach it to mark

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-05-27 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:258 + const Decl *D = DS->getSingleDecl(); + assert(D && "DeclStmt should have at least one Decl"); + const auto *VD = llvm::dyn_cast(D); NoQ wrote: > That's not

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

2021-05-27 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added reviewers: MaskRay, mati865. mstorsjo added a comment. Adding some more reviewers, this is a trivial bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102873/new/ https://reviews.llvm.org/D102873 ___

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

2021-05-27 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. @rnk Does this seem ok to you too? Comment at: clang/lib/CodeGen/CodeGenModule.cpp:992 +// (and this actually happens in the public interface of libstdc++), so +// such variables can't be marked as DSO local. if (GV->isDeclarationForLinker

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 348341. stefanp added a comment. Rebased revision to top of trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-27 Thread Fred Grim via Phabricator via cfe-commits
feg208 marked 3 inline comments as done. feg208 added a comment. I picked up most of these. One of the tests is already covered (I think) maybe I am misunderstanding Comment at: clang/unittests/Format/FormatTest.cpp:16478 + "{56, /* a comment */ 23, \"hello\"

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-27 Thread Fred Grim via Phabricator via cfe-commits
feg208 updated this revision to Diff 348346. feg208 marked an inline comment as done. feg208 added a comment. Rolls up review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/C

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-27 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. In D102543#2783516 , @cryptoad wrote: > I saw some bots failure for preinit.c: > > FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) > TEST 'ScudoStandalone-i386 :: preinit.c' FAILED > **

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-27 Thread Kostya Kortchinsky via Phabricator via cfe-commits
cryptoad added a comment. sanitizer-x86_64-linux https://lab.llvm.org/buildbot/#/builders/37/builds/4244 FAIL: ScudoStandalone-x86_64 :: preinit.c (772 of 856) ppc64be-clang-test https://lab.llvm.org/buildbot#builders/52/builds/7794 TEST 'ScudoStandalone-powerpc64 :: preinit.c' FAILED among othe

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

2021-05-27 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103229/new/ https://reviews.llvm.org/D103229 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

2021-05-27 Thread Thomas Lively via Phabricator via cfe-commits
tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM with that one last comment on the test. Comment at: llvm/test/CodeGen/WebAssembly/ir-locals.ll:17-20 + ; The DAG combiner infers that %reloaded is the same as %arg and

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

2021-05-27 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 348357. fhahn added a comment. Fix failing clang/test/CodeGenObjC/matrix-type-operators.m. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 Files: clang/lib/CodeGen/CG

[PATCH] D103163: [Matrix] Skip matrix casts checks for class or struct types in C++.

2021-05-27 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 348360. fhahn added a comment. I discussed the problem offline with John and he suggested to handle matrix casts in TryStaticCast. This allows us the handle both static_cast and C-style casts with the same code. As a consequence, the default error messages for

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

2021-05-27 Thread Marco Gartmann via Phabricator via cfe-commits
mgartmann updated this revision to Diff 348178. mgartmann marked an inline comment as done. mgartmann added a comment. - added testcase of explicit operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102779/new/ https://reviews.llvm.org/D102779

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-27 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16478 + "{56, /* a comment */ 23, \"hello\" },\n" + "{-1, 93463, \"world\" },\n" + "{ 7, 5,\"!!\" }\

[PATCH] D103163: [Matrix] Skip matrix casts checks for class or struct types in C++.

2021-05-27 Thread Saurabh Jha via Phabricator via cfe-commits
SaurabhJha accepted this revision. SaurabhJha added a comment. In D103163#2785578 , @fhahn wrote: > I discussed the problem offline with John and he suggested to handle matrix > casts in TryStaticCast. This allows us the handle both static_cast and > C-

[PATCH] D102730: [clang-format] Support custom If macros

2021-05-27 Thread Vitali Lovich via Phabricator via cfe-commits
vlovich added inline comments. Comment at: clang/include/clang/Format/Format.h:2983 /// \endcode -SBPO_ControlStatementsExceptForEachMacros, +SBPO_ControlStatementsExceptControlMacros, /// Put a space before opening parentheses only if the parentheses are not --

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

2021-05-27 Thread Vitali Lovich via Phabricator via cfe-commits
vlovich marked an inline comment as done. vlovich added a comment. I think all review comments have been addressed. Please let me know if there's anything else blocking merge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 __

[PATCH] D97340: [HIP] Support Spack packages

2021-05-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. opened https://reviews.llvm.org/D103281 to fix device lib detection for spack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 ___ cfe-comm

[PATCH] D103081: [analyzer] RetainCountChecker: Disable reference counting for OSMetaClass.

2021-05-27 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50f17e9d3139: [analyzer] RetainCountChecker: Disable reference counting for OSMetaClass. (authored by georgi_igna, committed by dergachev.a). Repos

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

2021-05-27 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102970/new/ https://reviews.llvm.org/D102970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2021-05-27 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. Hoping @lebedev.ri will take a look since he requested changes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___ cfe-commits m

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

2021-05-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. We tried it, and the warning is still firing in a similar (but not exactly the same) way: In file included from ../../content/browser/accessibility/browser_accessibility_manager_win.cc:19: In file included from ../..\content/browser/renderer_host/legacy_render_widget_

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2021-05-27 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. No real comments from me. I assume, the errors are because `-ffp-contract=on` actually results in *less* error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cb66bf2 - Replace 'magic static' with a member variable for SCYL kernel names

2021-05-27 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2021-05-27T13:46:31-07:00 New Revision: cb66bf2c6d20da01ab57cb78ec5e5c0978b873be URL: https://github.com/llvm/llvm-project/commit/cb66bf2c6d20da01ab57cb78ec5e5c0978b873be DIFF: https://github.com/llvm/llvm-project/commit/cb66bf2c6d20da01ab57cb78ec5e5c0978b873be.diff L

[clang] 0e4cf80 - [clang] [MinGW] Don't mark emutls variables as DSO local

2021-05-27 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-05-27T23:51:22+03:00 New Revision: 0e4cf807aeaf54a10e02176498a7df13ac722b37 URL: https://github.com/llvm/llvm-project/commit/0e4cf807aeaf54a10e02176498a7df13ac722b37 DIFF: https://github.com/llvm/llvm-project/commit/0e4cf807aeaf54a10e02176498a7df13ac722b37.diff

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

2021-05-27 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4cf807aeaf: [clang] [MinGW] Don't mark emutls variables as DSO local (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D102970?vs=347216&id=348379#toc Repository: rG LLVM Gi

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2021-05-27 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a subscriber: lebedev.ri. mibintc added a comment. In D74436#2785730 , @lebedev.ri wrote: > No real comments from me. > I assume, the errors are because `-ffp-contract=on` actually results in > *less* error? Yes, FMA improves accuracy, than

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

2021-05-27 Thread Zhaomo Yang via Phabricator via cfe-commits
zhaomo added inline comments. Comment at: clang/include/clang/ASTMatchers/GtestMatchers.h:39 + /// Matcher for gtest's ASSERT_... macros. internal::BindableMatcher gtestAssert(GtestCmp Cmp, StatementMatcher Left, hokein wrote: > as we add a new method to handl

[PATCH] D103286: [clang-format] Add PPIndentWidth option

2021-05-27 Thread Gerhard Gappmeier via Phabricator via cfe-commits
gergap created this revision. gergap added reviewers: klimek, Richard. Herald added a subscriber: krytarowski. gergap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows to set a different indent width for preprocessor statements.

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

2021-05-27 Thread Zhaomo Yang via Phabricator via cfe-commits
zhaomo updated this revision to Diff 348384. zhaomo marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103195/new/ https://reviews.llvm.org/D103195 Files: clang/include/clang/ASTMatchers/GtestMatchers.h clang/lib/ASTMatchers/GtestMatchers.cpp clang/unit

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

2021-05-27 Thread Jamie Schmeiser via Phabricator via cfe-commits
jamieschmeiser added a comment. The reason I worded it with 'may' is because, in C++, nullptr - nullptr is defined. If the code is "nullptr - p" or "p - nullptr", it is only undefined behaviour when p is not nullptr, hence the 'may' part of the warning because this is not known at compile time

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 348387. stefanp added a comment. Updated author to Quinn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[clang] 62b5df7 - [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via cfe-commits
Author: Quinn Pham Date: 2021-05-27T16:23:03-05:00 New Revision: 62b5df7fe2b3fda1772befeda15598fbef96a614 URL: https://github.com/llvm/llvm-project/commit/62b5df7fe2b3fda1772befeda15598fbef96a614 DIFF: https://github.com/llvm/llvm-project/commit/62b5df7fe2b3fda1772befeda15598fbef96a614.diff LO

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62b5df7fe2b3: [PowerPC] Added multiple PowerPC builtins (authored by quinnp, committed by stefanp). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

2021-05-27 Thread Zhaomo Yang via Phabricator via cfe-commits
zhaomo updated this revision to Diff 348399. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103195/new/ https://reviews.llvm.org/D103195 Files: clang/include/clang/ASTMatchers/GtestMatchers.h clang/lib/ASTMatchers/GtestMatchers.cpp clang/unittests/ASTMatchers/GtestMatchersTest.cpp

[PATCH] D55544: Warning: objc-encodings-larger-than=

2021-05-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Herald added a subscriber: dang. FYI D96816 made clang emit way smaller encodings by default Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 _

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

2021-05-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. FYI D96816 made clang emit way smaller encodings by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55640/new/ https://reviews.llvm.org/D55640 ___ cfe-commits mailing list cfe-c

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

2021-05-27 Thread Alexandre Rames via Phabricator via cfe-commits
arames updated this revision to Diff 348403. arames added a comment. Introduce and use `stable_hash_code` instead of modifying `hash_code`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/i

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

2021-05-27 Thread Alexandre Rames via Phabricator via cfe-commits
arames added a comment. The early commits are missing from the PR. Looking out to do this with `arc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 ___ cfe-co

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

2021-05-27 Thread Alexandre Rames via Phabricator via cfe-commits
arames updated this revision to Diff 348406. arames added a comment. Herald added a subscriber: mgorny. Diff against the parent commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/inclu

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

2021-05-27 Thread Alexandre Rames via Phabricator via cfe-commits
arames added a comment. This new version is an attempt to have modules not rely on `llvm::hash_code`, but on a new `llvm::stable_hash_code`. I understand modifying `ADT/Hashing.h` is sensitive, so maybe we need to discuss the high-level approach first. Repository: rG LLVM Github Monorepo CH

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

2021-05-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. LGTM. Comment at: clang/test/Driver/mingw-sysroot.cpp:21 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check

[PATCH] D103082: [AArch64][SVE] Optimize svbool dupq ACLE intrinsic to fixed predicate patterns

2021-05-27 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Do we really need a dedicated LLVM intrinsic to make the pattern-matching work here? It would be better if we could leverage @llvm.experimental.vector.insert.nxv16i8.v16i8 or something like that. Something along the lines of https://godbolt.org/z/Wz4azzKrP seems str

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

2021-05-27 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: mstorsjo, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC required version is 19.14 now (https://reviews.llvm.org/D92515). Update the default -fms-compatibility-ve

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

2021-05-27 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D101566#2785271 , @dblaikie wrote: > Right - to remove -Wweak-template-vtable in its entirety. The original > implementation explicitly didn't warn on implicit instantiations and I think > the fact that it warned on expl

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

2021-05-27 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D102026#2785243 , @delesley wrote: > Assert_capability is not a back door. It is supposed to be used only on a > function which does a run-time check: if (!mu_.is_locked()) fail(). Right, although assertions can turn i

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

2021-05-27 Thread ksyx via Phabricator via cfe-commits
ksyx added a comment. In D102839#2784297 , @luismarques wrote: > In D102839#2784275 , @ksyx wrote: > >> Thanks for mentioning that! Now, I changed the effect of `no-div` option >> into choosing a proper extensio

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

2021-05-27 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray updated this revision to Diff 348423. lichray added a comment. Add tests and update the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 Files: clang/docs/ClangFormatStyleOptions.r

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

2021-05-27 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno requested changes to this revision. bruno added a comment. This revision now requires changes to proceed. Overall looks good, few remaining nitpicks. Comment at: clang/lib/Lex/HeaderMap.cpp:245 +StringRef HeaderMapImpl::reverseLookupFilename(StringRef DestPath) const { +

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

2021-05-27 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray marked an inline comment as done. lichray added a comment. In D103204#2784234 , @MyDeveloperDay wrote: > Adding such a feature like this needs unit tests, it won't be let in without > them, you need to add them to clang/unittest/Format/Format.cp

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

2021-05-27 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added inline comments. Comment at: clang/include/clang/Format/Format.h:1839 +/// \endcode +BILS_AfterComma }; HazardyKnusperkeks wrote: > Maybe add a comma, so that the next addition will not need to modify this > line? Sure. Repository: r

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

2021-05-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D102943#2786015 , @arames wrote: > This new version is an attempt to have modules not rely on `llvm::hash_code`, > but on a new `llvm::stable_hash_code`. > I understand modifying `ADT/Hashing.h` is sensitive, so maybe we ne

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

2021-05-27 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray updated this revision to Diff 348424. lichray added a comment. Correct a copy-pasted test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 Files: clang/docs/ClangFormatStyleOptions.rst cl

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

2021-05-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D101566#2786112 , @aaronpuchert wrote: > In D101566#2785271 , @dblaikie > wrote: > >> Right - to remove -Wweak-template-vtable in its entirety. The original >> implementation explic

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

2021-05-27 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with the comment update I'm surprised there wasn't more fallout. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1340 IsWindowsMSVC)) { -// -fms-comp

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2021-05-27 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. @dexonsmith Yes, using the Clang Tooling API seems like a good option, however some logic could/would be needed from `clang/tools/clang-scan-deps/ClangScanDeps.cpp`. Using clang-scan-deps as-a-DLL seemed like the best option on the short term, since we're using its `main

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

2021-05-27 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 348438. zequanwu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103293/new/ https://reviews.llvm.org/D103293 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/

[clang] 59b8afe - [clang-cl] Bump default -fms-compatibility-version to 19.14

2021-05-27 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2021-05-27T20:40:37-07:00 New Revision: 59b8afe50274be975c62a4b11db49c84a874c0c0 URL: https://github.com/llvm/llvm-project/commit/59b8afe50274be975c62a4b11db49c84a874c0c0 DIFF: https://github.com/llvm/llvm-project/commit/59b8afe50274be975c62a4b11db49c84a874c0c0.diff LOG

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

2021-05-27 Thread Zequan Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59b8afe50274: [clang-cl] Bump default -fms-compatibility-version to 19.14 (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-05-27 Thread Jian Cai via Phabricator via cfe-commits
jcai19 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:217 + // after -march. And while only using the the value of last -march, it + // includes all the options passed via -Wa,-march. + success = true; joerg wrote: > This comme

LLVM build master will be restarted soon

2021-05-27 Thread Galina Kistanova via cfe-commits
Hello, LLVM build master will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2