[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3684 + return ToAttrOrErr.takeError(); +#if 0 +RecordType *FromRT = It is still not working. The testcase either PASSes despite this `#if 0` or it FAILs even if it is `#if 1`

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. Hi, sorry for taking so long for such a small change. I did the changes and generated a diff with the requested context. It's a huge file with a lot more diff than my changes, is that right? When I try to upload it, I'm getting `Unhandled Exception ("Exception")`, no o

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added a comment. @krasimir could you please check new diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] 058f384 - [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

Author: Tomasz Kamiński Date: 2021-05-24T10:16:52+02:00 New Revision: 058f384ae94ae0ac94441043804e4a25d338d483 URL: https://github.com/llvm/llvm-project/commit/058f384ae94ae0ac94441043804e4a25d338d483 DIFF: https://github.com/llvm/llvm-project/commit/058f384ae94ae0ac94441043804e4a25d338d483.dif

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG058f384ae94a: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr (authored by tomasz-kaminski-sonarsource, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko updated this revision to Diff 347326. ivanmurashko added a comment. @DmitryPolukhin suggestion was applied Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102906/new/ https://reviews.llvm.org/D102906 Files: clang-tools-extra/clang-tid

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. In D101868#2775550 , @feg208 wrote: > This reworks substantially this commit. I recognize there are lacking/broken > tests but I just would like to ensure that the general direction doesn't > seem likely to end in tears

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 347327. OikawaKirie added a comment. Herald added a subscriber: manas. In D101763#2768549 , @martong wrote: > First of all, thank you for the patch! > We had a meeting with my colleges (@steakhal, @gamesh411) and

[PATCH] D103008: Handle multiple escaped newlines between */ correctly

lodewillems created this revision. lodewillems requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang currently only recognizes a single escaped line between the end characters of a block comment. Fixes bug 15706 Repository: rG LLVM Git

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > I think we should remove the OpenCL check since it is not OpenC

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

This revision was automatically updated to reflect the committed changes. Closed by commit rG99d45ed22fd9: [Debug-Info] handle DW_TAG_rvalue_reference_type at strict DWARF. (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/n

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f819af73c5: [MC] Refactor MCObjectFileInfo initialization and allow targets to create… (authored by flip1995, committed by MaskRay). Repository:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. Thanks for your review! @dblaikie @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic updated this revision to Diff 347341. asavonic edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/ https://reviews.llvm.org/D101156 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { olestrohm wrote: > Anastasia wrote: > > I think we should remove the OpenCL check

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic added a comment. I went ahead and implemented a fix for EmitGlobalVarDefinition. Please let me know what approach is preferable: Diff 339986 or Diff 347341. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/ https://reviews.llvm.or

[clang] 237c692 - [OpenCL] Add clang extension for bit-fields.

Author: Anastasia Stulova Date: 2021-05-24T12:42:17+01:00 New Revision: 237c6924bd46ec0e33da71f9616caf9bf9965b23 URL: https://github.com/llvm/llvm-project/commit/237c6924bd46ec0e33da71f9616caf9bf9965b23 DIFF: https://github.com/llvm/llvm-project/commit/237c6924bd46ec0e33da71f9616caf9bf9965b23.d

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG237c6924bd46: [OpenCL] Add clang extension for bit-fields. (authored by Anastasia). Herald added subscribers: foad, ldrumm. Herald added a project: c

[clang] 626e964 - [OpenCL] Fix test by adding SPIR triple

Author: Anastasia Stulova Date: 2021-05-24T13:03:50+01:00 New Revision: 626e9641a2f5fde638b86d4e043f82fc58b908f8 URL: https://github.com/llvm/llvm-project/commit/626e9641a2f5fde638b86d4e043f82fc58b908f8 DIFF: https://github.com/llvm/llvm-project/commit/626e9641a2f5fde638b86d4e043f82fc58b908f8.d

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > olestrohm wrote: > > Anastasia wrote: > > > I think we should r

[clang] 5ccc79d - [OpenCL][Docs] Minor update to OpenCL 3.0

Author: Anastasia Stulova Date: 2021-05-24T14:19:22+01:00 New Revision: 5ccc79dc38b2df18cca5a9b4d66dcd4603f948e9 URL: https://github.com/llvm/llvm-project/commit/5ccc79dc38b2df18cca5a9b4d66dcd4603f948e9 DIFF: https://github.com/llvm/llvm-project/commit/5ccc79dc38b2df18cca5a9b4d66dcd4603f948e9.d

[PATCH] D103018: [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical type when checking for aliases.

flx created this revision. flx added reviewers: hokein, ymandel, aaron.ballman. Herald added subscribers: jeroen.dobbelaere, xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This fixes a false positive case where f

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx created this revision. flx added reviewers: hokein, ymandel, aaron.ballman. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This fixes false positive cases where a reference is initi

[PATCH] D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl()

tomasz-kaminski-sonarsource created this revision. tomasz-kaminski-sonarsource added reviewers: NoQ, vsavchenko, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. tomasz-kaminski-sona

[PATCH] D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl()

tomasz-kaminski-sonarsource added a comment. The alternative solution, that I think may be preferable is to remove following functions from CheckerContext and use CallEvent.getDecl() instead: const FunctionDecl *getCalleeDecl(const CallExpr *CE) const; StringRef getCalleeName(const FunctionD

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

aaron.ballman added a comment. Thanks! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102906/new/ https://reviews.llvm.org/D

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

aaron.ballman added a comment. In D49864#2776570 , @janosimas wrote: > Hi, sorry for taking so long for such a small change. > I did the changes and generated a diff with the requested context. > It's a huge file with a lot more diff than my changes, is th

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko marked an inline comment as done. ivanmurashko added a comment. Hi @aaron.ballman > Thanks! Do you need someone to commit on your behalf? I will appreciate your assistance in the landing the diff. > If so, what name and email address would you like used for patch attribution? It w

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. I found the issue with my diff and I was able to get the expected file. I'm still having issues uploading the file, this is the message I get in the browser console: POST https://reviews.llvm.org/differential/revision/update/49864/ 500 Repository: rG LLVM Github

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann added a comment. Dear reviewers, Since this work was conducted as part of a Bachelor's thesis, which has to be handed in on the 18th of June, 2021, we wanted to add a friendly ping to this patch. It would make us, the thesis team, proud to state that some of our work was accepted and i

[PATCH] D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks

mgartmann added a comment. Dear reviewers, Since this work was conducted as part of a Bachelor's thesis, which has to be handed in on the 18th of June, 2021, we wanted to add a friendly ping to this patch. It would make us, the thesis team, proud to state that some of our work was accepted and i

[clang-tools-extra] 7f2f024 - Remark was added to clang tooling Diagnostic

Author: Ivan Murashko Date: 2021-05-24T11:21:44-04:00 New Revision: 7f2f0247f855b143c12cd33d1f53d14bc63f3e82 URL: https://github.com/llvm/llvm-project/commit/7f2f0247f855b143c12cd33d1f53d14bc63f3e82 DIFF: https://github.com/llvm/llvm-project/commit/7f2f0247f855b143c12cd33d1f53d14bc63f3e82.diff

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 347401. urnathan added a comment. Addressing Davrec's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/DeclCXX.h clang/

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

aaron.ballman closed this revision. aaron.ballman added a comment. In D102906#2777296 , @ivanmurashko wrote: > Hi @aaron.ballman > >> Thanks! Do you need someone to commit on your behalf? > > I will appreciate your assistance in the diff landing. Thank

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann marked an inline comment as done. mgartmann added a comment. Dear reviewers, Since this work was conducted as part of a Bachelor's thesis, which has to be handed in on the 18th of June, 2021, we wanted to add a friendly ping to this patch. It would make us, the thesis team, proud to st

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

mgartmann added a comment. Dear reviewers, Since this work was conducted as part of a Bachelor's thesis, which has to be handed in on the 18th of June, 2021, we wanted to add a friendly ping to this patch. It would make us, the thesis team, proud to state that some of our work was accepted and i

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan marked 2 inline comments as done. urnathan added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3390 ConstructorUsingShadowDecl(ASTContext &C, DeclContext *DC, SourceLocation Loc, - UsingDecl *Using, NamedDecl *Target, +

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 347403. urnathan added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaD

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 347405. urnathan added a comment. Address davrec's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h clang/

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 347406. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl marked an inline comment as done. yaxunl added a comment. In D101630#2748513 , @tra wrote: > How about this: > If the user explicitly specified `--cuda-host-only` or `--cuda-device-only`, > then by default only allow producing the natural output f

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl updated this revision to Diff 347400. yaxunl added a comment. fixed option. bundle output if users specify output by -o or -E CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101630/new/ https://reviews.llvm.org/D101630 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#2776237 , @jdoerfert wrote: > This allows us to remove the switch in the device runtime, right? Yes, with a complication: for combined directives of worksharing loops (distributed parallel for) clang emits the l

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

aaron.ballman added a comment. In D49864#2777300 , @janosimas wrote: > I found the issue with my diff and I was able to get the expected file. > > I'm still having issues uploading the file, this is the message I get in the > browser console: > > POST h

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. In D101868#2776633 , @HazardyKnusperkeks wrote: > In D101868#2775550 , @feg208 wrote: > >> This reworks substantially this commit. I recognize there are lacking/broken >> tests but I just

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

delesley added a comment. I have a few concerns. First, this patch introduces an inconsistency between managed and unmanaged locks. For unmanaged locks, we warn, and //then assume the lock is held exclusively//. For managed locks, we don't warn, but //assume it is held shared//. The warn/no

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 added a comment. Dear reviewers, Since this work was conducted as part of a bachelor's thesis, which has to be handed in on the 18th of June 2021, we wanted to add a friendly ping to this patch. It would make us, the thesis team, proud to state that some of our work was accepted and inclu

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 347419. feg208 added a comment. clang-tidy and clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst c

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

delesley added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:4570 mu_.AssertHeld(); -mu_.Unlock(); - } // should this be a warning? +mu_.Unlock(); // should this be a warning? + } This function should have a warni

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen added a comment. @dexonsmith anything else required before this can land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101775/new/ https://reviews.llvm.org/D101775 ___ cfe-commits mailing list cfe

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal added a comment. Could you please reupload your diff to retrigger the bots? I'd like to make sure that everything passes, even the tests that do not belong to you. Unfortunately, I don't know any better way of retriggering the pre-merge checks - I don't have permission to manually retri

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. Herald added a subscriber: manas. @NoQ can you please have another look at this? I think it will be a useful checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 _

[PATCH] D101965: Added Support for Warning Flag -Wstack-usage=

rsanthir.quic abandoned this revision. rsanthir.quic added a comment. Moving forward with simpler approach here: https://reviews.llvm.org/D102782 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101965/new/ https://reviews.llvm.org/D101965 __

[PATCH] D101964: Added support for -Wstack-usage flag and Framesize reporting fix

rsanthir.quic abandoned this revision. rsanthir.quic added a comment. Moving forward with simpler approach here: https://reviews.llvm.org/D102782 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101964/new/ https://reviews.llvm.org/D101964 __

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh updated this revision to Diff 347428. svenvh edited the summary of this revision. svenvh added a comment. Fix formatting issues, rebase patch, add test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 Files: clang/test/Headers/lit.local

[PATCH] D103036: [cfe][inline-asm] Support target-specific escaped character in inline asm

myhsu created this revision. myhsu added reviewers: nickdesaulniers, nathanchance, m_zuckerman, rnk. myhsu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC allows each target to define a set of non-letter and non-digit escaped character

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:48-61 +void assign2() { + struct st_long_double st; +#ifndef NOERROR + // expected-error@+2{{long double is not supported on this target}} +#endif + st.ld = 0.42; +} pengfei wrote: > asav

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 347441. OikawaKirie added a comment. Re-submit the patch to re-build the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.llvm.org/D101763 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h clang/lib/Cr

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic updated this revision to Diff 347443. asavonic added a comment. Added LIT run lines for i686 and windows targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 Files: clang/include/clang/Basic/

[PATCH] D103036: [cfe][inline-asm] Support target-specific escaped character in inline asm

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1094-1095 + // Replace some escaped characters with another string based on + // target-specific rules + virtual llvm::Optional handleAsmEscapedChar(char C) const { Use

[PATCH] D103036: [cfe][inline-asm] Support target-specific escaped character in inline asm

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; please fix up minor nits. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103036/new/ https://review

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 347446. OikawaKirie added a comment. Re-submit the patch to re-build the code. Sorry for the spam of submitting an incomplete diff which triggers a patch apply failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a subscriber: echristo. tra added a comment. In D101630#2777346 , @yaxunl wrote: > In D101630#2748513 , @tra wrote: > >> How about this: >> If the user explicitly specified `--cuda-host-only` or `--cuda-

[PATCH] D102975: [HIP] Check compatibility of -fgpu-sanitize with offload arch

tra added inline comments. Herald added a subscriber: foad. Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:114-115 + /// specified and valid. + std::tuple, Optional, + Optional>> + getParsedTargetID(const llvm::opt::ArgList &DriverArgs) const; I'

[clang] 9a75c06 - [CUDA] Work around compatibility issue with libstdc++ 11.1.0

Author: Artem Belevich Date: 2021-05-24T11:07:09-07:00 New Revision: 9a75c06cd9d94d3fd13c47a01044da97b98cf26b URL: https://github.com/llvm/llvm-project/commit/9a75c06cd9d94d3fd13c47a01044da97b98cf26b DIFF: https://github.com/llvm/llvm-project/commit/9a75c06cd9d94d3fd13c47a01044da97b98cf26b.diff

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a75c06cd9d9: [CUDA] Work around compatibility issue with libstdc++ 11.1.0 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ htt

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

aaron.ballman added a comment. FWIW, this looks like it's also partially covering `-Wnon-virtual-dtor`, but that doesn't seem to have the checks for a protected destructor. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualBaseClassDestructorCheck.cpp:110-111

[PATCH] D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think this is good to go, I haven't observed any issues with this patch so far in my testing. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas updated this revision to Diff 347459. janosimas added a comment. I manage to upload it, copy-pasting the content to the text box. I have no idea why it is not working with the upload. Updates from the last change - Modified the tests to match the input - Addend file context Reposito

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. > Hmm, I'm not certain what's going on there. When I try to upload a patch for > the review, Phab lets me upload it (but I didn't try to submit the changes). > At what stage are you getting the failure? Is it when uploading the patch > itself, or at some other point?

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

arphaman added a comment. Hey, thanks for following up on this PR. I've done some more digging and I think we can remove this Darwin-specific workaround in the near future. I'm hoping to provide an update in the next few weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3961 +def warn_deprecated_ignored_on_using : Warning< + "%0 currently has no effect on using-declarations">, + In

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal accepted this revision. steakhal added a comment. It seems like everything passes. Yeey, good job! Shall I commit this tomorrow on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.llvm.org/D101763 __

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

jroelofs closed this revision. jroelofs added a comment. This landed in 1deee5cacbb76578367186d7ff2937b6fa79b827 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95070/new/ https:/

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp:22 +namespace { +auto hasAnyWhitelistedName(const std::string &Names) { + const std::vector NameList = Comment at: clang-tools-

[PATCH] D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType

victordk created this revision. victordk added reviewers: ilya-biryukov, saugustine. victordk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Template args of outer types were not fully-qualified when calling getFullyQualifiedType() for in

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

reikdas created this revision. reikdas added a reviewer: rsmith. reikdas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a default template type argument is manually specified to be of the default type, then it is committed when printin

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

aaron.ballman added a comment. In D49864#274 , @janosimas wrote: > I manage to upload it, copy-pasting the content to the text box. I have no > idea why it is not working with the upload. > > Updates from the last change > > - Modified the tests to ma

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. In D101192#2763498 , @mibintc wrote: > let 'er rip Thanks @mibintc! @rsmith -- I'll land this sometime later this week unless I hear further comments from you. If I land it and you still have feedback, I can address it p

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347475. jankratochvil added a comment. Update of the testcase but it still does not reproduce the LLDB problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

rjmccall added a comment. The Clang part of this looks fine to me; I can't review the backend changes, but you have partial approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 _

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added a comment. cat >1.cpp < struct DWrapper {}; typedef DWrapper DW; struct B { DW spd; } b; struct E { B &b_ref = b; static DW f() { return {}; } } e; EOH $ (set -ex;./bin/clang -c -o 1.o 1.cpp -Wall -g;./bin/lldb -b ./1.o -o 'p E' -o 'p e') (lldb) p

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347478. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp lldb/source/Plugins/Typ

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie added a comment. In D101763#2777821 , @steakhal wrote: > It seems like everything passes. Yeey, good job! > Shall I commit this tomorrow on your behalf? I do not have commit access to the code base. It would be appreciated if you could commi

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

rjmccall added a reviewer: rsmith. rjmccall added a comment. Top-level qualifiers aren't normally meaningful on pr-values. The C standard says that casts are to the unqualified type: N2454 6.5.4p5: Preceding an expression by a parenthesized type name converts the value of the expression to th

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas updated this revision to Diff 347489. janosimas added a comment. Fix a mistake in my last patch. I added a `--` in a command that should not have it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

rsmith added a comment. In D102689#2778011 , @rjmccall wrote: > The C++ standard does not appear to have similar wording. On the other hand, > the C++ standard says that e.g. "The result of the expression `(T) > cast-expression` is of type `T`", and si

[PATCH] D97340: [HIP] Support Spack packages

haampie added a comment. Herald added a subscriber: foad. Hi Yaxunl, > The patch should not cause circular dependency on HIP or device library. I'm not saying this patch introduces a circular dependency, I'm saying you are trying to solve an already existing circular dependency (clang needs dev

[clang] 13dd65b - Do not create LLVM IR `constant`s for objects with dynamic initialisation

Author: Momchil Velikov Date: 2021-05-24T22:04:15+01:00 New Revision: 13dd65b3a1a3ac049b5f3a9712059f7c61649bea URL: https://github.com/llvm/llvm-project/commit/13dd65b3a1a3ac049b5f3a9712059f7c61649bea DIFF: https://github.com/llvm/llvm-project/commit/13dd65b3a1a3ac049b5f3a9712059f7c61649bea.dif

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

This revision was automatically updated to reflect the committed changes. Closed by commit rG13dd65b3a1a3: Do not create LLVM IR `constant`s for objects with dynamic initialisation (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: tejohnson, craig.topper, RKSimon. Herald added subscribers: dexonsmith, pengfei, hiraditya, qcolombet. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commit

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

aybassiouny updated this revision to Diff 347504. aybassiouny added a comment. Add an assert CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unit

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 347508. Meinersbur added a comment. - Merge branch 'arcpatch-D102180' into HEAD - Use SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/in

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

rjmccall added a comment. In D102689#2778072 , @rsmith wrote: > In D102689#2778011 , @rjmccall > wrote: > >> The C++ standard does not appear to have similar wording. On the other >> hand, the C++ standard says

Re: [clang] b89e09a - Silence "Undefined or garbage value returned to caller" static analysis warning. NFCI.

If this is meant to be NFC, I guess the function is never meant to return null? (it's meant to be an invariant of the code that at least one of the builders is valid) - if that's the case, I'm not sure if this is good change. If there is a bug in the future that causes there to be an no valid buil

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

dblaikie added a comment. FWIW, there's some way to post reviews in draft form (I think via arc --draft or something like that) - which would ensure that emails for the review aren't sent to the -commits mailing list for something you don't want folks on the -commits list to review just yet, et

[clang] de6164e - PR50456: Properly handle multiple escaped newlines in a '*/'.

Author: Richard Smith Date: 2021-05-24T16:21:03-07:00 New Revision: de6164ec4da0cfea1b0d0e472c432ea1be4d9c29 URL: https://github.com/llvm/llvm-project/commit/de6164ec4da0cfea1b0d0e472c432ea1be4d9c29 DIFF: https://github.com/llvm/llvm-project/commit/de6164ec4da0cfea1b0d0e472c432ea1be4d9c29.diff

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/10125/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

haowei added a comment. This CL breaks our mac builders as well. Could you either fix the test or revert the change please? Error message: TEST 'Clang :: CodeGenCXX/const-dynamic-init.cpp' FAILED Script: -- : 'RUN: at line 1'; /opt/staging/ll

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

davrec accepted this revision. davrec added a comment. Looks good, thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

  1   2   >