[PATCH] D97340: [HIP] Support Spack packages

2021-05-23 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D97340#2775477 , @haampie wrote: > Hi @tra and @yaxunl, I'm commenting as a reviewer of the spack pull request > for the rocm 4.2.0 ecosystem. First of all: thanks for caring about spack > installations, that's highly appreciat

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-23 Thread Fred Grim via Phabricator via cfe-commits
feg208 updated this revision to Diff 347252. feg208 added a comment. Fixes/adds a test that yielded a seg fault and quiets some clang-tidy checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: c

[PATCH] D102989: Align documentation in Format.h and ClangFormatStyleOptions.rst.

2021-05-23 Thread Max Sagebaum via Phabricator via cfe-commits
Max_S created this revision. Max_S requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102989 Files: clang/include/clang/Format/Format.h Index: clang/include/clang/Format/For

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

2021-05-23 Thread Max Sagebaum via Phabricator via cfe-commits
Max_S added a comment. In D98237#2775514 , @MyDeveloperDay wrote: > When you made this commit you didn't regenerate the > ClangFormatStyleOptions.rst from the Format.h using > clang/docs/tool/dump_format_style.py now anyone else using the tool hit > is

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-05-23 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD updated this revision to Diff 347259. RedDocMD added a comment. Refactors to make code more stylistically accurate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-05-23 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD updated this revision to Diff 347260. RedDocMD added a comment. Removed unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h c

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-05-23 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD added a comment. I have put in the refactors, @teemperor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-commits mailing list cfe-commits@lists.

[clang] c2f819a - [MC] Refactor MCObjectFileInfo initialization and allow targets to create MCObjectFileInfo

2021-05-23 Thread Fangrui Song via cfe-commits
Author: Philipp Krones Date: 2021-05-23T14:15:23-07:00 New Revision: c2f819af73c54a8cf923e5a25099ca95dbe76312 URL: https://github.com/llvm/llvm-project/commit/c2f819af73c54a8cf923e5a25099ca95dbe76312 DIFF: https://github.com/llvm/llvm-project/commit/c2f819af73c54a8cf923e5a25099ca95dbe76312.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-05-23 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. This allows us to remove the switch in the device runtime, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mai

[clang] 99d45ed - [Debug-Info] handle DW_TAG_rvalue_reference_type at strict DWARF.

2021-05-23 Thread Chen Zheng via cfe-commits
Author: Chen Zheng Date: 2021-05-23T21:24:13-04:00 New Revision: 99d45ed22fd9c08ae81110956a817ac0eacded2e URL: https://github.com/llvm/llvm-project/commit/99d45ed22fd9c08ae81110956a817ac0eacded2e DIFF: https://github.com/llvm/llvm-project/commit/99d45ed22fd9c08ae81110956a817ac0eacded2e.diff LO

[PATCH] D102996: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of integer 0/1 for the operand of bundle "clang.arc.attachedcall"

2021-05-23 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added reviewers: rjmccall, ab, fhahn, dexonsmith. ahatanak added a project: clang. ahatanak requested review of this revision. This should make it easier to understand what the IR is doing and also simplify some of the passes as they no longer have to tran

[PATCH] D102996: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of integer 0/1 for the operand of bundle "clang.arc.attachedcall"

2021-05-23 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. https://reviews.llvm.org/D103000 is the llvm patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102996/new/ https://reviews.llvm.org/D102996 ___ cfe-commits mailing list cfe-c

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

2021-05-23 Thread Jan Kratochvil via Phabricator via cfe-commits
jankratochvil updated this revision to Diff 347315. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.