[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 347104. georgi_igna added a comment. trailing whitespace solved in os_object_base.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files: clang/lib/Analysis/Re

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 347107. georgi_igna added a comment. whitespace issue solved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files: clang/lib/Analysis/RetainSummaryManager.cpp

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2774185 , @nickdesaulniers wrote: > - upgrade module merge strategy to Error Probably want a test using llvm-link or llvm-lto to check this behavior (that alike flags are getting propagated as expected and that con

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM. An additional review here would be nice though. > good, it appears the patch bot fail is fixed -- it seems unhappy with > non-tree-like dependency graphs, and tries to apply each reachable

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. arames requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. `size_t` varying across platforms can

[PATCH] D102663: Bug 49633 - Added warning for static inline global and namespaced declarations for c++17+

serberoth added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:7127 << FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc()); +} else if (SC == SC_Static && DC->isFileContext() && + getLangOpts().CPlusPlus17) { erichkea

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added a comment. In D102742#2774562 , @tejohnson wrote: > In D102742#2774185 , > @nickdesaulniers wrote: > >> - upgrade module merge strategy to Error > > Probably want a test using llvm-link or l

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347113. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - doxygen comments, test that module flags aren't emitted without flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2774639 , @nickdesaulniers wrote: > In D102742#2774562 , @tejohnson > wrote: > >> In D102742#2774185 , >> @nickdesaulniers wrote:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Will work on explicit LTO tests. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"non

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

jwakely requested changes to this revision. jwakely added a comment. This revision now requires changes to proceed. You can't use `__GLIBCXX__` this way. It will be different for different snapshots from the gcc-11 branch. I would just check RELEASE == 11. If `__failed_assertion` is present, you

[clang] 4468e5b - [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

Author: Martin Storsjö Date: 2021-05-22T00:05:31+03:00 New Revision: 4468e5b8999291cc84b78f33f207dcd0e58146bc URL: https://github.com/llvm/llvm-project/commit/4468e5b8999291cc84b78f33f207dcd0e58146bc DIFF: https://github.com/llvm/llvm-project/commit/4468e5b8999291cc84b78f33f207dcd0e58146bc.diff

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4468e5b89992: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa… (authored by mstorsjo). Repository: rG LLVM Github Mono

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpText<"In

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2774191 , @weiwang wrote: > In D101793#2772717 , @yaxunl wrote: > >> In D101793#2772461 , @weiwang >> wrote: >> >>> Thanks for the appr

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

jroelofs added a comment. why do module hashes need to be stable when cross-compiling? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 ___ cfe-commits mailing l

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347124. nickdesaulniers added a comment. Herald added a subscriber: steven_wu. - add llvm/tests/LTO/AArch64/ and test case for module attr mismatch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/n

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpTe

[clang] 91dfd68 - [NFC][HIP] fix comments in __clang_hip_cmath.h

Author: Yaxun (Sam) Liu Date: 2021-05-21T17:44:18-04:00 New Revision: 91dfd68e90156dab3cbf11c9ae677cf60b2df65c URL: https://github.com/llvm/llvm-project/commit/91dfd68e90156dab3cbf11c9ae677cf60b2df65c DIFF: https://github.com/llvm/llvm-project/commit/91dfd68e90156dab3cbf11c9ae677cf60b2df65c.dif

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:20 #include #include #include ashi1 wrote: > we may not need to `#include` limits and/or type_traits if we replaced them > with `__hip:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347130. nickdesaulniers added a comment. - moved module attr mismatch test to llvm/test/Linker/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpText<"In

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 _

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra updated this revision to Diff 347133. tra added a comment. Check only _GLIBCXX_RELEASE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 Files: clang/lib/Headers/cuda_wrappers/complex Index: clang/l

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added a comment. In D102936#2774686 , @jwakely wrote: > You can't use `__GLIBCXX__` this way. It will be different for different > snapshots from the gcc-11 branch. Some distros are already shipping gcc-11 > snapshots with later dates. > > I would j

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

yaxunl added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:79 +#if _GLIBCXX_RELEASE == 11 +#define __failed_assertion __cuda_failed_assertion +#endif May I ask where is __cuda_failed_assertion defined? Thanks. Repository: rG LLVM Github

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: llvm/lib/Support/Path.cpp:1237 RenameEC = copy_file(TmpName, Name); setDeleteDisposition(H, true); } amccarth wrote: > I'm curious if this path has ever been exercised. > > I see that rename_handle is

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. In D102706#2774018 , @MyDeveloperDay wrote: > Could you clang-format the tests please so I can more easily read them. Sure. I was just taking my queue from the rest of the file which appeared to intentionally not clang-format t

[clang] 033138e - [IR] make stack-protector-guard-* flags into module attrs

Author: Nick Desaulniers Date: 2021-05-21T15:53:30-07:00 New Revision: 033138ea452f5f493fb5095e5963419905ad12e1 URL: https://github.com/llvm/llvm-project/commit/033138ea452f5f493fb5095e5963419905ad12e1 DIFF: https://github.com/llvm/llvm-project/commit/033138ea452f5f493fb5095e5963419905ad12e1.di

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG033138ea452f: [IR] make stack-protector-guard-* flags into module attrs (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/n

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpTe

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:79 +#if _GLIBCXX_RELEASE == 11 +#define __failed_assertion __cuda_failed_assertion +#endif yaxunl wrote: > May I ask where is __cuda_failed_assertion defined? Thanks. The function is n

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 347150. vlovich marked 3 inline comments as done. vlovich added a comment. Review response. Updated the options I changed via the dump_format_style.py script but didn't ingest all the other changes it generated. Changed the SBPO option to have a more generic

[PATCH] D102730: [clang-format] Support custom If macros

vlovich added inline comments. Comment at: clang/docs/ReleaseNotes.rst:252 +- Option ``IfMacros`` has been added. This lets you define macros that get + formatted like conditionals much like ``ForEachMacros`` get stiled like + foreach loops. MyDeveloperDay wrot

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. In D102706#2774010 , @MyDeveloperDay wrote: > Is ```Signature``` effectively as is? Yes. I noted that it's the default behavior. Please let me know if I can clarify the documentation wording somehow (or if you have preferred wo

[PATCH] D102924: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102924/new/ https://reviews.llvm.org/D102924 __

[clang] f7788e1 - Revert "[NewPM] Only invalidate modified functions' analyses in CGSCC passes"

Author: Arthur Eubanks Date: 2021-05-21T16:38:03-07:00 New Revision: f7788e1bff223a58292b8b1d0818dac63b713ead URL: https://github.com/llvm/llvm-project/commit/f7788e1bff223a58292b8b1d0818dac63b713ead DIFF: https://github.com/llvm/llvm-project/commit/f7788e1bff223a58292b8b1d0818dac63b713ead.diff

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich updated this revision to Diff 347152. vlovich added a comment. Regen documentation & clang-format test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

dexonsmith added a comment. In D102943#2774732 , @jroelofs wrote: > why do module hashes need to be stable when cross-compiling? IIUC, the use case is cross-compiling when building the modules, which are then sent to the target to use when compiling oth

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

pcc added a comment. Isn't the bug here that module hashing is using `hash_code`? So shouldn't the correct fix be to use a specific hashing algorithm for module hashes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. In D102633#2773578 , @aganea wrote: > In D102633#2769762 , @arphaman > wrote: > >> It might be good for @aganea to take a look as well. > >

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. In D102943#2775115 , @pcc wrote: > Isn't the bug here that module hashing is using `hash_code`? So shouldn't the > correct fix be to use a specific hashing algorithm for module hash

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames added a comment. In D102943#2775131 , @dexonsmith wrote: > In D102943#2775115 , @pcc wrote: > >> Isn't the bug here that module hashing is using `hash_code`? So shouldn't >> the correct fix be to use a sp

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames added a comment. In D102943#2775099 , @dexonsmith wrote: > In D102943#2774732 , @jroelofs > wrote: > >> why do module hashes need to be stable when cross-compiling? > > IIUC, the use case is cross-compili

<    1   2