[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2769297 , @weiwang wrote: > Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. > The heap RSS did drop significantly (from peak 100GB to 59GB) , but not as > good as the current fix (peak 26GB),

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 346838. georgi_igna added a comment. some files were missing in the previous patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Anal

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2772021 , @yaxunl wrote: > In D101793#2769297 , @weiwang wrote: > >> Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. >> The heap RSS did drop signifi

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. I've verified that Tensorflow still builds with this patch and that the patch does fix the regressions we've seen. If you could land this patch soon, that would be appreciated. CHANGES SINCE

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2772033 , @weiwang wrote: > In D101793#2772021 , @yaxunl wrote: > >> In D101793#2769297 , @weiwang >> wrote: >> >>> Tried to make `Sema

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

modimo added a subscriber: urnathan. modimo added a comment. Discussing with @urnathan this makes more sense for the BE to handle when optimizing by eliding the generated null check. Confirmed this is indeed the case so removing the generation in the FE isn't really needed. CHANGES SINCE LAST

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo created this revision. mstorsjo added a reviewer: rnk. mstorsjo requested review of this revision. Herald added a project: clang. Actually compare each version to the version of the last chosen one. There's no guarantee that the added test case does showcase the previous issue (it depend

[clang] e620bea - [M68k] Allow user to preserve certain registers

Author: Min-Yih Hsu Date: 2021-05-20T13:57:22-07:00 New Revision: e620bea21199791513f3193a71b819b20a707ab1 URL: https://github.com/llvm/llvm-project/commit/e620bea21199791513f3193a71b819b20a707ab1 DIFF: https://github.com/llvm/llvm-project/commit/e620bea21199791513f3193a71b819b20a707ab1.diff L

[PATCH] D102805: [M68k] Allow user to preserve certain registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe620bea21199: [M68k] Allow user to preserve certain registers (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D102805?vs=34

[clang] dccf5c7 - [M68k] Support for inline asm operands w/ simple constraints

Author: Min-Yih Hsu Date: 2021-05-20T14:00:09-07:00 New Revision: dccf5c7dfb9e68f8750947f5c10ad3227cd92b50 URL: https://github.com/llvm/llvm-project/commit/dccf5c7dfb9e68f8750947f5c10ad3227cd92b50 DIFF: https://github.com/llvm/llvm-project/commit/dccf5c7dfb9e68f8750947f5c10ad3227cd92b50.diff L

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdccf5c7dfb9e: [M68k] Support for inline asm operands w/ simple constraints (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo updated this revision to Diff 346850. mstorsjo added a comment. Update another affected testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102873/new/ https://reviews.llvm.org/D102873 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb42564ec4b: [CUDA][HIP] Fix device variables used by host (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[clang] 4cb4256 - [CUDA][HIP] Fix device variables used by host

Author: Yaxun (Sam) Liu Date: 2021-05-20T17:04:29-04:00 New Revision: 4cb42564ec4b56ef7eb4758bfa4ddf844a163687 URL: https://github.com/llvm/llvm-project/commit/4cb42564ec4b56ef7eb4758bfa4ddf844a163687 DIFF: https://github.com/llvm/llvm-project/commit/4cb42564ec4b56ef7eb4758bfa4ddf844a163687.dif

[PATCH] D102814: [AIX] Print printable byte list as quoted string

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments; thanks! Comment at: llvm/include/llvm/MC/MCAsmInfo.h:268-270 + /// This directive allows emission of an ascii strin

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

bruno added a comment. Sounds reasonable to me! Can you double check whether this attribute gets correctly serialized/deserialized in face of `CXXNewExpr`? An example of how to test that would be in `clang/test/PCH/cxx-method.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102820/n

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. NeHuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is patch is in a series of patches to provide builtins for compat

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added a comment. In D102812#2770821 , @DavidSpickett wrote: > Given that using both options currently crashes clang (therefore no one is > relying on this yet) and GCC doesn't have `-mimplicit-it` I think what you > have is actually the best w

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo updated this revision to Diff 346856. mstorsjo added a comment. Updated to allow mismatches and just picking the value that is set last on the command line - what do you think of this version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D102876: Fix tmp files being left on Windows builds.

akhuang created this revision. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first writing to a .tmp file and then renaming to the fi

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. > verifyFormat("test() {\n" > > " ([]() -> {\n" > "int b = 32;\n" > "return 3;\n" > " }).foo();\n" > "}", > Style); > > There you have parenthesis around the lambda, how about without? > Maybe just something like > > std::sort(v.begin(), v.end(),

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

bruno added a comment. Overall looks good, sounds like it's failing tests though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list c

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102812/new/ https://reviews.llvm.org/D102812 __

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 346863. vlovich added a comment. Review response: - Added additional tests. - Added `KJ_IF_MAYBE` to default `IfMacros`. - Added links to KJ documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730

[PATCH] D102730: [clang-format] Support custom If macros

vlovich marked an inline comment as done. vlovich added inline comments. Comment at: clang/include/clang/Format/Format.h:2098 + /// + /// For example: KJ_IF_MAYBE. + std::vector IfMacros; HazardyKnusperkeks wrote: > vlovich wrote: > > Should I put a hyperlink

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 346864. vlovich marked an inline comment as done. vlovich added a comment. Updated release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Generally LGTM. Some nits. Comment at: clang/include/clang/Driver/Options.td:2331 PosFlag, NegFlag, BothFlags<[NoArgumentUnused, HelpHidden]>>; -def fopenmp_cuda_parallel_target_regions : Flag<["-"], "fopenmp-cuda-parallel-target-regions">,

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang updated this revision to Diff 346866. weiwang added a comment. make both ASTReader::DeclsToCheckForDeferredDiags and Sema::DeclsToCheckForDeferredDiags SmallSetVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101793/new/ https://review

[PATCH] D102879: rdar://77307290 (Disable retain-count tracking for references to OSMetaClass)

georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102879 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Analys

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/ https://reviews.llvm.org/D102772 _

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101793/new/ https://reviews.llvm.org/D101793 __

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich updated this revision to Diff 346869. vlovich added a comment. Herald added a subscriber: mgrang. Review response - Add examples to documentation + links to KJ style guide. - Add better header doc - Add more test cases - Add release notes - Note current "problem" test with a TODO (corner

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 346870. vlovich added a comment. Fixed missing _ after the hyperlink to the KJ link in the Style options documentation. I'm assuming that's required formatting for hyperlinks by what renders the markdown. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] e6b8320 - [clang][AST] Improve AST Reader/Writer memory footprint

Author: Wei Wang Date: 2021-05-20T15:34:29-07:00 New Revision: e6b8320c0a634ba60c82693c6631ea90fb2988a6 URL: https://github.com/llvm/llvm-project/commit/e6b8320c0a634ba60c82693c6631ea90fb2988a6 DIFF: https://github.com/llvm/llvm-project/commit/e6b8320c0a634ba60c82693c6631ea90fb2988a6.diff LOG:

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6b8320c0a63: [clang][AST] Improve AST Reader/Writer memory footprint (authored by weiwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2769747 , @akhuang wrote: > In D102736#2769358 , @amccarth > wrote: > >> At some point, the duplicate handle must be closed. I don't

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 346882. akhuang added a comment. Change to using TempFiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files: clang/include/clang/Frontend/CompilerInstance.h

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Thanks for the approval! Just want to understand the list of "decls to check for deferred diagnostics" better, where are these decls coming from? And why do they need to be checked for warnings? I see decls from libc are in the list, but I have no idea why are they sel

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757-760 +bool HaveSanitizeCoverage = +CGM.getCodeGenOpts().SanitizeCoverageType || +CGM.getCodeGenOpts().SanitizeCoverageIndirectCalls || +

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

bruno accepted this revision. bruno added a reviewer: rsmith. bruno added a comment. This revision is now accepted and ready to land. Thanks for adding the tests. LGTM after some remaining nitpick. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11632 + // As with enum-decls, we ig

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2772461 , @weiwang wrote: > Thanks for the approval! > > Just want to understand the list of "decls to check for deferred diagnostics" > better, where are these decls coming from? And why do they need to be checked > f

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1-2 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s + hubert.reinterpretcast wrote: > hubert.r

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346907. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include/llvm/M

[clang] edf4d69 - [AIX] Print printable byte list as quoted string

Author: Jinsong Ji Date: 2021-05-21T02:37:55Z New Revision: edf4d69d3888d99187ac28cfcd96a93b41623896 URL: https://github.com/llvm/llvm-project/commit/edf4d69d3888d99187ac28cfcd96a93b41623896 DIFF: https://github.com/llvm/llvm-project/commit/edf4d69d3888d99187ac28cfcd96a93b41623896.diff LOG: [A

[PATCH] D102814: [AIX] Print printable byte list as quoted string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedf4d69d3888: [AIX] Print printable byte list as quoted string (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

modimo added a comment. In D102820#2772184 , @bruno wrote: > Sounds reasonable to me! Can you double check whether this attribute gets > correctly serialized/deserialized in face of `CXXNewExpr`? An example of how > to test that would be in `clang/test/

[PATCH] D52524: Add -Wpoison-system-directories warning

manojgupta added a comment. An earlier version did check for library directories [1]. I am not exactly sure why was it removed, maybe it didn't work. So if anyone is willing to test that, please apply the diff and try. [1] Diff https://reviews.llvm.org/D52524?id=215958 CHANGES SINCE LAST ACTI

[clang] 95423c7 - [clang][driver] Treat -flto=[auto, jobserver] as -flto

Author: Timm Bäder Date: 2021-05-21T08:38:41+02:00 New Revision: 95423c7c990d9100deb0056bd9738717cb2bcf2d URL: https://github.com/llvm/llvm-project/commit/95423c7c990d9100deb0056bd9738717cb2bcf2d DIFF: https://github.com/llvm/llvm-project/commit/95423c7c990d9100deb0056bd9738717cb2bcf2d.diff LO

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

This revision was automatically updated to reflect the committed changes. Closed by commit rG95423c7c990d: [clang][driver] Treat -flto=[auto,jobserver] as -flto (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https:/

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Andreas-Krebbel added a comment. > But looking at the GCC sources, it seems we actually intended to support this > use as well, there's just a bug. Given that, I think I'd be fine with > adding this to LLVM -- I'll make sure the GCC bug gets fixed as well. I've fixed the GCC issue now: https

<    1   2