[PATCH] D102736: Fix tmp files being left on Windows builds.

aganea added a comment. Do you think the existing crash tests can be modified to validate that .tmp files are deleted indeed? Comment at: clang/lib/Frontend/CompilerInstance.cpp:829 +Binary ? llvm::sys::fs::OF_None : llvm::sys::fs::OF_Text; +// Use OF_Delete on Win

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346308. Xiangling_L added a comment. Add comments to the block; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715 Files: clang/test/Sema/struct-packed-align.c Index: clang/test/Sema/struct-packed-ali

[PATCH] D102736: Fix tmp files being left on Windows builds.

rnk added a subscriber: jansvoboda11. rnk added a comment. For other reviewers, I know Duncan, @dexonsmith, has also spent some time working on the clang output file management APIs. And @jansvoboda11 as well, I think. Comment at: clang/lib/Frontend/CompilerInstance.cpp:720 +

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth added a comment. I'll have to dig into my archived email tomorrow. I seem to recall some thrashing on this topic a few months ago. If I'm remembering correctly, setting the disposition to delete temporary files on Windows was causing problems with Rust builds because you can't always

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

NoQ added a comment. In D102696#2766765 , @martong wrote: > In D102696#2766337 , @NoQ wrote: > >> Ok so the state has enough constraints. It's enough to know that `$x + $y == >> 0` and `$y == 0` in order to deduc

[PATCH] D102736: Fix tmp files being left on Windows builds.

aganea added a comment. In D102736#2767516 , @amccarth wrote: > I seem to recall some thrashing on this topic a few months ago. If I'm > remembering correctly, setting the disposition to delete temporary files on > Windows was causing problems with Rus

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. Here's a slightly simpler reproducer: https://godbolt.org/z/85EsxnPPM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102237/new/ https://reviews.llvm.org/D102237 ___ cfe-commits maili

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, pcc, xiangzhangllvm. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-co

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Obviously needs work/cleanup, changes to x86, and tests, but posting for early feedback about module level attributes vs function level attributes, or possibly something else. I tested this quickly with thin LTO

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

dblaikie added a comment. Thanks for following up on this. - Probably best to commit the revert of the workarounds as a separate follow-up commit, but I appreciate seeing them here to understand that this patch addresses them - Comment at: clang/lib/Sema/SemaChecking.cpp:104

[PATCH] D102715: [AIX] Fix LIT failure on native aix

hubert.reinterpretcast added a comment. From the comment, it seems the code as-is fails to test the property intended. It seems we want this: struct packed_chars { char a : 8, b : 8, c : 8, d : 4; char e : 8 __attribute__((packed)); char f : 4, g : 8, h : 8, i : 8; }; extern in

[clang] b5a80a0 - [CMake] Update Cmake cache file for Win to ARM Linux cross builds. NFC

Author: Vladimir Vereschaka Date: 2021-05-18T20:29:16-07:00 New Revision: b5a80a0f370ca218d935991fe2bec0d19ca3ba51 URL: https://github.com/llvm/llvm-project/commit/b5a80a0f370ca218d935991fe2bec0d19ca3ba51 DIFF: https://github.com/llvm/llvm-project/commit/b5a80a0f370ca218d935991fe2bec0d19ca3ba51

[PATCH] D102196: [NewPM] Add options to PrintPassInstrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c509dbc7e29: [NewPM] Add options to PrintPassInstrumentation (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 0c509db - [NewPM] Add options to PrintPassInstrumentation

Author: Arthur Eubanks Date: 2021-05-18T20:59:35-07:00 New Revision: 0c509dbc7e29cbd03f161513b8d335f768c7cc2b URL: https://github.com/llvm/llvm-project/commit/0c509dbc7e29cbd03f161513b8d335f768c7cc2b DIFF: https://github.com/llvm/llvm-project/commit/0c509dbc7e29cbd03f161513b8d335f768c7cc2b.diff

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC + SCUDO_STANDALONE_TEST_TAR

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu updated this revision to Diff 346338. myhsu marked 2 inline comments as done. myhsu added a comment. Fixed lint warning and added more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 Files: clang/lib/Basic/Targets/M68k.cpp

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); nickdesaulniers wrote: > did you mean to drop support for `'f'`? To drop it for now.

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

pengfei added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:48-61 +void assign2() { + struct st_long_double st; +#ifndef NOERROR + // expected-error@+2{{long double is not supported on this target}} +#endif + st.ld = 0.42; +} These seems pass with

<    1   2