[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

ychen added inline comments. Comment at: clang/test/Misc/inline-asm-clobber-warning.c:26 +// CHECK-NEXT: nop +// CHECK-NEXT: ^ DavidSpickett wrote: > I think this `^` is wrong because we don't/can't account for the asm printer > tabbing in the instructio

[clang] 2075f2b - [clang] Support -fpic -fno-semantic-interposition for RISCV

Author: Fangrui Song Date: 2021-05-11T11:38:32-07:00 New Revision: 2075f2b296b0fa90cb7597f0f318232940d29e95 URL: https://github.com/llvm/llvm-project/commit/2075f2b296b0fa90cb7597f0f318232940d29e95 DIFF: https://github.com/llvm/llvm-project/commit/2075f2b296b0fa90cb7597f0f318232940d29e95.diff

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2075f2b296b0: [clang] Support -fpic -fno-semantic-interposition for RISCV (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, Do you want to change it to a scoped enum or will this cause major issues? ClangABI is a scoped enum?!? CHANGES SINCE LAST ACT

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

aaron.ballman added a comment. In D102134#2751184 , @pooja2299 wrote: > In D102134#2747649 , @aaron.ballman > wrote: > >> Minor wordsmithing on the documentation changes, but more importantly: why >> is the corr

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, tschuett wrote: > Do you want to change it to a scoped enum or will this cause major issues? > ClangABI is a scoped enum?!?

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

arsenm added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2244-2247 +and is an optimization hint. It is mandatory to use this attribute in some +situations. Because when the attribute is absent, the compiler assumes the +default maximum workgroup size of 2

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently clang does not emit device template variables instantiated only in host functions, however, nvcc is able to do that: https://godbolt.org/z/fneEfferY This patch fixes this issue by refa

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a comment. I'll push this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. No worries. I just wondered why only ClangABI is scoped ^^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D102261: Introduce SYCL 2020 mode

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, aaron.ballman wrote: > tschuett wrote: > > Do you want to change it to a scoped enum or will this cause major issues? > > Clan

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2751782 , @tschuett wrote: > No worries. I just wondered why only ClangABI is scoped ^^ :-) FWIW, I think it's because `LangOptions::Ver1` would be hard to understand compared to `LangOptions::ClangABI::Ver1`,

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added inline comments. Comment at: llvm/include/llvm/MC/MCObjectFileInfo.h:255 + virtual unsigned getTextSectionAlignment() const { return 4; } MCSection *getTextSection() const { return TextSection; } This should be moved to D102052 =

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. But there is no SYCLMinorVersion today. So enum class SYCLVersion would suffice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:407 - MOFI->initMCObjectFileInfo(Ctx, PIC); + // FIXME: This is not pretty. MCContext has a ptr to MCObjectFileInfo and + // MCObjectFileInfo needs a MCContext reference in order to initialize itse

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. In D102261#2751819 , @tschuett wrote: > But there is no SYCLMinorVersion today. So enum class SYCLVersion would > suffice. I don't think the presence of the word 'Major' in Aaron's suggestion is the most offensive to me. Wh

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. The Ver in Ver2020 is redundant ::2020 would suffice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. In D102261#2751832 , @tschuett wrote: > The Ver in Ver2020 is redundant ::2020 would suffice. That is not valid syntax. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 344538. jhuber6 added a comment. Fixing tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files: clang/include/clang/Basic/LangOptions.def clang/include/

[PATCH] D102270: [CUDA][HIP] Fix device template variables

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Perhaps it would make sense to combine this patch with D102237 as both patches are changing the same code for the same reason, just for slightly d

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 344549. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reorder USE/DEF, add -verify-machineinstrs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. In D100919#2750125 , @dmgreen wrote: > It's worth adding -verify-machineinstrs to the tests, to check the code > passes the internal checks. Done. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + pzheng wrote: > MaskRay wrote: > > CC1 needs two options? > > >

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

steakhal added reviewers: NoQ, vsavchenko, steakhal. steakhal added a comment. I'm gonna have a look at this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 _

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102251/new/ https://reviews.llvm.org/D102251 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

steakhal added a comment. In D99260#2704102 , @NoQ wrote: > In https://bugs.llvm.org/show_bug.cgi?id=45786 the godbolt link shows that > there are still problems with `addressof` (yes, their "trunk" clang is fresh > enough). They seem to have `__addresso

[PATCH] D100919: [AArch64] Support customizing stack protector guard

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 +.addDef(Reg) +.addImm(Options.StackProtectorGuardOffset >> 3); + else nickdesaulniers wrote: > dmgreen wrote: > > What is StackProtectorGuar

LLVM build master will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46475a79f85b: [AIX][TLS] Diagnose use of unimplemented TLS models (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 46475a7 - [AIX][TLS] Diagnose use of unimplemented TLS models

Author: Victor Huang Date: 2021-05-11T17:21:08-05:00 New Revision: 46475a79f85b230fde3e7de8966c96bef14f0d24 URL: https://github.com/llvm/llvm-project/commit/46475a79f85b230fde3e7de8966c96bef14f0d24 DIFF: https://github.com/llvm/llvm-project/commit/46475a79f85b230fde3e7de8966c96bef14f0d24.diff

[clang] 5cb1772 - [clang][Fuchsia] Introduce compat multilibs

Author: Leonard Chan Date: 2021-05-11T15:45:38-07:00 New Revision: 5cb17728d19408725d4ced928ff3276dd4ffd1c9 URL: https://github.com/llvm/llvm-project/commit/5cb17728d19408725d4ced928ff3276dd4ffd1c9 DIFF: https://github.com/llvm/llvm-project/commit/5cb17728d19408725d4ced928ff3276dd4ffd1c9.diff

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG5cb17728d194: [clang][Fuchsia] Introduce compat multilibs (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D102030?vs=343526&id=

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > aaron.ballman wrote: > > dblaikie wrote: > > > aaron.ballman wrote: > > > > dblaikie wro

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

akyrtzi added a comment. To clarify, I was suggesting that //in addition// to removing the space from unhandled types, we also handle the member function pointer type and not leave it in this fallback case. Types should have unique USR characters so that overloaded functions (overloaded on the

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > aaron.ballman wrote: > > > dblaikie wrote: > > > > aaron.ballman wro

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > aaron.ballman wrote: > > > > dblaikie wrote: > > >

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > aaron.ballman wrote: > > >

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 +.addDef(Reg) +.addImm(Options.StackProtectorGuardOffset >> 3); + else dmgreen wrote: > nickdesaulniers wrote: > > dmgreen wrote: > >

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse created this revision. morehouse added reviewers: vitalybuka, eugenis. Herald added subscribers: dexonsmith, mgorny. morehouse requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. -fsanitize=lam is intended to be

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc, diag::err_ref_bad_target) - << /*host*/ 2

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 344602. ychen added a comment. - Rebase on updated D102145 (use `llvm.coro.raw.frame.ptr.addr` during allocation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl added a comment. In D102270#2751852 , @tra wrote: > LGTM in general. > Perhaps it would make sense to combine this patch with D102237 > as both patches are changing the same code > for the same reason, just for

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

rsmith added a comment. (No blocking concerns here.) Comment at: clang/lib/AST/Stmt.cpp:1000-1003 + if (Optional Result = + const_cast(this)->getNondiscardedCase(Ctx)) +return *Result; + return None; Can this simply be ``` return const_cast(thi

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl updated this revision to Diff 344605. yaxunl added a comment. Revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102270/new/ https://reviews.llvm.org/D102270 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/C

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2747142 , @ChuanqiXu wrote: >> which should be correct. It is implemented by >> CodeGenFunction::EmitBuiltinAlignTo. > > I agree it is correct. I just want to say we should comment it to avoid > confusing. Happy to do it

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen updated this revision to Diff 344609. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102147/new/ https://reviews.llvm.org/D102147 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/Bu

[clang] 697ac15 - Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

Author: Richard Smith Date: 2021-05-11T17:35:33-07:00 New Revision: 697ac15a0fc71888c372667bdbc5583ab42d4695 URL: https://github.com/llvm/llvm-project/commit/697ac15a0fc71888c372667bdbc5583ab42d4695 DIFF: https://github.com/llvm/llvm-project/commit/697ac15a0fc71888c372667bdbc5583ab42d4695.diff

[clang] 3978333 - Add test for PR50039.

Author: Richard Smith Date: 2021-05-11T17:35:34-07:00 New Revision: 3978333b71bff3516ad69aac484b808617976c7a URL: https://github.com/llvm/llvm-project/commit/3978333b71bff3516ad69aac484b808617976c7a DIFF: https://github.com/llvm/llvm-project/commit/3978333b71bff3516ad69aac484b808617976c7a.diff

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG697ac15a0fc7: Fix bad mangling of for a closu

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, xazax.hun, vsavchenko. Herald added subscribers: martong, mgehre, rnkovacs. NoQ requested review of this revision. Herald added a project: clang-tools-extra. If the loop condition is a value of an instance variable,

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

tstellar added a comment. I was originally skeptical of this change, because of some negative feedback about these flags in the past on the Fedora development list. However, the people I've talked to more recently seem to be in favor of this change, so no objection from me. Repository: rG

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

NoQ updated this revision to Diff 344616. NoQ added a comment. Fix typo in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102294/new/ https://reviews.llvm.org/D102294 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/test/clang-tidy/checkers

[clang] bb72638 - Revert "Fix bad mangling of for a closure in the initializer of a variable at global namespace scope."

Author: Richard Smith Date: 2021-05-11T17:46:18-07:00 New Revision: bb726383ac7554857c62edd2d19e83dc713165ee URL: https://github.com/llvm/llvm-project/commit/bb726383ac7554857c62edd2d19e83dc713165ee DIFF: https://github.com/llvm/llvm-project/commit/bb726383ac7554857c62edd2d19e83dc713165ee.diff

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

rsmith reopened this revision. rsmith added a comment. (Reopening, earlier commit was accidental.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101968/new/ https://reviews.llvm.org/D101968 ___ cfe-commi

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl updated this revision to Diff 344629. yaxunl edited the summary of this revision. yaxunl added a comment. fix lint warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102270/new/ https://reviews.llvm.org/D102270 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/AST

<    1   2