[PATCH] D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

This revision was automatically updated to reflect the committed changes. Closed by commit rG313ee609e16b: [OpenMP] Fix non-determinism in clang task codegen (lastprivates) (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[clang] 92f2c39 - [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-05-04T12:06:03-07:00 New Revision: 92f2c39f915adc8f71be02d2604df4916069c9d4 URL: https://github.com/llvm/llvm-project/commit/92f2c39f915adc8f71be02d2604df4916069c9d4 DIFF: https://github.com/llvm/llvm-project/commit/92f2c39f915adc8f71be02d2604df4916069c9d

[PATCH] D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG92f2c39f915a: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. In D101702#2736886 , @exv wrote: > According to the wiki, it seems like someone who has commit access must now > submit this change. Yes, I'll land it. Please provide "Name " for commit attribution if it differs from the info

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

martong added a comment. Thank you for this patch! Could you please provide a lit test that ignites the over and over parsing behaviour? I think you need to create two files and the second one should contain parser error(s). Comment at: clang/include/clang/CrossTU/CrossTrans

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv marked an inline comment as done. exv added a comment. Eliza Velasquez Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-com

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2728788 , @ABataev wrote: > In D99432#2726997 , @estewart08 > wrote: > >> In D99432#2726845 , @ABataev wrote: >> >>> In D99432#2726588

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2736970 , @estewart08 wrote: > In D99432#2728788 , @ABataev wrote: > >> In D99432#2726997 , @estewart08 >> wrote: >> >>> In D99432#2726845

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

hvdijk added a comment. Herald added a subscriber: pengfei. There is a risk of bitcode incompatibilities with this change, but we already have that the code we generate now is incompatible with GCC and results in crashes that way too, I don't think there's a perfect fix, I'd like it if we could

[clang] 6c3a107 - Mark Basic/TargetCXXABI.def as textual in the module map.

Author: Adrian Prantl Date: 2021-05-04T12:52:52-07:00 New Revision: 6c3a10760da3707186d5204bd9283e99344fa90f URL: https://github.com/llvm/llvm-project/commit/6c3a10760da3707186d5204bd9283e99344fa90f DIFF: https://github.com/llvm/llvm-project/commit/6c3a10760da3707186d5204bd9283e99344fa90f.diff

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

hvdijk created this revision. hvdijk added reviewers: sammccall, usaxena95. hvdijk added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgorny. hvdijk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. The current code acc

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ updated this revision to Diff 342844. NoQ added a comment. Unforget to add `-fblocks` to the bugprone-redundant-branch-condition checks. Thanks pre-commit testing! - it wasn't failing on my machine, I guess it's enabled by default on darwin. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added a comment. In D96215#2735546 , @njames93 wrote: > Just my $0.02, We shouldn't worry too much about pathological cases like > that. I imagine that code would almost never appear in the wild. And for > cases where you don't have access to definit

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added a comment. In D100934#2735955 , @jansvoboda11 wrote: > In D100934#2733857 , @dexonsmith > wrote: > >> Given that there are four different things being done in this commit, it >> sounds naively

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45 +// Treat lambda capture by reference as a form of taking a reference. +return llvm::any_of(LE->captures(), [Var](const LambdaCapture &C) { + return C.capturesVariable() &

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. I have completed two other formatting fixes related to C# 8 nullables since my last commit. Should I create a new review request for those or update this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://r

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Preferably a new one unless it's something really minor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

exv created this revision. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff is based on https://reviews.llvm.org/D101702. This fixes two errors: Previously, clang-format was splitting up type identifiers from the nullable ?.

[PATCH] D101862: [clang-format] Rename common types between C#/JS

exv created this revision. exv added a reviewer: curdeius. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is based on https://reviews.llvm.org/D101860 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10186

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. how's the runtime of this test compared to others in clang? Is it worth splitting it up to improve test execution parallelism? (I'm guessing /probably not/ (guess while the file is long, it's relatively simple for the compiler compared to some other non-trivial templat

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7 # namespace-qualified class name. +set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR}) function(gen_decision_forest model filename cpp_class) nit: Directly refer

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45 +// Treat lambda capture by reference as a form of taking a reference. +return llvm::any_of(LE->captures(), [Var](const LambdaCapture &C) { + return C.capturesVariable() && C.ge

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

echristo added inline comments. Comment at: clang/test/Frontend/invalid-cxx-abi.cpp:1 +// These should succeed. +// RUN: %clang -c -fc++-abi=itanium %s Following up on an offline conversation :) This should be a driver test rather than (what it ended up being) a

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

hvdijk updated this revision to Diff 342881. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101851/new/ https://reviews.llvm.org/D101851 Files: clang-tools-extra/clangd/quality/CompletionModel.cmake Index: clang-tools-extra/clangd/quality/Complet

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

hvdijk marked an inline comment as done. hvdijk added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7 # namespace-qualified class name. +set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR}) function(gen_decision_forest model filename cpp_class

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:9 function(gen_decision_forest model filename cpp_class) - set(model_compiler ${LLVM_EXTERNAL_

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for making this happen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 ___

[PATCH] D101867: [clang][test] Update -fc++-abi tests

leonardchan created this revision. leonardchan added a reviewer: echristo. leonardchan added a project: clang. Herald added a subscriber: phosek. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-a

[PATCH] D101867: [clang][test] Update -fc++-abi tests

echristo added a comment. Couple cleanups, but should be better now. Thanks! -eric Comment at: clang/test/Driver/cxx-abi-flag.cpp:3 +// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \ +// RUN: |& FileCheck %s -check-prefix=ITANIUM +// RUN: %clang -##

[PATCH] D101867: [clang][test] Update -fc++-abi tests

leonardchan updated this revision to Diff 342889. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-abi-flag.cpp clang/test/Front

[PATCH] D101867: [clang][test] Update -fc++-abi tests

leonardchan updated this revision to Diff 342891. leonardchan added a comment. Forgot the pipe in cxx-abi-flag.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-abi-flag.c

[clang] 0277a24 - [clang][test] Update -fc++-abi tests

Author: Leonard Chan Date: 2021-05-04T15:53:00-07:00 New Revision: 0277a24f4bbac284ba7a2ace7eeefdf6305e7f69 URL: https://github.com/llvm/llvm-project/commit/0277a24f4bbac284ba7a2ace7eeefdf6305e7f69 DIFF: https://github.com/llvm/llvm-project/commit/0277a24f4bbac284ba7a2ace7eeefdf6305e7f69.diff

[PATCH] D101867: [clang][test] Update -fc++-abi tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0277a24f4bba: [clang][test] Update -fc++-abi tests (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. At just under 4 seconds on my machine, it's certainly not one of the quickest clang lit tests, but neither is it one of the slowest. It looks like there are many that take tens of seconds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D101868: Adds a formatter for aligning arrays of structs

feg208 created this revision. feg208 added reviewers: tinloaf, djasper, klimek, curdeius. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a new formatter to arrange array of struct initializers into neat columns Reposito

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru created this revision. qdelacru added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. qdelacru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Having nested macros

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 342905. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebase, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D10

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:20 +; RUN: --stack-protector-guard-offset=-1 -o - | \ +; RUN: FileCheck --check-prefix=CHECK --check-prefix=CHECK-NPOT-NEG-OFFSET

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2737531 , @tlively wrote: > At just under 4 seconds on my machine, it's certainly not one of the quickest > clang lit tests, but neither is it one of the slowest. It looks like there > are many that take tens of seco

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64 Depends on D101872

MaskRay created this revision. MaskRay added reviewers: dmgreen, efriedma, peter.smith. Herald added subscribers: danielkiss, s.egerton, simoncook, kristof.beyls. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956cae2f09b2: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monore

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

tlively added inline comments. Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:351 IO.enumCase(ID, "scalable-vector", TargetStackID::ScalableVector); +IO.enumCase(ID, "object", TargetStackID::Object); IO.enumCase(ID, "noalloc", TargetStackID::NoAlloc); --

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) + .addImm(Options.StackPr

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

MaskRay created this revision. MaskRay added reviewers: craig.topper, jrtc27, luismarques, serge-sans-paille. Herald added subscribers: StephenFan, vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook. MaskRay requested review of this revision. H

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 342921. nickdesaulniers added a comment. - prefer addDef, explicit register kills Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files: clang/include/clang

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) + .addImm(Options.StackPr

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) + .addImm(Options.StackPr

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama created this revision. pirama added reviewers: MyDeveloperDay, srhines. pirama requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes PR46992. Git stores symlinks as text files and we should not format them even if they have one

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 342927. pirama added a comment. Leave two empty lines after filter_symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clan

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 8 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

penzn added a comment. I think there is another dimension to this aside from project composition - intrinsics have a tendency to "interact" with their surroundings, and it better to capture the IR rather than the end result. Even if we can verify that simple calls produce instructions we expect

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a subscriber: compnerd. Ericson2314 added a comment. @compnerd Would you like to review this one too (which the other you approved needs)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 abandoned this revision. Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D99755: Remove `clang/runtime`

Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://revi

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2737842 , @penzn wrote: > I think there is another dimension to this aside from project composition - > intrinsics have a tendency to "interact" with their surroundings, and it > better to capture the IR rather than t

[PATCH] D101883: [WebAssembly] Update SIMD builtin function operand types

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `const` to the pointer

[PATCH] D101883: [WebAssembly] Update SIMD builtin function operand types

tlively updated this revision to Diff 342946. tlively added a comment. - Remove (incorrect) const pointer changes. Will fix them and put them in a separate revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101883/new/ https://reviews.llvm.or

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek updated this revision to Diff 342950. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/ https://reviews.llvm.org/D101813 Files: clang/test/Driver/immediate-options.c clang/test/Driver/print

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the SIMD builtin load

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

MaskRay added inline comments. Comment at: clang/test/Driver/print-resource-dir.c:3 +// RUN:-resource-dir=%S/Inputs/resource-dir \ +// RUN: | FileCheck %s -check-prefix=PRINT-RESOURCE-DIR +// PRINT-RESOURCE-DIR: Inputs{{/|\\}}resource-dir You can use

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added a comment. I think this patch is ready to go: running the test-suite on an ARM machine didn't complain anything. Well, but one thing that I'm concerned about is that from tomorrow I'll not be online for about three weeks. :( I'd like to find someone who reverts this patch if there

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek updated this revision to Diff 342954. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/ https://reviews.llvm.org/D101813 Files: clang/test/Driver/immediate-options.c clang/test/Driver/print

[clang] cab3c6c - [clang][TargetCXXABI] Fix -Wreturn-type warning (NFC)

Author: Yang Fan Date: 2021-05-05T14:44:48+08:00 New Revision: cab3c6c6c48ed0da0f047bdc1a337d991c78ad8c URL: https://github.com/llvm/llvm-project/commit/cab3c6c6c48ed0da0f047bdc1a337d991c78ad8c DIFF: https://github.com/llvm/llvm-project/commit/cab3c6c6c48ed0da0f047bdc1a337d991c78ad8c.diff LOG:

[PATCH] D101885: [WebAssembly] Add SIMD const_splat intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These intrinsics do not corre

<    1   2