[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

MaskRay added inline comments. Comment at: clang/test/Driver/print-resource-dir.c:1 +// Test if the -print-resource-dir option is accepted without error. +// Allow unspecified output because the value of CLANG_RESOURCE_DIR is unknown. This isn't very useful. You

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. That's great. Thanks for working on this and for the cleanup. Comment at: clang/lib/Format/FormatTokenLexer.cpp:102 + +// FIXME: Investigate what token type giv

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

nikic added a comment. An unfortunate side-effect of this change is that NewPM uses even more memory. tramp3d-v4 is up 20% in max-rss (https://llvm-compile-time-tracker.com/compare.php?from=4ef1f90e4d564b872e3598ccef45adb740eb0f0d&to=d14d84af2f5ebb8ae2188ce6884a29a586dc0a40&stat=max-rss) Repos

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

jansvoboda11 accepted this revision. jansvoboda11 added a comment. Nice, thank you, Paul! Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, Were you planning to refactor this to

[PATCH] D101743: [clangd] Fix hover crash on broken code

kadircet updated this revision to Diff 342671. kadircet added a comment. - s/x/undefined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101743/new/ https://reviews.llvm.org/D101743 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D101743: [clangd] Fix hover crash on broken code

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2447 +// Setter variable heuristic might fail if the callexpr is broken. +struct X { int Y; void [[^setY]](float) { Y = foo(x); } };)cpp"); + hokein wrote: > IIU

[clang] b83b232 - Introduce -Wreserved-identifier

Author: serge-sans-paille Date: 2021-05-04T11:19:01+02:00 New Revision: b83b23275b745287bf9d3d72a93b593119f53f75 URL: https://github.com/llvm/llvm-project/commit/b83b23275b745287bf9d3d72a93b593119f53f75 DIFF: https://github.com/llvm/llvm-project/commit/b83b23275b745287bf9d3d72a93b593119f53f75.d

[PATCH] D93095: Introduce -Wreserved-identifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb83b23275b74: Introduce -Wreserved-identifier (authored by serge-sans-paille). Herald added a project: clang. Changed prior to commit: https://rev

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

krasimir added a comment. @penagos, I'll submit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang-tools-extra] f800ac8 - [clangd] Fix hover crash on broken code

Author: Kadir Cetinkaya Date: 2021-05-04T11:42:31+02:00 New Revision: f800ac8309417b78c084f2eabfd54d43a66b64a2 URL: https://github.com/llvm/llvm-project/commit/f800ac8309417b78c084f2eabfd54d43a66b64a2 DIFF: https://github.com/llvm/llvm-project/commit/f800ac8309417b78c084f2eabfd54d43a66b64a2.dif

[PATCH] D101743: [clangd] Fix hover crash on broken code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf800ac830941: [clangd] Fix hover crash on broken code (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342688. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-t

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342689. kbobyrev added a comment. Remove (now) unused Python JSON import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd/index/rem

[clang] 8fa56f7 - [clang-format] Prevent extraneous space insertion in bitshift operators

Author: Luis Penagos Date: 2021-05-04T12:28:49+02:00 New Revision: 8fa56f7ededcbe28cbbb810b5d261b72ab0d8035 URL: https://github.com/llvm/llvm-project/commit/8fa56f7ededcbe28cbbb810b5d261b72ab0d8035 DIFF: https://github.com/llvm/llvm-project/commit/8fa56f7ededcbe28cbbb810b5d261b72ab0d8035.diff

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa56f7ededc: [clang-format] Prevent extraneous space insertion in bitshift operators (authored by penagos, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D101516: Introduce clangd-server-monitor tool

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, let's ship it! Comment at: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp:15 +#include "llvm/Support/CommandLine.h" +#include "llvm/Support/FormatVaria

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342692. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: cla

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342693. kbobyrev added a comment. Remove leftover --with-monitor from the lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd

[clang-tools-extra] 34593ae - Introduce clangd-server-monitor tool

Author: Kirill Bobyrev Date: 2021-05-04T12:48:21+02:00 New Revision: 34593ae9982ad267639893ed4ce41242f9493056 URL: https://github.com/llvm/llvm-project/commit/34593ae9982ad267639893ed4ce41242f9493056 DIFF: https://github.com/llvm/llvm-project/commit/34593ae9982ad267639893ed4ce41242f9493056.diff

[PATCH] D101516: Introduce clangd-server-monitor tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34593ae9982a: Introduce clangd-server-monitor tool (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang-tools-extra] c2e9baf - [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

Author: Georgy Komarov Date: 2021-05-04T13:49:20+03:00 New Revision: c2e9baf2e8dafe92f57fe4171d4b6a5f50d5999e URL: https://github.com/llvm/llvm-project/commit/c2e9baf2e8dafe92f57fe4171d4b6a5f50d5999e DIFF: https://github.com/llvm/llvm-project/commit/c2e9baf2e8dafe92f57fe4171d4b6a5f50d5999e.diff

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2e9baf2e8da: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with… (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 342698. wingo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang datalayout expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.ll

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added a comment. In D100934#2733857 , @dexonsmith wrote: > Given that there are four different things being done in this commit, it > sounds naively like it should be four separate commits. If the logic is too > intertwined to land each of

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Were you planning to refactor this too? You can't use the pas

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, Paul-C-Anagnostopoulos wrote: > jansvoboda11 wrote: > > Were you planning to refactor this to

[PATCH] D101630: [HIP] Fix device-only compilation

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:977 NegFlag>; +defm hip_bundle_device_output : BoolFOption<"hip-bundle-device-output", EmptyKPM, DefaultTrue, + PosFlag, The TableGen marshalling infrastructure (`BoolFOpti

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

aaron.ballman added a comment. > Once accepted I'll need someone to commit the change on my behalf. Thanks for mentioning this up front! What email address and name would you like to have used for attribution on the commit? Comment at: clang/include/clang/Analysis/CFG.h:1392-

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I believe everything I pointed out so far has been resolved. I still have one more nit about the unit test though (just to not make it fail on some Windows setups). FWIW, given that thi

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. (Obviously this should still wait on Richard & John as I think they still have unaddressed objections) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailin

[clang] d0e3a15 - [clang][cli] NFC: Remove confusing `EmptyKPM` variable

Author: Jan Svoboda Date: 2021-05-04T14:27:57+02:00 New Revision: d0e3a15e36830d0fe6049eb0543f0af5a2e1ad12 URL: https://github.com/llvm/llvm-project/commit/d0e3a15e36830d0fe6049eb0543f0af5a2e1ad12 DIFF: https://github.com/llvm/llvm-project/commit/d0e3a15e36830d0fe6049eb0543f0af5a2e1ad12.diff L

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Paul-C-Anagnostopoulos wrote: > > jansvoboda11 wrote: > > > W

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342708. pmatos added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix patch submitted to phab... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342712. pmatos added a comment. Fix patch set... again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssembly.cpp llvm/include/l

[clang] 0089583 - [clang][cli][docs] Clarify marshalling infrastructure documentation

Author: Jan Svoboda Date: 2021-05-04T15:16:32+02:00 New Revision: 00895831ab23f4de2713a6ad529ba48773d067c1 URL: https://github.com/llvm/llvm-project/commit/00895831ab23f4de2713a6ad529ba48773d067c1 DIFF: https://github.com/llvm/llvm-project/commit/00895831ab23f4de2713a6ad529ba48773d067c1.diff L

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

baloghadamsoftware added a comment. In D101790#2734937 , @NoQ wrote: > +Adam, the original author of bugprone-redundant-branch-condition. Adam, do > you have any thoughts regarding the tests regressed by this patch? Are they > something we should absolu

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

jansvoboda11 added a comment. Nice, that looks better. I think we can optimize it a tad by introducing an enum with two cases and store that in `LangOptions` instead of a 32-bit number. Comment at: clang/include/clang/Basic/LangOptions.def:417 +COMPATIBLE_VALUE_LANGOPT(Exten

[clang] 64911ee - [OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0.

Author: Anastasia Stulova Date: 2021-05-04T14:30:42+01:00 New Revision: 64911eec75bb0c54e40665a2c3f744f046c66a59 URL: https://github.com/llvm/llvm-project/commit/64911eec75bb0c54e40665a2c3f744f046c66a59 DIFF: https://github.com/llvm/llvm-project/commit/64911eec75bb0c54e40665a2c3f744f046c66a59.d

[PATCH] D101052: [OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64911eec75bb: [OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

zahen updated this revision to Diff 342715. zahen added a comment. Updated the macro based on Aaron's suggestion. clang-formatted the function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101776/new/ https://reviews.llvm.org/D101776 Files: clang/include/clang/Analysis/CFG.h Inde

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

zahen added a comment. In D101776#2736003 , @aaron.ballman wrote: >> Once accepted I'll need someone to commit the change on my behalf. > > Thanks for mentioning this up front! What email address and name would you > like to have used for attribution on

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342718. pmatos added a comment. Fix broken merge of table ins reordering commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssem

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 342719. wingo added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets/WebAssembly.h clang/test/CodeGen/target

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:1524 + Alias, + HelpText<"Deprecated, use -fsanitize-coverage-ignorelist= instead">; def fsanitize_memory_track_origins_

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101832/new/ https://reviews.llvm.org/D101832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] db210bc - [Matrix] Implement C-style explicit type conversions in CXX for matrix types

Author: Saurabh Jha Date: 2021-05-04T15:27:57+01:00 New Revision: db210bc69bb50979fb843b68fcb71a9c905e971b URL: https://github.com/llvm/llvm-project/commit/db210bc69bb50979fb843b68fcb71a9c905e971b DIFF: https://github.com/llvm/llvm-project/commit/db210bc69bb50979fb843b68fcb71a9c905e971b.diff L

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb210bc69bb5: [Matrix] Implement C-style explicit type conversions in CXX for matrix types (authored by SaurabhJha, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342729. pmatos added a comment. Removed extraneous changes to previous patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssemb

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

saghir updated this revision to Diff 342732. saghir added a comment. Addressed review comments to add _mma_ version of the built-ins as aliases to the existing _vsx_ versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100482/new/ https://review

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

wingo added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:150 : WebAssemblyTargetInfo(T, Opts) { -resetDataLayout("e-m:e-p:32:32-i64:64-n32:64-S128"); +resetDataLayout("e-m:e-p:32:32-i64:64-n32:64-S128-ni:1"); } This change

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 342734. dgoldman added a comment. Fix test broken on non-macOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[clang] d882750 - [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

Author: Ella Ma Date: 2021-05-04T16:50:21+02:00 New Revision: d882750f1105b20d892545e7ebd96f82166dcb53 URL: https://github.com/llvm/llvm-project/commit/d882750f1105b20d892545e7ebd96f82166dcb53 DIFF: https://github.com/llvm/llvm-project/commit/d882750f1105b20d892545e7ebd96f82166dcb53.diff LOG:

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd882750f1105: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in… (authored by OikawaKirie, committed by steakhal). Changed prior to commit: https://reviews.llvm.org/D83660?vs

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); ABataev wrote: > jdoerfert wrote: > > ABata

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101776/new/ https://reviews.llvm.org/D101776 ___ cfe-commits mailing lis

[clang] 54bff15 - Rename a template parameter that conflicted with a common macro; NFC

Author: Zachary Henkel Date: 2021-05-04T11:19:54-04:00 New Revision: 54bff1522fc863329894d875d54c2fe4cd1b4f3f URL: https://github.com/llvm/llvm-project/commit/54bff1522fc863329894d875d54c2fe4cd1b4f3f DIFF: https://github.com/llvm/llvm-project/commit/54bff1522fc863329894d875d54c2fe4cd1b4f3f.diff

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've committed on your behalf in 54bff1522fc863329894d875d54c2fe4cd1b4f3f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101776

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342750. mibintc added a comment. Responded to suggestions from @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files: clang/include/clang/Basic/LangOp

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 342764. jdoerfert added a comment. Use mutateType, add test for static variable in function with allocate directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 342765. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Remove const cast, clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 Files

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, the only suggestion I have is below. Comment at: clang/lib/Driver/ToolChain.cpp:408 default: return getOS(); } It might be cleaner to do

[PATCH] D101755: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101755/new/ https://reviews.llvm.org/D101755

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert marked 7 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E);

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a subscriber: ggeorgakoudis. jdoerfert added a comment. I'll wait for @ggeorgakoudis to update the tests with the script, then I'll adjust all clang tests again. FWIW, this also fixes an issue in OpenMC where declare target triggered this: llvm-project/clang/lib/CodeGen/CodeGe

[clang] 5285748 - Fix assert on the variable which is used in omp clause is not marked

Author: Jennifer Yu Date: 2021-05-04T09:07:35-07:00 New Revision: 5285748c2c764c1d7fb3f882ba9f11ed79f676a1 URL: https://github.com/llvm/llvm-project/commit/5285748c2c764c1d7fb3f882ba9f11ed79f676a1 DIFF: https://github.com/llvm/llvm-project/commit/5285748c2c764c1d7fb3f882ba9f11ed79f676a1.diff L

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added a comment. In D101030#2736508 , @jdoerfert wrote: > I'll wait for @ggeorgakoudis to update the tests with the script, then I'll > adjust all clang tests again. FWIW, this also fixes an issue in OpenMC where > declare target triggered this:

[PATCH] D101781: Fix assert on the variable which is used in omp clause is not marked as used

This revision was automatically updated to reflect the committed changes. Closed by commit rG5285748c2c76: Fix assert on the variable which is used in omp clause is not marked (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101781/n

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia created this revision. Anastasia added reviewers: svenvh, olestrohm. Herald added subscribers: ebevhan, kerbowa, yaxunl, nhaehnle, jvesely, jholewinski. Anastasia requested review of this revision. Bitfields result in struct/union layout that is implementation dependent and therefore i

[PATCH] D101630: [HIP] Fix device-only compilation

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:977 NegFlag>; +defm hip_bundle_device_output : BoolFOption<"hip-bundle-device-output", EmptyKPM, DefaultTrue, + PosFlag, jansvoboda11 wrote: > The TableGen marshalling infrastructur

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. In D99599#2735582 , @evgeny777 wrote: >> I've already run into having to update these two golden file tests twice > > I think you can just reduce the tests. No need to revert the entire change, > unless there is a replacement for

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. > Could you explain why -debug-pass-manager doesn't fit your use case? I wanted to have something similar to -debug-pass=Structure, because the above is too verbose and lacks identation. What's the problem with this one, anyway? Repository: rG LLVM Github Monorepo

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 updated this revision to Diff 342778. njames93 added a comment. Add test case demonstrating new behvaiour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 Files: clang/lib/Format/Format.cpp c

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone added a comment. In D79714#2735455 , @Abpostelnicu wrote: > I'm seeing here something very strange, if the user provided copy assignment > operator is provided but is = delete and the copy constructor is default this > warning will still tri

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

MaskRay added subscribers: vitalybuka, MaskRay. MaskRay added a comment. I think @vitalybuka has concrete suggestion on the naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101832/new/ https://reviews.llvm.org/D101832

[PATCH] D100983: [OpenCL] Fix optional image types

azabaznov accepted this revision. azabaznov added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Thanks! Looks good to me in general. See a comment. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex updated this revision to Diff 342790. SilensAngelusNex retitled this revision from "Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`." to "Make `hasTypeLoc` matcher support more node types.". SilensAngelusNex added a comment. A

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 342792. mibintc added a comment. I rebased the patch and responded to review comments from @aaron.ballman and @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93

[clang-tools-extra] e1c729c - [clang-tidy][NFC] Update tests and Default options to use boolean value

Author: Nathan James Date: 2021-05-04T18:17:56+01:00 New Revision: e1c729c56829d3b9502b9ac2439003f87231db50 URL: https://github.com/llvm/llvm-project/commit/e1c729c56829d3b9502b9ac2439003f87231db50 DIFF: https://github.com/llvm/llvm-project/commit/e1c729c56829d3b9502b9ac2439003f87231db50.diff

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks added a comment. In D100917#2735651 , @nikic wrote: > An unfortunate side-effect of this change is that NewPM uses even more > memory. tramp3d-v4 is up 20% in max-rss > (https://llvm-compile-time-tracker.com/compare.php?from=4ef1f90e4d564b872e3

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1c729c56829: [clang-tidy][NFC] Update tests and Default options to use boolean value (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:138-150 +template struct disjunction; +template struct disjunction : public T {}; +template struct disjunction { + using type = + typename std::conditional>::type; +

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

mtrofin added a comment. In D100917#2736702 , @aeubanks wrote: > In D100917#2735651 , @nikic wrote: > >> An unfortunate side-effect of this change is that NewPM uses even more >> memory. tramp3d-v4 is up 20% in m

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:234 +FEM_Extended, +/// Use the default float eval method specified by Target +FEM_TargetDefault mibintc wrote: > aaron.ballma

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list cfe-commit

[clang] b451ecd - [Clang][AArch64] Disable rounding of return values for AArch64

Author: Andrew Savonichev Date: 2021-05-04T20:29:01+03:00 New Revision: b451ecd86e13ec6ef47caf37f62977645c4f748e URL: https://github.com/llvm/llvm-project/commit/b451ecd86e13ec6ef47caf37f62977645c4f748e DIFF: https://github.com/llvm/llvm-project/commit/b451ecd86e13ec6ef47caf37f62977645c4f748e.d

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGb451ecd86e13: [Clang][AArch64] Disable rounding of return values for AArch64 (authored by asavonic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100591/new

[clang] 84c4754 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Author: Leonard Chan Date: 2021-05-04T10:52:13-07:00 New Revision: 84c475437267e7fffedc40029ce274b099d8f8f3 URL: https://github.com/llvm/llvm-project/commit/84c475437267e7fffedc40029ce274b099d8f8f3 DIFF: https://github.com/llvm/llvm-project/commit/84c475437267e7fffedc40029ce274b099d8f8f3.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

This revision was automatically updated to reflect the committed changes. Closed by commit rG84c475437267: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/

[clang] 61dc0f2 - [Format] Don't sort includes if DisableFormat is true

Author: Nathan James Date: 2021-05-04T19:04:12+01:00 New Revision: 61dc0f2b593da149a4c0cea67819cd7bdbdd50b8 URL: https://github.com/llvm/llvm-project/commit/61dc0f2b593da149a4c0cea67819cd7bdbdd50b8 DIFF: https://github.com/llvm/llvm-project/commit/61dc0f2b593da149a4c0cea67819cd7bdbdd50b8.diff

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dc0f2b593d: [Format] Don't sort includes if DisableFormat is true (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https:

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

delcypher updated this revision to Diff 342809. delcypher edited the summary of this revision. delcypher added a comment. Use `isOSDarwin()` instead of explicitly checking Darwin OS enum values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101682/n

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

delcypher marked an inline comment as done. delcypher added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:408 default: return getOS(); } arphaman wrote: > It might be cleaner to do a check for `isOSDarwin` here, as that will help > with

[clang] 1971823 - [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

Author: Dan Liew Date: 2021-05-04T11:28:26-07:00 New Revision: 1971823ecb9eaa077554a5d268a44c7cb75eccce URL: https://github.com/llvm/llvm-project/commit/1971823ecb9eaa077554a5d268a44c7cb75eccce DIFF: https://github.com/llvm/llvm-project/commit/1971823ecb9eaa077554a5d268a44c7cb75eccce.diff LOG:

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1971823ecb9e: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on… (authored by delcypher). Repository: rG LLVM Github Mon

[clang] 9c72a21 - Fix for test failure caused by 84c475437267e7fffedc40029ce274b099d8f8f3.

Author: Leonard Chan Date: 2021-05-04T11:45:32-07:00 New Revision: 9c72a210b58f19632af0e91679da7aa63f51ad7a URL: https://github.com/llvm/llvm-project/commit/9c72a210b58f19632af0e91679da7aa63f51ad7a DIFF: https://github.com/llvm/llvm-project/commit/9c72a210b58f19632af0e91679da7aa63f51ad7a.diff

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342813. exv marked an inline comment as done. exv added a comment. - Remove obsolete comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/For

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv marked an inline comment as done. exv added a comment. According to the wiki, it seems like someone who has commit access must now submit this change. Comment at: clang/lib/Format/FormatTokenLexer.cpp:102 + +// FIXME: Investigate what token type gives the correct opera

[clang] 313ee60 - [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

Author: Giorgis Georgakoudis Date: 2021-05-04T11:56:31-07:00 New Revision: 313ee609e16b93a7d81cd595f8cffdb408390495 URL: https://github.com/llvm/llvm-project/commit/313ee609e16b93a7d81cd595f8cffdb408390495 DIFF: https://github.com/llvm/llvm-project/commit/313ee609e16b93a7d81cd595f8cffdb40839049

  1   2   >