[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723505 , @Abpostelnicu wrote: > Also I don’t remember seeing this proposed on cfe dev mailing list. There is no such requirement. I don't recall that happening basically ever, actually. Repository: rG LLVM Gi

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. In D100581#2723611 , @lebedev.ri wrote: > In D100581#2723505 , @Abpostelnicu > wrote: > >> Also I don’t remember seeing this proposed on cfe dev mailing list. > > There is no such r

[PATCH] D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

Abpostelnicu accepted this revision. Abpostelnicu added a comment. This revision is now accepted and ready to land. Thank you for this! Also I think it’s very well that you want to implement this warning in clang, with a little bit of more polish it will be up for merger! Repository: rG LLVM

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723621 , @Abpostelnicu wrote: > In D100581#2723611 , @lebedev.ri > wrote: > >> In D100581#2723505 , @Abpostelnicu >> wrote: >> >

[clang] 6d8d133 - Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

Author: Arthur Eubanks Date: 2021-04-28T12:47:18-07:00 New Revision: 6d8d1338629ceeaf6f56dc9eabc72e1a63f05169 URL: https://github.com/llvm/llvm-project/commit/6d8d1338629ceeaf6f56dc9eabc72e1a63f05169 DIFF: https://github.com/llvm/llvm-project/commit/6d8d1338629ceeaf6f56dc9eabc72e1a63f05169.diff

[PATCH] D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

aeubanks added a comment. https://reviews.llvm.org/rG6d8d1338629ceeaf6f56dc9eabc72e1a63f05169 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101480/new/ https://reviews.llvm.org/D101480 ___ cfe-commits ma

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. reverted regarding having a reviewer who is knowledgable in clang diagnostics, I assumed that george.burgess.iv was knowledgable and was happy with the change after his comments, perhaps I should have waited for an explicit LGTM Repository: rG LLVM Github Monorepo

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723709 , @aeubanks wrote: > reverted > regarding having a reviewer who is knowledgable in clang diagnostics, I > assumed that george.burgess.iv was knowledgable and was happy with the change > after his comments,

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. So it seems there are 3 issues here: 1. local variables declared extern should not trigger this warning. I'll fix this. 2. Should `x` in this code trigger the warning: int x; int y = (x = 0); These are essentially the "false positives" reported in the Linux kern

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. In D100581#2723789 , @mbenfield wrote: > But gcc's behavior is to not trigger here so maybe following it is best. Perhaps file a bug against GCC to find whether that was intentional or a bug? Repository: rG LLVM Githu

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2723794 , @nickdesaulniers wrote: > In D100581#2723789 , @mbenfield > wrote: > >> But gcc's behavior is to not trigger here so maybe following it is best. > > Perhaps file a

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @rsmith ping2... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

rsmith added a comment. When this change returns, I'd like to see a different implementation strategy. Running a recursive AST visitation after the fact is generally not the right way to look for this kind of issue; adding an extra pass to speculatively hunt for each kind of warning we might wa

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2723801 , @xbolva00 wrote: > > Yes, the best solution. Also consider to check gcc’s test-suite - if they > have this type of testcase, then this is wanted behaviour. gcc has `Wunused-var-5.c`, where the warning

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:25 + Names) { + const auto FullName = "::" + Node.getQualifiedNameAsString(); + Please don't use auto unless type is spelled explicitly in s

[clang] ea12d77 - [libc++] Support per-target __config_site in per-target runtime build

Author: Petr Hosek Date: 2021-04-28T14:27:16-07:00 New Revision: ea12d779bc238c387511fe7462020f4ecf4a8246 URL: https://github.com/llvm/llvm-project/commit/ea12d779bc238c387511fe7462020f4ecf4a8246 DIFF: https://github.com/llvm/llvm-project/commit/ea12d779bc238c387511fe7462020f4ecf4a8246.diff LO

[PATCH] D101490: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix.

delcypher created this revision. delcypher added a reviewer: vitalybuka. Herald added subscribers: dexonsmith, dang. delcypher requested review of this revision. Herald added a project: clang. This is post commit follow up based on discussions in https://reviews.llvm.org/D101122. Repository: r

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher created this revision. delcypher added reviewers: vitalybuka, jansvoboda11. Herald added a subscriber: dang. delcypher requested review of this revision. Herald added a project: clang. Renaming the option is based on discussions in https://reviews.llvm.org/D101122. It is normally not a

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

delcypher added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +llvm::AsanDetectStackUseAfterReturnMode::

[PATCH] D101461: [clangd][NFC] Reserve storage when creating semantic token encoding.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3846bcfe1cc: [clangd][NFC] Reserve storage when creating semantic token encoding. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1014

[clang-tools-extra] c3846bc - [clangd][NFC] Reserve storage when creating semantic token encoding.

Author: Nathan James Date: 2021-04-28T22:39:54+01:00 New Revision: c3846bcfe1cc6d6421a543757b5046ea841d4610 URL: https://github.com/llvm/llvm-project/commit/c3846bcfe1cc6d6421a543757b5046ea841d4610 DIFF: https://github.com/llvm/llvm-project/commit/c3846bcfe1cc6d6421a543757b5046ea841d4610.diff

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher added a comment. @jansvoboda11 Should I use the the alias feature so that the old `-fsanitize-address-destructor-kind` argument is still parsed? I'm not sure if it's worth it but if doing so is very simple and has a low maintenance burden we should probably do it. Repository: rG L

[clang] b30521c - [analyzer] Wrong type cast occurs during pointer dereferencing after type punning

Author: Denys Petrov Date: 2021-04-29T01:03:38+03:00 New Revision: b30521c28a4dc1b94d793385e4144ede5822b2c1 URL: https://github.com/llvm/llvm-project/commit/b30521c28a4dc1b94d793385e4144ede5822b2c1 DIFF: https://github.com/llvm/llvm-project/commit/b30521c28a4dc1b94d793385e4144ede5822b2c1.diff

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

This revision was automatically updated to reflect the committed changes. Closed by commit rGb30521c28a4d: [analyzer] Wrong type cast occurs during pointer dereferencing after type… (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/ClangCommandLineReference.rst:873 -.. option:: -fsanitize-address-destructor-kind= +.. option:: -fsanitize-address-destructor=

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101344/new/ https://reviews.llvm.org/D101344 ___ cfe-commits mailing list cfe-com

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > I would say if it is going to take longer than the end of the week to fix the > issue, it might be nice to have it reverted so that other people's builds > continue to work (I know a few people who build with full LTO in a two stage > configuration every week). Defini

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341338. Ericson2314 added a comment. Rebase, no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CM

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 341342. nicovank added a comment. Fix a couple variable names and explicitely specify a couple types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 Files: clang-t

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Eugene.Zelenko added a comment. Please mark fixed suggestions as done. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:248 + const auto *Call = PushBackCall ? PushBackCall : EmplacyCall; + Please don't use auto unless type is spelled e

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 341349. nicovank added a comment. Explicitely specify one more type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 Files: clang-tools-extra/clang-tidy/modernize/U

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

njames93 updated this revision to Diff 341350. njames93 added a comment. Remove unnecessary test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97955/new/ https://reviews.llvm.org/D97955 Files: clang-tools-extra/clang-tidy/modernize/LoopCon

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 341352. aabbaabb edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt clang/tools/scan-build-p

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank marked 3 inline comments as done. nicovank added a comment. Thank you for the feedback, I appreciate it! Let me know if there is any other I missed, AFAIK all `auto` uses introduced by me should be good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2721880 , @phosek wrote: > In D101139#2718112 , @aabbaabb > wrote: > >> In D101139#2718057 , @phosek wrote: >> >>> In D101139#2713530

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:29 + int Count = 0; + for (const auto &Character : FullName) { +if (Character == '<') { I'm not sure, but probably braces could be elided in `for` a

[PATCH] D101502: [ObjC][ARC] Don't enter the cleanup scope if the initializer expression isn't an ExprWithCleanups

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. ahatanak requested review of this revision. This patch fixes a bug where a temporary ObjC pointer is released before the end of the full expression. This fixes PR50043. rdar://7

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval created this revision. clementval added reviewers: jdoerfert, kiranchandramohan. Herald added subscribers: rriddle, guansong, hiraditya, yaxunl. clementval requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, stephenneuendorffer. Herald added

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

kuhar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:28 + std::string FullNameTrimmed; + int Count = 0; + for (const auto &Character : FullName) { Can you add a comment explaining what this loops tries to do? Idea

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

dexonsmith created this revision. dexonsmith added a reviewer: zturner. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, bmahjour, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle

[clang] 1bbbcff - [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix.

Author: Dan Liew Date: 2021-04-28T18:37:16-07:00 New Revision: 1bbbcff99de8e53b89146386bb2587ed4fc8e9cf URL: https://github.com/llvm/llvm-project/commit/1bbbcff99de8e53b89146386bb2587ed4fc8e9cf DIFF: https://github.com/llvm/llvm-project/commit/1bbbcff99de8e53b89146386bb2587ed4fc8e9cf.diff LOG:

[PATCH] D101490: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bbbcff99de8: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix. (authored by delcypher). Repository: rG LLVM Github Mono

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher updated this revision to Diff 341384. delcypher added a comment. Remove metavar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101491/new/ https://reviews.llvm.org/D101491 Files: clang/docs/ClangCommandLineReference.rst clang/include/

[PATCH] D101502: [ObjC][ARC] Don't enter the cleanup scope if the initializer expression isn't an ExprWithCleanups

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101502/new/ https://reviews.llvm.org/D101502

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

rjmccall added a comment. I think this is intentional; requiring the indirect-result parameter to be in the alloca address space would prevent direct initialization of non-temporary memory, which is an important optimization in C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101389/

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl added a comment. In D101389#2724636 , @rjmccall wrote: > I think this is intentional; requiring the indirect-result parameter to be in > the alloca address space would prevent direct initialization of non-temporary > memory, which is an important

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

OikawaKirie added a comment. If this patch is OK, could you please commit it on my behalf (Ella Ma )? Thx. And I will continue working on the `-Xanalyzer` option for clang-check, as it is too complex when adding analyzer options via the `-extra-arg` option. CHANGES SINCE LAST ACTION https://

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

MaskRay added a comment. Perhaps split the migration part from the `OpenFlags` removal part. I thought about deleting the aliases too but refrained because I noticed our internal code base needs migration. Since you propose this, I will start migration and hopefully can finish that next week so

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

rjmccall added a comment. In D101389#2724700 , @yaxunl wrote: > In D101389#2724636 , @rjmccall > wrote: > >> I think this is intentional; requiring the indirect-result parameter to be >> in the alloca address sp

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101097/new/ https://reviews.llvm.org/D101097 ___

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

rjmccall added a comment. What's the crash exactly/ Is IRGen just unhappy about processing the user definition when we've generated a declaration with a different type? Because we're already supposed to be being cautious about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur abandoned this revision. Meinersbur added a comment. Abandoned in favor of D101266 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89974/new/ https://reviews.llvm.org/D89974

[clang] 9363aa9 - [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

Author: Marek Kurdej Date: 2021-04-29T08:58:50+02:00 New Revision: 9363aa90bfe6f73df105799abc55bb74d4f186bf URL: https://github.com/llvm/llvm-project/commit/9363aa90bfe6f73df105799abc55bb74d4f186bf DIFF: https://github.com/llvm/llvm-project/commit/9363aa90bfe6f73df105799abc55bb74d4f186bf.diff

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9363aa90bfe6: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

<    1   2