[PATCH] D99530: [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99530/new/ https://reviews.llvm.org/D99530 _

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

jdoerfert added a comment. The cast was never the problem but the fact that the `$ref` lives in the global address space while the global value might be in the shared one. D101030 gives a way out here by not creating `$ref` variables if there is no host version

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341071. Ericson2314 added a comment. Herald added subscribers: openmp-commits, lldb-commits, cfe-commits, jvesely. Herald added projects: clang, LLDB, OpenMP. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In D91054#2711654 , @fghanim wrote: >> This is generally fine with me, @fghanim @Meinersbur any concerns? > > I have none. All good for me Then L

[clang] 36430d4 - [Driver] Use normalized triples for per-target runtimes

Author: Petr Hosek Date: 2021-04-27T22:31:36-07:00 New Revision: 36430d44edba9063a08493c89864edf5f071d08c URL: https://github.com/llvm/llvm-project/commit/36430d44edba9063a08493c89864edf5f071d08c DIFF: https://github.com/llvm/llvm-project/commit/36430d44edba9063a08493c89864edf5f071d08c.diff LO

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:84 + // In these cases we need to remove all typedefs one by one to check this. + const auto VaListKind = Context.getTargetInfo().getBuiltinVaListKind(); + using

[PATCH] D101387: remove single quotes around sugguestion diagnostic

rsmith added a comment. Note that, per https://clang.llvm.org/docs/InternalsManual.html#the-format-string, > Diagnostics should never take random English strings as arguments: you > shouldn’t use “you have a problem with %0” and pass in things like “your > argument” or “your return value” as a

<    1   2   3