[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D101194#2714991 , @phosek wrote: > In D101194#2714206 , @MaskRay wrote: > >>> Different platforms use di

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. In D83660#2675064 , @mikhail.ramalho wrote: > Indeed it looks like a copy & paste error, I'm surprised no one found it > earlier. > > Regarding the tests, we used to have `make check-clang-analysis-z3` (or > something simila

[PATCH] D101248: [RISCV] [1/2] Add IR intrinsic for Zbm extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, kito-cheng, jrtc27, asb, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMos

[PATCH] D101249: [RISCV] [2/2] Add IR intrinsic for Zbm extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, jrtc27, asb, kito-cheng, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, benna, psnobl, kadircet, jocewei, PkmX, arphama

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 340340. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp Index: clang/unittests/

[PATCH] D100658: [RISCV] Apply clang_builtin_alias to overloaded builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8fa5ef6a297: [RISCV] Apply clang_builtin_alias to overloaded builtins. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org

[clang] a9676fe - [AST] Add DeclarationNameInfo to node introspection

Author: Stephen Kelly Date: 2021-04-25T12:12:03+01:00 New Revision: a9676febb99d54289117a497c3fea4ba35cef2b4 URL: https://github.com/llvm/llvm-project/commit/a9676febb99d54289117a497c3fea4ba35cef2b4 DIFF: https://github.com/llvm/llvm-project/commit/a9676febb99d54289117a497c3fea4ba35cef2b4.diff

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9676febb99d: [AST] Add DeclarationNameInfo to node introspection (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ http

[clang-tools-extra] 8d018c7 - Add srcloc output to clang-query

Author: Stephen Kelly Date: 2021-04-25T12:12:04+01:00 New Revision: 8d018c79ee5f14e1433b8cbb02dd89d0941516ff URL: https://github.com/llvm/llvm-project/commit/8d018c79ee5f14e1433b8cbb02dd89d0941516ff DIFF: https://github.com/llvm/llvm-project/commit/8d018c79ee5f14e1433b8cbb02dd89d0941516ff.diff

[PATCH] D93325: Add srcloc output to clang-query

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d018c79ee5f: Add srcloc output to clang-query (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D93325?vs=339583&id=3

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added a comment. In D98657#2701673 , @crownyanguan wrote: > How about -Wl option, it will cause link error like " Only `-Werror` is > supported currently" Thanks for pointing it out. The issue was due to restricting -W` options in `f18` as

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv created this revision. jubnzv added reviewers: njames93, aaron.ballman. jubnzv added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. jubnzv requested review of this revision. This commit fixes `cppcoreguidelines-pro-type-vararg` false positives

[PATCH] D101143: [RISCV] [1/2] Add IR intrinsic for Zbe extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101143/new/ https://reviews.llvm.org/D101143 ___

[PATCH] D101248: [RISCV] [1/2] Add IR intrinsic for Zbm extension

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbm.c:16 +// +long clmul(long a, long b) { + return __builtin_riscv_bmator(a, b); clmul? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 68ff493 - [NFC] Fixed some D79714 warnings

Author: Vitaly Buka Date: 2021-04-25T12:41:46-07:00 New Revision: 68ff493dfc950c05c102e09e14a16d06253ffa16 URL: https://github.com/llvm/llvm-project/commit/68ff493dfc950c05c102e09e14a16d06253ffa16 DIFF: https://github.com/llvm/llvm-project/commit/68ff493dfc950c05c102e09e14a16d06253ffa16.diff L

[PATCH] D101214: Disable deprecated-copy warnings on various LLVM code to bring the bot back to green

This revision was automatically updated to reflect the committed changes. Closed by commit rG504eee28fe0f: Disable deprecated-copy warnings on various LLVM code to bring the bot back to… (authored by nemanjai, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D101214?

[PATCH] D99052: [clangd] Produce semantic token for name referring to UnresolvedUsingValueDecl

nridge updated this revision to Diff 340381. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99052/new/ https://reviews.llvm.org/D99052 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang

[PATCH] D99056: [clangd] Use HeuristicResolver to produce a better semantic token for name referring to UnresolvedUsingValueDecl

nridge updated this revision to Diff 340382. nridge added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99056/new/ https://reviews.llvm.org/D99056 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang-tools-extra/cla

[clang-tools-extra] ddfe13e - [clangd] Produce semantic token for name referring to UnresolvedUsingValueDecl

Author: Nathan Ridge Date: 2021-04-25T16:43:58-04:00 New Revision: ddfe13e757cb72c056cba8d889d6cb8ee69f1afa URL: https://github.com/llvm/llvm-project/commit/ddfe13e757cb72c056cba8d889d6cb8ee69f1afa DIFF: https://github.com/llvm/llvm-project/commit/ddfe13e757cb72c056cba8d889d6cb8ee69f1afa.diff

[clang-tools-extra] d941863 - [clangd] Use HeuristicResolver to produce a better semantic token for name referring to UnresolvedUsingValueDecl

Author: Nathan Ridge Date: 2021-04-25T16:45:04-04:00 New Revision: d941863de2becb3d8d2e00676fc7125974934c7f URL: https://github.com/llvm/llvm-project/commit/d941863de2becb3d8d2e00676fc7125974934c7f DIFF: https://github.com/llvm/llvm-project/commit/d941863de2becb3d8d2e00676fc7125974934c7f.diff

[PATCH] D99052: [clangd] Produce semantic token for name referring to UnresolvedUsingValueDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddfe13e757cb: [clangd] Produce semantic token for name referring to UnresolvedUsingValueDecl (authored by nridge). Repository: rG LLVM Github Mono

[PATCH] D99056: [clangd] Use HeuristicResolver to produce a better semantic token for name referring to UnresolvedUsingValueDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd941863de2be: [clangd] Use HeuristicResolver to produce a better semantic token for name… (authored by nridge). Changed prior to commit: https://r

[PATCH] D100715: [clangd] Omit parameter hint if parameter name comment is present

nridge updated this revision to Diff 340391. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100715/new/ https://reviews.llvm.org/D100715 Files: clang-tools-e

[PATCH] D100731: [clangd] Omit parameter hint for setter functions

nridge updated this revision to Diff 340392. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100731/new/ https://reviews.llvm.org/D100731 Files: clang-tools-e

[PATCH] D100741: [clangd] Rename HeuristicResolver::resolveCallExpr() to resolveReturnTypeOfCallExpr()

nridge updated this revision to Diff 340393. nridge marked an inline comment as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100741/new/ https://reviews.llvm.org/D100741 Files: clang-tools-ex

[clang-tools-extra] 753b247 - [clangd] Omit parameter hint if parameter name comment is present

Author: Nathan Ridge Date: 2021-04-25T19:20:10-04:00 New Revision: 753b247d71d7e74dd6998735848a2d9e0b6317de URL: https://github.com/llvm/llvm-project/commit/753b247d71d7e74dd6998735848a2d9e0b6317de DIFF: https://github.com/llvm/llvm-project/commit/753b247d71d7e74dd6998735848a2d9e0b6317de.diff

[clang-tools-extra] 6f6cf2d - [clangd] Omit parameter hint for setter functions

Author: Nathan Ridge Date: 2021-04-25T19:20:12-04:00 New Revision: 6f6cf2da8d9453f2bd57978be1e5d0765ea50a36 URL: https://github.com/llvm/llvm-project/commit/6f6cf2da8d9453f2bd57978be1e5d0765ea50a36 DIFF: https://github.com/llvm/llvm-project/commit/6f6cf2da8d9453f2bd57978be1e5d0765ea50a36.diff

[clang-tools-extra] c624e70 - [clangd] Rename HeuristicResolver::resolveCallExpr() to resolveTypeOfCallExpr()

Author: Nathan Ridge Date: 2021-04-25T19:20:14-04:00 New Revision: c624e701491c320cf5c662006082a8e956c30e8d URL: https://github.com/llvm/llvm-project/commit/c624e701491c320cf5c662006082a8e956c30e8d DIFF: https://github.com/llvm/llvm-project/commit/c624e701491c320cf5c662006082a8e956c30e8d.diff

[PATCH] D100715: [clangd] Omit parameter hint if parameter name comment is present

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG753b247d71d7: [clangd] Omit parameter hint if parameter name comment is present (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100731: [clangd] Omit parameter hint for setter functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f6cf2da8d94: [clangd] Omit parameter hint for setter functions (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D100741: [clangd] Rename HeuristicResolver::resolveCallExpr() to resolveReturnTypeOfCallExpr()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc624e701491c: [clangd] Rename HeuristicResolver::resolveCallExpr() to resolveTypeOfCallExpr() (authored by nridge). Repository: rG LLVM Github Mo

[PATCH] D101270: [clangd] Avoid including HeuristicResolver.h from ParsedAST.h

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Githu

[PATCH] D101270: [clangd] Avoid including HeuristicResolver.h from ParsedAST.h

nridge added a comment. Motivation: ParsedAST.h is widely included, and now that ParsedAST stores HeuristicResolved by unique_ptr, the header dependency is no longer necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101270/new/ https://revi

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:854 + // Save raw frame pointer to alloca + Value *Mem = Shape.CoroBegin->getMem(); + AllocaInst *FramePtrAddr = This seems to align with what this mem argument i

[PATCH] D101143: [RISCV] [1/2] Add IR intrinsic for Zbe extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cf54c7ff50c: [RISCV] [1/2] Add IR intrinsic for Zbe extension (authored by LevyHsu, committed by craig.topper). Changed prior to commit: https://

[clang] 8cf54c7 - [RISCV] [1/2] Add IR intrinsic for Zbe extension

Author: Levy Hsu Date: 2021-04-25T19:14:34-07:00 New Revision: 8cf54c7ff50cc4db79b2bc633e7d9d96509ef000 URL: https://github.com/llvm/llvm-project/commit/8cf54c7ff50cc4db79b2bc633e7d9d96509ef000 DIFF: https://github.com/llvm/llvm-project/commit/8cf54c7ff50cc4db79b2bc633e7d9d96509ef000.diff LOG:

[PATCH] D100824: [RISCV] Implement the vwcvt{u}.x.x.v/vncvt.x.x.w builtin.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100824/new/ https://reviews.llvm.org/D100824 __

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100821/new/ https://reviews.llvm.org/D100821 __

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Githu

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. @thakis https://reviews.llvm.org/D100611 had landed, could you check your bot to see the cycle time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741 ___

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15122 + case PPC::BI__builtin_ppc_rsqrtd: { +auto FMF = Builder.getFastMathFlags(); +Builder.getFastMathFlags().setFast(); Seems FMF will be automatically restored without the three

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

uabelho added a comment. In D79714#2713610 , @xbolva00 wrote: > I pushed a fix to just disable this warning for googlemock/gtest. Unfortunately that fix breaks compiling llvm with clang8. I commented in https://reviews.llvm.org/rG9658d045926545e62cc3f963

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann added a comment. Friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:967-968 + + // While looking for the last var bindings, we can still find + // `AllocFirstBinding` to be one of them. In situations like this, + // it would

[PATCH] D100852: [analyzer] Track leaking object through stores

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:636 if (isa(R)) - Result.push_back(R); + Result.emplace_back(R, Val)

[PATCH] D100742: [clangd] Parameter hints for dependent calls

nridge updated this revision to Diff 340439. nridge added a comment. Herald added a subscriber: cfe-commits. Add some more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100742/new/ https://reviews.llvm.org/D100742 Files: clang-tools-e

[PATCH] D100742: [clangd] Parameter hints for dependent calls

nridge added a reviewer: sammccall. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:264 +// FIXME: This one does not work yet. +A::static_member($par3[[t]]); } This is an interesting case. Cla

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:163-165 + ProgramStateManager &StateMgr = N->getState()->getStateManager(); + MemRegionManager &MRMgr = StateMgr.getRegionManager(); + return MRMgr.getVarRegion(VD, N->getL

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2713579 , @ychen wrote: > In D100739#2711698 , @ChuanqiXu > wrote: > >>> This is an alternative to D97915 which >>> missed proper deallocat