[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen updated this revision to Diff 339902. ychen added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100739/new/ https://reviews.llvm.org/D100739 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGenCoroutines/coro-al

[clang-tools-extra] a46bbc1 - [cland] Dont emit missing newline warnings when building preamble

Author: Kadir Cetinkaya Date: 2021-04-23T08:56:32+02:00 New Revision: a46bbc14f004c06bd1317e6d7a486c29133f1c0b URL: https://github.com/llvm/llvm-project/commit/a46bbc14f004c06bd1317e6d7a486c29133f1c0b DIFF: https://github.com/llvm/llvm-project/commit/a46bbc14f004c06bd1317e6d7a486c29133f1c0b.dif

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa46bbc14f004: [cland] Dont emit missing newline warnings when building preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen updated this revision to Diff 339906. ychen added a comment. fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100739/new/ https://reviews.llvm.org/D100739 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGenCoroutines/coro-al

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 updated this revision to Diff 339912. xbolva00 added a comment. Updated comment for getNewAlign() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGCall.cpp clan

[PATCH] D101143: [RISCV] [1/2] Add IR intrinsic for Zbe extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, kito-cheng, asb, jrtc27, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMos

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879 ___ cfe-commits mailing list

[PATCH] D101144: [RISCV] [2/2] Add IR intrinsic for Zbe extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, jrtc27, Jim, asb, kito-cheng. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, benna, psnobl, kadircet, jocewei, PkmX, arphama

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

rogfer01 added a comment. In D100821#2710998 , @HsiangKai wrote: > Rebase. Thanks, I had missed that and my comment above was wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100821/new/ https://revie

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

t.p.northover added a comment. On big-endian targets the rounding up to 64-bits (specified in the AAPCS) is significant; it means that structs get passed in the high bits of `x0` rather than low. E.g. https://godbolt.org/z/6v36oexsW. I think this patch would break that. Repository: rG LLVM

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong marked 3 inline comments as done. martong added a comment. Thanks for the review Valeriy! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:338-339 } +llvm_unreachable("The constraint must be either a concrete value or " +

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong updated this revision to Diff 339934. martong marked 3 inline comments as done. martong added a comment. - Assert on SizeArgN Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101060/new/ https://reviews.llvm.org/D101060 Files: clang/lib/Sta

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 339943. anastasiia_lukianenko marked an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Fo

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

jansvoboda11 updated this revision to Diff 339944. jansvoboda11 added a comment. Improve naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101051/new/ https://reviews.llvm.org/D101051 Files: clang/include/clang/Tooling/DependencyScanning/Depe

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

vsavchenko added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-notes.cpp:32 +__buf_size_arg_constraint_concrete(buf); // \ +// expected-note{{The size of the 0th arg should be equal to or less than the value of 10}} \ +// e

[PATCH] D101057: [clangd] Allow AST request without range

ckandeler updated this revision to Diff 339948. ckandeler added a comment. Herald added a subscriber: cfe-commits. Addressed clang-tidy and clang-format comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D10

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko updated this revision to Diff 339951. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/ContinuationIndenter.cpp clang/l

[PATCH] D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel builtins

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100984/new/ https://reviews.llvm.org/D100984 ___ cfe-commits mailing list cfe-co

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2297544c047: [Clang] Propagate guaranteed alignment for malloc and others (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] c229754 - [Clang] Propagate guaranteed alignment for malloc and others

Author: Dávid Bolvanský Date: 2021-04-23T11:07:14+02:00 New Revision: c2297544c04764237cedc523083c7be2fb3833d4 URL: https://github.com/llvm/llvm-project/commit/c2297544c04764237cedc523083c7be2fb3833d4 DIFF: https://github.com/llvm/llvm-project/commit/c2297544c04764237cedc523083c7be2fb3833d4.dif

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

mantognini accepted this revision. mantognini added a comment. Feels appropriate to remove this indeed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100985/new/ https://reviews.llvm.org/D100985 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel builtins

mantognini accepted this revision. mantognini added a comment. Thanks, I believe this goes in the right direction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100984/new/ https://reviews.llvm.org/D100984 ___ cfe-commits mailing list cfe-com

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > do you think it is valuable to keep this behavior at all? As I said, I would be happy too if we remove pragma extension as it will really simplify the codebase of OpenCL in clang and the usage of optional functionality itself. Maybe we should add a diagnostic that p

[clang] 6914a0e - Revert "[Clang] Propagate guaranteed alignment for malloc and others"

Author: Dávid Bolvanský Date: 2021-04-23T11:33:33+02:00 New Revision: 6914a0ed2b30924b188968e59a83efa07ac5fe57 URL: https://github.com/llvm/llvm-project/commit/6914a0ed2b30924b188968e59a83efa07ac5fe57 DIFF: https://github.com/llvm/llvm-project/commit/6914a0ed2b30924b188968e59a83efa07ac5fe57.dif

[PATCH] D101057: [clangd] Allow AST request without range

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:895 + auto Node = DynTypedNode::create( +*Inputs->AST.getASTContext().getTranslationUnitDecl()); + return CB(dumpAST(Node, Inputs->AST.getTokens(), ---

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

fghanim added a comment. > This is generally fine with me, @fghanim @Meinersbur any concerns? I have none. All good for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054

[PATCH] D101066: [clangd] Dont index deeply nested symbols

kadircet updated this revision to Diff 339960. kadircet added a comment. Herald added a subscriber: cfe-commits. - Revert unrelated changes in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101066/new/ https://reviews.llvm.org/D101066 Files:

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. > This is an alternative to D97915 which > missed proper deallocation of the over-allocated frame. This patch handles > both allocations and deallocations. If D97915 is not needed, we should abandon i

[PATCH] D101066: [clangd] Dont index deeply nested symbols

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:142 this->Opts.ShouldTraverseDecl = [this](const Decl *D) { + // Many operations performed duri

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2711588 , @azabaznov wrote: >> do you think it is valuable to keep this behavior at all? > > As I said, I would be happy too if we remove pragma extension as it will > really simplify the codebase of OpenCL in clang

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#2709218 , @sameerds wrote: > 1. It is actually okay add control dependences to a convergent function as > long as the new branches are uniform. > 2. Some times we hack a transform to avoid doing things that cannot be > d

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz updated this revision to Diff 339840. shchenz added a comment. 1: put test cases in single file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/D100826 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/in

[PATCH] D69498: IR: Invert convergent attribute handling

sameerds added a comment. In D69498#2710675 , @arsenm wrote: > In D69498#2709218 , @sameerds wrote: > >> 1. It is actually okay add control dependences to a convergent function as >> long as the new branches are un

[PATCH] D69498: IR: Invert convergent attribute handling

foad added a comment. In D69498#2705441 , @sameerds wrote: > I would propose refining the definition of the `noconvergent` attribute as > follows: > >> noconvergent: >> >> Some targets with a parallel execution model provide cross-thread operations >> wh

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 339973. bader marked an inline comment as done. bader added a comment. Generalize getStringLiteralAddressSpace to GetGlobalConstantAddressSpace Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

olestrohm updated this revision to Diff 339976. olestrohm added a comment. I noticed that I could move the new check above the diagnostic for program scope variables, and the check during parsing can then be removed, while maintaining good diagnostics. This does change the diagnostic for `event

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. In D85802#2709832 , @leonardchan wrote: > I added `cc1` invocations to the test and an extra one to assert that the > flag is actually maki

[clang] ddfbdbf - [clang] Do not crash on template specialization following a fatal error

Author: Adam Czachorowski Date: 2021-04-23T13:34:05+02:00 New Revision: ddfbdbfefae04ea71391a38ed5e9cb6975f6630b URL: https://github.com/llvm/llvm-project/commit/ddfbdbfefae04ea71391a38ed5e9cb6975f6630b DIFF: https://github.com/llvm/llvm-project/commit/ddfbdbfefae04ea71391a38ed5e9cb6975f6630b.d

[PATCH] D100675: [clang] Do not crash on template specialization following a fatal error

This revision was automatically updated to reflect the committed changes. Closed by commit rGddfbdbfefae0: [clang] Do not crash on template specialization following a fatal error (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

uabelho added a comment. Hi, With this commit I get failures in the following testcases when building check-runtimes on trunk: Failed Tests (29): libc++ :: libcxx/debug/containers/db_sequence_container_iterators.pass.cpp libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp libc++ :

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov updated this revision to Diff 339983. azabaznov added a comment. Herald added a reviewer: aaron.ballman. Addressed comments, did some more refactoring. Is it OK to have "2.0" diagnostics for C++ for OpenCL? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 2cae702 - Reland "[Clang] Propagate guaranteed alignment for malloc and others"

Author: Dávid Bolvanský Date: 2021-04-23T14:05:57+02:00 New Revision: 2cae7025c1d9e83d971f670c9a66497a8c1094ec URL: https://github.com/llvm/llvm-project/commit/2cae7025c1d9e83d971f670c9a66497a8c1094ec DIFF: https://github.com/llvm/llvm-project/commit/2cae7025c1d9e83d971f670c9a66497a8c1094ec.dif

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

HsiangKai added a comment. In D100821#2711395 , @rogfer01 wrote: > In D100821#2710998 , @HsiangKai > wrote: > >> Rebase. > > Thanks, I had missed that and my comment above was wrong. That's fine. Thanks for your

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 added a comment. In D79714#2711871 , @uabelho wrote: > Hi, > > With this commit I get failures in the following testcases when building > check-runtimes on trunk: > > Failed Tests (29): > libc++ :: libcxx/debug/containers/db_sequence_contai

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic created this revision. asavonic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes PR49198: Wrong usage of __dso_handle in user code leads to a compiler crash. `__dso_handle` variable is now created with a prefix to avoid

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can't say I really understand this (either the before/after state). It seems like we're trying to vertically-align a bunch of operands to a ?: chain, and this patch stops aligning the on

[PATCH] D101057: [clangd] Allow AST request without range

ckandeler updated this revision to Diff 339994. ckandeler added a comment. Fixed TU traversal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D101057: [clangd] Allow AST request without range

ckandeler updated this revision to Diff 339995. ckandeler marked 2 inline comments as done. ckandeler added a comment. "top-level" -> "root" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

joerg added a comment. There are two approaches that work for reviewing: starting from clang and going down or starting from compiler-rt and going up the layers. I'd prefer to do the latter as it means meaningful testing can be done easier. There are two natural steps here: clang flag+IR genera

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > For cl_khr_fp64 I still want to keep the pragma for the other use case - to > convert double literal into single-precision > (https://github.com/KhronosGroup/OpenCL-Docs/issues/578). The reason why I > think it could be useful is that the precision change might lead

[PATCH] D101057: [clangd] Allow AST request without range

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thank you! Just a couple of nits. Want me to land this for you? Comment at: clang-tools-extra/clangd/DumpAST.cpp:339 + + bool TraverseTUDecl(TranslationUni

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-notes.cpp:32 +__buf_size_arg_constraint_concrete(buf); // \ +// expected-note{{The size of the 0th arg should be equal to or l

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong updated this revision to Diff 33. martong marked an inline comment as done. martong added a comment. - Start arg index display from 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101060/new/ https://reviews.llvm.org/D101060 Files:

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2711963 , @azabaznov wrote: >> For cl_khr_fp64 I still want to keep the pragma for the other use case - to >> convert double literal into single-precision >> (https://github.com/KhronosGroup/OpenCL-Docs/issues/578).

[PATCH] D101159: Show why clang analyzer could not be executed

Ramin created this revision. Ramin added a reviewer: clang-tools-extra. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Ramin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

vsavchenko added a comment. Awesome, thanks! LGTM now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101060/new/ https://reviews.llvm.org/D101060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. It's still failing but I can disable HSA on this machine for now. FYI -- FAILED: tools/clang/tools/amdgpu-arch/CMakeFiles/amdgpu-arch.dir/AMDGPUArch.cpp.o /p/tllvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__

[clang] fcb45b5 - [OpenCL] Fix typo in the test.

Author: Anastasia Stulova Date: 2021-04-23T14:36:36+01:00 New Revision: fcb45b544d3da87e0aab895eaac7903197a6c58c URL: https://github.com/llvm/llvm-project/commit/fcb45b544d3da87e0aab895eaac7903197a6c58c DIFF: https://github.com/llvm/llvm-project/commit/fcb45b544d3da87e0aab895eaac7903197a6c58c.d

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2134-2151 +Sema::DeclareTargetContextInfo *DTCI = +new Sema::DeclareTargetContextInfo(DKind, DTLoc); +if (HasClauses) + ParseOMPDeclareTargetClauses(*DTCI); // Skip the last ann

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

cebowleratibm accepted this revision. cebowleratibm added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -target-feature +altivec -target-featur

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 340011. bader added a comment. Incorporate https://reviews.llvm.org/D89909 review feedback. Allow one way implicit conversion only for now. >From named address space to default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 5 inline comments as done. bader added a comment. @Anastasia, I've updated https://reviews.llvm.org/D99488 and refactored `getStringLiteralAddressSpace` to handle non-string constants as well. Please, take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

krasimir added a comment. I also have a limited understanding based on the original patch https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea together with examining affected test cases. I believe the intention of this section is to handle, e.g., the alignment of

[PATCH] D101057: [clangd] Allow AST request without range

ckandeler updated this revision to Diff 340014. ckandeler added a comment. Fixed remaining issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-tools-extra/clangd/ClangdServer.cpp clang

[PATCH] D101057: [clangd] Allow AST request without range

ckandeler added a comment. In D101057#2711997 , @sammccall wrote: > Want me to land this for you? Yes, please. I don't have push privileges. Thanks for the prompt and helpful review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:365 +def warn_opencl_unsupported_core_feature : Warning< + "%0 is a core feature in OpenCL C %1 but not supported on this target">, + InGroup, DefaultIgnore; I would

[PATCH] D101166: This commit tries to revert Clang commit 40beb1f84a to see if that's the cause of failures in the Runtimes build.

ldionne created this revision. Herald added a subscriber: arichardson. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. I'm creating a Phab review for this to take advantage of t

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic added a comment. John, can you please review this patch? I originally wanted to add a diagnostic to prevent the crash in CG (PR49198), but the case seems easy enough to support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/ ht

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

bmahjour added a comment. LGTM Comment at: clang/test/CodeGen/builtins-ppc-xlcompat.c:6 +// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx \ + // RUN: -triple powerpc64le-unknown-unknown -emit-llvm %s -o - \ +// RUN: -D__XL_COMPAT_ALTIVEC__ | FileCheck %s --

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

martong added a comment. Awesome! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1529 + // b = a; + // c = foo(b); + // I'd rather use `identity` here (and at line 1509) instead of `foo`, I think that could make this e

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1529 + // b = a; + // c = foo(b); + // martong wrote: > I'd rather use `identity` here (and at line 1509) instead of `foo`, I think > that

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

lxfind added a comment. > Sorry for the confusion. I think either overaligned or under-aligned could be > used here to describe the problem: either "Handle overaligned frame" or "Fix > under-aligned frame". Since c++ spec defines the former but not the later > (https://en.cppreference.com/w/cpp

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

svenvh accepted this revision. svenvh added a comment. LGTM, thanks! Please make sure that the commit message corresponds to the new shape of your patch: you might want to update the description of this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/ https://reviews.

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

jsji added inline comments. Comment at: clang/lib/Headers/altivec.h:3055 +#ifdef __XL_COMPAT_ALTIVEC__ +/* vec_ctf */ This only affects __VSX__ version right? If so, can we move `#ifdef __XL_COMPAT_ALTIVEC__` into `#ifdef __VSX__`？ Or even better only into the

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

jsji added inline comments. Comment at: clang/lib/Headers/altivec.h:3065 + (__b)), \ + vector unsigned long long \ + : (__builtin_vsx_xvcvuxdsp((v

[PATCH] D101089: [OpenCL] Document legacy atomics with generic address space

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Nitpick to make the sentence read more smoothly; otherwise LGTM! Comment at: clang/docs/LanguageExtensions.rst:1819 + +Clang allows use of atomic functions from earlier than

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

sammccall added a comment. A too-late drive-by - maybe we'd be better detecting these in clang never emitting these Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100501/new/ https://reviews.llvm.org/D100501 ___

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

sammccall added a comment. Hit send too soon. But IIRC PP knows whether it's building a preamble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100501/new/ https://reviews.llvm.org/D100501 ___ cfe-commit

[PATCH] D101054: [AST] Sort introspection results without instantiating other data

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. This I suppose is a good fast way to sort these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101054/new/ https://reviews.llvm.org/D101054

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, kerbowa, jfb, yaxunl, nhaehnle, jvesely, jholewinski. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This featur

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

njames93 added inline comments. Comment at: clang/include/clang/Tooling/NodeIntrospection.h:29 class CXXBaseSpecifier; +class DeclarationNameInfo; Please fix this lint warning. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:

[PATCH] D101054: [AST] Sort introspection results without instantiating other data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35918bcb6f50: [AST] Sort introspection results without instantiating other data (authored by stephenkelly). Repository: rG LLVM Github Monorepo C

[clang] 35918bc - [AST] Sort introspection results without instantiating other data

Author: Stephen Kelly Date: 2021-04-23T16:21:01+01:00 New Revision: 35918bcb6f507cb3d28f80ab4408125ba292400c URL: https://github.com/llvm/llvm-project/commit/35918bcb6f507cb3d28f80ab4408125ba292400c DIFF: https://github.com/llvm/llvm-project/commit/35918bcb6f507cb3d28f80ab4408125ba292400c.diff

[PATCH] D101092: [OpenCL][Docs] Misc updates about C++ for OpenCL and offline compilation

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101092/new/ https://reviews.llvm.org/D101092 ___ cfe-commits mailing list cfe-commits@

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1532 + // Telling the user that the value of 'a' is assigned to 'c', while + // correct, can be confusing. + StoreManager::FindUniqueBinding FB(V.getAsLocSymbol()); ---

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

uabelho added a comment. In D79714#2711898 , @xbolva00 wrote: > Can you try this fix? > > diff --git a/libcxx/utils/libcxx/test/params.py > b/libcxx/utils/libcxx/test/params.py > index ddf277dea246..abf712e78a61 100644 > --- a/libcxx/utils/libcxx/te

[clang] a7cb951 - [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

Author: Gabor Marton Date: 2021-04-23T17:27:54+02:00 New Revision: a7cb951fa40df14d98c51059194ae42855b96a08 URL: https://github.com/llvm/llvm-project/commit/a7cb951fa40df14d98c51059194ae42855b96a08 DIFF: https://github.com/llvm/llvm-project/commit/a7cb951fa40df14d98c51059194ae42855b96a08.diff

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7cb951fa40d: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints (authored by martong). Changed prior to commit: https://reviews.llvm.org/D101060?vs=33&id=340048#toc Repository: rG L

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire updated this revision to Diff 340049. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling

[PATCH] D101166: This commit tries to revert Clang commit 40beb1f84a to see if that's the cause of failures in the Runtimes build.

ldionne updated this revision to Diff 340050. ldionne added a comment. Try running a full bisect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101166/new/ https://reviews.llvm.org/D101166 Files: libcxx/utils/ci/buildkite-pipeline.yml libcxx/ut

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1532 + // Telling the user that the value of 'a' is assigned to 'c', while + // correct, can be confusing. + StoreManager::FindUniqueBinding FB(V.getAsLocSymbol());

[PATCH] D93325: Add srcloc output to clang-query

njames93 added inline comments. Comment at: clang-tools-extra/clang-query/Query.cpp:106-108 + if (Scout->first == CommonEntry) { +++Iter; + } nit: Elide braces. Comment at: clang-tools-extra/clang-query/Query.cpp:122 + +Te

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Looks okay for me, but please fix the formatting notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. None of those include paths look like the result of find_package locating a hsa so I'd guess this some quirk of cmake. It seems it is setting hsa-runtime64_FOUND but not doing the include path setup to match. I don't know how to debug that. @pdhaliwal? Reposit

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. LGTM but please wait for @MyDeveloperDay opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-commits mailing

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov updated this revision to Diff 340053. azabaznov added a comment. Use `LangOptions::getOpenCLVersionTuple()` to provide diagnostics of OpenCL version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D1010

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 added a comment. In D79714#2712393 , @uabelho wrote: > In D79714#2711898 , @xbolva00 wrote: > >> Can you try this fix? >> >> diff --git a/libcxx/utils/libcxx/test/params.py >> b/libcxx/utils/libcxx/test/

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:179 + static bool isOpenCLOptionCoreIn(const LangOptions &LO, Args &&... args) { +return OpenCLOptionInfo(std::forward(args)...).isCoreIn(LO); + } Anastasia wrote: > Do y

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2134-2151 +Sema::DeclareTargetContextInfo *DTCI = +new Sema::DeclareTargetContextInfo(DKind, DTLoc); +if (HasClauses) + ParseOMPDeclareTargetClauses(*DTCI); // Skip the last a

[PATCH] D93325: Add srcloc output to clang-query

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the nits from @njames93 and I. Comment at: clang-tools-extra/clang-query/Query.cpp:96 + + auto printLocations = [](auto &OS, auto Iter, auto En

  1   2   3   >