[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks added a comment. Looking at one of the examples in llvm-test-suite that regressed, this seems to be regressing some very simple code: void f(double *a) { double c[20] = { 0.1051, 0.0157, 0.0185, 0.0089, 0.0219, 0.0141, 0.0097, 0.0758, 0.0168, 0.1188, 0.1635, 0.0112

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5917 if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) BE->getBlockDecl()->setDoesNotEscape(); We need to be checking that the parameter type is a block point

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

HsiangKai updated this revision to Diff 339875. HsiangKai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100821/new/ https://reviews.llvm.org/D100821 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/R

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

HsiangKai updated this revision to Diff 339876. HsiangKai added a comment. Use new defined intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

HsiangKai updated this revision to Diff 339879. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td clang/tes

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks added a comment. Actually, the InstCombine transform allows LoopFullUnrollPass to unroll the copy loop which results in a bunch of stores. Previously during LoopFullUnrollPass we wouldn't see the global within the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda added a comment. I'm new here. I was told to take small steps. This will eventually effect compiler-rt and llvm. I took the smallest possible step. What I had previously: https://reviews.llvm.org/D99630 And was told it was too large. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added subscribers: akyrtzi, benlangmuir. rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; This is necessary because it's possible to derive this type from a mode attribute? ===

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

rjmccall added a comment. What is the purpose of the builtin? Where is it being used? Typically you *can't* change the signature of a builtin because the builtin is itself a language feature that's documented to have a particular signature. If you've made a builtin purely for use in generate

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen updated this revision to Diff 339900. ychen edited the summary of this revision. ychen added a comment. - Address feebacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100739/new/ https://reviews.llvm.org/D100739 Files: clang/lib/CodeGen

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2706973 , @lxfind wrote: > Thanks for working on this. > I am still having a bit hard time understanding the solution. > A few questions: > > 1. I assume this patch is to solve the problem where the promise object is > n

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2711181 , @rjmccall wrote: > What is the purpose of the builtin? Where is it being used? Typically you > *can't* change the signature of a builtin because the builtin is itself a > language feature that's documented t

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

kadircet updated this revision to Diff 339901. kadircet marked an inline comment as done. kadircet added a comment. Herald added a subscriber: cfe-commits. - Handle cxx98 and extension versions of the warning too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This avoids test failures where extra files exist in the tree, such as the standard library built using the runtimes buil

[clang-tools-extra] 9a930aa - [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument

Author: Georgy Komarov Date: 2021-04-22T10:14:10+03:00 New Revision: 9a930aa5bd2fc4686002d02411141a19f0ad8f36 URL: https://github.com/llvm/llvm-project/commit/9a930aa5bd2fc4686002d02411141a19f0ad8f36 DIFF: https://github.com/llvm/llvm-project/commit/9a930aa5bd2fc4686002d02411141a19f0ad8f36.diff

[PATCH] D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a930aa5bd2f: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D93031: Enable fexec-charset option

cor3ntin added a comment. In D93031#2706988 , @joerg wrote: > "Keeping the original spelling around" would assume that the input is not > using a stateful encoding. That seems worse as assumption than giving the > canonical output in UTF-8 and shifting t

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:651 + + return Result; +} NoQ wrote: > I feel semi-irrational urge to add comments whenever NRVO is employed. I know, and I lacked trus

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

crr0004 added a comment. One thing I noticed was that you need to be over the base class or overriding class identifier in order to get the code action. For some editors like Visual Studio Code this is less noticeable but for others like VIM it is more noticeable as you need to know it's there.

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn accepted this revision. fhahn added a comment. LGTM, thanks! I'll commit the patch shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 ___ cfe-commi

[PATCH] D99299: Normalize interaction with boolean attributes

serge-sans-paille added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:660-663 +bool AttributeImpl::getValueAsBool() const { + assert(getValueAsString().empty() || getValueAsString() == "false" || getValueAsString() == "true"); + return getValueAsString() == "true"; +

[clang] fbc6f42 - clang-format: [JS] do not merge side-effect imports.

Author: Martin Probst Date: 2021-04-22T10:36:47+02:00 New Revision: fbc6f42dbee5d1d4ced30f520418c2b62942845a URL: https://github.com/llvm/llvm-project/commit/fbc6f42dbee5d1d4ced30f520418c2b62942845a DIFF: https://github.com/llvm/llvm-project/commit/fbc6f42dbee5d1d4ced30f520418c2b62942845a.diff

[PATCH] D101020: clang-format: [JS] do not merge side-effect imports.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbc6f42dbee5: clang-format: [JS] do not merge side-effect imports. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert created this revision. jdoerfert added reviewers: ABataev, grokos, dreachem, cchen, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. Herald added a reviewer: aaron.ballman. jdoerfert requested review of this revision. Herald added subscribers: l

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 339515. bader marked an inline comment as done. bader added a comment. Added SYCL address spaces mangling for targets without address space map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://rev

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

rogfer01 added a comment. I can reproduce the crash above in my computer, so something is definitely off. Looks like we emit this case RISCV::BI__builtin_rvv_vmmv_m_b8: case RISCV::BI__builtin_rvv_vmmv_m_b4: case RISCV::BI__builtin_rvv_vmmv_m_b2:

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. The fact that tests pass in assert builds without the argument generation suggests the feature doesn't have sufficient test coverage. Currently, the flag will be dropped

[clang] 398f253 - [clang][deps] Include "-cc1" in the arguments

Author: Jan Svoboda Date: 2021-04-22T10:57:56+02:00 New Revision: 398f2534f26d648ebbc7eae9dc401ffc7d5f URL: https://github.com/llvm/llvm-project/commit/398f2534f26d648ebbc7eae9dc401ffc7d5f DIFF: https://github.com/llvm/llvm-project/commit/398f2534f26d648ebbc7eae9dc401ffc7d5f.diff L

[PATCH] D100942: [clang][deps] Include "-cc1" in the arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG398f2534: [clang][deps] Include "-cc1" in the arguments (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100942/new/ https://re

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang-format was indenting the lines following the `?` in the added test case by +5 instead of +4. This only happens in a very specific situation, wher

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added a comment. > Do you know if any existing code already uses the __nvvm_* builtins for > cp.async? In other words, does nvcc provide them already or is it something > we're free to name as we wish? I do not see any relevant intrinsics mentioned > in NVVM IR spec: https://docs.

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:140 +// space must be compatible with the generic address space +return LangAS::sycl_global; + } Anastasia wrote: > This needs a language guar

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Module.h:896 + int getFramePointer() const; + void setFramePointer(int V); + It should be enum, similar to PIELevel. And probably needs IR documentation update? Repository: rG LLVM Github M

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

hokein created this revision. Herald added a subscriber: xazax.hun. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101037 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-ext

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. If `-ast-dump=json` was a driver flag, it would be trivial to pass `-ast-dump -ast-dump-format json` to -cc1 instead. However, aliasing a single option to two options within the -cc1 argument parser isn't possible at th

[PATCH] D101038: [clang-format] change shebang to python3.

hokein created this revision. hokein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101038 Files: clang/tools/clang-format/clang-format-diff.py Index: clang/tools/clang-

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

vitalybuka added inline comments. Comment at: llvm/lib/IR/Function.cpp:346 + case 1: +B.addAttribute("frame-pointer", "non-leaf"); +break; Should these be added into Attribute:: ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

arichardson added a comment. In D100762#2707812 , @jansvoboda11 wrote: > If `-ast-dump=json` was a driver flag, it would be trivial to pass `-ast-dump > -ast-dump-format json` to -cc1 instead. However, aliasing a single option to > two options within t

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 339533. whisperity edited the summary of this revision. whisperity added a comment. - **NFC** Fix lint of header guard nomenclature - **NFC** Tear out obsolete `LLVM_DEBUG` calls from the implementation Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; penagos wrote: > MyDeveloperDay wrote: > >

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

asavonic added a comment. Ping. Please let me know if the patch is acceptable for AArch64, or something else should be done to avoid overhead from rounding of return values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100591/new/ https://reviews

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @rsmith ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] 21ce124 - [AST] Add NestedNameSpecifierLoc accessors to node introspection

Author: Stephen Kelly Date: 2021-04-22T11:27:19+01:00 New Revision: 21ce124e1e638e380ce56dbcc97d174c58530566 URL: https://github.com/llvm/llvm-project/commit/21ce124e1e638e380ce56dbcc97d174c58530566 DIFF: https://github.com/llvm/llvm-project/commit/21ce124e1e638e380ce56dbcc97d174c58530566.diff

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rG21ce124e1e63: [AST] Add NestedNameSpecifierLoc accessors to node introspection (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1007

[clang] 3bcd0ec - [PowerPC] Add vec_roundc as alias for vec_rint in altivec.h

Author: Nemanja Ivanovic Date: 2021-04-22T05:31:38-05:00 New Revision: 3bcd0ece43bd117b9931d2b010b50884aa74870a URL: https://github.com/llvm/llvm-project/commit/3bcd0ece43bd117b9931d2b010b50884aa74870a DIFF: https://github.com/llvm/llvm-project/commit/3bcd0ece43bd117b9931d2b010b50884aa74870a.di

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declaration

Anastasia created this revision. Anastasia added reviewers: svenvh, yaxunl, mantognini. Herald added subscribers: ebevhan, mgrang. Anastasia requested review of this revision. The current implementation of extension pragma is not conformant to the spec as it does not disable anything and therefor

[PATCH] D100984: [OpenCL] Remove the need for subgroupd extension pragma in enqueue kernel builtins

azabaznov added a comment. I wish it could be true... But `cl_khr_subgroups` still requires pragma in some versions as it wasn't a core feature earlier (https://www.khronos.org/registry/OpenCL/sdk/2.2/docs/man/html/cl_khr_subgroups.html). I know that we are going around in circles and we discus

[clang] be2277f - [Matrix] Support #pragma clang fp

Author: Hamza Mahfooz Date: 2021-04-22T11:45:34+01:00 New Revision: be2277fbf233cca8e1bd698fa9ab6de404001c3a URL: https://github.com/llvm/llvm-project/commit/be2277fbf233cca8e1bd698fa9ab6de404001c3a DIFF: https://github.com/llvm/llvm-project/commit/be2277fbf233cca8e1bd698fa9ab6de404001c3a.diff

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe2277fbf233: [Matrix] Support #pragma clang fp (authored by effective-light, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

azabaznov added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7-8 -#ifdef EXT -#pragma OPENCL EXTENSION cl_khr_int64_base_atomics:enable -#pragma OPENCL EXTENSION cl_khr_int64_extended_atomics:enable -#pragma OPENCL EXTENSION cl_khr_fp64:enable -#if __OP

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. Same as for https://reviews.llvm.org/D100984, `cl_khr_fp64` wasn't always core and thus it requires pragma for OpenCL C < 1.2 versions. //9.3 Double Precision Floating-Point, OpenCL C 1.0// (https://www.khronos.org/registry/OpenCL/specs/opencl-1.0.pdf): OpenCL 1.0

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#2705441 , @sameerds wrote: > I realize now that what @foad says above puts the idea in a clearer context. > Essentially, any check for isConvergent() isn't happening in a vacuum. It is > relevant only in the presence of

[PATCH] D69498: IR: Invert convergent attribute handling

sameerds added a comment. In D69498#2706524 , @arsenm wrote: > In D69498#2705441 , @sameerds wrote: > >> I realize now that what @foad says above puts the idea in a clearer context. >> Essentially, any check for is

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz added a comment. In D100826#2702135 , @dblaikie wrote: > Do you know if you're going to be using LTO with DBX? If so, to respect this > flag, it would need to be added to LLVM IR module metadata (like the Dwarf > Version and Debug Info Version f

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz added a comment. Thanks for your review! @probinson @dblaikie @aprantl Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550 +Use DWARF extensions in later DWARF versions. + .. option:: -gz=, -gz (equivalent to -gz=zlib) probinson wrote: > d

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie added a comment. In D100826#2707145 , @shchenz wrote: > In D100826#2702135 , @dblaikie > wrote: > >> Do you know if you're going to be using LTO with DBX? If so, to respect this >> flag, it would need t

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

This revision was automatically updated to reflect the committed changes. Closed by commit rG26f138eed4af: [Debug-Info] implement -gstrict-dwarf (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D100809?vs=338752&id=339464#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz updated this revision to Diff 339470. shchenz added a comment. Herald added a subscriber: nemanjai. 1: add NFC testcases to use `-gstrict-dwarf` option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/D1008

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

aaron.ballman added a comment. In D100762#2707823 , @arichardson wrote: > In D100762#2707812 , @jansvoboda11 > wrote: > >> If `-ast-dump=json` was a driver flag, it would be trivial to pass >> `-ast-dump -ast-d

[PATCH] D100984: [OpenCL] Remove the need for subgroupd extension pragma in enqueue kernel builtins

Anastasia added a comment. In D100984#2707980 , @azabaznov wrote: > I wish it could be true... But `cl_khr_subgroups` still requires pragma in > some versions as it wasn't a core feature earlier > (https://www.khronos.org/registry/OpenCL/sdk/2.2/docs/ma

[clang] aee6c86 - [AST] De-duplicate empty node introspection

Author: Stephen Kelly Date: 2021-04-22T12:30:04+01:00 New Revision: aee6c86c4dc78da6ca75e0e6e6cfd50f95f2d956 URL: https://github.com/llvm/llvm-project/commit/aee6c86c4dc78da6ca75e0e6e6cfd50f95f2d956 DIFF: https://github.com/llvm/llvm-project/commit/aee6c86c4dc78da6ca75e0e6e6cfd50f95f2d956.diff

<    1   2   3