[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3523 +else + Opts.CXXABI = TargetCXXABI::getKind(CXXABI); + } The original command-line arguments must be generated from this in `GenerateLangArgs`. See https://

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

NoQ added a comment. This is a major improvement. `MallocChecker` will have to catch up on that. Hopefully through increased code re-use. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:651 + + return Result; +} I

[PATCH] D100929: [Clang] Allow the combination of loader_uninitialized and address spaces

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added a project: clang. When an object is allocated in a non-default address space we do not need to check for a construct

[PATCH] D100930: [Clang] Add clang attribute `clang_builtin_alias`.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01, khchen, aaron.ballman. Herald added subscribers: StephenFan, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrt

[PATCH] D100919: [AArch64] Support customizing stack protector guard

kristof.beyls added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:26 -// RUN: not %clang -target aarch64-linux-gnu -mstack-protector-guard-offset=10 %s 2>&1 | \ +// RUN: not %clang -target arm-linux-gnuebi -mstack-protector-guard-offset=10 %s 2>&1 | \

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added a comment. @aaron.ballman, could we discuss the generalization in https://reviews.llvm.org/D100930? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 ___

[clang] 0ad50bf - Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Pushpinder Singh Date: 2021-04-21T08:05:38Z New Revision: 0ad50bf27f892873427bd372a8e7d2e9b234586d URL: https://github.com/llvm/llvm-project/commit/0ad50bf27f892873427bd372a8e7d2e9b234586d DIFF: https://github.com/llvm/llvm-project/commit/0ad50bf27f892873427bd372a8e7d2e9b234586d.diff L

[PATCH] D100852: [analyzer] Track leaking object through stores

NoQ added a comment. I think this is already way better than before. I see that `OSDynamicCast` isn't supported yet and we seem to hit the same wall as D97183 because inter-operation between `trackExpressionValue` and the checkers isn't implemented yet.

[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

LemonBoy created this revision. LemonBoy added a reviewer: PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. LemonBoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ppc32` cpu model was introduced a while ago in a9321059

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enabled explicitly building inferred modules. Effectively a cherry-pick of htt

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn added a comment. In D100834#2702550 , @kpn wrote: > I don't know the matrix implementation so I can't swear this hits every place > needed, but the uses of CGFPOptionsRAII in this patch look correct at least. Other parts of the extension include `

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 339136. jansvoboda11 added a comment. Apply clang-format suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files: clang/include/clang/Basic/Module.h

[PATCH] D96286: [clangd][NFC] Change TidyProvider cache to use a linked list approach

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96286/new/ https://reviews.llvm.org/D96286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos added a comment. Thanks Peter. Since one week has passed, I plan to commit these changes by the end of the day if nothing surfaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https://reviews.llvm.org/D100372 _

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

LevyHsu updated this revision to Diff 339138. LevyHsu added a comment. 1. llvm/lib/Target/RISCV/RISCVISelLowering.cpp - Fix format issue with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100830/new/ https://reviews.llvm.org/D100830

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG11072a0bdbc0: [RISCV][Clang] Add RVV AMO builtins (authored by arcbbb). Changed prior to commit: https://reviews.llvm.org/D100448?vs=338419&id=339139#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] 64bc44f - [llvm-rc] Run clang to preprocess input files

Author: Martin Storsjö Date: 2021-04-21T11:50:10+03:00 New Revision: 64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95 URL: https://github.com/llvm/llvm-project/commit/64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95 DIFF: https://github.com/llvm/llvm-project/commit/64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95.diff

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64bc44f5ddfb: [llvm-rc] Run clang to preprocess input files (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D100755?vs=3

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( +

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

frasercrmck added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048 + return Cmp < 0; + // Some mask intrinsics use the same IRName as unmasked. + // Sort the unmasked intrinsics first. -

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:460-468 +TARGET_BUILTIN(__nvvm_redux_sync_add_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_min_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_max_s32, "SiSii", "

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko updated this revision to Diff 339143. vsavchenko marked an inline comment as done. vsavchenko added a comment. Add a comment and replace getAs with castAs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100852/new/ https://reviews.llvm.org

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko added a comment. In D100852#2704282 , @NoQ wrote: > I think this is already way better than before. I see that `OSDynamicCast` > isn't supported yet and we seem to hit the same wall as D97183 > because inter-

[PATCH] D100935: [OpenCL] Add missing C++ legacy atomics with generic

svenvh created this revision. svenvh added reviewers: Anastasia, olestrohm. svenvh added a project: clang. Herald added subscribers: ldrumm, jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D62335 added some C++ for OpenCL spec

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc256a443a45: [flang][driver] Add support for `-fget-definition` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] dc256a4 - [flang][driver] Add support for `-fget-definition`

Author: Andrzej Warzynski Date: 2021-04-21T09:31:36Z New Revision: dc256a443a456a8e0e4d72736fee1c9442bcf4bd URL: https://github.com/llvm/llvm-project/commit/dc256a443a456a8e0e4d72736fee1c9442bcf4bd DIFF: https://github.com/llvm/llvm-project/commit/dc256a443a456a8e0e4d72736fee1c9442bcf4bd.diff

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

LevyHsu updated this revision to Diff 339150. LevyHsu added a comment. Fix format in RISCVTargetLowering::LowerINTRINSIC_WO_CHAIN Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100830/new/ https://reviews.llvm.org/D100830 Files: clang/include/cla

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham created this revision. simon_tatham added reviewers: mstorsjo, thakis. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. I

[clang] 066b8f2 - [llvm-rc] Try to fix the Preprocessor/llvm-rc.rc test on non arm/x86 architectures

Author: Martin Storsjö Date: 2021-04-21T12:47:33+03:00 New Revision: 066b8f2fc6d584635a017a0a15494ce4460744e3 URL: https://github.com/llvm/llvm-project/commit/066b8f2fc6d584635a017a0a15494ce4460744e3 DIFF: https://github.com/llvm/llvm-project/commit/066b8f2fc6d584635a017a0a15494ce4460744e3.diff

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

rengolin accepted this revision. rengolin added a comment. It's a weird flag, for sure, but if that's the semantics of it, than this change LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https://reviews.llvm.org/D100372 _

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Driver/woa-crypto.c:2 +// RUN: %clang -target arm-windows-msvc -### -S %s -O0 -o /dev/null 2>&1 | FileCheck %s

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 339158. mstorsjo added a comment. Rebased, updated with fixes making the full preprocessing test pass on windows, including fixes for the default arch when running on arches that aren't normally supported as windows targets. Repository: rG LLVM Github M

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vneg.c:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -triple riscv32 -target-feature +f -target-feature +d -target-feature +experimental-v \ +// RUN: -target-feature +exp

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham added a comment. Yes, it looks easy enough to add something in `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. I'd mildly prefer to do that //as well// as having the test here, because the call site in the clang driver is quite complicated. My real aim is t

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo added a comment. In D100937#2704530 , @simon_tatham wrote: > Yes, it looks easy enough to add something in > `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. > > I'd mildly prefer to do that //as well// as having the tes

[PATCH] D100935: [OpenCL] Add missing C++ legacy atomics with generic

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I realized that as they haven't been added to the OpenCL 3 yet it means they remain as Clang extension. I am going to document this. We could allow their uses in OpenCL C too as a

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham updated this revision to Diff 339161. simon_tatham added a comment. Added a unit test on the LLVM side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 Files: clang/test/Driver/woa-crypto.c

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); bader wr

[clang] 77e170d - [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

Author: Simon Tatham Date: 2021-04-21T11:20:05+01:00 New Revision: 77e170db8678e582af986ffe27e12df196e4357b URL: https://github.com/llvm/llvm-project/commit/77e170db8678e582af986ffe27e12df196e4357b DIFF: https://github.com/llvm/llvm-project/commit/77e170db8678e582af986ffe27e12df196e4357b.diff

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77e170db8678: [ARM][Driver][Windows] Allow command-line upgrade to Armv8. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100727/new/ https://reviews.llvm.org/D100727 ___ cfe-commits mailing list cf

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

MyDeveloperDay added a comment. > I don't think we should change the LLVM style I'm not 100% convinced we are changing the LLVM style per say. LLVM always "cuddles" the "{" and Allow short Enums on a single line is true, this means if the "{" is on a new line then I think its actually a bug.

[clang] 174e796 - [llvm-rc] Fix a new test to disambiguate macOS paths like /Users/... from options starting with a slash

Author: Martin Storsjö Date: 2021-04-21T13:34:33+03:00 New Revision: 174e796c7d41e720e2a78e3de451b893d9e3a43f URL: https://github.com/llvm/llvm-project/commit/174e796c7d41e720e2a78e3de451b893d9e3a43f DIFF: https://github.com/llvm/llvm-project/commit/174e796c7d41e720e2a78e3de451b893d9e3a43f.diff

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

thakis added a comment. Purely FYI: the `--` in the test isn't needed just on macOS but also on Linux if your checkout is eg under /usr: http://45.33.8.238/linux/44652/step_7.txt (clang-cl has some nice diag if the /U flag is an existing file, since that happens fairly often. Maybe llvm-rc coul

[PATCH] D100929: [Clang] Allow the combination of loader_uninitialized and address spaces

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I misread this as implying loaded_uninitialized for addrspace globals, but actually it's a straightforward oversight from the original implementation. Thanks!

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen updated this revision to Diff 339169. steffenlarsen added a comment. Changes: - Removed integer type from builtin and intrinsic names. - Signedness in builtin and intrinsic names moved to operator name, i.e. umin and umax. - Removed redundant addition variant. CHANGES SINCE LAST

[clang] fdcb9c2 - [OpenCL] Refactor shuffle builtin decls

Author: Sven van Haastregt Date: 2021-04-21T11:59:24+01:00 New Revision: fdcb9c272899fc270bd9bd067dc20363f54ff190 URL: https://github.com/llvm/llvm-project/commit/fdcb9c272899fc270bd9bd067dc20363f54ff190 DIFF: https://github.com/llvm/llvm-project/commit/fdcb9c272899fc270bd9bd067dc20363f54ff190.

[clang] e2b3b89 - [OpenCL] Do not add builtins with unavailable types

Author: Sven van Haastregt Date: 2021-04-21T11:59:29+01:00 New Revision: e2b3b89bf1ce74bf889897e0353a3e3fa93e4452 URL: https://github.com/llvm/llvm-project/commit/e2b3b89bf1ce74bf889897e0353a3e3fa93e4452 DIFF: https://github.com/llvm/llvm-project/commit/e2b3b89bf1ce74bf889897e0353a3e3fa93e4452.

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b3b89bf1ce: [OpenCL] Do not add builtins with unavailable types (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

olestrohm updated this revision to Diff 339175. olestrohm added a comment. Inlined the `thread_local` check and moved `static clk_event_t` into the appropriate test. I did not move the `thread_local` check since NewVD had the wrong value for `TSCS`, so D was required. CHANGES SINCE LAST ACTION

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

arsenm added inline comments. Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:46-58 +/** + * @brief Lower incoming arguments into generic MIR, this method is responsible + * for splitting aggregate arguments into multiple single value types as well + * as setting

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added subscribers: jansvoboda11, dexonsmith, dang. shchenz requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2697732 , @dblaikie wrote: > In D100630#2697728 , @shchenz wrote: > >> In D100630#2694681 , @probinson >> wrote: >> >>> If DBX is goin

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 338697. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt clang-tools-e

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 338695. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-rvalue-ref.cpp Index: clang/test

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 338755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-rvalue-ref.cpp Index: clang/test

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added a subscriber: hiraditya. shchenz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: l

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

dblaikie added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550 +Use DWARF extensions in later DWARF versions. + .. option:: -gz=, -gz (equivalent to -gz=zlib) This description is probably backwards/doesn't explicitly clarify whi

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz updated this revision to Diff 338752. shchenz marked 2 inline comments as done. shchenz added a comment. address @dblaikie comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100809/new/ https://reviews.llvm.org/D100809 Files: clang/

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3973-3974 + // as true by default. + if (const Arg *A = Args.getLastArg(options::OPT_gstrict_dwarf)) +(void)checkDebugInfoOption(A, Args, D, TC); + if (Args.hasFlag(options::OPT_gstrict_dwarf,

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. You have a clang-format warning, aside from that LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie added a comment. Do you know if you're going to be using LTO with DBX? If so, to respect this flag, it would need to be added to LLVM IR module metadata (like the Dwarf Version and Debug Info Version fields) rather than as an MCOption. (we're pretty wishy-washy about what things we dec

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

probinson added a comment. Nit on the description, this patch supports -gstrict-dwarf in the frontend. Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550 +Use DWARF extensions in later DWARF versions. + .. option:: -gz=, -gz (equivalent to -gz=zlib) -

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100809/new/ https://reviews.llvm.org/D100809

[PATCH] D69498: IR: Invert convergent attribute handling

sameerds added a comment. The way I see it, the notion of convergence is relevant only to a certain class of targets (usually represented by GPUs) and it only affects certain optimizations. Then why not have only these optimizations check `TTI` to see if convergence matters? `TTI.hasBranchDiver

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99439/new/ https://reviews.llvm.org/D99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D69498: IR: Invert convergent attribute handling

foad added a comment. In D69498#2703317 , @sameerds wrote: > The way I see it, the notion of convergence is relevant only to a certain > class of targets (usually represented by GPUs) and it only affects certain > optimizations. Then why not have only th

[PATCH] D100942: [clang][deps] Include "-cc1" in the arguments

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To simplify tools consuming dependency scanning results, prepend the "-cc1" argument by d

[PATCH] D69498: IR: Invert convergent attribute handling

sameerds added a comment. In D69498#2704364 , @foad wrote: >> This recasts the whole question to be one about combining optimizations with >> target-specific information. The only changes required are in transforms >> that check `CallInst::isConvergent()

[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100933/new/ https://reviews.llvm.org/D100933 __

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 339187. jansvoboda11 added a comment. Rebase on top of D100942 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files: clang/

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan added a comment. thanks for the comments. My plan wrt documentation was to address that (and the feature macro) once the patches are in. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12353 + ED = R->getAsSingle(); +else if (UD && UD->shadow_size () == 1) +

[PATCH] D69498: IR: Invert convergent attribute handling

foad added a comment. > But in practice, the main issue for everyone is the effect on compile time > for targets that don't care about convergence/divergence. For such targets, > running even the divergence analysis is an unnecessary cost. LegacyDivergenceAnalysis::runOnFunction bails out immed

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 updated this revision to Diff 339189. xbolva00 added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-fns-alignment.c Index: clang/test/CodeGen/a

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added a comment. In D100879#2703979 , @rjmccall wrote: > Please addd tests, including tests that we suppress this assumption under > e.g. `-fno-builtin-malloc` Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://re

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 updated this revision to Diff 339191. xbolva00 added a comment. Handle also aligned_alloc and memalign. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-fns-alignment.c

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 updated this revision to Diff 339192. xbolva00 added a comment. Fixed small typo in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-fns-alignment.c Index: clang

[clang] 8c16c8b - Reland "[clang-scan-deps] Add support for clang-cl"

Author: Sylvain Audi Date: 2021-04-21T07:56:39-04:00 New Revision: 8c16c8b7ef7b1bbb1b24a980f30cf07d249dca5f URL: https://github.com/llvm/llvm-project/commit/8c16c8b7ef7b1bbb1b24a980f30cf07d249dca5f DIFF: https://github.com/llvm/llvm-project/commit/8c16c8b7ef7b1bbb1b24a980f30cf07d249dca5f.diff

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseTemporary,

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

olestrohm updated this revision to Diff 339197. olestrohm added a comment. Ran git-clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/ https://reviews.llvm.org/D100860 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaOpenCL/clk_event_t.cl clang/test/SemaOpenC

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. This will still produce a redundant `XXSLDWI`: vector float test(vector float a, float b) { a[3] = b; return a; } when compiled with `-mcpu=pwr9`. Repository: rG

[clang] 5f02c30 - Fix clang/test/Frontend/plugin-annotate-functions.c

Author: John Brawn Date: 2021-04-21T14:00:38+01:00 New Revision: 5f02c308e68d2412e2555017d4dbe3e2cc122913 URL: https://github.com/llvm/llvm-project/commit/5f02c308e68d2412e2555017d4dbe3e2cc122913 DIFF: https://github.com/llvm/llvm-project/commit/5f02c308e68d2412e2555017d4dbe3e2cc122913.diff LO

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

xbolva00 added a comment. In D99790#2680857 , @jyknight wrote: > It seems like there's a bug with vtable thunks getting the wrong information. > This appears to be a pre-existing bug, but this change has caused it to start > actively breaking code. > > T

[clang] 8e33651 - [clang] Recognize ppc32 as valid mcpu value

Author: LemonBoy Date: 2021-04-21T15:11:01+02:00 New Revision: 8e336511f18ab56cd0c8d93b5c18219df411963a URL: https://github.com/llvm/llvm-project/commit/8e336511f18ab56cd0c8d93b5c18219df411963a DIFF: https://github.com/llvm/llvm-project/commit/8e336511f18ab56cd0c8d93b5c18219df411963a.diff LOG:

[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e336511f18a: [clang] Recognize ppc32 as valid mcpu value (authored by LemonBoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100933/new/ https://reviews.

[clang] a63c9b2 - Do not pass null attributes to BuildAttributedStmt during instantiation

Author: Aaron Ballman Date: 2021-04-21T09:30:56-04:00 New Revision: a63c9b25620c8a4da9fcf1e1e8535d3110819ec0 URL: https://github.com/llvm/llvm-project/commit/a63c9b25620c8a4da9fcf1e1e8535d3110819ec0 DIFF: https://github.com/llvm/llvm-project/commit/a63c9b25620c8a4da9fcf1e1e8535d3110819ec0.diff

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, let's just rename `template-diagnostics.clcpp` into something like `template-opencl-types.clcpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/ https://review

[PATCH] D100953: clang-format: [JS] do not wrap after `asserts`

mprobst created this revision. mprobst added reviewers: krasimir, h-joo. mprobst requested review of this revision. Herald added a project: clang. `asserts` is a pseudo keyword in TypeScript used in return types. Wrapping after it triggers automatic semicolon insertion, which breaks the code seman

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

aaron.ballman added a comment. In D100762#2699350 , @dexonsmith wrote: > In D100762#2699252 , @arichardson > wrote: > >> I'm not sure it's a good idea to remove the `-ast-dump=json` option. While >> this is -cc

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. I was under the impression that `#!/usr/bin/env sh` is a sensible invocation for running a shell on various systems. The current theory for this struggling with the ppc buildbot is that fedora doesn't support that. Ad hoc searching suggests 'sh' is required to e

[PATCH] D100955: [-Wcalled-once] Do not run analysis on Obj-C++

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Objective-C++ is not yet suppoerted. rdar://76729552 Repository: rG LLV

[clang] ee3e016 - [Clang][ARM] Define __VFP_FP__ macro unconditionally

Author: Victor Campos Date: 2021-04-21T15:03:59+01:00 New Revision: ee3e01627ff876ef2225d691fc4d0a127c4abc78 URL: https://github.com/llvm/llvm-project/commit/ee3e01627ff876ef2225d691fc4d0a127c4abc78 DIFF: https://github.com/llvm/llvm-project/commit/ee3e01627ff876ef2225d691fc4d0a127c4abc78.diff

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rGee3e01627ff8: [Clang][ARM] Define __VFP_FP__ macro unconditionally (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https:

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

protze.joachim accepted this revision. protze.joachim added a comment. This revision is now accepted and ready to land. The latest changes fix the issue. I tested with x86_64 and nvidia offloading. The behavior and tests looks good to me, just one comment. Comment at: openmp/

[clang] ba7a92c - [Support] Don't include VirtualFileSystem.h in CommandLine.h

Author: Nico Weber Date: 2021-04-21T10:19:01-04:00 New Revision: ba7a92c01e86b5048a93abe7c26c25b90ea9040a URL: https://github.com/llvm/llvm-project/commit/ba7a92c01e86b5048a93abe7c26c25b90ea9040a DIFF: https://github.com/llvm/llvm-project/commit/ba7a92c01e86b5048a93abe7c26c25b90ea9040a.diff LO

[PATCH] D100957: [Support] Don't include VirtualFileSystem.h in CommandLine.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba7a92c01e86: [Support] Don't include VirtualFileSystem.h in CommandLine.h (authored by thakis). Herald added a project: clang. Herald added a subscr

[PATCH] D100953: clang-format: [JS] do not wrap after `asserts`

h-joo accepted this revision. h-joo added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3856 return false; // Otherwise automatic semicolon insertion would trigger. +if (NonComment && NonComment->is(to

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; MyDeveloperDay wrote: > I don't really under

  1   2   3   >