[PATCH] D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers

george.burgess.iv added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3/new/ https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); Quuxplusone wrote: > IMO you should use `"test < a | b >> c;"` as your test case here, to reassu

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. In D97183#2699080 , @RedDocMD wrote: > For the following function: > > void foo(std::unique_ptr P) { > A* praw = P.get(); > A* other = praw; > if (other) {} > P->foo(); > } > > Where do we expect a note? Where

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

dexonsmith added a comment. In D100762#2699252 , @arichardson wrote: > I'm not sure it's a good idea to remove the `-ast-dump=json` option. While > this is -cc1 option, there do seem to be external consumers based on a quick > search for "-ast-dump=jso

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

george.burgess.iv added a reviewer: rtrieu. george.burgess.iv added a comment. Just a few more nits and LGTM. We probably want the thoughts of someone with ownership in warnings to be sure. +rtrieu might be good? Comment at: clang/lib/Sema/SemaDecl.cpp:13740 +// other than ass

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a subscriber: rsmith. xbolva00 added a comment. In D100581#2697697 , @mbenfield wrote: > In D100581#2693131 , @xbolva00 > wrote: > These warnings are not enabled by any other flags. This is di

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. another false positive: ../../third_party/abseil-cpp/absl/strings/internal/str_format/float_conversion.cc:879:20: error: variable 'kBufSizeForHexFloatRepr' set but not used [-Werror,-Wunused-but-set-variable] constexpr size_t kBufSizeForHexFloatRepr = https://s

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2698422 , @curdeius wrote: > More I look at the current state of this option, more I think it's misleading. > I would expect that the if after else is also controlled by this option. And, > the last else as

[clang] abacaef - [AST] Update introspection API to use const-ref for copyable types

Author: Stephen Kelly Date: 2021-04-19T21:07:47+01:00 New Revision: abacaef1816254fc425fa81d137a8d54215d5913 URL: https://github.com/llvm/llvm-project/commit/abacaef1816254fc425fa81d137a8d54215d5913 DIFF: https://github.com/llvm/llvm-project/commit/abacaef1816254fc425fa81d137a8d54215d5913.diff

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

This revision was automatically updated to reflect the committed changes. Closed by commit rGabacaef18162: [AST] Update introspection API to use const-ref for copyable types (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D100720?vs=338366&id=338613#toc Repository

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. This seems to break our `Fucshia` builds. If we cannot do a quick fix, we need to revert this patch. Please see the error message below: FAIL: Clang :: ClangScanDeps/vfsoverlay.cpp (1863 of 27822) TEST 'Clang :: ClangScanDeps/vfsoverlay.cpp' FAILED

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const &RHS) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false;

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

This revision was automatically updated to reflect the committed changes. Closed by commit rG782c3e23ba09: [AST] Fix comparison to of SourceRanges in container (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100723/new/ htt

[clang] 782c3e2 - [AST] Fix comparison to of SourceRanges in container

Author: Stephen Kelly Date: 2021-04-19T21:19:21+01:00 New Revision: 782c3e23ba09ca7b01034d0fbf0b34044c1c79a3 URL: https://github.com/llvm/llvm-project/commit/782c3e23ba09ca7b01034d0fbf0b34044c1c79a3 DIFF: https://github.com/llvm/llvm-project/commit/782c3e23ba09ca7b01034d0fbf0b34044c1c79a3.diff

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire updated this revision to Diff 338620. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100712/new/ https://reviews.llvm.org/D100712 Files: clang/lib/Tooling/DumpTool/APIData.h clang/lib/Tooling/DumpTool/A

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280 STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc()) })); // clang-format on steveire wrote: > njames93 wrote: > > I'm not entirely sure on the case,

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rnk added subscribers: jyknight, echristo. rnk added a comment. Of the three people who commented on D17183 , you and I are on the only ones in favor of this approach. I think @echristo and @jyknight both preferred approach 2. I'd like to get at least an agreemen

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev updated this revision to Diff 338624. ABataev added a comment. Fixes and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/d

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. @gulfem We're taking a look now. Could you please post a link to the full build log, including the cmake flags used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. In D100776#2699565 , @rnk wrote: > Of the three people who commented on D17183 > , you and I are on the only ones in favor of > this approach. I think @echristo and @jyknight both preferred approa

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda abandoned this revision. kda added a comment. will attempt in smaller pieces. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:3317 ConstantInt::get(IntptrTy, LocalStackSize)); -IRB.SetInsertPoint(InsBefore); -FakeStack

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. > @gulfem We're taking a look now. Could you please post a link to the full > build log, including the cmake flags used? This is the link to one of our failing builds: https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang-linux-arm64/b8849674814150864912/overview Here,

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. Thanks! We found the issue. I think I'll revert the patch, and will reland a fixed version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 _

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire updated this revision to Diff 338631. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100712/new/ https://reviews.llvm.org/D100712 Files: clang/lib/Tooling/DumpTool/APIData.h clang/lib/Tooling/DumpTool/A

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. > Thanks! We found the issue. I think I'll revert the patch, and will reland a > fixed version. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 __

[PATCH] D93325: Add srcloc output to clang-query

steveire added a comment. @aaron.ballman ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Remove the dependence on standard C++ header for overloaded math functions in HIP header since standard C++ header is not available for hipRTC. https://reviews.llvm.org/D100794 Files: clang/l

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 338641. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp =

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos marked an inline comment as done. penagos added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); Quuxplusone wrote: > Quuxplusone wrote: > > IMO you should

[clang] 199c397 - Revert "[clang-scan-deps] Add support for clang-cl"

Author: Alexandre Ganea Date: 2021-04-19T17:45:18-04:00 New Revision: 199c39748292cbc89cd148a0d8364ebb1014ec38 URL: https://github.com/llvm/llvm-project/commit/199c39748292cbc89cd148a0d8364ebb1014ec38 DIFF: https://github.com/llvm/llvm-project/commit/199c39748292cbc89cd148a0d8364ebb1014ec38.dif

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 338648. penagos added a comment. Update Format test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/For

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

dexonsmith added a comment. Maybe LLVM should grow an `LLVMTargetInfo` library that sits between `LLVMSupport` and `LLVMCore`, as a version of solution 2 that doesn't induce more bloating in Support. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17183/new/ https

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

tra added a subscriber: jlebar. tra added a comment. LGTM overall. @jlebar: I could use your opinion here. Comment at: clang/lib/Headers/__clang_hip_cmath.h:341 - typedef decltype(__test(std::declval<_Tp>())) type; - static const bool value = !std::is_same::value; + typed

[PATCH] D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC]

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The motivation here is to make it available in the base class whether a fact is managed

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. Sorry, getting back to this only now. In D98450#2621907 , @aaron.ballman wrote: > In D98450#2621877 , @MForster wrote: > >> That's ok for me. I'd suggest to wait for Aaron's feedback, bec

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. In D98450#2699970 , @arphaman wrote: > Sorry, getting back to this only now. > > In D98450#2621907 , @aaron.ballman > wrote: > >> In D98450#2621877

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2699412 , @xbolva00 wrote: > I am a little bit worried that another off by default warning is not ideal > from user point of view. Either the user simply would fail to find out that > there is a new option or will b

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. So I checked gcc on godbolt since gcc docs are not so clear. UnusedButSetParameter is ignored with: - -Wunused alone - -Wextra alone - -Wall -Wunused But works with -Wextra -Wunused or -Wall -Wextra. So I think we should put UnusedButSetParameter under -Wextra

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. @dblaikie I did some investigation, found the root cause and provided an alternative solution. Could you check whether you are okay with either approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ http

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman created this revision. arphaman added reviewers: ab, t.p.northover. Herald added subscribers: ributzka, kristof.beyls. arphaman requested review of this revision. Herald added a project: clang. Clang's driver currently prints out different default triples when it's invoked like this on A

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGST

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. I hadn't looked into the details. I would try to make it. But from my understanding to this problem, the correct solution should remain the previous behavior if the end user doesn't specify `alignas` for `promise_type`. I mean, it shouldn't make so many test cases fail

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2700273 , @ChuanqiXu wrote: > I hadn't looked into the details. I would try to make it. > But from my understanding to this problem, the correct solution should remain > the previous behavior if the end user doesn't spec

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2699038 , @dblaikie wrote: > In D99160#2698980 , @alok wrote: > >> In D99160#2671899 , @dblaikie wrote: >> >>> In D99160#2670460

[PATCH] D100368: [X86] Support some missing intrinsics

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2700324 , @ychen wrote: > In D100739#2700273 , @ChuanqiXu > wrote: > >> I hadn't looked into the details. I would try to make it. >> But from my understanding to this problem

[PATCH] D68321: Fix clang Visual Studio build instructions

Loghorn added a comment. Is there a chance this will ever be merged? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

khchen added a comment. Is it okay to you? @kito-cheng @frasercrmck This patch could fix https://bugs.llvm.org/show_bug.cgi?id=49962, I hope this could be merged soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm

<    1   2