[PATCH] D100616: [clang] Fix a potential assert failure

craig.topper added a comment. In D100616#2693607 , @MaskRay wrote: > In D100616#2693603 , @craig.topper > wrote: > >> In D100616#2693595 , @MaskRay >> wrote: >> >>> SVE:

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added a comment. The transposition problem arises from: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D100616: [clang] Fix a potential assert failure

MaskRay added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:334 static constexpr uint64_t LargestBuiltinID = std::max( {NEON::FirstTSBuiltin, ARM::LastTSBuiltin, SVE::FirstTSBuiltin, AArch64::LastTSBuiltin, BPF::LastTSBuiltin, PPC::Last

[PATCH] D100619: [ASTReader] Only mark module out of date if not already compiled

bnbarham created this revision. bnbarham added a reviewer: akyrtzi. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a module contains errors (ie. it was built with -fallow-pcm-with-compiler-errors and had errors) and was from th

[PATCH] D100615: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

kito-cheng added a comment. So I think it's more than consistent issue, it's a bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100615/new/ https://reviews.llvm.org/D100615 ___ cfe-commits mailing

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

kito-cheng added a comment. Could you also check the compiler diagnostic messages? it will report `__builtin_rvv_vadd_vv_i8m1` or `vadd_generic` if argument type mis-match, which one you expected? I assume without `__clang_riscv_builtin_alias` clang will report `vadd_generic`? Repository: r

[PATCH] D100590: DeclContext: Fix iterator category

HazardyKnusperkeks updated this revision to Diff 337985. HazardyKnusperkeks added a comment. Trigger build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100590/new/ https://reviews.llvm.org/D100590 Files: clang/include/clang/AST/DeclBase.h In

[clang] 7029cff - [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

Author: Pushpinder Singh Date: 2021-04-16T05:26:20Z New Revision: 7029cffc4e78556cfe820791c612968bb15b2ffb URL: https://github.com/llvm/llvm-project/commit/7029cffc4e78556cfe820791c612968bb15b2ffb DIFF: https://github.com/llvm/llvm-project/commit/7029cffc4e78556cfe820791c612968bb15b2ffb.diff L

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7029cffc4e78: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev, grokos. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. We

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In D45639#2692142 , @ldionne wrote: > In D45639#2383754 , @smeenai wrote: > >> Just following up on this, cos I'm curious :) I have 12.1 now, and I still >> only see the C++ headers in the t

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 337988. yonghong-song added a comment. check FD->isDefined() as well before emit debuginfo for the declaration. It is okay to emit a declaration subprogram and later refined to be with definition. But it is not okay to refine a definition to a declarat

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

Max_S added a comment. Sorry forgot about that: Max Sagebaum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. In D91054#2693514 , @fghanim wrote: > You can update the tests as long as long as the output is correct. for > example the difference is only in names, ordering of basicblocks and > instructions that doesn't affect correctness,

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

njames93 added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:1294 + +#ifndef _WIN32 +TEST(Introspection, SourceLocations_TypeOfTypeLoc) { steveire wrote: > njames93 wrote: > > Can you add a comment explaining the issues with thi

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 337993. yonghong-song added a comment. - check Fn->getSubprogram() before emit debuginfo. This is consistent with EmitFuncDeclForCallSite() and is better than checking FD->isDefined() as we may hit multiple DeclRefExpr and all of them will go through e

[PATCH] D100621: [OpenMP] Ensure the DefaultMapperId has a location

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev, grokos. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. A u

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 337998. mbenfield added a comment. Respond to comments. - Use /// for function comment - Improve the text of function comment - Use SmallPtrSet instead of SmallDenseMap - Use reference instead of pointer in AllUsesAreSetsVisitor - Capture with [&] - co

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 337999. mbenfield marked an inline comment as done. mbenfield added a comment. Capitalization and periods for comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D1005

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield marked 4 inline comments as done. mbenfield added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13751 +bool TraverseBinaryOperator(BinaryOperator *BO) { + auto *LHS = BO->getLHS(); + auto *DRE = dyn_cast(LHS); george.burgess.iv

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 338002. yonghong-song added a comment. - checked both !FD->isDefined() and !Fn->getSubprogram() before emitting debuginfo for the declaration - added additional tests to mix DeclRefExpr and actual function definition. Repository: rG LLVM Github Mono

<    1   2   3