[PATCH] D100402: [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u}

2021-04-14 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6a18cc23efad: [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u} (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D100402?vs=337213&id=337540#toc Repository: rG LLV

[PATCH] D100507: [Clang][Docs] Claim the atomic compare

2021-04-14 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. Herald added a subscriber: jfb. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. I'm working on the implementation of OpenMP 5.1 feature `atomi

[PATCH] D100509: Support GCC's -fstack-usage flag

2021-04-14 Thread Pengxuan Zheng via Phabricator via cfe-commits
pzheng created this revision. pzheng added reviewers: apazos, efriedma, seaneveson, bruno, MatzeB, hfinkel. Herald added subscribers: jansvoboda11, dexonsmith, dang, hiraditya. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

2021-04-14 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. In D99949#2689583 , @gregrodgers wrote: > Dependence on hsa is not necessary. The amdgpu and nvidia drivers both use > PCI codes available in /sys . We should use architecture independent methods > as much as possible.

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

2021-04-14 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 337556. ggeorgakoudis added a comment. Fix llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/tes

[PATCH] D100509: Support GCC's -fstack-usage flag

2021-04-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Might you be interested in implementing [[ https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D1005

[PATCH] D100509: Support GCC's -fstack-usage flag

2021-04-14 Thread Pengxuan Zheng via Phabricator via cfe-commits
pzheng added a comment. In D100509#2689839 , @lebedev.ri wrote: > Might you be interested in implementing [[ > https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a > follow-up? Thanks for bring it up, @lebedev.ri. Yes, I will lo

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

2021-04-14 Thread Melanie Blower via Phabricator via cfe-commits
mibintc created this revision. mibintc added a reviewer: aaron.ballman. Herald added a subscriber: pengfei. mibintc requested review of this revision. Herald added a project: clang. I got a bug report that https://reviews.llvm.org/D97764 which introduced this diagnostic, was causing problems in i

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

2021-04-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 337567. lebedev.ri added a comment. @rsmith thank you for taking a look! This still feels pretty much like doing it while blindfolded. I've tried to store `GlobalDecl`, but i'm clearly missing something else, since there are still 23 test failures, and not

[PATCH] D100231: [NewPM] Cleanup IR printing instrumentation

2021-04-14 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 337572. aeubanks marked 2 inline comments as done. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D100231: [NewPM] Cleanup IR printing instrumentation

2021-04-14 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. I'm not sure that having a helper method with 4 lambdas is any cleaner. Normal control flow in a function is easier to read and understand, and not really that much more code. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:222 if (any_

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

2021-04-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Herald added a project: clang-tools-extra. Thanks for working on this and sorry for the long delay! I also think it's really useful, I hope we can simplify the impl a little and land it. Comment at: clang-tools-extra/clangd/refactor/tweaks/Implement

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2021-04-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D93185#2688003 , @dblaikie wrote: > @thakis - just FYI, Phab doesn't send mail to the mailing list when a patch > is approved without any text. Please include some text when approving patches > to make sure there's a record on

[PATCH] D100514: [OpenMP] Added codegen for masked directive

2021-04-14 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repos

[clang] c960c38 - NFC: Remove condition to simplify code

2021-04-14 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2021-04-14T23:38:04+01:00 New Revision: c960c3836c6a28ba8f8c0b21db0474bf7d674a18 URL: https://github.com/llvm/llvm-project/commit/c960c3836c6a28ba8f8c0b21db0474bf7d674a18 DIFF: https://github.com/llvm/llvm-project/commit/c960c3836c6a28ba8f8c0b21db0474bf7d674a18.diff

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

2021-04-14 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3066 - if (isCopyElisionCandidate(ReturnType, VD, CESK)) -return VD; - return nullptr; +static void downgradeNRVOResult(Sema::NRVOResult &Res, bool CanMove) { + Res.S = std::min(Res.S, CanMove ?

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

2021-04-14 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Indeed, I just this evening discovered the need for this to be stable across runs for testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100378/new/ https://reviews.llvm.org/D100378 __

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

2021-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Basic/Thunk.h:157 + + /// Holds a pointer to the overridee(!) method this thunk is for, + /// if needed by the ABI to distinguish different thunks with equal Isn't this the same as `BaseMethod.getDec

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

2021-04-14 Thread Ten Tzen via Phabricator via cfe-commits
tentzen added a comment. bool keepFramePointer(const MachineFunction &MF) const override; In D80344#2673335 , @lebedev.ri wrote: > In D80344#2673148 , @asmith wrote: > >> In D80344#2671157

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

2021-04-14 Thread Stephen Kelly via Phabricator via cfe-commits
steveire requested changes to this revision. steveire added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:26 +if (On->returnsPointer()) + OS << "->"; +else The reason for the `Loca

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman updated this revision to Diff 337576. haberman marked 6 inline comments as done. haberman added a comment. - Word-smithed diagnostics and addressed other review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://rev

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

2021-04-14 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rGb23abbeab1d7: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] b23abbe - [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

2021-04-14 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2021-04-15T00:12:22+01:00 New Revision: b23abbeab1d76376b4b46142d04e6c105c1074f0 URL: https://github.com/llvm/llvm-project/commit/b23abbeab1d76376b4b46142d04e6c105c1074f0 DIFF: https://github.com/llvm/llvm-project/commit/b23abbeab1d76376b4b46142d04e6c105c1074f0.diff

[clang] bfb6c28 - [AST][NFC] Remove temporary ASTTU file from Introspection generation.

2021-04-14 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2021-04-15T00:14:55+01:00 New Revision: bfb6c2874be830cc6f7595652d23192598edecf0 URL: https://github.com/llvm/llvm-project/commit/bfb6c2874be830cc6f7595652d23192598edecf0 DIFF: https://github.com/llvm/llvm-project/commit/bfb6c2874be830cc6f7595652d23192598edecf0.diff

[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

2021-04-14 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb6c2874be8: [AST][NFC] Remove temporary ASTTU file from Introspection generation. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[clang] 6890f30 - [AST][Introspection] Fix args not being set.

2021-04-14 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2021-04-15T00:19:40+01:00 New Revision: 6890f302f587ca4f6712be728bd9302da597fe0c URL: https://github.com/llvm/llvm-project/commit/6890f302f587ca4f6712be728bd9302da597fe0c DIFF: https://github.com/llvm/llvm-project/commit/6890f302f587ca4f6712be728bd9302da597fe0c.diff

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

2021-04-14 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. One of the ten commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

2021-04-14 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. One of the ten commits that landed here (https://github.com/llvm/llvm-project/compare/a3bfddbb6a27...59d5b8c27b43), this being one of them, slowed down check-clang by over 20%: https://bugs.llvm.org/show_bug.cgi?id=49962 Since recovering test runtime regressions is very

[clang] dd98555 - Reapply "[InferAttributes] Materialize all infered attributes for declaration"" and follow on patches.

2021-04-14 Thread Philip Reames via cfe-commits
Author: Philip Reames Date: 2021-04-14T16:38:07-07:00 New Revision: dd985551c247752ee2be71f04a141225a40641ef URL: https://github.com/llvm/llvm-project/commit/dd985551c247752ee2be71f04a141225a40641ef DIFF: https://github.com/llvm/llvm-project/commit/dd985551c247752ee2be71f04a141225a40641ef.diff

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

2021-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:299 + " with attribute 'no_caller_saved_registers'">, + InGroup; def warn_arm_interrupt_calling_convention : Warning< Please don't add warnings directly to `-Wextra`; t

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman updated this revision to Diff 337581. haberman added a comment. - More diagnostic wordsmithing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/AST/IgnoreExpr.h clang

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

2021-04-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D99741#2690124 , @thakis wrote: > One of the ten commits that landed here > (https://github.com/llvm/llvm-project/compare/a3bfddbb6a27...59d5b8c27b43), > this being one of them, slowed down check-clang by over 20%: > htt

[clang] dc1ab59 - [Sema] Fold VLA types in compound literals to constant arrays.

2021-04-14 Thread Eli Friedman via cfe-commits
Author: Eli Friedman Date: 2021-04-14T17:09:59-07:00 New Revision: dc1ab590a0527533815aeed0100de54a5f4a4829 URL: https://github.com/llvm/llvm-project/commit/dc1ab590a0527533815aeed0100de54a5f4a4829 DIFF: https://github.com/llvm/llvm-project/commit/dc1ab590a0527533815aeed0100de54a5f4a4829.diff

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

2021-04-14 Thread Eli Friedman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1ab590a052: [Sema] Fold VLA types in compound literals to constant arrays. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

2021-04-14 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Look good in general, only the few comments. Comment at: clang/unittests/Format/FormatTest.cpp:8892 FormatStyle Style = getLLVMStyle(); + FormatStyle NoEmptyLines = getLLVMStyle(); + NoEmptyLines.MaxEmptyLinesToKeep = 0;

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

2021-04-14 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5077 + verifyFormat("asm volatile(\"string\", : : val);", Style); + verifyFormat("asm volatile(\"string\", : val1 : val2);", Style); + You should add a test case with lo

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman updated this revision to Diff 337589. haberman added a comment. - Added release note for [[clang::musttail]]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100161: Redistribute energy for Corpus

2021-04-14 Thread taotao gu via Phabricator via cfe-commits
gtt1995 added a comment. In D100161#2689156 , @morehouse wrote: > At this point I am not convinced this patch will provide benefit for the > default use case when `-entropic=1`. I am hesitant to add complexity to the > code for unsure benefit. > > If y

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman updated this revision to Diff 337590. haberman added a comment. - Fixed release note escaping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

2021-04-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 337591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/include/.keep

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman updated this revision to Diff 337592. haberman added a comment. - Fixed several cases in CodeGen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

2021-04-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D97669#2688771 , @Anastasia wrote: > In D97669#2687419 , @benshi001 wrote: > >> In D97669#2685698 , @Anastasia >> wrote: >> >>> In D97669#26784

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

2021-04-14 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: njames93. Herald added subscribers: mgrang, mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the matchers gathering API for types to record template parameter

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Thanks, cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman updated this revision to Diff 337597. haberman added a comment. - Fixed typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst clang/include/clang/A

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2021-04-14 Thread Josh Haberman via Phabricator via cfe-commits
haberman added a comment. Ok I think this is ready to land. There are a few FIXME comments, I will follow up with some small changes to address them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 __

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatability

2021-04-14 Thread Amy Kwan via Phabricator via cfe-commits
amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:683 +// Provided builtins with _mma_ prefix for compatability. +CUSTOM_BUILTIN(mma_lxvp, "W256SLLiW256C*", false) --

[PATCH] D100368: [X86] Support some missing intrinsics

2021-04-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9611 +/// starting at location \a base_addr at packed 32-bit integer indices stored in +/// the lower half of \a vindex scaled by \a scale into dst using writemask +/// \a mask (elements are copied from

RE: [clang] 5ad15f4 - Require commas between double square bracket attributes.

2021-04-14 Thread via cfe-commits
Hi Aaron, Your change is causing the compiler to go into an infinite loop in one of our internal tests. I have put details up in PR49966, can you please take a look? Douglas Yung -Original Message- From: cfe-commits On Behalf Of Aaron Ballman via cfe-commits Sent: Tuesday, April 13, 2

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

2021-04-14 Thread Pushpinder Singh via Phabricator via cfe-commits
pdhaliwal updated this revision to Diff 337640. pdhaliwal added a comment. Rebase and review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files: clang/include/clang/Basic/DiagnosticDriverKinds

<    1   2