[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added a comment. Ping.. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D98912: Fix -Winteger-overflow to diagnose regardless of the top-level syntactic form.

vsapsai accepted this revision. vsapsai added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:972-973 +// Determine if we might warn that the given expression exhibits undefined +// behavior. +bool mightWa

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Change looks good, so it's accepted on my end. I'll let the other reviewers have a look and post their comments. Please do not commit until we have reached an agreement for all 4 patches toget

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 335702. yaxunl added a comment. revised by Richard's comments. Check function-scope static var. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CodeGenCUDA/de

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2672668 , @tejohnson wrote: > In D99683#2672578 , @yaxunl wrote: > >> In D99683#2672554 , @tejohnson >> wrote: >> >>> This raises some high

[PATCH] D99810: [ifs][elfabi] Merge llvm-elfabi tool into llvm-ifs

haowei marked 3 inline comments as done. haowei added a comment. I will try to split this change. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:26 const bool WriteBin = !Args.getLastArg(options::OPT_emit_merged_ifs); - CmdArgs.push_back(WriteBin ? "write-bin" :

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. In D80344#2671157 , @lebedev.ri wrote: > It would be good for @rjmccall / @rsmith / etc to actually finish reviewing > this and accept it. > I would personally want to see the next patches - what changes are needed for > llvm an

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. @rjmccall @rsmith Thanks for your help. Do you have any additional feedback before we commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added a comment. Here's a reduced repro - a file that has different behavior before and after the patch (sorry, not perfectly reduced, my creduce is broken again): // RUN: clang --analyze %s typedef Oid; typedef Pointer; typedef text; errstart(int elevel, filename, lineno, funcname

[clang] 000cf84 - Revert "[NFC][Clang] Speculative fix for builtins-ppc-quadword-noi128.c"

Author: Petr Hosek Date: 2021-04-06T23:22:08-07:00 New Revision: 000cf84cf1bb2f5475600737c16c3ccf43096f58 URL: https://github.com/llvm/llvm-project/commit/000cf84cf1bb2f5475600737c16c3ccf43096f58 DIFF: https://github.com/llvm/llvm-project/commit/000cf84cf1bb2f5475600737c16c3ccf43096f58.diff LO

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aeubanks added a comment. could you clang-format the patch? Comment at: clang/lib/CodeGen/CGException.cpp:1666-1667 + ++J) { + if (isa(J)) { +auto LI = dyn_cast(J); +LI->setVolatile(true); ``` if (auto*LI = dyn_cast<...>(J)) { ...

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

sylvestre.ledru added a comment. To understand better, we will be fixing a bug from 2015, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { Anastasia wrote: > benshi

<    1   2   3