[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2021-04-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Alright, mostly looks good. Comment at: clang/lib/Sema/SemaChecking.cpp:5011 +!ValType->isFloatingType()) { + Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_atomic_int_ptr_or_fp) << IsC11 << Ptr->getType() << Ptr->getSour

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

2021-04-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. The last major conversation we had about this was this RFC I sent out about five years ago: https://lists.llvm.org/pipermail/llvm-dev/2016-January/094012.html In that RFC, I specifically argued that we should not do this, and that it should only be considered undefi

<    1   2