[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

Jim added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:26 + +} // TargetPrefix = "riscv" + How about put it between Atomics and Vector to follow canonical order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk commandeered this revision. hvdijk edited reviewers, added: glaubitz; removed: hvdijk. hvdijk added a comment. > Feel free to update the diff here with your suggested patch. Alright, thanks. Updating this requires me to 'commandeer' it, doing that now. Repository: rG LLVM Github Monore

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk updated this revision to Diff 334365. hvdijk added a comment. This updates the diff as described, plus includes test suite changes needed to make `check-clang` pass. The changes to `clang/test/Driver/Inputs/basic_cross_linux_tree/usr` are because we now correctly detect that a x86_64 GCC

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

MaskRay added inline comments. Comment at: clang/test/Driver/baremetal.cpp:37 // CHECK-V6M-DEFAULTCXX: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" -// CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}lib{{(64)?}}{{[/\\]+}}clang{{[/\\]+}}{{.*}}{{[/\\]

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:331 // Note: LAnd, LOr, Comma are handled specially by higher-level logic.

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added inline comments. Comment at: clang/test/Driver/baremetal.cpp:37 // CHECK-V6M-DEFAULTCXX: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" -// CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}lib{{(64)?}}{{[/\\]+}}clang{{[/\\]+}}{{.*}}{{[/\\]+

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

steakhal added reviewers: erichkeane, rnk, majnemer, EricWF. steakhal added a comment. I'm adding a couple of reviewers to get this going. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89649/new/ https://reviews.llvm.org/D89649 ___ cfe-commit

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added inline comments. Comment at: clang/test/Driver/baremetal.cpp:37 // CHECK-V6M-DEFAULTCXX: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" -// CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}lib{{(64)?}}{{[/\\]+}}clang{{[/\\]+}}{{.*}}{{[/\\]+

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. >> We probably need to talk about it. > > +1. Do you use discord/slack/skype? I will try to summarize the discussion here. @rjmccall , @rsmith please feel free to correct me if I am wrong or add important points that I missed. The discussion focused on supporting tw

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

MaskRay added inline comments. Comment at: clang/test/Driver/baremetal.cpp:37 // CHECK-V6M-DEFAULTCXX: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" -// CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}lib{{(64)?}}{{[/\\]+}}clang{{[/\\]+}}{{.*}}{{[/\\]

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added inline comments. Comment at: clang/test/Driver/baremetal.cpp:37 // CHECK-V6M-DEFAULTCXX: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" -// CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}lib{{(64)?}}{{[/\\]+}}clang{{[/\\]+}}{{.*}}{{[/\\]+

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2655880 , @LuoYuanke wrote: >> Whether to further optimizations are correct is a different problem, but we >> need a specification for the builtins, intrinsics and the type before going >> any further in that direction. >

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added inline comments. Comment at: clang/test/Driver/baremetal.cpp:37 // CHECK-V6M-DEFAULTCXX: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" -// CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}lib{{(64)?}}{{[/\\]+}}clang{{[/\\]+}}{{.*}}{{[/\\]+

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added reviewers: martong, balazske, Szelethus, ASDenysPetrov. steakhal added a comment. Herald added a subscriber: rnkovacs. spam reviewers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://reviews.llvm.org/D83660 ___

[clang] b5995fc - [OpenCL] Limit popcount to OpenCL 1.2 and above

Author: Sven van Haastregt Date: 2021-03-31T09:54:18+01:00 New Revision: b5995fced41de0885a5ef8f1b8a25ef45d8be711 URL: https://github.com/llvm/llvm-project/commit/b5995fced41de0885a5ef8f1b8a25ef45d8be711 DIFF: https://github.com/llvm/llvm-project/commit/b5995fced41de0885a5ef8f1b8a25ef45d8be711.

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4656-4657 !getLangOpts().ObjC) { -ProhibitAttributes(attrs); +ProhibitCXX11Attributes(attrs, diag::err_attributes_not_allowed, +/*DiagnoseEmptyAttrs=*/true); i

[clang] 49c0ab6 - [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

Author: Balázs Kéri Date: 2021-03-31T11:19:42+02:00 New Revision: 49c0ab6d7611050ae902f6369fc878e17da453ad URL: https://github.com/llvm/llvm-project/commit/49c0ab6d7611050ae902f6369fc878e17da453ad DIFF: https://github.com/llvm/llvm-project/commit/49c0ab6d7611050ae902f6369fc878e17da453ad.diff L

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rG49c0ab6d7611: [clang][Checkers] Extend PthreadLockChecker state dump (NFC). (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

jansvoboda11 added a comment. In D99568#2659526 , @dexonsmith wrote: > I'm not sure a deep copy is entirely sound, due to odd ownership rules in > "remapped buffers" (I forget the subclass that includes those). A few months > ago I got most of the way to

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds two

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann created this revision. mgartmann added reviewers: aaron.ballman, njames93, alexfh. mgartmann added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. mgartmann requested review of this revision. **Problem Description** The `iostream` header file defines multiple

[clang] 936d1e9 - [ASTImporter][NFC] Improve test coverage

Author: Balazs Benics Date: 2021-03-31T12:10:23+02:00 New Revision: 936d1e97a32d05471f845d69496abcbf54687e72 URL: https://github.com/llvm/llvm-project/commit/936d1e97a32d05471f845d69496abcbf54687e72 DIFF: https://github.com/llvm/llvm-project/commit/936d1e97a32d05471f845d69496abcbf54687e72.diff

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG936d1e97a32d: [ASTImporter][NFC] Improve test coverage (authored by Balazs Benics ). Changed prior to commit: htt

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

thakis added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported) { Does this

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported) { thakis

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

thakis added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported) { steakhal

[clang] 9d474be - [ASTImporter][NFC] Fix duplicated symbols in "Improve test coverage"

Author: Balazs Benics Date: 2021-03-31T12:47:50+02:00 New Revision: 9d474be11d71b5ae13490d3d8bd66150765560e3 URL: https://github.com/llvm/llvm-project/commit/9d474be11d71b5ae13490d3d8bd66150765560e3 DIFF: https://github.com/llvm/llvm-project/commit/9d474be11d71b5ae13490d3d8bd66150765560e3.diff

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal marked 2 inline comments as done. steakhal added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlock

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plu

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plus_p

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz accepted this revision. shchenz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/ https://reviews.llvm.org/D99250 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlock

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

ABataev added a comment. Could you add a small codegen test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann added a comment. I am working on fixing the failing build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. In D96853#2660443 , @benshi001 wrote: > In D96853#2659266 , @Anastasia wrote: > >> Btw is any pointer conversion between address space 1 and the default >> address space allowed? I.e. is

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

riccibruno added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25 + .bind("match"), + this); +} Will this match `my_namespace::cin`? Comment at: clang-tools-extra/clang-tidy/

[PATCH] D99456: [C++2b] Support size_t literals

aaron.ballman added a comment. Generally LGTM but I did have a question about the feature testing macro. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L");

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske added inline comments. Comment at: clang/test/Analysis/pthreadlock_state.c:59 + // CHECK-NEXT: "mtx: destroyed", + // CHECK-NEXT: "SymRegion{reg_$[[REG:[0-9]+]]}: not tracked, possibly destroyed", + // CHECK-NEXT: "Mutexes in unresolved possibly destro

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

arnamoy10 added inline comments. Comment at: flang/test/Parser/omp-allocate-unparse.f90:1 -! RUN: %f18 -fdebug-no-semantics -funparse -fopenmp %s | FileCheck %s +! RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp %s | FileCheck %s ! Check Unparsing of OpenMP Allocate directive -

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:159 +def err_verify_nonconst_addrspace : Error< + "qualifier 'const' is needed for variables in address space '%0'">; Ok, do you plan to pass anything other than

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

steakhal added inline comments. Comment at: clang/test/Analysis/pthreadlock_state.c:59 + // CHECK-NEXT: "mtx: destroyed", + // CHECK-NEXT: "SymRegion{reg_$[[REG:[0-9]+]]}: not tracked, possibly destroyed", + // CHECK-NEXT: "Mutexes in unresolved possibly destro

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unhandled-exception-at-new.cpp:143 + f_est_noexcept_dependent_used(); +} balazske wrote: > balazske wrote: > > aaron.ballman wrote: > > > You have tests for pla

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334420. bader marked 24 inline comments as done. bader added a comment. Applied code review suggestions Resolved merge conflicts with D99190 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader added inline comments. Comment at: clang/docs/SYCLSupport.md:821 +SYCL compiler toolchain. Section 3.8.2 of SYCL 2020 specification defines +[memory model](https://www.khronos.org/registry/SYCL/specs/sycl-2020/html/sycl-2020.html#_sycl_device_memory_model), +section 4.7.7

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, xazax.hun, balazske, Szelethus. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. steakhal requested review of thi

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

thakis added a comment. Thanks, that bot is happy again. Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089 +struct ImportBlock : ASTImporterOptionSpecificTestBase {}; +const internal::VariadicDynCastAllOfMatcher blockDecl; +TEST_P(ImportBlock, ImportBlocksAreUnsupported)

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8) -

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334422. AntonBikineev added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td c

[PATCH] D99456: [C++2b] Support size_t literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch! Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defin

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for the fixes! Comment at: clang/lib/Parse/ParseDecl.cpp:4656-4657 !getLangOpts().ObjC) { -ProhibitAttributes(attrs); +ProhibitCXX11Attributes(attrs, diag::err_attributes_not_all

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

asb added a comment. Can I just check the reasoning on the naming? I see that the bitmanip 0.93 spec proposes _{rv,rv32,rv64}_{opname} intrinsics. Does the __builtin__{riscv,riscv32,riscv64}_opname format match what GCC are doing / planning to do here? Precedent for RVV, for other archs, or som

[clang] ffcb4b4 - Revert "[clang][Checkers] Extend PthreadLockChecker state dump (NFC)."

Author: Balázs Kéri Date: 2021-03-31T15:28:53+02:00 New Revision: ffcb4b43b799f518891088076ef083ca8f13c537 URL: https://github.com/llvm/llvm-project/commit/ffcb4b43b799f518891088076ef083ca8f13c537 DIFF: https://github.com/llvm/llvm-project/commit/ffcb4b43b799f518891088076ef083ca8f13c537.diff L

[PATCH] D99521: [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1.

JimCownie added a comment. This patch appears to fix the problem on my Mac Mini M1 machine (at least, it passes the trivial test in the bug report). I cannot comment on the code itself, which someone else should review. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske added a comment. Test failures occurred, fix of the problem is not trivial, probably the test file should be split. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. > Unfortunately this is not possible to use an opaque type with the AMX > intrinsics at the moment, because of the way they are define. It is possible > to use opaque types with intrinsics in general though, e.g. see > https://llvm.godbolt.org/z/Ezhf6535c > > My point

[PATCH] D99590: [Clang] Do not use memcpy for scalable struct copy.

frasercrmck added inline comments. Comment at: clang/include/clang/AST/Type.h:4627 + /// Recursively check all fields in the record for sizeless. If any field + /// is sizeless type, return true. Otherwise, return false. + bool hasSizelessFields() const; nit:

[PATCH] D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99108/new/ https://reviews.llvm.org/D99108 ___ cfe-co

[PATCH] D99659: [analyzer][taint] Extent of heap regions should get taint sometimes

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, balazske, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a reviewer: Szeleth

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Looking great! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99658/new/ https://reviews.llvm.org/D99658 ___

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

frasercrmck added a comment. Are there any tests for this? Comment at: clang/lib/CodeGen/CGCall.cpp:1299 bool DestIsVolatile) { // Prefer scalar stores to first-class aggregate stores. if (llvm::StructType *STy = dyn_cast(Val->get

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

vsavchenko added inline comments. Comment at: clang/test/Analysis/explain-svals.cpp:56 clang_analyzer_explain(x); // expected-warning-re^pointer to element of type 'int' with index 0 of heap segment that starts at symbol of type 'int \*' conjured at statement 'new int \[

[clang] dc7ebd2 - [C++2b] Support size_t literals

Author: Anton Bikineev Date: 2021-03-31T13:36:23Z New Revision: dc7ebd2cb0cf4a83bb6cd1bfc8853b0a30054777 URL: https://github.com/llvm/llvm-project/commit/dc7ebd2cb0cf4a83bb6cd1bfc8853b0a30054777 DIFF: https://github.com/llvm/llvm-project/commit/dc7ebd2cb0cf4a83bb6cd1bfc8853b0a30054777.diff LOG

[PATCH] D99521: [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. I assume we can soon get rid of the variadic function type if we never use it as such. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev closed this revision. AntonBikineev added a comment. Aaron, Richard, thanks a lot for reviewing this! Sorry, forgot to add amend the commit with 'Differential revision', closing this manually.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

everton.constantino added a comment. @fhahn When I mentioned the splats I was talking about the IR, not the final code. On the Godbolts links you sent, its the same that I see. However take a look into the IR your example generates: %vec.cast = bitcast [4 x float]* %A to <2 x float>* %col.l

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

martong accepted this revision. martong added a comment. I went through the change and it looks good, seems like this is indeed a copy paste error from line 132. I checked the related conversation, and thanks for all the effort spent with the test. > BTW, I was obstructed by the z3 requirement

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:61 +} // namespace clang \ No newline at end of file Please add newline. Comment at: clang-tools-extra/clang-tidy/misc/S

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334433. bader added a comment. Convert document to ReST format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/SYCLSupport.rst Index: clang/docs/SYC

[PATCH] D99456: [C++2b] Support size_t literals

Quuxplusone added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8) aaron.ballman wrote: > AntonBikine

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:258 + DefinedOrUnknownSVal Size = + getDynamicSize(State, MR->getBaseRegion(), C.getSValBuilder()); Wait a bit, I think it should consider the offset to

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

vsavchenko added inline comments. Comment at: clang/test/Analysis/inner-pointer.cpp:23 + +char *data(std::string &c); + martong wrote: > Seems like all test are exercising with std::string, this looks like a legacy > in this Checker. > Still, I miss a bit at lea

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:258 + DefinedOrUnknownSVal Size = + getDynamicSize(State, MR->getBaseRegion(), C.getSValBuilder()); martong wrote: > Wait a bit, I think it should consi

[clang] a8cf32b - [RISCV] Add XFAIL riscv32 for known issue with the old pass manager

Author: Luís Marques Date: 2021-03-31T15:18:32+01:00 New Revision: a8cf32baf57de151bb6a8341957e101b04a6e816 URL: https://github.com/llvm/llvm-project/commit/a8cf32baf57de151bb6a8341957e101b04a6e816 DIFF: https://github.com/llvm/llvm-project/commit/a8cf32baf57de151bb6a8341957e101b04a6e816.diff

[PATCH] D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8cf32baf57d: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager (authored by luismarques). Repository: rG LLVM Github Monorepo

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added inline comments. Comment at: clang/test/Analysis/z3/Inputs/MockZ3_solver_check.c:6 + +// Mock implementation: return UNDEF for the 5th invocation, otherwise it just +// returns the result of the real invocation. martong wrote: > It's not clear why

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:159 +def err_verify_nonconst_addrspace : Error< + "qualifier 'const' is needed for variables in address space '%0'">;

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, ahatanak. erik.pilkington requested review of this revision. Clang used to emit a bad -Wbridge-cast diagnostic on the cast in the attached test. This was because, after 09abecef7

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn added a comment. In D99433#2661357 , @everton.constantino wrote: > @fhahn When I mentioned the splats I was talking about the IR, not the final > code. On the Godbolts links you sent, its the same that I see. However take a > look into the IR your

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

martong added a comment. Ah, I see you need `nonloc::SymbolVal` in your next patch, and `getDynamicSizeWithOffset` returns an Unknown if the extend is symbolic. Anyway, I still feel misleading that `clang_analyzer_getExtent` does not handle the offset. Could we change `getDynamicSizeWithOffset`

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

steakhal planned changes to this revision. steakhal added a comment. In D99658#2661452 , @martong wrote: > Ah, I see you need `nonloc::SymbolVal` in your next patch, and > `getDynamicSizeWithOffset` returns an Unknown if the extend is symbolic. > > Anyway

[clang] 5018e15 - [clang][parser] Allow GNU-style attributes in explicit template...

Author: Timm Bäder Date: 2021-03-31T16:44:19+02:00 New Revision: 5018e15fdfda855f130cdb78acb88540046853af URL: https://github.com/llvm/llvm-project/commit/5018e15fdfda855f130cdb78acb88540046853af DIFF: https://github.com/llvm/llvm-project/commit/5018e15fdfda855f130cdb78acb88540046853af.diff LO

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5018e15fdfda: [clang][parser] Allow GNU-style attributes in explicit template... (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/n

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

martong added inline comments. Comment at: clang/test/Analysis/inner-pointer.cpp:23 + +char *data(std::string &c); + vsavchenko wrote: > martong wrote: > > Seems like all test are exercising with std::string, this looks like a > > legacy in this Checker. > > Sti

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8) Quuxplusone wrote: > aaron.ballm

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM thank you for trying where you could to use verifyFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 _

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

Anastasia added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:15 +struct s10 a0; +a0.a = c; +a0.b = b; Minor thing - I guess for the purpose of this testing you could skip initialization on struct variables? CHANGES SINCE

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. Is `stdio.h` used by anything? Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { --

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM, but please clean up the comments before landing. Comment at: clang/docs/ClangFormatStyleOptions.rst:2132 +**EmptyLineAfterAccessModifier** (``EmptyLineAfterAccessMo

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2661369 , @martong wrote: > I went through the change and it looks good, seems like this is indeed a copy > paste error from line 132. > I checked the related conversation, and thanks for all the effort spent with > th

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334445. serge-sans-paille added a comment. Herald added a subscriber: dexonsmith. Another round of review :-) I addressed both the scattering of `warnOnReservedIdentifier` and the code split between `Decl.cpp` and `IdentifierInfo.cpp`. CHANGES SI

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:1097 + // ignored values) that we don't warn on it. + if (Name.size() <= 1) +return ReservedIdentifierStatus::NotReserved; rsmith wrote: > Would it make sense to move the rest of th

[PATCH] D99663: [clang-cl] [Sema] Do not prefer integral conversion over floating-to-integral for MS compatibility 19.28 and higher.

curdeius created this revision. curdeius added reviewers: mstorsjo, thakis, phosek. Herald added a subscriber: dexonsmith. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As of MSVC 19.28 (2019 Update 8), integral conversion is no

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. In D83660#2661369 , @martong wrote: >> BTW, I was obstructed by the z3 requirement in the regression test case when >> I tried to understand your test case. Even though I set the variables >> LLVM_Z3_INSTALL_DIR and LLVM_ENAB

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

njames93 added a comment. Is it not wise to also check the c standard library. So check for function refs to these names in the global or std namespace. `printf`, `vprintf`, `puts`, `putchar`, `scanf`, `scanf`, `getchar` and `gets` It may be a bit of a pain checking for usages of `stdin` and `std

[PATCH] D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing

Anastasia added a comment. This approach is really great because the testing is so quick! While it is not providing the coverage for invocation through clang, it can still be very valuable in various forms to enhance the testing and improve the coverage at very little cost. Thanks for working o

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added a comment. In D99320#2661285 , @asb wrote: > Can I just check the reasoning on the naming? I see that the bitmanip 0.93 > spec proposes `_{rv,rv32,rv64}_{opname}` intrinsics. Does the > `__builtin__{riscv,riscv32,riscv64}_opname` forma

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION ${CMAKE_INSTAL

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

ldionne added a subscriber: phosek. ldionne added a comment. I am generally OK with the libcxx and libcxxabi changes. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/

[PATCH] D99456: [C++2b] Support size_t literals

Quuxplusone added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8) AntonBikineev wrote: > AntonBikine

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

  1   2   >