[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

2021-03-30 Thread LevyHsu via Phabricator via cfe-commits
LevyHsu updated this revision to Diff 334332. LevyHsu added a comment. 1. clang/lib/Headers/riscv_zbr_intrin.h - Fix coding style issues - Added error messages to alert user not include this headfile directly. 2. clang/lib/Headers/rvintrin.h - Fix coding style issues. Repository: rG LLVM

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

2021-03-30 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

2021-03-30 Thread Jim Lin via Phabricator via cfe-commits
Jim added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:28 +TARGET_BUILTIN(__builtin_riscv_crc32_d, "LiLi", "nc", "experimental-zbr") +TARGET_BUILTIN(__builtin_riscv_crc32c_d, "LiLi", "nc", "experimental-zbr") + I don't know why it does

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

2021-03-30 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

2021-03-30 Thread Ben Shi via Phabricator via cfe-commits
benshi001 marked 3 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + benshi001 wrote: > Anastasia wrote: > > If you are only checking the diagnostics

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

2021-03-30 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:28 +TARGET_BUILTIN(__builtin_riscv_crc32_d, "LiLi", "nc", "experimental-zbr") +TARGET_BUILTIN(__builtin_riscv_crc32c_d, "LiLi", "nc", "experimental-zbr") + Jim wrote: > I

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

2021-03-30 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 334336. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

2021-03-30 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui updated this revision to Diff 334338. kamleshbhalui added a comment. Marked failed tests as unsupported on windows system Because now clang emits native path for DIFile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https:/

LLVM buildmaster will be restarted soon

2021-03-30 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 32ca5a0 - [RISCV] Refine pre-define macro tests

2021-03-30 Thread Jim Lin via cfe-commits
Author: Jim Lin Date: 2021-03-31T14:06:20+08:00 New Revision: 32ca5a037ab9191d570bf9b5e0f13e28c3db27d9 URL: https://github.com/llvm/llvm-project/commit/32ca5a037ab9191d570bf9b5e0f13e28c3db27d9 DIFF: https://github.com/llvm/llvm-project/commit/32ca5a037ab9191d570bf9b5e0f13e28c3db27d9.diff LOG:

[PATCH] D99631: [RISCV] Refine pre-define macro tests

2021-03-30 Thread Jim Lin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG32ca5a037ab9: [RISCV] Refine pre-define macro tests (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99631/new/ https://reviews.llvm.org/D99

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

2021-03-30 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui updated this revision to Diff 334356. kamleshbhalui added a comment. clang formatting the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp cl

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

2021-03-30 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui updated this revision to Diff 334359. kamleshbhalui added a comment. updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeG

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

2021-03-30 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I think this looks good to me. Anyone else have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.llvm.org/D99009 ___ cfe-commits mailin

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

2021-03-30 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I think this looks good to me. Anyone else have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99320/new/ https://reviews.llvm.org/D99320 ___ cfe-commits mailin

<    1   2   3