[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

bkramer created this revision. bkramer added reviewers: rupprecht, rjmccall, rsmith. bkramer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This looks like an oversight from a875721d8a2d

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98980/new/ https://reviews.llvm.org/D98980

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

bkramer added a comment. Landing this as it's a pretty bad crasher. Feel free to point out all my mistakes in post-commit review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98980/new/ https://reviews.llvm.org/D98980 _

[clang] 19d2c65 - [CodeGen] Don't crash on for loops with cond variables and no increment

Author: Benjamin Kramer Date: 2021-03-19T20:43:52+01:00 New Revision: 19d2c65ddd757997785163709800f837857f686d URL: https://github.com/llvm/llvm-project/commit/19d2c65ddd757997785163709800f837857f686d DIFF: https://github.com/llvm/llvm-project/commit/19d2c65ddd757997785163709800f837857f686d.dif

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19d2c65ddd75: [CodeGen] Don't crash on for loops with cond variables and no increment (authored by bkramer). Repository: rG LLVM Github Monorepo

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331984. arnamoy10 added a comment. Addressing reviewers' comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp fl

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

rjmccall added a comment. Yes, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98980/new/ https://reviews.llvm.org/D98980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:298 + driverPath.append("/../include/flang/"); + return driverPath.str().str(); +} awarzynski wrote: > Given this [[ > https://github.com/llvm/llvm-project/blob/987ee6e3cc1f

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

Quuxplusone marked 2 inline comments as done. Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks for seeing this through CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable.

bkramer added a comment. Invalid IR generation should be addressed by 19d2c65ddd757997785163709800f837857f686d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98816/new/ https://

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2611142 , @probinson wrote: > In D97411#2598625 , @akhuang wrote: > >> I started looking into some diffs of debug info in libc++ tests, but it's >> pretty hard to tell what's diff

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:390-391 + +if (!TM.getTargetTriple().isArch64Bit()) + return false; + lebedev.ri wrote: > gulfem wrote: > > lebedev.ri wrote: > > > 1. But all tests are using `x86_64` tri

[PATCH] D94355: [Passes] Add relative lookup table converter pass

lebedev.ri accepted this revision. lebedev.ri added a comment. Thank you! Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:390-391 + +if (!TM.getTargetTriple().isArch64Bit()) + return false; + gulfem wrote: > lebedev.ri wrote: > > gulfem wrote: > >

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

NoQ accepted this revision. NoQ added a comment. Aha ok, seems reasonable, thx! Comment at: clang/test/Analysis/PR49642.c:1 +// RUN: %clang --analyze -Xclang -analyzer-checker=core %s + Why not the usual `%clang_analyze_cc1`? Your approach only adds driver test

[clang] 4c2da86 - [Driver] Suppress GCC detection under -B

Author: Fangrui Song Date: 2021-03-19T15:42:18-07:00 New Revision: 4c2da8641087f7b734337a6e6306329cd2535d60 URL: https://github.com/llvm/llvm-project/commit/4c2da8641087f7b734337a6e6306329cd2535d60 DIFF: https://github.com/llvm/llvm-project/commit/4c2da8641087f7b734337a6e6306329cd2535d60.diff

[PATCH] D97993: [Driver] Suppress GCC detection under -B

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c2da8641087: [Driver] Suppress GCC detection under -B (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.

[clang] 94a793f - [docs] Improve documentation of -B and --gcc-toolchain

Author: Fangrui Song Date: 2021-03-19T15:42:37-07:00 New Revision: 94a793f096653fa3536f39c6c1b9e3281907619f URL: https://github.com/llvm/llvm-project/commit/94a793f096653fa3536f39c6c1b9e3281907619f DIFF: https://github.com/llvm/llvm-project/commit/94a793f096653fa3536f39c6c1b9e3281907619f.diff

[PATCH] D97902: [docs] Improve documentation of -B and --gcc-toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG94a793f09665: [docs] Improve documentation of -B and --gcc-toolchain (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https:/

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

MaskRay added a comment. The recommended named parameter form is probably `/*Param=*/something`. It is liked by both https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html and clang-format. Another form look to me as well, if both the two tools like it. Repository: rG

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2638609 , @akhuang wrote: > In D97411#2611142 , @probinson wrote: > >> In D97411#2598625 , @akhuang wrote: >> >>> I started looking into s

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added subscribers: lanza, smeenai. smeenai added a comment. With NDK r22, I only see libunwind.a for armv7. Will it be provided for other architectures in future NDK versions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96403/new/ https:

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > Does this need to be down h

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

rprichard added a comment. In D96403#2638883 , @smeenai wrote: > With NDK r22, I only see libunwind.a for armv7. Will it be provided for other > architectures in future NDK versions? NDK r23 should have a libunwind.a for all architectures. This change is

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

MaskRay added a comment. Should `-cuid=` be `--cuid=`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https://reviews.llvm.org/D95007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1006-1007 MarshallingInfoString>; +def module_dir : Separate<["-"], "module-dir">, + Flags<[FlangOption,FC1Option]>, HelpText<"Add to the list of directories to be searched by an USE statement">

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3102 +// C++20 [class.copy.elision]p3: +// ...either a non-volatile object or an rvalue reference to a non-volatile object type... +if (!(CESK & CES_AllowRValueReferenceType)) ---

[clang] f9cac39 - [Driver] Delete compatibility aliases -mpie-copy-relocations and -mno-pie-copy-relocations

Author: Fangrui Song Date: 2021-03-19T17:47:30-07:00 New Revision: f9cac39930c8ae13892f8daa8662e4ec65439f22 URL: https://github.com/llvm/llvm-project/commit/f9cac39930c8ae13892f8daa8662e4ec65439f22 DIFF: https://github.com/llvm/llvm-project/commit/f9cac39930c8ae13892f8daa8662e4ec65439f22.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie wrote: > > > > > Does t

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > hoy wrote: > > > > > dblaik

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

Quuxplusone marked 3 inline comments as done. Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie wrote: > > > > > hoy wr

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn added a comment. This is something I have been doing for over 20 years now. Not sure when I initially picked it up but I find a space before the ;'s in a C for loop improves readability. It more clearly differentiates the different parts. I beleive the space before the colon in C++ range

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->is

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added a comment. In D96403#2638932 , @rprichard wrote: > In D96403#2638883 , @smeenai wrote: > >> With NDK r22, I only see libunwind.a for armv7. Will it be provided for >> other architectures in future NDK

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

srhines added a comment. In D96403#2639137 , @smeenai wrote: > In D96403#2638932 , @rprichard wrote: > >> In D96403#2638883 , @smeenai wrote: >> >>> With NDK r22, I only see

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > hoy wrote: > > > > > dblaik

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

srhines added a comment. In D96403#2639180 , @srhines wrote: > In D96403#2639137 , @smeenai wrote: > >> In D96403#2638932 , @rprichard >> wrote: >> >>> In D96403#2638883

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov created this revision. Herald added subscribers: jansvoboda11, dexonsmith, lxfind, dang. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WIP, not yet ready for review. Small sample of things wrong with this patch: - Have

[clang] 28d58d8 - [Driver] Stop searching other prefixes once a GCC installation is found in one prefix

Author: Fangrui Song Date: 2021-03-19T20:35:59-07:00 New Revision: 28d58d8fe2094af6902dee7b4d68ec30a3e9d737 URL: https://github.com/llvm/llvm-project/commit/28d58d8fe2094af6902dee7b4d68ec30a3e9d737 DIFF: https://github.com/llvm/llvm-project/commit/28d58d8fe2094af6902dee7b4d68ec30a3e9d737.diff

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D97916#2625170 , @luismarques wrote: > This patch seems to be in pretty good shape now. > > One thing that might be useful (important?) t

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1754 + + int RC = llvm::sys::ExecuteAndWait(GCCPath, GCCArgs, None, Redirects); + Even if ExecuteAndWait is accepted, you may consider a pipe. The current implementation leaves tempo

[PATCH] D98783: [CUDA][HIP] Remove unused addr space casts

yaxunl added a comment. In D98783#2633261 , @tra wrote: > In D98783#2632244 , @yaxunl wrote: > >> In D98783#2632143 , @tra wrote: >> >>> Shouldn't the unused ASCs be eliminat

[PATCH] D99008: [RISCV] Add intrinsic for Zbr extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, evandro, kito-cheng, khchen. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99008: [RISCV] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 332076. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99008/new/ https://reviews.llvm.org/D99008 Files:

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, kito-cheng, evandro, khchen. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[clang] 1f4959b - [Driver] Drop unneeded $triple/gcc/$triple detection

Author: Fangrui Song Date: 2021-03-19T22:45:50-07:00 New Revision: 1f4959b27607d4748c83820ffcf8bf24f09fdd47 URL: https://github.com/llvm/llvm-project/commit/1f4959b27607d4748c83820ffcf8bf24f09fdd47 DIFF: https://github.com/llvm/llvm-project/commit/1f4959b27607d4748c83820ffcf8bf24f09fdd47.diff

[clang] a6a15dd - [Driver] Delete toplevel i386-gnu/gcc detection in favor of i386-gnu alias triple detection

Author: Fangrui Song Date: 2021-03-19T22:50:36-07:00 New Revision: a6a15dde5a870f0ce6be0ea26d36cec60e846a2d URL: https://github.com/llvm/llvm-project/commit/a6a15dde5a870f0ce6be0ea26d36cec60e846a2d DIFF: https://github.com/llvm/llvm-project/commit/a6a15dde5a870f0ce6be0ea26d36cec60e846a2d.diff

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

vsavchenko added inline comments. Comment at: clang/test/Analysis/PR49642.c:1 +// RUN: %clang --analyze -Xclang -analyzer-checker=core %s + NoQ wrote: > Why not the usual `%clang_analyze_cc1`? Your approach only adds driver > testing which doesn't seem to test a

[clang] bdf39e6 - [Driver] Drop obsoleted Ubuntu 11.04 gcc detection

Author: Fangrui Song Date: 2021-03-19T23:23:28-07:00 New Revision: bdf39e6b0ed4b41a1842ac0193f30a726f8d9f63 URL: https://github.com/llvm/llvm-project/commit/bdf39e6b0ed4b41a1842ac0193f30a726f8d9f63 DIFF: https://github.com/llvm/llvm-project/commit/bdf39e6b0ed4b41a1842ac0193f30a726f8d9f63.diff

[clang] b98ad2a - Title: Remove a redundant parameter in clang/unittests/AST/CMakeLists.txt Reviewed by: MaskRay Differential Revision: https://reviews.llvm.org/D98922

Author: joker881 Date: 2021-03-20T14:39:05+08:00 New Revision: b98ad2ac0845835b1d58faf6881b688e3e186b84 URL: https://github.com/llvm/llvm-project/commit/b98ad2ac0845835b1d58faf6881b688e3e186b84 DIFF: https://github.com/llvm/llvm-project/commit/b98ad2ac0845835b1d58faf6881b688e3e186b84.diff LOG:

[clang] bed9933 - [Driver][test] Fix gcc-toolchain.cpp on non-x86_64

Author: Fangrui Song Date: 2021-03-19T23:50:22-07:00 New Revision: bed9933a461e7b3d0c8c5a8fa770aa1b49802660 URL: https://github.com/llvm/llvm-project/commit/bed9933a461e7b3d0c8c5a8fa770aa1b49802660 DIFF: https://github.com/llvm/llvm-project/commit/bed9933a461e7b3d0c8c5a8fa770aa1b49802660.diff

<    1   2