[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D98539#2623038 , @thakis wrote: > Can we get this landed asap please? Done! Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

2021-03-12 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 330344. akhuang added a comment. add allowInC to attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

2021-03-12 Thread Amilendra Kodithuwakku via Phabricator via cfe-commits
amilendra updated this revision to Diff 330345. amilendra added a comment. Add a newline before the sub-list to fix a rendering issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 Files: clang/docs/Rel

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

2021-03-12 Thread Amilendra Kodithuwakku via Phabricator via cfe-commits
amilendra requested review of this revision. amilendra added a comment. Sorry for the back-and-forth. Requesting re-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 __

[clang] d7cd208 - [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

2021-03-12 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2021-03-12T12:30:01-08:00 New Revision: d7cd208f08afca450484be97604a55704a628e88 URL: https://github.com/llvm/llvm-project/commit/d7cd208f08afca450484be97604a55704a628e88 DIFF: https://github.com/llvm/llvm-project/commit/d7cd208f08afca450484be97604a55704a628e88.diff LOG

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

2021-03-12 Thread Amy Huang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cd208f08af: [DebugInfo] Add an attribute to force type info to be emitted for types that… (authored by akhuang). Repository: rG LLVM Github Mono

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D89909#2617194 , @bader wrote: > In D89909#2606180 , @Anastasia wrote: > >> In D89909#2600859 , @aaron.ballman >> wrote: >> >>> Just a few mino

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

2021-03-12 Thread Ta-Wei Tu via Phabricator via cfe-commits
TaWeiTu created this revision. TaWeiTu added reviewers: tmatheson, rsmith, dnsampaio. TaWeiTu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=49534, where the call to the constructor of the

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

2021-03-12 Thread Ta-Wei Tu via Phabricator via cfe-commits
TaWeiTu added a comment. I'm not familiar with this code and clang/sema in general, so not sure if the fix makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98548/new/ https://reviews.llvm.org/D98548 _

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

2021-03-12 Thread Kristof Beyls via Phabricator via cfe-commits
kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 _

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D97058#2623160 , @thakis wrote: > I'm going to revert this in 30 minutes. The tree has been red for 12h due to > this then. I have committed the fix mentioned above. Apology for the delay. Repository: rG LLVM Github Mono

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D89909#2623211 , @Anastasia wrote: > In D89909#2617194 , @bader wrote: > >> @Anastasia, do you suggest we copy >> https://github.com/intel/llvm/blob/sycl/sycl/doc/CompilerAndRuntim

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

2021-03-12 Thread Amilendra Kodithuwakku via Phabricator via cfe-commits
amilendra closed this revision. amilendra added a comment. Commited the fix to LLVM Release 12.x branch. Rendering looks okay this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 _

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

2021-03-12 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. I'm missing tests with both EmptyLineBeforeAccessModifier and EmptyLine(s)AfterAccessModifier options. And possibly other options that could interfere with them. Comment at: clang/include/clang/Format/Format.h:1957 + /// Defines how many lines are pu

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

2021-03-12 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 330352. jhuber6 added a comment. Herald added a subscriber: ormris. Changed the RTL to have an argument that indicates if there is only one active caller for a team. This makes it easier to optimize. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L created this revision. Xiangling_L added reviewers: rzurob, hubert.reinterpretcast, jsji, lei, cebowleratibm. Herald added a subscriber: dexonsmith. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we deli

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. If we use this workaround, can we also revert 561fb7f60ab631e712c3fb6bbeb47061222c6818 and 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:25 #include "llvm/ADT/None.h" +// Add this header as a workaround to unblock the XL build compiler issue. +#include "llvm/ADT/SmallVector.h" Is there a better comment? "unblock the XL bu

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added a comment. In D98552#2623399 , @jsji wrote: > If we use this workaround, can we also revert > 561fb7f60ab631e712c3fb6bbeb47061222c6818 > and > 8dc70bdcd0fe4efb65876d

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

2021-03-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted because

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:25 #include "llvm/ADT/None.h" +// Add this header as a workaround to unblock the XL build compiler issue. +#include "llvm/ADT/SmallVector.h"

[PATCH] D98554: Save strings for CC_PRINT env vars

2021-03-12 Thread Sean via Phabricator via cfe-commits
SeanP created this revision. SeanP added reviewers: hubert.reinterpretcast, uweigand, Kai. SeanP requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The contents of the string returned by getenv() is not guaranteed across calls to getenv(). T

[PATCH] D98556: [ASTMatchers][Dynamic] Add missing matchers from Registry

2021-03-12 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the `fixedPointLiteral`, `hasAnyBody` and `templateArgumentLoc` to the dynamic matcher

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 330369. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Herald added a subscriber: jansvoboda11. Addressed the comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ h

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks @Xiangling_L and also to the other reviewers for the great comments. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

2021-03-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. @tstellar :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

2021-03-12 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev updated this revision to Diff 330381. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments -- rename test file; add a logging diagnostic consumer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D960

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

2021-03-12 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:93 + "Initialization failed. " + "Unable to create diagnostics engine"); + sgraenitz wrote: > It looks like `

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:71 using llvm::SmallString; - using llvm::SmallVector; - using llvm::SmallVectorImpl; It's my bad to not wait for a build finished before updating the patch, I saw a lot of buil

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

2021-03-12 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted because it would invoke a deleted " "comparison function%select{| for member %2| f

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

2021-03-12 Thread Arlo Siemsen via Phabricator via cfe-commits
arlosi updated this revision to Diff 330386. arlosi marked an inline comment as done. arlosi added a comment. Use automatic marshaling for command line arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

2021-03-12 Thread Stefan Gränitz via Phabricator via cfe-commits
sgraenitz accepted this revision. sgraenitz added a comment. Thanks. From my side this looks good now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] c9fd92d - [clang] Improve diagnostics on implicitly deleted defaulted comparisons

2021-03-12 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2021-03-13T01:13:52+01:00 New Revision: c9fd92d573988c59b7a613f07909596cdad36095 URL: https://github.com/llvm/llvm-project/commit/c9fd92d573988c59b7a613f07909596cdad36095 DIFF: https://github.com/llvm/llvm-project/commit/c9fd92d573988c59b7a613f07909596cdad36095.dif

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

2021-03-12 Thread Matheus Izvekov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc9fd92d57398: [clang] Improve diagnostics on implicitly deleted defaulted comparisons (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

2021-03-12 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98546/new/ https://reviews.llvm.org/D98546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] d4a8c73 - [clang] Fix ICE on invalid type parameters for concepts

2021-03-12 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2021-03-13T01:23:02+01:00 New Revision: d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a URL: https://github.com/llvm/llvm-project/commit/d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a DIFF: https://github.com/llvm/llvm-project/commit/d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a.dif

[PATCH] D98095: [clang] Fix ICE on invalid type parameters for concepts

2021-03-12 Thread Matheus Izvekov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd4a8c7359b57: [clang] Fix ICE on invalid type parameters for concepts (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98095/new/ https

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

2021-03-12 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 330399. ggeorgakoudis added a comment. NFC change in update_llc_test_checks for compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/

[clang] 5eaf70a - Replace func name with regex for update test scripts

2021-03-12 Thread Giorgis Georgakoudis via cfe-commits
Author: Giorgis Georgakoudis Date: 2021-03-12T17:00:42-08:00 New Revision: 5eaf70afb5f8ae6789587e60d51c60f56caf18b0 URL: https://github.com/llvm/llvm-project/commit/5eaf70afb5f8ae6789587e60d51c60f56caf18b0 DIFF: https://github.com/llvm/llvm-project/commit/5eaf70afb5f8ae6789587e60d51c60f56caf18b

[PATCH] D97107: Replace func name with regex for update test scripts

2021-03-12 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf70afb5f8: Replace func name with regex for update test scripts (authored by ggeorgakoudis). Changed prior to commit: https://reviews.llvm.org/

[clang] 9f9a4df - Revert "Replace func name with regex for update test scripts"

2021-03-12 Thread Giorgis Georgakoudis via cfe-commits
Author: Giorgis Georgakoudis Date: 2021-03-12T17:20:00-08:00 New Revision: 9f9a4dfda7348eddbc840ae558e7082677c3bab6 URL: https://github.com/llvm/llvm-project/commit/9f9a4dfda7348eddbc840ae558e7082677c3bab6 DIFF: https://github.com/llvm/llvm-project/commit/9f9a4dfda7348eddbc840ae558e7082677c3bab

[PATCH] D94355: [Passes] Add relative lookup table converter pass

2021-03-12 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem updated this revision to Diff 330405. gulfem added a comment. 1. Used IsConstantOffsetFromGlobal() function 2. Added this pass to the end of legacy pass manager pipeline 3. Moved all the tests under a new test directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D97107: Replace func name with regex for update test scripts

2021-03-12 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 330407. ggeorgakoudis added a comment. Fix for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/utils/update_cc_test_checks/Inputs/

[PATCH] D97107: Replace func name with regex for update test scripts

2021-03-12 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ce846be04f8: Replace func name with regex for update test scripts (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 1ce846b - Replace func name with regex for update test scripts

2021-03-12 Thread Giorgis Georgakoudis via cfe-commits
Author: Giorgis Georgakoudis Date: 2021-03-12T17:37:09-08:00 New Revision: 1ce846be04f8ce7f899e37424772c0bef1851f76 URL: https://github.com/llvm/llvm-project/commit/1ce846be04f8ce7f899e37424772c0bef1851f76 DIFF: https://github.com/llvm/llvm-project/commit/1ce846be04f8ce7f899e37424772c0bef1851f7

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D89909#2623250 , @aaron.ballman wrote: > In D89909#2623211 , @Anastasia wrote: > >> In D89909#2617194 , @bader wrote: >> >>> @Anastasia, do you

[PATCH] D94355: [Passes] Add relative lookup table converter pass

2021-03-12 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem marked 7 inline comments as done. gulfem added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:384 + bool shouldBuildRelLookupTables() { +const TargetMachine &TM = getTLI()->getTargetMachine(); leonardchan wrote: > Sorry, I thi

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

2021-03-12 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary so we can run Polly tests in 2 s

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

2021-03-12 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98572/new/ https://reviews.llvm.org/D98572 _

[clang] 75cdeff - [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

2021-03-12 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2021-03-12T18:31:20-08:00 New Revision: 75cdeff43b2b83baf643ccfd318f6669844fe370 URL: https://github.com/llvm/llvm-project/commit/75cdeff43b2b83baf643ccfd318f6669844fe370 DIFF: https://github.com/llvm/llvm-project/commit/75cdeff43b2b83baf643ccfd318f6669844fe370.diff LO

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

2021-03-12 Thread Petr Hosek via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75cdeff43b2b: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D98134: [RFC] Introduce callback argument encoding mode into callback metadata

2021-03-12 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 330414. tianshilei1992 added a comment. add the support for stacked mode in `AbstractCallSite::getCallArgOperand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

2021-03-12 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. We probably don't need the index for `size_t size`. If the `ArgNo` is out of range, we simply return `nullptr`. Besides, CUDA function `cudaLaunchKernel` doesn't have an argument for size as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

2021-03-12 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: llvm/lib/IR/AbstractCallSite.cpp:209 + +if (!GEP || !GEP->hasOneUse()) + return nullptr; If we don't use have a size, `GEP` will be `nullptr` here, and we can just return it. Repository: rG LLVM Gith

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 330415. Xiangling_L added a comment. Bring back two forward declarations to avoid changing pervasive `SmallVector` to `llvm::SmallVector` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 Files: clang/i

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

2021-03-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > There are also going to be binaries in our system build that don't use foo.h > and ideally shouldn't have any overhead since nothing inside them is > instrumented (they should behave as if -fprofile-instr-generate wasn't set > for them at all). That's not the case tod

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Retained `using` declarations look fine. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 ___ cfe-commits mai

[clang] 0bf2da5 - [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread via cfe-commits
Author: xling-Liao Date: 2021-03-12T21:41:36-06:00 New Revision: 0bf2da53c12b3d2bf213f667af74059280a0d661 URL: https://github.com/llvm/llvm-project/commit/0bf2da53c12b3d2bf213f667af74059280a0d661 DIFF: https://github.com/llvm/llvm-project/commit/0bf2da53c12b3d2bf213f667af74059280a0d661.diff LO

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

2021-03-12 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf2da53c12b: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue (authored by xling-Liao ). Repository

[PATCH] D98554: Save strings for CC_PRINT env vars

2021-03-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Driver/Driver.h:160 /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled. - const char *CCPrintStatReportFilename; + std::string CCPrintStatReportFilename; I'm seein

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-03-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; qiucf wrote: > hubert.reinterpretcast wrote: > > qi

[PATCH] D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

2021-03-12 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Hmm this probably even deserves a warning? Like, the mutex goes out of scope but we don't know whether we've successfully destroyed it? Even if we perform the check later, we can't do anything about

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-03-12 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD updated this revision to Diff 330422. RedDocMD added a comment. Removed an embarassingly dumb mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/Smar

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-03-12 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD added a comment. @NoQ, sorry for the absurdly dumb mistake. Not entirely sure what I was thinking. Can you please have a look at it now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___

LLVM build master will be restarted soon

2021-03-12 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-03-12 Thread Jonathan Wakely via Phabricator via cfe-commits
jwakely added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > > hubert.reinterpre

<    1   2