[PATCH] D97119: [flang][driver] Add options for -std=2018

arnamoy10 updated this revision to Diff 326760. arnamoy10 added a comment. 1. Updated the test case to include a check when the option is not given and make sure works with f18 as well (with `Mstandard`) 2. Changed variable names as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:66 +// element type which is bool +// 0: void type, ignores "t" +// z: size_t, ignores "t" craig.topper wrote: > jrtc27 wrote: > > khchen wrote: > > > jrtc27 wrote: > > >

[PATCH] D97447: Add GNU attribute 'retain'

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with a minor doc tweak My reading of the discussion is that this is ready, but please wait for others if you are aware of any outstanding concerns. Comment at: clang/include

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 326762. varungandhi-apple added a comment. Added checks for C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 Files: clang/lib/CodeGen/CGCall.cpp clang

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:66 +// element type which is bool +// 0: void type, ignores "t" +// z: size_t, ignores "t" jrtc27 wrote: > craig.topper wrote: > > jrtc27 wrote: > > > khchen wrote:

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 326766. MaskRay added a comment. Improve doc as rnk suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97447/new/ https://reviews.llvm.org/D97447 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking added a comment. So with this patch, I tried to imitate the existing code as much as possible. However, I think it would be quite a bit better to use the `write_basic_package_version_file` command from `CMakePackageConfigHelpers`. It gained support for major + minor version compati

[PATCH] D97534: SEH: capture 'this'

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97534/new/ https://reviews.llvm.org/D97534 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao created this revision. pmrao added reviewers: ABataev, bader, erichkeane, jdoerfert. Herald added subscribers: guansong, yaxunl. pmrao requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Ensure that we are in a function declaration context b

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. Thanks! I am still curious about the forward declare/redeclaration behavior and whether that is a situation that makes sense or not. I suspect this case may make sense (and likely already works): // Should test redeclaration behavior. struct [[clang::standalon

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc added a comment. In D96744#2564828 , @MyDeveloperDay wrote: > Does this need to be an option? It's easy to add an option, but there are already two //main include//-related options, so before adding a third I wanted to give this some thought. A

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, jasonliu. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding it to the general filepaths results in it being added to the linker argume

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

ldionne added a comment. In D97411#2588181 , @akhuang wrote: > @ldionne Do you think it'd be reasonable to add this debug info attribute to > some types in libc++? (For types that have constructors but don't call them; > some previous discussion in https

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 updated this revision to Diff 326779. njames93 marked 6 inline comments as done. njames93 added a comment. Rebased and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files: clan

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2591030 , @aaron.ballman wrote: > Thanks! I am still curious about the forward declare/redeclaration behavior > and whether that is a situation that makes sense or not. I suspect this case > may make sense (and likely

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2591030 , @aaron.ballman wrote: > Thanks! I am still curious about the forward declare/redeclaration behavior > and whether that is a situation that makes sense or not. I suspect this case > may make sense (and likely

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326787. akhuang marked 3 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx created this revision. flx added reviewers: aaron.ballman, alexfh, sbenza. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This disables the check for false positive cases where implicit type co

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx updated this revision to Diff 326792. flx added a comment. Remove include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 Files: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp clang

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx updated this revision to Diff 326793. flx added a comment. Remove include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 Files: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp clang

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. In D94973#2590867 , @jdenny wrote: > One property of this patch that has bothered me is that OMPCanonicalLoop is > not a loop. Instead, it's an AST node that is sandwiched between a directive > and a loop to contain extra inf

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 326797. ychen added a comment. - Simplify MCContext changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/lib/CodeGen/CodeGenAction.cpp lldb/source/Ex

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx updated this revision to Diff 326798. flx added a comment. Add tests for PerformanceUnnecssaryCopyInitialization check which actually uses decl_ref_expr::isOnlyUsedAsConst(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://revi

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. In D96120#2590587 , @russell.gallop wrote: > Hi @mstorsjo. Thanks for the suggestions. I tried running up an mingw > environment with msys but had trouble getting it working (running into cmake > issues). Would you be able to h

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

vitalybuka added a comment. >> This is intended as a step to porting scudo standalone. Why this is needed for scudo stadalone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96120/new/ https://reviews.llvm.org/D96120 __

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau updated this revision to Diff 326816. qchateau added a comment. - [clangd] make more compile commands compatible - [clangd] ignore incompatible preamble I improved command line compatibility detection (faster & matches more files) and I had to blacklist some preambles. Namely, when th

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. In D94973#2591210 , @Meinersbur wrote: > In D94973#2590867 , @jdenny wrote: > >> One property of this patch that has bothered me is that OMPCanonicalLoop is >> not a loop. Instead, it's an

[clang] 4a8530f - [clang] implicitly delete space ship operator with function pointers

Author: Matheus Izvekov Date: 2021-02-26T16:03:01-08:00 New Revision: 4a8530fc3039f128eddc38737f0172bb3d489bcf URL: https://github.com/llvm/llvm-project/commit/4a8530fc3039f128eddc38737f0172bb3d489bcf DIFF: https://github.com/llvm/llvm-project/commit/4a8530fc3039f128eddc38737f0172bb3d489bcf.dif

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8530fc3039: [clang] implicitly delete space ship operator with function pointers (authored by mizvekov, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 155c49e - [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

Author: Vladimir Vereschaka Date: 2021-02-26T16:16:00-08:00 New Revision: 155c49e0878de667b8021b9ba685390151dee11e URL: https://github.com/llvm/llvm-project/commit/155c49e0878de667b8021b9ba685390151dee11e DIFF: https://github.com/llvm/llvm-project/commit/155c49e0878de667b8021b9ba685390151dee11e

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG155c49e0878d: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 233ba27 - [Driver] Fix a warning about the the initialization order

Author: Kazu Hirata Date: 2021-02-26T16:32:30-08:00 New Revision: 233ba2709bde54ea820cdaba0405d46b2c197e01 URL: https://github.com/llvm/llvm-project/commit/233ba2709bde54ea820cdaba0405d46b2c197e01 DIFF: https://github.com/llvm/llvm-project/commit/233ba2709bde54ea820cdaba0405d46b2c197e01.diff L

[clang] 8afdacb - Add GNU attribute 'retain'

Author: Fangrui Song Date: 2021-02-26T16:37:50-08:00 New Revision: 8afdacba9dcd36fc838eb86fca86f7f903040030 URL: https://github.com/llvm/llvm-project/commit/8afdacba9dcd36fc838eb86fca86f7f903040030 DIFF: https://github.com/llvm/llvm-project/commit/8afdacba9dcd36fc838eb86fca86f7f903040030.diff

[PATCH] D97447: Add GNU attribute 'retain'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8afdacba9dcd: Add GNU attribute 'retain' (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D97447?vs=326766&id=326839#toc

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2567710 , @nand wrote: > CodePtr points into the bytecode emitted by the byte code compiler. In some > instances, pointers to auxiliary data structures are embedded into the byte > code, such as functions or AST nodes wh

[clang] a0c1cd6 - [test] Add -triple x86_64 to attr-retain.c

Author: Fangrui Song Date: 2021-02-26T17:26:26-08:00 New Revision: a0c1cd642da51ab8f471d2dd5ba905cf81760187 URL: https://github.com/llvm/llvm-project/commit/a0c1cd642da51ab8f471d2dd5ba905cf81760187 DIFF: https://github.com/llvm/llvm-project/commit/a0c1cd642da51ab8f471d2dd5ba905cf81760187.diff

[clang] 9e0d550 - [clang][NFC] Clean up whitespace in ClangOpcodesEmitter output

Author: Jessica Clarke Date: 2021-02-27T01:28:56Z New Revision: 9e0d55024d4ed776f209ee04e260bdd314854993 URL: https://github.com/llvm/llvm-project/commit/9e0d55024d4ed776f209ee04e260bdd314854993 DIFF: https://github.com/llvm/llvm-project/commit/9e0d55024d4ed776f209ee04e260bdd314854993.diff LOG

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2591732 , @jrtc27 wrote: > In D64146#2567710 , @nand wrote: > >> CodePtr points into the bytecode emitted by the byte code compiler. In some >> instances, pointers to auxiliary dat

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

nickdesaulniers added a comment. I tested this on some wacko LTO kernel build failure (https://github.com/ClangBuiltLinux/linux/issues/1269). The error message went from: > :0: error: __ia32_compat_sys_sysctl changed binding to STB_GLOBAL To: unimplemented UNREACHABLE executed at ../incl

[PATCH] D97605: [Lifetimes] Fix false positive warning from BUG 49342

xazax.hun created this revision. xazax.hun added reviewers: rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun requested review of this revision. Herald added a subscriber: cfe-commits. After some interaction betw

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. I am supportive of getting rid of InlineAsmDiagnosticHandler, too. The updated AMDGPU tests suggeste that previously `MCContext::reportError` may be called with no `SrcMgr` or `InlineSrcMgr`, so the error is propagated to the temporary `SourceMgr()`. The `LLCDiagnosticH

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 created this revision. jrtc27 added reviewers: nand, jfb, Bigcheese, rsmith, dexonsmith. Herald added subscribers: kristof.beyls, arichardson. jrtc27 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang interpreter's bytecode us

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:477 + StringRef Message = D.getMessage(); + if (Message.startswith("error: ")) +Message = Message.substr(7); `StringRef::consume_front` I know you are moving code, but do you kn

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 updated this revision to Diff 326872. jrtc27 added a comment. Reworked code slightly to make it look nicer after clang-format uglified it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97606/new/ https://reviews.llvm.org/D97606 Files: clan

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2591830 , @jrtc27 wrote: > In D64146#2591732 , @jrtc27 wrote: > >> In D64146#2567710 , @nand wrote: >> >>> CodePtr points into the bytecode

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 added a comment. Is there any way I can usefully test this? As far as I can tell there's only a single constexpr test in the tree that uses the new interpreter, and it's pretty trivial? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97606/ne

[clang] 2e2ee43 - [test] Add -triple x86_64 to attr-retain.cpp

Author: Fangrui Song Date: 2021-02-26T19:35:53-08:00 New Revision: 2e2ee4300d1f9766209d435c0d8c44c72092b974 URL: https://github.com/llvm/llvm-project/commit/2e2ee4300d1f9766209d435c0d8c44c72092b974 DIFF: https://github.com/llvm/llvm-project/commit/2e2ee4300d1f9766209d435c0d8c44c72092b974.diff

[PATCH] D97608: Move EntryExitInstrumentation pass location

aeubanks created this revision. Herald added subscribers: nikic, pengfei, hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This seems to be more of a Clang thing rather than a generic LLVM thing, so this

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

aeubanks added a comment. Alternatively: https://reviews.llvm.org/D97608 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96803/new/ https://reviews.llvm.org/D96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

lebedev.ri added a comment. It is best not to change existing tests, but add new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 ___ cfe-commits mailing lis

<    1   2