[clang] 91f8aac - [Android] Use -l:libunwind.a with --rtlib=compiler-rt

Author: Ryan Prichard Date: 2021-02-25T15:40:02-08:00 New Revision: 91f8aacc040f5a458cfc2a10c4039e0028931455 URL: https://github.com/llvm/llvm-project/commit/91f8aacc040f5a458cfc2a10c4039e0028931455 DIFF: https://github.com/llvm/llvm-project/commit/91f8aacc040f5a458cfc2a10c4039e0028931455.diff

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91f8aacc040f: [Android] Use -l:libunwind.a with --rtlib=compiler-rt (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

keith added a comment. No worries! Makes sense, I think this is a good change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97434/new/ https://reviews.llvm.org/D97434 ___ cfe-commits mailing list cfe-com

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

jrtc27 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037 + assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8 && + "Expected at least natural alignment at this point."); Doesn't this introduce another copy of the sam

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

njames93 updated this revision to Diff 326540. njames93 added a comment. Fix up portability-simd-intrinsics diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/ https://reviews.llvm.org/D97488 Files: clang-tools-extra/clang-tidy/

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added a comment. In D97449#2588804 , @rnk wrote: > This still feels a bit messy and I don't totally understand how it all fits > together, but I'm super supportive of getting rid of the inline asm > diagnostic handler and standardizing on Diagnosti

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: llvm/include/llvm/MC/MCContext.h:33 #include "llvm/Support/MD5.h" +#include "llvm/Support/SourceMgr.h" #include "llvm/Support/raw_ostream.h" rnk wrote: > MCContext.h is popular, let's try not to leak SourceMgr.h as an in

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

ilinpv created this revision. ilinpv added reviewers: willlovett, ktkachov. Herald added subscribers: danielkiss, jfb, kristof.beyls. ilinpv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Description for AArch64 -moutline-atomics, -mno-out

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ... unless it's a literal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97512 Files: clang/lib/Se

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

ilinpv updated this revision to Diff 326550. ilinpv added a comment. Fixing typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97510/new/ https://reviews.llvm.org/D97510 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking created this revision. alexreinking added reviewers: chandlerc, gottesmm, pmccormick. Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

njames93 added a comment. In D97491#2588835 , @Eugene.Zelenko wrote: > If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe > just to remove `readability-deleted-default`. Wdefaulted-function-deleted was introduced in 8.0 and I thi

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

Eugene.Zelenko added a comment. In D97491#2589097 , @njames93 wrote: > In D97491#2588835 , @Eugene.Zelenko > wrote: > >> If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe >> just to remove

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Other than the additional comments I've requested, LGTM. Thanks for the explanations and the changes. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::Transf

[clang] c90dac2 - [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

Author: Justin Lebar Date: 2021-02-25T17:45:19-08:00 New Revision: c90dac27e94ec354a3e8919556ac5bc89b62c731 URL: https://github.com/llvm/llvm-project/commit/c90dac27e94ec354a3e8919556ac5bc89b62c731 DIFF: https://github.com/llvm/llvm-project/commit/c90dac27e94ec354a3e8919556ac5bc89b62c731.diff

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc90dac27e94e: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best. (authored by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] e890fff - Fix signed-compare warning.

Author: Justin Lebar Date: 2021-02-25T18:14:40-08:00 New Revision: e890fffcab8b7e95deba4269c14db9fab003a737 URL: https://github.com/llvm/llvm-project/commit/e890fffcab8b7e95deba4269c14db9fab003a737 DIFF: https://github.com/llvm/llvm-project/commit/e890fffcab8b7e95deba4269c14db9fab003a737.diff

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

pengfei added a comment. In D97318#2587866 , @yaxunl wrote: > So should we revive this patch by classifying _Float16 as SSE, then it will > conform to the ABI. And we should be compatible with gcc assuming it also > follows the ABI. @pengfei Thanks @hli

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

darwin added a comment. In D97137#2587075 , @HazardyKnusperkeks wrote: > In D97137#2584417 , @darwin wrote: > >> Hi guys, thanks for accepting the change. But I don't have commit access of >> LLVM. Can someone com

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT updated this revision to Diff 326581. oToToT added a comment. Fix typo and rename function to `createTarget`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97493/new/ https://reviews.llvm.org/D97493 Files: clang/include/clang/Frontend/Com

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT added a comment. Since I don't have commit access currently, might @sammccall commit this for me with `--author="Yu-Hsun Chiang "`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97493/new/ https://reviews.llvm.org/D97493 __

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86376/new/ https://reviews.llvm.org/D86376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. Nice! I suspect you're adding too many notes. The note needs to not be there if the *raw* pointer is not tracked. Eg., I suspect that your patch would add a note in the following case in which it shouldn't be there because the raw pointer value doesn't participate in the r

[clang] 9e56a09 - [Driver] Create -ffile-compilation-dir alias

Author: Petr Hosek Date: 2021-02-25T21:20:10-08:00 New Revision: 9e56a093eeca15704180cce3a808aec195b331d1 URL: https://github.com/llvm/llvm-project/commit/9e56a093eeca15704180cce3a808aec195b331d1 DIFF: https://github.com/llvm/llvm-project/commit/9e56a093eeca15704180cce3a808aec195b331d1.diff LO

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e56a093eeca: [Driver] Create -ffile-compilation-dir alias (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97433/new/ https://reviews.ll

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 326597. ychen added a comment. - Refrain from including SourceMgr.h in MCContext.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/lib/CodeGen/CodeGenActio

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 added a comment. I tried to implement a fix by using the `hasCopyAssignmentWithConstParam()` method (instead of `hasNonTrivialCopyConstructor()`), the same test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://re

[clang] 8459b8e - [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

Author: Petr Hosek Date: 2021-02-25T21:40:12-08:00 New Revision: 8459b8ef39f4d745f2aab8c43821b3389b0e5a74 URL: https://github.com/llvm/llvm-project/commit/8459b8ef39f4d745f2aab8c43821b3389b0e5a74 DIFF: https://github.com/llvm/llvm-project/commit/8459b8ef39f4d745f2aab8c43821b3389b0e5a74.diff LO

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8459b8ef39f4: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix… (authored by phosek). Changed prior to commit: https:

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a driver only flag so it has to be expanded when invoking cc1. Repository: rG LLVM Github Monorepo https://r

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

phosek updated this revision to Diff 326601. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97528/new/ https://reviews.llvm.org/D97528 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c Index: clang/test/Driver/clang_

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97528/new/ https://reviews.llvm.org/D97528 __

[clang] bf6380c - [Driver] Don't pass -ffile-compilation-dir through to cc1

Author: Petr Hosek Date: 2021-02-25T23:03:54-08:00 New Revision: bf6380c0966b26a2aec7f2072efd0a1a9b6328f2 URL: https://github.com/llvm/llvm-project/commit/bf6380c0966b26a2aec7f2072efd0a1a9b6328f2 DIFF: https://github.com/llvm/llvm-project/commit/bf6380c0966b26a2aec7f2072efd0a1a9b6328f2.diff LO

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6380c0966b: [Driver] Don't pass -ffile-compilation-dir through to cc1 (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

lebedev.ri added a comment. Patch is missing a description of the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 ___ cfe-commits mailing list cfe-commit

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

khchen updated this revision to Diff 326612. khchen marked 3 inline comments as done. khchen added a comment. address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https://reviews.llvm.org/D96843 Files: clang/include

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1052 uint8_t PrevExt = (*Defs.begin())->getRISCV_Extensions(); - bool NeedEndif = emitExtDefStr(PrevExt, OS); + bool NeedEndif = + (*Defs.begin())->hasAutoDef() ? emitExtDefStr(PrevExt, OS)

<    1   2   3