[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

echristo added a comment. Exclusion list? or exclude? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D97461: [clang][cli] Implement '-cuid=' marshalling

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97461/new/ https://reviews.llvm.org/D97461 ___

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

ahatanak added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4087-4088 -Marking virtual functions as ``not_tail_called`` is an error: +Marking virtual functions as ``not_tail_called`` will not have effect on the +overriding functions of derived classes: -

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay added a comment. In D97446#2587806 , @probinson wrote: >> GNU ld has a rule "start_/stop_ references from a live input section retain >> the associated C identifier name sections", > > which LLD may change in the future (D96914

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang marked an inline comment as done. akhuang added a comment. In D97411#2586201 , @dblaikie wrote: > Oh, that might be a bit different again - if the type isn't required to be > complete in this translation unit, should this attribute override the >

[clang] 7f6e331 - Support `#pragma clang section` directives on MachO targets

Author: Jon Roelofs Date: 2021-02-25T09:30:10-08:00 New Revision: 7f6e3316456f939a062aad0eeaac983251a1747c URL: https://github.com/llvm/llvm-project/commit/7f6e3316456f939a062aad0eeaac983251a1747c DIFF: https://github.com/llvm/llvm-project/commit/7f6e3316456f939a062aad0eeaac983251a1747c.diff L

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f6e3316456f: Support `#pragma clang section` directives on MachO targets (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; Does this attribute have effect

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > Does this attr

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks added a comment. In `Linux.cpp` I only see uses of VFS, no uses of `llvm::sys::fs` so I think it should work there. And using clangd on vscode on Linux, it works with --sysroot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ htt

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc added a comment. In D96203#2587942 , @echristo wrote: > Exclusion list? or exclude? In 2a4317bfb319e , (Fangrui Song 2020-06-19) changed option name fsanitize-coverage-whitelis

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; dblaikie wrote: > aaron.ballman wrote:

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau added a comment. The hardcoded 5 premables can indeed be changed, I did not want to waste time on coding a configuration logic at such an early stage. Well indeed do some extra work if we elect a compatible but almost useless preamble. We'll basically do the work twice (but at least we

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

probinson added a comment. In D97446#2587996 , @MaskRay wrote: > In D97446#2587806 , @probinson wrote: > >>> GNU ld has a rule "start_/stop_ references from a live input section retain >>> the associated C identifi

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::TransformOMPCanonicalLoop(OMPCanonicalLoop *L) { + // The OMPCanonicalLoop will be recreated when transforming the loop-associted + // directive. jdenny wrote: >

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; akhuang wrote: > dblaikie wrote: > >

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

arphaman accepted this revision. arphaman added a comment. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; dblaikie wrote: > akhuang wrote:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a subscriber: ldionne. akhuang added a comment. @ldionne Do you think it'd be reasonable to add this debug info attribute to some types in libc++? (For types that have constructors but don't call them; some previous discussion in https://reviews.llvm.org/D90719). Repository: rG

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326438. akhuang marked an inline comment as done. akhuang added a comment. -Add LangOpts[CPlusPlus] to the attribute -Maybe change the attribute to also override required complete types and change name to standalone_debug Repository: rG LLVM Github Monore

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 326439. whisperity added a comment. - **[NFC]** Reformat the documentation so option values are in single backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity updated this revision to Diff 326440. whisperity added a comment. - **[NFC]** Reformat the documentation so option values are in single backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 326441. whisperity added a comment. - **[NFC]** Reformat the documentation so option values are in single backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 326442. whisperity marked 2 inline comments as done. whisperity added a comment. - **[NFC]** Reformat the documentation so option values are in single backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 326443. whisperity added a comment. - **[NFC]** Reformat the documentation so option values are in single backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/ https://reviews.llvm.org/D78652

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4087-4088 -Marking virtual functions as ``not_tail_called`` is an error: +Marking virtual functions as ``not_tail_called`` will not have effect on the +overriding functions of derived classes:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/force-debug-attribute.cpp:4-12 +#if SETATTR +#define DEBUGASNEEDED __attribute__((standalone_debug)) +#else +#define DEBUGASNEEDED +#endif + +// Struct that isn't constructed, so its full type info should be omitte

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

delcypher added a comment. In D97327#2585410 , @jansvoboda11 wrote: > LGTM. > > If you don't get around committing this today, please rebase this on top of > D97375 that I'm going to commit tomorrow. @jansvoboda11 This

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

delcypher added a comment. In D97327#2582981 , @yln wrote: > LGTM, cleanup only, right? Yes. This is just a small clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97327/new/ https://reviews.llvm.org

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix up cases where diag is called by piecing together

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

jansvoboda11 added a comment. In D97327#2588222 , @delcypher wrote: > @jansvoboda11 This doesn't build anymore because > https://reviews.llvm.org/D97375 removed `AutoNormalizeEnum`. Based on skim > reading the patch it looks like I should remove the `Au

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 326445. ABataev added a comment. Removed unnecessary changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files: clang/include/clang/AST/OpenMPClause.h clang/li

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks added a comment. Looks like -ivfsoverlay doesn't take effect in the driver. And -working-directory also changes the program's working directory since there's no vfs in the driver so it uses the actual fs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ... For removal in next release cycle. The clang warning that do

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b7104a2f203: Fix a test case that should check whether or not it is passed into lld (authored by Conanap). Repository: rG LLVM Github Monorepo C

[PATCH] D97420: [AMDGPU] require s-memtime-inst for __builtin_amdgcn_s_memtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG502b3bfc6a71: [AMDGPU] require s-memtime-inst for __builtin_amdgcn_s_memtime (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mon

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:678 +else + OS << ", Ops[" << Twine(static_cast(Idx)) << "]->getType()"; + } We don't need Twine here Comment at: clang/utils/TableGen/RISCVVEmitte

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:32 +static llvm::SmallString<0> findSPACKPackage(const Driver &D, + const llvm::SmallString<0> &Path, + StringRef

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I think we also do some registry searching, which is not virtualized. I guess those are all absolute references and paths, so if you use clangd on the same machine, it should just work. It oc

[clang] 4f395db - adds more checks to -Wfree-nonheap-object

Author: Christopher Di Bella Date: 2021-02-25T19:25:00Z New Revision: 4f395db86b5cc11bb56853323d3cb1d4b6db5a0b URL: https://github.com/llvm/llvm-project/commit/4f395db86b5cc11bb56853323d3cb1d4b6db5a0b DIFF: https://github.com/llvm/llvm-project/commit/4f395db86b5cc11bb56853323d3cb1d4b6db5a0b.dif

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f395db86b5c: adds more checks to -Wfree-nonheap-object (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.or

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

kadircet added a comment. In D97417#2588101 , @qchateau wrote: > Well indeed do some extra work if we elect a compatible but almost useless > preamble. We'll basically do the work twice (but at least we do it > concurrently \o/). I am afraid this can ha

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks updated this revision to Diff 326455. aeubanks added a comment. remove extra parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 Files: clang/lib/Driver/ToolChains/MSVC.cpp Index: clang/li

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rnk added a comment. I think the main user-facing feature here to think about is `__attribute__((used))`. I see that it's currently listed as Undocumented. We should fix that while we're rehashing how this is supposed to work, and clarify what it does on each platform. As I understand it, `__at

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks added a comment. We don't use a VFS for registry searching because we just take the value given by the registry and pass it on, rather than checking for the existence of specific files/directories. But yeah they're probably all absolute paths so it shouldn't matter in those cases. Re

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d64dd8e3c22: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend… (authored by delcypher). Repository: rG LLVM Githu

[clang] fdce098 - [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling with `-mkernel` or `-fapple-kext`.

Author: Dan Liew Date: 2021-02-25T12:02:21-08:00 New Revision: fdce098b49cb038996441741a7b2ab3652502aec URL: https://github.com/llvm/llvm-project/commit/fdce098b49cb038996441741a7b2ab3652502aec DIFF: https://github.com/llvm/llvm-project/commit/fdce098b49cb038996441741a7b2ab3652502aec.diff LOG:

[PATCH] D96573: [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling with `-mkernel` or `-fapple-kext`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdce098b49cb: [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling… (authored by delcypher). Repository: rG LLVM Github Mo

[clang] 5d64dd8 - [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

Author: Dan Liew Date: 2021-02-25T12:02:21-08:00 New Revision: 5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117 URL: https://github.com/llvm/llvm-project/commit/5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117 DIFF: https://github.com/llvm/llvm-project/commit/5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117.diff LOG:

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT created this revision. oToToT added reviewers: sammccall, rsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. As @sammccall mentioned in D97109

[clang] ec4408a - [CodeGen] Call ConvertTypeForMem instead of ConvertType

Author: Akira Hatanaka Date: 2021-02-25T12:11:18-08:00 New Revision: ec4408ad692b20a01cca8b5d86f359f6f16bae87 URL: https://github.com/llvm/llvm-project/commit/ec4408ad692b20a01cca8b5d86f359f6f16bae87 DIFF: https://github.com/llvm/llvm-project/commit/ec4408ad692b20a01cca8b5d86f359f6f16bae87.diff

[clang] 9a887f6 - [clang,NFC] Fix typos in file headers

Author: Vitaly Buka Date: 2021-02-25T12:47:02-08:00 New Revision: 9a887f652c2e87019d2a0dfaa2e03a447b056270 URL: https://github.com/llvm/llvm-project/commit/9a887f652c2e87019d2a0dfaa2e03a447b056270 DIFF: https://github.com/llvm/llvm-project/commit/9a887f652c2e87019d2a0dfaa2e03a447b056270.diff L

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d52c4819294: Rewrite MSVC toolchain discovery with VFS (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 6d52c48 - Rewrite MSVC toolchain discovery with VFS

Author: Arthur Eubanks Date: 2021-02-25T12:50:08-08:00 New Revision: 6d52c4819294dafb2c072011d72bb523092248a2 URL: https://github.com/llvm/llvm-project/commit/6d52c4819294dafb2c072011d72bb523092248a2 DIFF: https://github.com/llvm/llvm-project/commit/6d52c4819294dafb2c072011d72bb523092248a2.diff

Re: [PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

To my taste "exclude" better represents meaning than "disallow". E.g. disallow can be interpreted as "make them fatal". We can fix 2a4317bfb319e for consistency later. -fsanitize-exclude-list= ? On Thu, 25 Feb 2021 at 09:54, Melanie Blower via Phabricator < revi...@reviews.llvm.org> wrote: > mibi

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:165 + // and it will have to be provided manually. See IntrinsicTypes below. + bit HasManualCodegen = true; + Why do we need a flag? Can we just make ManualCodegen and Man

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

delcypher updated this revision to Diff 326474. delcypher added a comment. - Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97327/new/ https://reviews.llvm.org/D97327 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[clang] 7b1d2a2 - [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

Author: Dan Liew Date: 2021-02-25T13:24:50-08:00 New Revision: 7b1d2a2891d812ffc1bb08712143c79e457acbd4 URL: https://github.com/llvm/llvm-project/commit/7b1d2a2891d812ffc1bb08712143c79e457acbd4 DIFF: https://github.com/llvm/llvm-project/commit/7b1d2a2891d812ffc1bb08712143c79e457acbd4.diff LOG:

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b1d2a2891d8: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address… (authored by delcypher). Repository: rG LLVM Github Monorep

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

cryptoad created this revision. cryptoad added reviewers: delcypher, vitalybuka. Herald added a subscriber: dexonsmith. cryptoad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Post D96572 , a warning starte

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

amccarth added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326477. vvereschaka added a comment. Updated diff: - rewording the doc part - removed `ClaimAllArgs` for `OPT_fproc_stat_report` - updated `if` statement for `CCPrintStatReportFilename` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay updated this revision to Diff 326480. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Adopted rnk's list (Thanks!) Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added inline comments. Comment at: clang/docs/UsersManual.rst:799 + setting the ``CC_PRINT_PROC_STAT`` and ``CC_PRINT_PROC_STAT_FILE`` environment + variables. Use ``CC_PRINT_PROC_STAT_FILE`` to provide a file name to store + the statistics. agane

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu updated this revision to Diff 326484. zequanwu added a comment. Adopt Quuxplusone's phrasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96832/new/ https://reviews.llvm.org/D96832 Files: clang/include/clang/Basic/AttrDocs.td clang/

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 ___ cfe-commits mailing list cfe-commi

[PATCH] D97499: [PM] Show the pass argument in pre/post-pass IR dumps

nlguillemot created this revision. nlguillemot added reviewers: jroelofs, thegameg, dsanders. Herald added subscribers: dexonsmith, hiraditya. nlguillemot requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds eac

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm > I see that it's currently listed as Undocumented. We should fix that while > we're rehashing how this is supposed to work, and clarify what it does on > each platform. As I understand it, __

[PATCH] D97499: [PM] Show the pass argument in pre/post-pass IR dumps

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97499/new/ https://reviews.llvm.org/D97499 ___

[clang] 3573a90 - [PM] Show the pass argument in pre/post-pass IR dumps

Author: Nicolas Guillemot Date: 2021-02-25T14:02:00-08:00 New Revision: 3573a90b8aec082b8d7a1e2fc35f7103a0df7cb6 URL: https://github.com/llvm/llvm-project/commit/3573a90b8aec082b8d7a1e2fc35f7103a0df7cb6 DIFF: https://github.com/llvm/llvm-project/commit/3573a90b8aec082b8d7a1e2fc35f7103a0df7cb6.d

[PATCH] D97447: Add GNU attribute 'retain'

rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:74 +COFF and Mach-O targets (Windows and Apple platforms), this attribute prevents +the definition and its symbol from being removed by the linker. On ELF +targets, it has no effect on its own, and the

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 326505. myhsu marked 4 inline comments as done. myhsu added a comment. - [NFC] Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/C

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu marked an inline comment as done. myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:142 +const char *&Name, TargetInfo::ConstraintInfo &info) const { + // FIXME: implement + switch (*Name) { jrtc27 wrote: > This is implemented?

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 326506. myhsu marked 3 inline comments as done. myhsu added a comment. - Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/CM

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu marked an inline comment as done. myhsu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380 ve::getVETargetFeatures(D, Args, Features); +break; } jrtc27 wrote: > jrtc27 wrote: > > Unrelated > I committed this as 22215e49

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. Can you also add semantic tests that verify the attribute only works in C++, only appertains to a record (as opposed to other kinds of declarations like functions), and doesn't accept arguments. Some other tests that may be interesting: // Should test redeclara

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

jrtc27 added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --check

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks pretty unintrusive and will save a bunch of duplication. Comment at: clang/include/clang/Frontend/CompilerInstance.h:385 + // Create Target and Au

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

glaubitz added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --che

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

keith accepted this revision. keith added a comment. This revision is now accepted and ready to land. I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you 😛 https://reviews.llvm.org/D83154?id=275480#2146086

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

jrtc27 added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --check

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 326513. MaskRay marked 2 inline comments as done. MaskRay added a comment. Improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97447/new/ https://reviews.llvm.org/D97447 Files: clang/include/

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:74 +COFF and Mach-O targets (Windows and Apple platforms), this attribute prevents +the definition and its symbol from being removed by the linker. On ELF +targets, it has no effect on its own, and

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

glaubitz added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --che

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov updated this revision to Diff 326514. mizvekov added a comment. Updated comment and moved tests to correct places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409 Files: clang/lib/Sema/SemaDeclCX

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

cryptoad updated this revision to Diff 326516. cryptoad added a comment. Opt for a version that satisfies `clang-diagnostic-covered-switch-default` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97496/new/ https://reviews.llvm.org/D97496 Files: c

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

rnk added a comment. This still feels a bit messy and I don't totally understand how it all fits together, but I'm super supportive of getting rid of the inline asm diagnostic handler and standardizing on DiagnosticHandler/DiagnosticInfo. Comment at: llvm/include/llvm/MC/MCCo

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Libomptarget changes look good, I'll let @jdoerfert provide feedback for the clang part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Quuxplusone accepted this revision. Quuxplusone added a comment. Marking "accepted" from me, merely to indicate that my grammar stuff is not blocking and I don't expect I'll have any further substantive comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4101 + Fo

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

Eugene.Zelenko added a comment. If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe just to remove `readability-deleted-default`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97491/new/ https://reviews.llvm.org/D97491

[clang] d95c6d3 - [www] Add cxx_status tracking for C++23.

Author: Richard Smith Date: 2021-02-25T14:47:43-08:00 New Revision: d95c6d3b69219d7b3049732f4081e3bb6ca70016 URL: https://github.com/llvm/llvm-project/commit/d95c6d3b69219d7b3049732f4081e3bb6ca70016 DIFF: https://github.com/llvm/llvm-project/commit/d95c6d3b69219d7b3049732f4081e3bb6ca70016.diff

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

scui added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); This is failing our build, This line and line 686. The msg is:

[clang] 4500f0a - [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Author: Zequan Wu Date: 2021-02-25T14:58:18-08:00 New Revision: 4500f0a7321d75a061d09d92987b522e9cc09517 URL: https://github.com/llvm/llvm-project/commit/4500f0a7321d75a061d09d92987b522e9cc09517 DIFF: https://github.com/llvm/llvm-project/commit/4500f0a7321d75a061d09d92987b522e9cc09517.diff LOG

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rG4500f0a7321d: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual… (authored by z

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

delcypher added a comment. @cryptoad Thanks. LGTM Originally this code had a `default` case in the switch but clang complained about it being unnecessary because it was exhaustive, so I removed it... It seems this is causing problems with your compiler :( Repository: rG LLVM Github Monorep

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek added a comment. In D97434#2588755 , @keith wrote: > I personally prefer this, and this is what I landed in swiftc a while back, > but I changed to -fprofile-prefix-map based on feedback from you 😛 > https://reviews.llvm.org/D83154?id=275480#21460

[clang] 24539f1 - Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

Author: James Y Knight Date: 2021-02-25T18:29:42-05:00 New Revision: 24539f1ef2471d07bd87f833cb0288fc0f251f4b URL: https://github.com/llvm/llvm-project/commit/24539f1ef2471d07bd87f833cb0288fc0f251f4b DIFF: https://github.com/llvm/llvm-project/commit/24539f1ef2471d07bd87f833cb0288fc0f251f4b.diff

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24539f1ef247: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg. (authored by jyknight). Herald added a subscriber: cota.

[clang] 41751b6 - [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

Author: Kostya Kortchinsky Date: 2021-02-25T15:32:18-08:00 New Revision: 41751b637317bd9c97b0506ba77075694cd2d9cf URL: https://github.com/llvm/llvm-project/commit/41751b637317bd9c97b0506ba77075694cd2d9cf DIFF: https://github.com/llvm/llvm-project/commit/41751b637317bd9c97b0506ba77075694cd2d9cf.

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41751b637317: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case (authored by cryptoad). Repository: rG LLVM Github Mon

<    1   2   3   >