[PATCH] D97000: [clang] Increase the bitness of data length in ASTDeclContextNameLookup

danlark abandoned this revision. danlark added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97000/new/ https://reviews.llvm.org/D97000 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. In D96090#2572069 , @ASDenysPetrov wrote: > In D96090#2568431 , @steakhal wrote: > >> Could you please rebase this? > > I'll update and rebase this patch soon. > >> If it depends on any pa

[PATCH] D96866: [AArch64] Add some missing Neoverse features

This revision was automatically updated to reflect the committed changes. Closed by commit rG260f90bb3d1a: [AArch64] Add some missing Neoverse features (authored by SjoerdMeijer). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llv

[clang] 260f90b - [AArch64] Add some missing Neoverse features

Author: Sjoerd Meijer Date: 2021-02-19T09:18:35Z New Revision: 260f90bb3d1aef90764de3506f86dedd1339e37c URL: https://github.com/llvm/llvm-project/commit/260f90bb3d1aef90764de3506f86dedd1339e37c DIFF: https://github.com/llvm/llvm-project/commit/260f90bb3d1aef90764de3506f86dedd1339e37c.diff LOG:

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 ___ cfe-commits mailing list c

[PATCH] D96884: [flang][driver] Add more -fdebug options

FarisRehman updated this revision to Diff 324926. FarisRehman added a comment. Remove -fdebug-parsing-log Remove `-fdebug-parsing-log` from this patch as it requires additional work that can be implemented in a separate patch. Also address review comments by @awarzynski Repository: rG LLVM G

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

jansvoboda11 created this revision. Herald added a subscriber: wenlei. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves the creation of the '-Wspir-compat' argument from cc1 to the driver. Without this change,

[PATCH] D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for updating this @FarisRehman ! The original implementation of ``-fdebug-parsing-log` submitted here was not 100% compatible with `-fdebug-instrumented-parse` from `f18` as

[PATCH] D97042: [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch stops creating the '-Wno-stdlibcxx-not-found' argument in `CompilerInvocation::CreateFromArgs`. The code was added in 2e7ab55e657f

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 updated this revision to Diff 324933. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96280/new/ https://reviews.llvm.org/D96280 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D96848: [clang][cli] Don't emit manufactured warnings

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Abandoning this in favor of D97041 & D97042 . Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2347-2353 +// This warning was manufac

[clang] 529f718 - [flang][driver] Add debug measure-parse-tree and pre-fir-tree options

Author: Faris Rehman Date: 2021-02-19T11:27:54Z New Revision: 529f71811b0475995f2d9cf766f18d897eec574c URL: https://github.com/llvm/llvm-project/commit/529f71811b0475995f2d9cf766f18d897eec574c DIFF: https://github.com/llvm/llvm-project/commit/529f71811b0475995f2d9cf766f18d897eec574c.diff LOG:

[PATCH] D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG529f71811b04: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options (authored by FarisRehman). Repository: rG LLVM Github Monorepo

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

vabridgers added a comment. Polite ping. This is a small and simple change, my only doubt is the test coverage. But frankly I see none of the literals are covered in any of the test cases (unless I'm missing something). Could I get some guidance on required test coverage for this simple change,

[PATCH] D97043: [clang][DeclPrinter] Pass Context into StmtPrinter whenever possible

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ASTContext were only passed to the StmtPrinter in some places, whi

[PATCH] D97043: [clang][DeclPrinter] Pass Context into StmtPrinter whenever possible

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:526 HI.Name = "result"; - HI.Definition = "static constexpr int result = 1 + 2"; + HI.Definition = "static constexpr int result = a + b"; HI.Kind = in

[PATCH] D96950: [clang][CodeComplete] Ensure there are no crashes when completing with ParenListExprs as LHS

kadircet updated this revision to Diff 324945. kadircet marked 4 inline comments as done. kadircet added a comment. - Pull unwrapping of parenlistexprs into a function - Merge comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96950/new/ https:

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

kadircet updated this revision to Diff 324946. kadircet marked 2 inline comments as done. kadircet added a comment. - Update comment. - Get rid of a parent_path usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96123/new/ https://reviews.llvm.or

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

kadircet updated this revision to Diff 324947. kadircet added a comment. - Get rid of parent_path usage for real Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96123/new/ https://reviews.llvm.org/D96123 Files: clang-tools-extra/clangd/ConfigProvi

[PATCH] D96906: [AMDGPU] gfx90a support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } This is a problem

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added a comment. > The point is that nobody upstream even got a chance to chime in. We are and will be taking care of any feedback provided in this review post-commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96906/new/ https://revi

[PATCH] D96906: [AMDGPU] gfx90a support

msearles added a comment. In D96906#2572749 , @kzhuravl wrote: >> The point is that nobody upstream even got a chance to chime in. > > We are and will be taking care of any feedback provided in this review > post-commit. To be fair to @rampitec , it was

[PATCH] D96906: [AMDGPU] gfx90a support

tra added a comment. In D96906#2572842 , @msearles wrote: > In D96906#2572749 , @kzhuravl wrote: > >>> The point is that nobody upstream even got a chance to chime in. >> >> We are and will be taking care of any fee

[PATCH] D96906: [AMDGPU] gfx90a support

echristo added a comment. In D96906#2572842 , @msearles wrote: > In D96906#2572749 , @kzhuravl wrote: > >>> The point is that nobody upstream even got a chance to chime in. >> >> We are and will be taking care of an

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:737 EF_AMDGPU_MACH_AMDGCN_FIRST = EF_AMDGPU_MACH_AMDGCN_GFX600, - EF_AMDGPU_MACH_AMDGCN_LAST = EF_AMDGPU_MACH_AMDGCN_GFX805, + EF_AMDGPU_MACH_AMDGCN_LAST = EF_AMDGPU_MACH_AMDGCN_GFX90A, --

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

foad added a comment. In D96906#2573265 , @echristo wrote: > In D96906#2572842 , @msearles wrote: > >> In D96906#2572749 , @kzhuravl wrote: >> The point is that nobody u

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[clang-tools-extra] 6329ce7 - [clangd] Expose absoluteParent helper

Author: Kadir Cetinkaya Date: 2021-02-19T13:40:21+01:00 New Revision: 6329ce75da7a44c40d4406bf48e973ef5fdb URL: https://github.com/llvm/llvm-project/commit/6329ce75da7a44c40d4406bf48e973ef5fdb DIFF: https://github.com/llvm/llvm-project/commit/6329ce75da7a44c40d4406bf48e973ef5fdb.dif

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6329ce75da7a: [clangd] Expose absoluteParent helper (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D96123?vs=324947&id=

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 324949. arnamoy10 added a comment. Set the option as a frontend-only option, also modified the test case accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files: clang/include/clang/Driver/Op

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

kadircet accepted this revision. kadircet added inline comments. Comment at: clang/docs/InternalsManual.rst:1882 + example. +- representing invalid node: the invalid node is preserved in the AST in some + form, e.g. when the "declaration" part of the declaration contains semant

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96856/new/ https://reviews.llvm.org/D96856

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 324956. jansvoboda11 added a comment. Put `RemarkKind` in `RemarkPattern`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang/include/clang/Basic/CodeG

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3016 .. code-block:: console svenvh wrote: > Anastasia wrote: > > svenvh wrote: > > > I wonder if we need to keep this example? You're not referring to it > > > from the text and it

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM. In D96905#2574322 , @vabridgers wrote: > Polite ping. This is a small and simple change, my only doubt is the test > coverage. But frankly I

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. That's a bit nicer. Not sure if `RemarkPattern` is a good name now, as it may represent an optimization remark that doesn't have any pattern associated with it. How about calling it `OptimizationRemark` and merging `operator bool` and `operator ->` into `bool patte

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

steakhal added a comment. In D96905#2574398 , @steakhal wrote: > You could call it like `c-index-getCursor-fixed-point.c`. Hmm, to be honest, this was probably not what you wanted to test. What about simply inserting your own use-case which uncovered this

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2141 + Group, Flags<[CC1Option]>, + HelpText<"Ignore attribute objc_direct so that direct methods can be tested">; + arphaman wrote: > Do you need to use the new options mars

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267 + if (Triple.isSPIR()) +CmdArgs.push_back("-Wspir-compat"); It seems like this should have been in `addClangWarningOptions` but there is no toolchain for SPIR? Could

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:433-434 +if (To == MAX) { + Result.insert(Result.end(), What.begin(), What.end()); + return makePersistent(std::move(Result)); +} ASDenysPetro

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

njames93 added a comment. Before landing this, can you update the title of this to reflect its in the concurrency module, the title is typically used for the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96719/new/ https://reviews.

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Btw since we are moving this code anyway, do you think we could fix the formatting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

jansvoboda11 updated this revision to Diff 324959. jansvoboda11 added a comment. Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97041/new/ https://reviews.llvm.org/D97041 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Frontend

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

jansvoboda11 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267 + if (Triple.isSPIR()) +CmdArgs.push_back("-Wspir-compat"); Anastasia wrote: > It seems like this should have been in `addClangWarningOptions` but there is > no too

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. I've left a few comments, but these are nice-to-haves from my perspective. @tskeith , what do you think about the suggested changes in `f18`? We could upload a separate patch for that.

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

svenvh added a comment. In D96948#257 , @Anastasia wrote: > LGTM! Btw since we are moving this code anyway, do you think we could fix the > formatting? Sure, I'll do that before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97041/new/ https://reviews.llvm.org/D97041 ___

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 324964. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Rebased revision on top of the main branch. Minor improvements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal wrote: > This patch preserves all previous reports as expected. If this patch is technically full-baked and does not bring any harm, can we approve this it as well to move forward? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; Btw, I am guessing

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl updated this revision to Diff 324971. yaxunl marked 3 inline comments as done. yaxunl added a comment. refactor CGCUDARuntime interface not to expose transformManagedVar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96195/new/ https://reviews.llvm.org/D96195 Files: clang/lib/

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

tskeith added inline comments. Comment at: flang/test/Flang-Driver/fdefault.f90:4 + +! REQUIRES: new-flang-driver + awarzynski wrote: > tskeith wrote: > > Can't this work with the f18 driver too? That's the best way to ensure they > > are consistent. > I think t

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov added a comment. This is just a note for me to correctly rebase it in the future: https://reviews.llvm.org/D96090?vs=321602&id=322422#toc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 _

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 324981. njames93 added a comment. Restrict availability of default capture fixit based on init captures already specified. `[=, A]() {}` and `[&, &A]() {}` are both invalid as explicit captures can't be specified with the same type as default capture. So w

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7459-7460 "capture-default specified">; + def note_lambda_variable_capture_fixit : Note< +"capture variable %0 by %select{value|reference}1">; + def note_lambda_default_capture

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia created this revision. Anastasia added reviewers: azabaznov, svenvh, mantognini. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. Currently, extension pragma is always added when new OpenCL option (extension or feature) is added to the fronten

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. In D96771#2571855 , @Anastasia wrote: > This is only the initial patch and for the moment the primary goal is to > remove the need for the flag at least from the clang perspective. Shorter compiler invocation is always nice! D

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis created this revision. joechrisellis added reviewers: c-rhodes, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \ +//

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324997. arnamoy10 added a comment. Added a missing option test for `-flarge-sizes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChai

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/test/Flang-Driver/flarge_sizes.f90:1 +! Ensure argument -flarge-sizes works as expected. +! TODO: Add checks when actual codegen is possible for this family awarzynski wrote: > Could you add a `NOOPTION` variant

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: jfb, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no need to check for enabled pragma for core or optiona

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. Thanks! I review is shortly. As for now, I also was doing some refactoring: https://reviews.llvm.org/D97058. Check-clang passes, as I see there are no conflicts for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; Anastasia wrote: > Bt

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

zatrazz updated this revision to Diff 325004. zatrazz retitled this revision from "EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)" to "EntryExitInstrumenter: Enable at all optimization levels (PR49143)". zatrazz edited the summary of this revision. za

[clang] 71a8e4e - [MemCopyOpt] Enable MemorySSA by default

Author: Nikita Popov Date: 2021-02-19T18:06:25+01:00 New Revision: 71a8e4e7d6b947c8b954ec0763ff7969b3879d7b URL: https://github.com/llvm/llvm-project/commit/71a8e4e7d6b947c8b954ec0763ff7969b3879d7b DIFF: https://github.com/llvm/llvm-project/commit/71a8e4e7d6b947c8b954ec0763ff7969b3879d7b.diff

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

This revision was automatically updated to reflect the committed changes. nikic marked an inline comment as done. Closed by commit rG71a8e4e7d6b9: [MemCopyOpt] Enable MemorySSA by default (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D97060: [OpenCL] Add ndrange builtin functions to TableGen

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add ndrange builtin functions to TableGen. Also ensure all kernel enqueue functions

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:24 +//its behavior explicitly is deprecated. Therefore the default +//value if false. // avail - minimum OpenCL version supporting it. typo =

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

rupprecht added a comment. This fixes a build error we're seeing, so I'd like to land this in a bit if that's OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 ___

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \ +//

[clang] 1a368ae - [CUDA] fix builtin constraints for PTX 7.2

Author: Artem Belevich Date: 2021-02-19T09:57:21-08:00 New Revision: 1a368ae3b78dd7a364e8f17658fddaf86b1e98db URL: https://github.com/llvm/llvm-project/commit/1a368ae3b78dd7a364e8f17658fddaf86b1e98db DIFF: https://github.com/llvm/llvm-project/commit/1a368ae3b78dd7a364e8f17658fddaf86b1e98db.diff

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a368ae3b78d: [CUDA] fix builtin constraints for PTX 7.2 (authored by tra, committed by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 325027. rsanthir.quic added a comment. Windows builds were failing due to missing builtins in Intrinsics map CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl added a comment. So in this case, the virtual call in user code is resolved to a strong definition in the shared library even though user code also has a derived class defined? In other words, the library provides another overrider definition as the final overrider? Repository: rG L

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 325029. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Ba

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2884 +Tok.setKind(tok::kw__Static_assert); +Tok.setIdentifierInfo(getIdentifierInfo("_Static_assert")); +MI->AddTokenToBody(Tok); rsmith wrote: > Do we need to give the ex

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson added a comment. In D96919#2575037 , @davidxl wrote: > So in this case, the virtual call in user code is resolved to a strong > definition in the shared library even though user code also has a derived > class defined? In other words, the libra

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1770 - if (!VTable->isDeclarationForLinker()) + if (!VTable->isDeclarationForLinker() || + CGM.getCodeGenOpts().WholeProgramVTables) { Can you add some comment here -- also he

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) I think core and optional core features d

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. In D85176#2572661 , @saugustine wrote: > This commit introduced an unused variable warning when built without asserts. > (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 >

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 325034. rsanthir.quic added a comment. rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp clang/test/Code

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 325039. ldionne added a comment. Fix GCC issues. I swear I had done the same fix locally previously, but I must have messed something up with Git or `arc diff`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5010

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order a

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson updated this revision to Diff 325041. tejohnson added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96919/new/ https://reviews.llvm.org/D96919 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/t

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 +// analysis. +if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable); Is it better to guard it with with if (CGM.getCodeGenOpts().WholeProgramVTa

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 325036. whisperity retitled this revision from "[clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'" to "[clang-tidy] Suppress reports to similarly used parameters in 'bug

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 +// analysis. +if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable); davidxl wrote: > Is it better to guard it with with if > (CGM.getCodeGenO

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > I think core and optio

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added a comment. Thank you for reviewing this @DavidSpickett ! If you get a chance could you commit this for me? I do not have commit access yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381

  1   2   >