[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2539483 , @jdoerfert wrote: > Also, now you don't warn for different missing runtimes, which seems odd. What do you mean? Is the value returned from `GetRuntimeLibType()` ever going to change? CHANGES SINCE LAST ACTIO

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. My proposal would be to cache the return value of the three routines in `ToolChain`. This has the advantage that the values get parsed only once and there is at most one warning. I don't know how this plays with parallelization efforts, but I don't think we should worr

[clang] cde8d2f - Fix miscompile when performing template instantiation of non-dependent

Author: Richard Smith Date: 2021-02-03T23:38:02-08:00 New Revision: cde8d2fddbff55cae520d90f47f6faf124d3f953 URL: https://github.com/llvm/llvm-project/commit/cde8d2fddbff55cae520d90f47f6faf124d3f953 DIFF: https://github.com/llvm/llvm-project/commit/cde8d2fddbff55cae520d90f47f6faf124d3f953.diff

[clang] 3b9de99 - Give this test a target triple.

Author: Richard Smith Date: 2021-02-03T23:38:52-08:00 New Revision: 3b9de993c9dffd0941ad79c80a2cb7785bc63f03 URL: https://github.com/llvm/llvm-project/commit/3b9de993c9dffd0941ad79c80a2cb7785bc63f03 DIFF: https://github.com/llvm/llvm-project/commit/3b9de993c9dffd0941ad79c80a2cb7785bc63f03.diff

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2541129 , @Hahnfeld wrote: > My proposal would be to cache the return value of the three routines in > `ToolChain`. This has the advantage that the values get parsed only once and > there is at most one warning. I don't

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. In D95915#2541132 , @tbaeder wrote: > That's what I was looking at right now as well, since using > `std::call_once()` already means the methods can't be `const` anymore anyway. > Might as well just cache the value. You can mak

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:333 + // not invalidated. + DynTypedNodeList Parents(DynTypedNode::create(RenamedDecl)); + auto GetSingleParent = [&](DynTypedNode Node) -> const DynTypedNode * { If the int

<    1   2   3