[PATCH] D94644: [Inliner] Inline alwaysinline calls first

2021-01-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D94644#2497125 , @mtrofin wrote: > Would running the function simplification pipeline after the always inline > pass address the issue? Probably yes, but last time we measured the compile time implications of that, it was ve

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

2021-01-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. An alternative is to run the mandatory inliner in the same CGSCC pipeline as everything else, but the way InlineAdvisorAnalysis is setup made it hard to implement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN if -fthinlto-index= is specified

2021-01-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D94647#2497170 , @dblaikie wrote: > In implicit thinlto this seemed to work for me without any changes: > > $ clang++-tot -flto=thin test.cpp -g -c > $ clang++-tot -flto=thin -fuse-ld=lld -gsplit-dwarf test.o && > llvm-dwar

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

2021-01-13 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. This is still incorrect. The indices for the hi/low words are backwards. You can easily demonstrate this with a test case such as: a.c: vector double test() { return (vector

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN if -fthinlto-index= is specified

2021-01-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright. I wouldn't mind knowing a bit more about how these things interact if different types of input files are listed together in a single command line, though. Repository: rG

[clang] 53b3460 - [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

2021-01-13 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2021-01-13T21:01:53-08:00 New Revision: 53b34601abf1d48e8df210ab8127b16fd35e275a URL: https://github.com/llvm/llvm-project/commit/53b34601abf1d48e8df210ab8127b16fd35e275a DIFF: https://github.com/llvm/llvm-project/commit/53b34601abf1d48e8df210ab8127b16fd35e275a.diff

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

2021-01-13 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53b34601abf1: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index= (authored by MaskRay). Changed prior to commit: https://

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

2021-01-13 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType hoy wrote: > wmi wrote: > > The bits in dis

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

2021-01-13 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. In D94644#2497180 , @aeubanks wrote: > An alternative is to run the mandatory inliner in the same CGSCC pipeline as > everything else, but the way InlineAdvisorAnalysis is setup made it hard to > implement I don't remember there

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

2021-01-13 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 316567. hoy added a comment. Adding support in the priority-based inliner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ https://reviews.llvm.org/D93264 Files: clang/test/CodeGen/pseudo-probe-emit.c

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

2021-01-13 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnalyzer.cpp:71 Env.getFirstStartColumn(), Style, Encoding, Allocator, - IdentTable); timwoj wrote: > HazardyKnusperkeks wrote: > > Unrelat

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

2021-01-13 Thread Wei Mi via Phabricator via cfe-commits
wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType hoy wrote: > hoy wrote: > > wmi wrote: > >

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

2021-01-13 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

2021-01-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3758 + // Normally -gsplit-dwarf is only useful with -gN. For -gsplit-dwarf in the + // backend phase of a distributed ThinLTO which does object file generation + // and no IR generation, -gN sh

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

2021-01-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3758 + // Normally -gsplit-dwarf is only useful with -gN. For -gsplit-dwarf in the + // backend phase of a distributed ThinLTO which does object file generation + // and no IR generation, -gN sho

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

2021-01-13 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > hoy wrote: > > hoy wrote: > >

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

2021-01-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3758 + // Normally -gsplit-dwarf is only useful with -gN. For -gsplit-dwarf in the + // backend phase of a distributed ThinLTO which does object file generation + // and no IR generation, -gN shou

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

2021-01-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3758 + // Normally -gsplit-dwarf is only useful with -gN. For -gsplit-dwarf in the + // backend phase of a distributed ThinLTO which does object file generation + // and no IR generation, -gN sh

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

2021-01-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: dblaikie, tejohnson. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This generalizes D94647 to IR input, as suggested by @tejohnson. Repos

<    1   2