[clang] c6ffe4d - [clang] Fix message text for `-Wpointer-sign` to account for plain char

Author: Hubert Tong Date: 2021-01-11T18:41:14-05:00 New Revision: c6ffe4d76fbf6ae505c0abccaf29017414265e32 URL: https://github.com/llvm/llvm-project/commit/c6ffe4d76fbf6ae505c0abccaf29017414265e32 DIFF: https://github.com/llvm/llvm-project/commit/c6ffe4d76fbf6ae505c0abccaf29017414265e32.diff L

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6ffe4d76fbf: [clang] Fix message text for `-Wpointer-sign` to account for plain char (authored by hubert.reinterpretcast). Changed prior to commit: https://reviews.llvm.org/D93999?vs=315648&id=315956#t

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt added a comment. In D94337#2491515 , @tra wrote: > Does it make sense? Yep, most of what your saying makes sense to me. Thanks for taking the time to review this. A few notes: > That would still require properly defined CUDA macros. CUDA in

[PATCH] D94337: Add cuda header type for cuh files

tra added a comment. In D94337#2491761 , @rgreenblatt wrote: > For example consider the following header: > > #pragma once > > __global__ void a() { > unsigned block_idx = blockIdx.x; > unsigned thread_idx = threadIdx.x; > > __shfl_do

[PATCH] D94463: [Driver] Make -fcs-profile-generate require -fprofile-use

MaskRay created this revision. MaskRay added a reviewer: xur. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds some tests missing in D54176 and disallows `-fcs-profile-generate` without `-

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thomasanderson added a comment. We appear to still be carrying a patch for this in Chromium, so I think the issue still stands. https://source.chromium.org/chromium/chromium/src/+/master:buildtools/third_party/libc++/BUILD.gn;drc=21272efa27e69622c6d174f29e4a73f1a6088cfc;l=135 Repository: rG L

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt updated this revision to Diff 315986. rgreenblatt added a comment. Added CUDAHeader_DEVICE to propery handle split compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94337/new/ https://reviews.llvm.org/D94337 Files: clang/incl

[PATCH] D94438: Fis for Assertion failure on dependent expression.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: clang/test/Sema/builtin-returnaddress.c:3 // RUN: %clang_cc1 -fsyntax-only -Wmost -verify %s +// RUN: %clang_cc1 -x c++ -fsyntax-only -Wframe-address -verify %s +// RUN: %clang

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inline-asm.c cl

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

NoQ added a comment. > this would be a great flow-sensitive check for the clang static analyzer You could indeed use static analyzer's path sensitivity to get rid of these obvious false positives where the multiplication is performed pretty much immediately after a branch (or assert) that avoid

[PATCH] D94468: [test] Demonstrate bad error message

rupprecht created this revision. rupprecht requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should not be committed, but demonstrates an issue with cascading errors after D84673 . Repository: rG LLV

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

rupprecht added a comment. I ran into this commit when integrating commits today (specifically, 97100646d1b4526de1eac3aacdb0b098739c6ec9 ) -- there's nothing wrong with this patch AFAICT, but I'm wondering if the error messag

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2488 + if (Clobber == "eax") { +std::string::size_type position = Constraints.find("={eax}"); +if (position != std::string::npos) { `={eax}` is set in `X86_32TargetCodeGe

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

phosek added a comment. I agree that if we want to allow selecting C++ ABI only, a flag like `-fc++abi=` with some additional checks to disallow invalid combinations is better. The question is whether we want to allow that in the first place? The motivation behind this change is to support gene

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt added a comment. In D94337#2491825 , @tra wrote: > 'Works' is not exactly the same as 'works correctly'. This example makes > `a()` look like a regular host function, instead of the kernel, and that > affects how the rest of the TU get parsed

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2488 + if (Clobber == "eax") { +std::string::size_type position = Constraints.find("={eax}"); +if (position != std::string::npos) { pengfei wrote: > `={eax}` is set in `

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

nridge updated this revision to Diff 316000. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94382/new/ https://reviews.llvm.org/D94382 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

<    1   2