[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481073 , @dblaikie wrote: > In D93747#2481053 , @tmsriram wrote: > >> In D93747#2480442 , @dblaikie wrote: >> >>> @tmsriram - any ideas what y

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481095 , @hoy wrote: > In D93747#2481073 , @dblaikie wrote: > >> In D93747#2481053 , @tmsriram wrote: >> >>> In D93747#2480442

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481163 , @dblaikie wrote: > In D93747#2481095 , @hoy wrote: > >> In D93747#2481073 , @dblaikie wrote: >> >>> In D93747#2481053

[clang] a032a4e - [-Wcalled-once-parameter][NFC] Fix operator precedence warning

Author: Yang Fan Date: 2021-01-06T12:16:30+08:00 New Revision: a032a4e7998c9adc7faea9e7b8e36a9552d3503b URL: https://github.com/llvm/llvm-project/commit/a032a4e7998c9adc7faea9e7b8e36a9552d3503b DIFF: https://github.com/llvm/llvm-project/commit/a032a4e7998c9adc7faea9e7b8e36a9552d3503b.diff LOG:

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

rjmccall added a comment. Without bothering to look it up, I would guess that the attribute-parsing code used to generically handle the ambiguity between identifier expressions and identifier attribute arguments by just always parsing simple identifiers as identifier arguments, making it Sema's

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rjmccall added a comment. People can't actually just copy/paste from the comment anyway because of the comment characters on the line, and I don't think anyone will misunderstand the example if the backslash is missing. It's silly that GCC has a problem with this, but since it does, let's just

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits mailing list cfe-commits

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481223 , @tmsriram wrote: > In D93747#2481163 , @dblaikie wrote: > >> In D93747#2481095 , @hoy wrote: >> >>> In D93747#2481073

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. I do feel like this is a terrible idea, sorry. It's a *very* niche use case to be dedicating a new compiler feature to, and it's a feature that demands a lot from the internal compiler architecture in ways that other features don't. If you really need to build code wi

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added a comment. Are you committed to the name `__ibm128`? I think a name that says something about floating point would be better than just a company name and a number. "double double" is the common name for this format pretty much everywhere, and while I certainly would *not* sugge

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

SouraVX accepted this revision. SouraVX added a comment. LGTM! - Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 ___ cfe-commits mailing list cfe-commits@

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481304 , @tmsriram wrote: > In D93747#2481223 , @tmsriram wrote: > >> In D93747#2481163 , @dblaikie wrote: >> >>> In D93747#2481095

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 _

[clang] 4909cb1 - [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

Author: Pushpinder Singh Date: 2021-01-06T02:03:30-05:00 New Revision: 4909cb1a0fe9f2494ccbadc2856b6ddfc70051b5 URL: https://github.com/llvm/llvm-project/commit/4909cb1a0fe9f2494ccbadc2856b6ddfc70051b5 DIFF: https://github.com/llvm/llvm-project/commit/4909cb1a0fe9f2494ccbadc2856b6ddfc70051b5.di

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

This revision was automatically updated to reflect the committed changes. Closed by commit rG4909cb1a0fe9: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2481306 , @rjmccall wrote: > I do feel like this is a terrible idea, sorry. It's a *very* niche use case > to be dedicating a new compiler feature to, and it's a feature that demands a > lot from the internal compiler

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; shafik wrote: > Is this to fix the bug or is this f

<    1   2   3