[PATCH] D93596: [ASTMatchers] Traverse-ignore range-for implementation details

2020-12-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 313205. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93596/new/ https://reviews.llvm.org/D93596 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/lib/ASTMatchers

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

2020-12-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 313208. MaskRay edited the summary of this revision. MaskRay added a comment. Improve BE test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 Files: clang/docs/Releas

[clang] 6bbb04a - [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

2020-12-21 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-12-21T15:32:35-08:00 New Revision: 6bbb04a732cdf203282f93b95d5a89cfc6fed8f4 URL: https://github.com/llvm/llvm-project/commit/6bbb04a732cdf203282f93b95d5a89cfc6fed8f4 DIFF: https://github.com/llvm/llvm-project/commit/6bbb04a732cdf203282f93b95d5a89cfc6fed8f4.diff

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

2020-12-21 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bbb04a732cd: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables (authored by MaskRay). Repository: rG LLVM Github Mon

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

2020-12-21 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 313211. hliao added a comment. Herald added a subscriber: mgorny. Fix the cmake to distribute that header wrapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files:

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

2020-12-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rnk. leonardchan added a project: clang. Herald added subscribers: dexonsmith, dang. leonardchan requested review of this revision. This is a more concentrated version of D85802 whi

[PATCH] D93452: [clangd] Trim memory periodically

2020-12-21 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau updated this revision to Diff 313215. qchateau marked 3 inline comments as done. qchateau added a comment. The log is back, I renamed the CMake option and the command line option and reduced the number of preprocessor directives. I chose not to modify the files for the `gn` build system,

[PATCH] D93633: [format] Add overload to parseConfiguration that accept llvm::MemoryBufferRef

2020-12-21 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang/include/clang/Format/Format.h:2946-2951 +/// Like above but accepts an unnamed buffer. +inline std::error_code parseConfiguration(StringRef Config, FormatStyle *Style, + bool AllowUnknownOp

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

2020-12-21 Thread Krystian Kuzniarek via Phabricator via cfe-commits
kuzkry updated this revision to Diff 313218. kuzkry retitled this revision from "[clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option" to "[clang-format][PR47290] Add ShortNamespaceLines format option". kuzkry added a comment. Renamed MaxUnwrappedLinesForShortNamespace to

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2020-12-21 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. Seems that conversion diagnostic test cases are completely missing. Comment at: clang/include/clang/Basic/TargetInfo.h:680 + /// Return the mangled code of __ibm128. + virtual const char *getIbm128Mangling() const { return "g"; } + T

[PATCH] D92806: Single function compilation mode.

2020-12-21 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 313221. hoy added a comment. Herald added subscribers: cfe-commits, dexonsmith, dang, steven_wu, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added a project: clang. Adding LTO, linker and clang suppor

Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

2020-12-21 Thread David Blaikie via cfe-commits
Would be handy to include a comment to document which compiler version, etc - so we know when we can remove this/don't waste time trying to remove it too soon. On Thu, Dec 17, 2020 at 3:51 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall > Date: 2020-12-17

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

2020-12-21 Thread Tom Stellard via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb01536f6f4: scan-view: Remove Reporter.py and associated AppleScript files (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/

[clang] dbb0153 - scan-view: Remove Reporter.py and associated AppleScript files

2020-12-21 Thread Tom Stellard via cfe-commits
Author: Tom Stellard Date: 2020-12-21T19:24:35-08:00 New Revision: dbb01536f6f49fa428f170e34466072ef439b3e9 URL: https://github.com/llvm/llvm-project/commit/dbb01536f6f49fa428f170e34466072ef439b3e9 DIFF: https://github.com/llvm/llvm-project/commit/dbb01536f6f49fa428f170e34466072ef439b3e9.diff

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

2020-12-21 Thread Juneyoung Lee via Phabricator via cfe-commits
aqjune added a comment. > There are 792 files in llvm/test, most of which are in test/Transform (119) > and test/CodeGen(655). > The transition will be swiftly done (if there's no other issue hopefully) by > the next weekend. Thinking about these again, do we need to make a poison copy for test

Re: [clang] 638867a - DR2064: decltype(E) is only a dependent type if E is type-dependent, not

2020-12-21 Thread Arthur Eubanks via cfe-commits
I've bisected https://crbug.com/1161059 down to this change. Would you like a reduced repro? clang++: /b/s/w/ir/cache/builder/src/third_party/llvm/clang/lib/AST/ItaniumMangle.cpp:5763: void {anonymous}::CXXNameMangler::addSubstitution(uintptr_t): Assertion `!Substitutions.count(Ptr) && "Substitutio

Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

2020-12-21 Thread Sam McCall via cfe-commits
Yeah. I don't actually know those details, the phab revision referenced (should have been a URL, oops) is all I know. The new version with the qualifier is better than the old one in any case though, so no need to ever remove it. (At least, we try to always spell the llvm qualifiers in clangd) O

[PATCH] D93452: [clangd] Trim memory periodically

2020-12-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. In D93452#2467046 , @qchateau wrote: > I did not use the CMke option as the default value for the command line > option: IMO this CMake option is only useful if you encounter build problems > r

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

2020-12-21 Thread Xiang Zhang via Phabricator via cfe-commits
xiangzhangllvm added inline comments. Comment at: compiler-rt/trunk/lib/hwasan/hwasan_checks.h:76 +#endif + return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag; +} Hello @pcc I think here seems some problem, the ptr is user passing point, *(ptr + n) should h

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

2020-12-21 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added inline comments. Comment at: compiler-rt/trunk/lib/hwasan/hwasan_checks.h:76 +#endif + return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag; +} xiangzhangllvm wrote: > Hello @pcc I think here seems some problem, the ptr is user passing point, > *(pt

[clang-tools-extra] b8c3715 - [clangd] Trim memory periodically when using glibc malloc

2020-12-21 Thread Sam McCall via cfe-commits
Author: Quentin Chateau Date: 2020-12-22T08:54:28+01:00 New Revision: b8c37153d5393aad96feefe0b4689b7b62bc160d URL: https://github.com/llvm/llvm-project/commit/b8c37153d5393aad96feefe0b4689b7b62bc160d DIFF: https://github.com/llvm/llvm-project/commit/b8c37153d5393aad96feefe0b4689b7b62bc160d.dif

[PATCH] D93452: [clangd] Trim memory periodically

2020-12-21 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb8c37153d539: [clangd] Trim memory periodically when using glibc malloc (authored by qchateau, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

2020-12-21 Thread David Blaikie via cfe-commits
oh, fair - I didn't stop to notice this was over in Clang/non-llvm-namespace'd code, so yeah, sounds good! On Mon, Dec 21, 2020 at 10:49 PM Sam McCall wrote: > Yeah. I don't actually know those details, the phab revision referenced > (should have been a URL, oops) is all I know. > > The new vers

<    1   2