[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93350/new/ https://reviews.llvm.org/D93350 ___ cfe-com

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits, thank you for the fix! Do you need me to commit on your behalf? (If so, are you okay with using `Emma Blink ` for patch attribution?)

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. In D92039#2458042 , @vsavchenko wrote: > That was a tough choice whether we should do it in the analyzer or not. > The analyzer check would've been easier in terms of existing infrastructure, > path sensitivity, and IPA. It

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

arphaman added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; It looks like the change on this line is fai

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 312256. tmroeder added a comment. Rebase to the latest head, mostly to force the CI infrastructure to run again now that it is said to work again: https://github.com/google/llvm-premerge-checks/issues/268#issuecomment-745979134. Repository: rG LLVM Gith

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:261-263 /// The inlining stack depth limit. - // Cap the stack depth at 4 calls (5 sta

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Thank you for the patch! Do you need me to commit on your behalf? If so, are you okay with `Tomas Matheson ` for patch attribution? ==

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; arphaman wrote: > It looks like the change o

[PATCH] D91444: [InstCombine] Preserve !annotation metadata for memory combines.

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. LGTM, nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91444/new/ https://reviews.llvm.org/D91444 __

[PATCH] D91444: [InstCombine] Preserve !annotation metadata for memory combines.

lebedev.ri accepted this revision. lebedev.ri added a comment. In D91444#2458024 , @fhahn wrote: > In D91444#2394512 , @lebedev.ri > wrote: > >> What about teaching IRBuilder to deal with it like it deals with debu

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258

[PATCH] D90275: [clang][IR] Add support for leaf attribute

xur added a comment. This breaks llvm/test/Bitcode/attributes.ll. The added test code was obviously wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 ___ cf

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

0x1eaf updated this revision to Diff 312272. 0x1eaf added a comment. Updated to address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93402/new/ https://reviews.llvm.org/D93402 Files: clang-tools-extra/test/clang-tidy/checkers/

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

0x1eaf added a comment. > Do you need me to commit on your behalf? Yes, I don't have commit access. The attribution line looks good to me. Thank you! 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93402/new/ https://reviews.llvm.org/D93402

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. > The problem in `llvm/test/Bitcode/attributes.ll` is clear? Instead of `define void @f70() nocallback`, it should be `define void @f69() nocallback`, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https:/

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

dexonsmith added a comment. In D83892#2458049 , @probinson wrote: > One thing this patch does, is make decisions about default behavior static. > Meaning, the option behavior cannot depend on other options; specifically, it > can't be based on the tripl

Re: [PATCH] D90275: [clang][IR] Add support for leaf attribute

yes. Also #43 should be #42 I fixed it in https://reviews.llvm.org/D92493 But that was just to make my test pass. On Wed, Dec 16, 2020 at 11:35 AM Gulfem Savrun Yeniceri via Phabricator < revi...@reviews.llvm.org> wrote: > gulfem added a comment. > > > The problem in `llvm/test/Bitcode/attributes

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

aaron.ballman added a comment. In D93110#2448587 , @vsavchenko wrote: > Right now, I reused existing `suppress` attribute. However I did it in a > rather unconventional manner. I allowed 0 arguments in one spelling and >1 > in another, which seems odd.

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. > I fixed it in > https://reviews.llvm.org/D92493 > But that was just to make my test pass. Ok, thank you! I did not realize that typo after the merge, and sorry about that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D902

[clang] 7685d81 - Mark implicit coroutine variables as being implicit

Author: Emma Blink Date: 2020-12-16T14:42:07-05:00 New Revision: 7685d818ef329cd3f6ef121af1208be409eb59db URL: https://github.com/llvm/llvm-project/commit/7685d818ef329cd3f6ef121af1208be409eb59db DIFF: https://github.com/llvm/llvm-project/commit/7685d818ef329cd3f6ef121af1208be409eb59db.diff LO

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

aaron.ballman closed this revision. aaron.ballman added a comment. In D93402#2458591 , @0x1eaf wrote: >> Do you need me to commit on your behalf? > > Yes, I don't have commit access. The attribution line looks good to me. Thank > you! 🙂 I've commit on yo

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

dexonsmith added a comment. In D83892#2458603 , @dexonsmith wrote: > Maybe it's worth defining another set of derived multiclasses, [...] Another possibility of course is to make `Bool*Option` work this way (removing the ChangedBy, ResetBy, DefaultsToTru

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

rsmith added a comment. @rnk Your thoughts on this would be appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91659/new/ https://reviews.llvm.org/D91659 ___ cfe-commits mailing list cfe-commits@

[clang] b9fb063 - [clang-offload-bundler] Add option -allow-missing-bundles

Author: Yaxun (Sam) Liu Date: 2020-12-16T14:52:39-05:00 New Revision: b9fb063e63c7959e8bc9b424bd34b266ca826826 URL: https://github.com/llvm/llvm-project/commit/b9fb063e63c7959e8bc9b424bd34b266ca826826 DIFF: https://github.com/llvm/llvm-project/commit/b9fb063e63c7959e8bc9b424bd34b266ca826826.dif

[PATCH] D93068: [clang-offload-bundler] Add option -allow-missing-bundles

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGb9fb063e63c7: [clang-offload-bundler] Add option -allow-missing-bundles (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://rev

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 312277. jdoerfert added a comment. Fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Parse/Parser.h clang/include/clan

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15752-15754 + bool AnonymousEnumEligible = getLangOpts().MSVCCompat && + (Kind == TTK_Enum) && + Tag->getDeclName().isEmpty()

[clang] 735ab86 - PR47474: Add test for Clang's current behavior.

Author: Richard Smith Date: 2020-12-16T12:01:00-08:00 New Revision: 735ab86b811e40f1533ced98dfc4b7a0c09c545b URL: https://github.com/llvm/llvm-project/commit/735ab86b811e40f1533ced98dfc4b7a0c09c545b DIFF: https://github.com/llvm/llvm-project/commit/735ab86b811e40f1533ced98dfc4b7a0c09c545b.diff

[PATCH] D93325: Add srcloc output to clang-query

aaron.ballman added a comment. Thank you for this, it looks really useful! Comment at: clang-tools-extra/clang-query/Query.cpp:94 +void dumpLocations(llvm::raw_ostream &OS, ast_type_traits::DynTypedNode node, + ASTContext &Ctx, const DiagnosticsEngine &Diags

[clang] e53b9f7 - Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

Author: Shivanshu Goyal Date: 2020-12-16T12:03:31-08:00 New Revision: e53b9f733a7cb0a5da372b73ab6b7711c0300d65 URL: https://github.com/llvm/llvm-project/commit/e53b9f733a7cb0a5da372b73ab6b7711c0300d65 DIFF: https://github.com/llvm/llvm-project/commit/e53b9f733a7cb0a5da372b73ab6b7711c0300d65.dif

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe53b9f733a7c: Print source location in the error message when parens are missing around… (authored by shivanshu3, committed by rsmith). Repository:

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. Looks like I missed the transition of my credentials from SVN from github, so I can't currently commit this. How do I go about getting those credentials restored? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

probinson added a comment. Thanks Duncan! I (or someone) will play around with that and see what we need to do. May take a little while, as we're about to freeze a release and then go on break for two weeks, but good to know there's a straightforward path. Repository: rG LLVM Github Monore

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2458715 , @tmroeder wrote: > Looks like I missed the transition of my credentials from SVN from github, so > I can't currently commit this. > > How do I go about getting those credentials restored? Never mind, I found

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

yonghong-song added a comment. We could enable ExtIntType in bpf backend. But we need some kernel changes related to BTF to accommodate the new types. Currently, the kernel uapi file (linux/include/uapi/linux/btf.h) defines #define BTF_INT_BITS(VAL) ((VAL) & 0x00ff) which means the

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman added a comment. In D92577#2445714 , @aaron.ballman wrote: > Ping Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 ___ cfe-commits mailing

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

trixirt added a comment. Yes, this change has problems, I will resubmit. There are many log function checks in checkpatch, and i need to write another one to find the unattibuted decls. I don't think adding linux specific warnings is -Wformat is needed, that doesn't scale with all the other pro

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added inline comments. Comment at: clang/include/clang/APINotes/APINotesWriter.h:1 +//===-- APINotesWriter.h - API Notes Writer -*- C++ -*-===// +// martong wrote: > How are we going to use this class? I mean what are the use cases t

[clang] b7905e8 - Fix split-debug.c test on Windows

Author: Reid Kleckner Date: 2020-12-16T13:48:57-08:00 New Revision: b7905e81fc3d7b045a5346442ce92ee87bdb7b21 URL: https://github.com/llvm/llvm-project/commit/b7905e81fc3d7b045a5346442ce92ee87bdb7b21 DIFF: https://github.com/llvm/llvm-project/commit/b7905e81fc3d7b045a5346442ce92ee87bdb7b21.diff

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

rnk added a comment. In D91659#2458639 , @rsmith wrote: > @rnk Your thoughts on this would be appreciated. I think it's important to make MIDL happy if we can. As to how to restructure the code to get there, I took a look, but wasn't able to come up with

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

seanyoung added a comment. Ok, I'll do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; kbobyrev wrote: > arphaman wrote: > > It lo

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6502 + // except that it has a non-trivial member *with* the trivial_abi attribute. + for (auto Base : D->bases()) { +if (auto CxxRecord = Base.getType()->getAsCXXRecordDecl()) It lo

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

rjmccall added a comment. Please test that there's actually an object declared and that it's not *just* a tag declaration. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 ___ cfe-commits mailing list

[clang] 150fe05 - [Test] Fix undef var in catch-undef-behavior.c

Author: Thomas Preud'homme Date: 2020-12-16T22:39:41Z New Revision: 150fe05db4417c3ed9e4470b7bbd1a6aee7fe505 URL: https://github.com/llvm/llvm-project/commit/150fe05db4417c3ed9e4470b7bbd1a6aee7fe505 DIFF: https://github.com/llvm/llvm-project/commit/150fe05db4417c3ed9e4470b7bbd1a6aee7fe505.diff

[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG150fe05db441: [Test] Fix undef var in catch-undef-behavior.c (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

rsmith added a comment. In D91659#2458872 , @rnk wrote: > In D91659#2458639 , @rsmith wrote: > >> > > What is the issue with the current structure, ActOnTag produces the wrong AST > node, an ElaboratedType, but we

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. I think that as long as the class leaves a copy/move constructor defaulted, there's no need for a new trivial_abi attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 __

[clang] f31e9bc - Test commit: add valid punctuation to a comment. NFC.

Author: Tom Roeder Date: 2020-12-16T15:33:19-08:00 New Revision: f31e9bcd73eb5f99256a19ae8ed958140ba58a42 URL: https://github.com/llvm/llvm-project/commit/f31e9bcd73eb5f99256a19ae8ed958140ba58a42 DIFF: https://github.com/llvm/llvm-project/commit/f31e9bcd73eb5f99256a19ae8ed958140ba58a42.diff LO

[clang] 1844ab7 - [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

Author: Tom Roeder Date: 2020-12-16T15:39:50-08:00 New Revision: 1844ab770cb9380a1896d83b1863b93766ffdf22 URL: https://github.com/llvm/llvm-project/commit/1844ab770cb9380a1896d83b1863b93766ffdf22 DIFF: https://github.com/llvm/llvm-project/commit/1844ab770cb9380a1896d83b1863b93766ffdf22.diff LO

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1844ab770cb9: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes. (authored by tmroeder). Repository: rG LLVM Github Monorepo

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 312327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[clang-tools-extra] ddffcdf - [clang-tidy] Add a diagnostic callback to parseConfiguration

Author: Nathan James Date: 2020-12-17T00:24:58Z New Revision: ddffcdf0a6603747a6734dcf23dfe81476b5523c URL: https://github.com/llvm/llvm-project/commit/ddffcdf0a6603747a6734dcf23dfe81476b5523c DIFF: https://github.com/llvm/llvm-project/commit/ddffcdf0a6603747a6734dcf23dfe81476b5523c.diff LOG:

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddffcdf0a660: [clang-tidy] Add a diagnostic callback to parseConfiguration (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

steplong created this revision. Herald added subscribers: danielkiss, kristof.beyls. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Generate the .note.gnu.property section with GNU_PROPERTY_AARCH64_FEATURE_1_BTI when compiling ass

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. So the intention here is to generate the property when BTI branch protection is enabled, to guarantee the generate .o indeed has the property set, without requiring to pass the flag -mmark-bti-property explicitly. This is convenient for users. Or is there a clear reason

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy updated this revision to Diff 312339. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ https://reviews.llvm.org/D93264 Files: clang/test/CodeGen/pseudo-probe-emit.c llvm/include/llvm/IR/IntrinsicInst.

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu updated this revision to Diff 312348. zequanwu marked 2 inline comments as done. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 Files: clang/include/c

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3438-3439 } + if (DeclOrStmt) +DiagList.push_back("statements"); } aaron.ballman wrote: > I think this will do the wrong thing when the subject list has

[PATCH] D93436: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Currently warnings when parsing .

[clang] 2e6e4e6 - [OpenMP] Add initial support for `omp [begin/end] assumes`

Author: Johannes Doerfert Date: 2020-12-16T20:02:49-06:00 New Revision: 2e6e4e6aeef71dd8fba038177a34a82b574d2126 URL: https://github.com/llvm/llvm-project/commit/2e6e4e6aeef71dd8fba038177a34a82b574d2126 DIFF: https://github.com/llvm/llvm-project/commit/2e6e4e6aeef71dd8fba038177a34a82b574d2126.d

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

arphaman added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; sammccall wrote: > kbobyrev wrote: > > arpha

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

jdoerfert added a comment. Thanks for continuing to work on this. Change the commit message as it is working for non integer types now, just not for "too many". Some more comments below. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:119 ///

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

emaste added a comment. > I think it's ok to only warn on Windows. IMO that's sensible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing li

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1001 + "LangOpts->AccessControl", DefaultsToTrue, + ChangedBy, + ResetBy>; `ChangedBy` are a bit verbose. How about a shorthand for this most common form? Repository: rG LLVM

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. > I think that as long as the class leaves a copy/move constructor defaulted, > there's no need for a new trivial_abi attribute. Sorry, I'm not sure I follow. Could you elaborate a bit or provide an example? What do you mean by "new" trivial_abi attribute? Repositor

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6502 + // except that it has a non-trivial member *with* the trivial_abi attribute. + for (auto Base : D->bases()) { +if (auto CxxRecord = Base.getType()->getAsCXXRecordDecl()) ahat

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6502 + // except that it has a non-trivial member *with* the trivial_abi attribute. + for (auto Base : D->bases()) { +if (auto CxxRecord = Base.getType()->getAsCXXRecordDecl()) zoeca

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6502 + // except that it has a non-trivial member *with* the trivial_abi attribute. + for (auto Base : D->bases()) { +if (auto CxxRecord = Base.getType()->getAsCXXRecordDecl()) ahat

[clang] c70f368 - Use basic_string::find(char) instead of basic_string::find(const char *s, size_type pos=0)

Author: Fangrui Song Date: 2020-12-16T23:28:32-08:00 New Revision: c70f36865e040840f4c4a82108f5e356d92a2923 URL: https://github.com/llvm/llvm-project/commit/c70f36865e040840f4c4a82108f5e356d92a2923 DIFF: https://github.com/llvm/llvm-project/commit/c70f36865e040840f4c4a82108f5e356d92a2923.diff

[PATCH] D68410: [AttrDocs] document always_inline

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 ___

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. In D92361#2459513 , @zoecarver wrote: >> I think that as long as the class leaves a copy/move constructor defaulted, >> there's no need for a new trivial_abi attribute. > > Sorry, I'm not sure I follow. Could you elaborate a bit

<    1   2