[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism created this revision. swamulism added a reviewer: aeubanks. swamulism requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently there is an issue where the legacy pass manager uses a different OptBisect counter

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

xur accepted this revision. xur added a comment. Sorry to the late response (I somehow missed the reply). (1) Can we add some comments to explain the reason for enabling this for -Oz -- I think the comments from @rnk is useful to some people (at least to me). (2) Also please add a testcase. Fe

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 310387. ahatanak marked 2 inline comments as done. ahatanak edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/lib/CodeG

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2328 + CGF.CGM.getTarget().getTriple().isAArch64() && + !CGF.CGM.getTarget().getTriple().isOSWindows()) { +auto *callBase = cast(value); rjmccall wrote: > It would be good to e

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

yaxunl added a comment. LGTM. Can we have a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92893/new/ https://reviews.llvm.org/D92893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] 5207f19 - ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-08T17:33:19-08:00 New Revision: 5207f19d103dc3e0ec974fa64d2c031d84d497a8 URL: https://github.com/llvm/llvm-project/commit/5207f19d103dc3e0ec974fa64d2c031d84d497a8 DIFF: https://github.com/llvm/llvm-project/commit/5207f19d103dc3e0ec974fa64d2c031d84d4

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5207f19d103d: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC (authored by dexonsmith). Changed prior to commit: https://revi

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310394. tmroeder edited the summary of this revision. tmroeder added a comment. Added C++ tests for result-dependent uses, and added that fact to the description as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder marked 2 inline comments as done. tmroeder added inline comments. Comment at: clang/test/ASTMerge/generic-selection-expr/Inputs/generic.c:1 +void f() { + int x; aaron.ballman wrote: > Should we also have a C++ test for a result-dependent use of _Generic

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

This revision was automatically updated to reflect the committed changes. Closed by commit rG75cd8d756d6e: Support: Add RedirectingFileSystem::create from simple list of redirections (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D91317?vs=304702&id=310398#toc Repo

[clang] 2878e96 - Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-12-08T18:10:53-08:00 New Revision: 2878e965af27ce037378a4f0409e89039108c09f URL: https://github.com/llvm/llvm-project/commit/2878e965af27ce037378a4f0409e89039108c09f DIFF: https://github.com/llvm/llvm-project/commit/2878e965af27ce037378a4f0409e89039108

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

This revision was automatically updated to reflect the committed changes. dexonsmith marked an inline comment as done. Closed by commit rG2878e965af27: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added a comment. Thanks for looking into this! Can you upload the diff with full context (e.g. use `diff -U ` or use arcanist to upload)? Comment at: clang/lib/CodeGen/BackendUtil.cpp:1153 + // Sets legacy pass manager OptBisect to the same one as npm so passes

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith added a comment. Thanks for the reviews! Pushed 2878e965af27ce037378a4f0409e89039108c09f . Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +ret

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added a comment. Oh and in the description > This means that when using OptBisect under the NPM it runs twice when it > should only run once. doesn't really make sense. I'd say something like > e.g. -opt-bisect-limit=1 will run both the first optional optimization pass > and the firs

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 updated this revision to Diff 310401. psionic12 added a comment. Fix grammar Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 Files: clang/examples/Attribute/Attribute.cpp

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

dexonsmith added a comment. This seems fine to me, I agree this option doesn't need to be present all the time. Thanks for clarifying that `-triple` is still there. @Bigcheese, WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https:

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > (One idea we've been playing with is that traversal of the AST usually goes > through TranslationUnitDecls::decls_begin(), which triggers loading from the > preamble. We could add a stateful flag to DeclContext that causes this to > behave like noload_decls_begin in

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 310416. aorlov added a comment. Simplify the patch. @Quuxplusone, Actually you've pushed me to some thinking of what more syntactic cases it could be. And I came to that we can get rid of this hack and simplify the patch pretty much. Hope, this fix will be mo

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:18 +// RUN: %clang -### -target x86_64-linux-gnu -c %s -gdwarf-5 -gembed-source 2>&1 | FileCheck %s --check-prefix=DWARF-CLAMP +// CHECK: debug information option '{{-gz|-fdebug-info

Buildbot to listen main branch

Hello everyone, To follow the main branch creation I'm going to update the buildbot to listen for the changes in this branch and instruct all the workers to checkout this branch. No work is required on the workers. Please check your annotated scripts to make sure it accepts the branch name from

[PATCH] D92915: [Driver] Add -f[no-]new-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay created this revision. MaskRay added reviewers: aeubanks, reames, rsmith. Herald added subscribers: dang, steven_wu, hiraditya. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new PM is considered stable and many downstr

[PATCH] D92917: [Driver] Pass -plugin-opt=no-new-pass-manager to the linker

MaskRay created this revision. MaskRay added reviewers: aeubanks, asbirlea, ychen. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So that if -fno-new-pass-manager is requested for an -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=on build,

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

hliao added a comment. LGTM if there's a regression test available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92893/new/ https://reviews.llvm.org/D92893 ___ cfe-commits mailing list cfe-commits@lists

[clang] cf2bb22 - [clang][cli] CompilerInvocationTest: join two test fixtures into one

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: cf2bb2239252c0e1970e646308ae6fb552fcb002 URL: https://github.com/llvm/llvm-project/commit/cf2bb2239252c0e1970e646308ae6fb552fcb002 DIFF: https://github.com/llvm/llvm-project/commit/cf2bb2239252c0e1970e646308ae6fb552fcb002.diff L

[clang] f825ec8 - [clang][cli] CompilerInvocationTest: rename member variable in fixture

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: f825ec86e14b1369a9edf382d65259351eae679e URL: https://github.com/llvm/llvm-project/commit/f825ec86e14b1369a9edf382d65259351eae679e DIFF: https://github.com/llvm/llvm-project/commit/f825ec86e14b1369a9edf382d65259351eae679e.diff L

[clang] 5afff86 - [clang][cli] CompilerInvocationTest: split enum test into two

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 5afff86d26163bc3ba93fb299ccfc2522d3fdc94 URL: https://github.com/llvm/llvm-project/commit/5afff86d26163bc3ba93fb299ccfc2522d3fdc94 DIFF: https://github.com/llvm/llvm-project/commit/5afff86d26163bc3ba93fb299ccfc2522d3fdc94.diff L

[clang] 4894e42 - [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 4894e423e7b4b121bd4fb23cdba9870ff0f2a6b6 URL: https://github.com/llvm/llvm-project/commit/4894e423e7b4b121bd4fb23cdba9870ff0f2a6b6 DIFF: https://github.com/llvm/llvm-project/commit/4894e423e7b4b121bd4fb23cdba9870ff0f2a6b6.diff L

[clang] 03692ba - [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 03692bae1fc9b6232de7caea3b57ad2f3dc2a9d0 URL: https://github.com/llvm/llvm-project/commit/03692bae1fc9b6232de7caea3b57ad2f3dc2a9d0 DIFF: https://github.com/llvm/llvm-project/commit/03692bae1fc9b6232de7caea3b57ad2f3dc2a9d0.diff L

[clang] 216d430 - [clang][cli] CompilerInvocationTest: join and add test cases

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 216d43053b4e7327e5f9eb5705a7c8e4f6ae850b URL: https://github.com/llvm/llvm-project/commit/216d43053b4e7327e5f9eb5705a7c8e4f6ae850b DIFF: https://github.com/llvm/llvm-project/commit/216d43053b4e7327e5f9eb5705a7c8e4f6ae850b.diff L

[PATCH] D92825: [clang][cli] CompilerInvocationTest: join two test fixtures into one

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2bb2239252: [clang][cli] CompilerInvocationTest: join two test fixtures into one (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] 35621cc - [clang][cli] CompilerInvocationTest: add tests for boolean options

Author: Jan Svoboda Date: 2020-12-09T08:58:46+01:00 New Revision: 35621cc2e3b3778abc2bacf37f3b1e9dfac52895 URL: https://github.com/llvm/llvm-project/commit/35621cc2e3b3778abc2bacf37f3b1e9dfac52895 DIFF: https://github.com/llvm/llvm-project/commit/35621cc2e3b3778abc2bacf37f3b1e9dfac52895.diff L

[PATCH] D92826: [clang][cli] CompilerInvocationTest: rename member variable in fixture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf825ec86e14b: [clang][cli] CompilerInvocationTest: rename member variable in fixture (authored by jansvoboda11). Repository: rG LLVM Github Monore

<    1   2   3