[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc updated this revision to Diff 309932. mibintc added a comment. ready for review, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGe

[clang] 1b734c6 - [Parse] Delete unused declarations

Author: Fangrui Song Date: 2020-12-07T08:46:17-08:00 New Revision: 1b734c662bd92c5ae065667fee7e11cff1e1f190 URL: https://github.com/llvm/llvm-project/commit/1b734c662bd92c5ae065667fee7e11cff1e1f190 DIFF: https://github.com/llvm/llvm-project/commit/1b734c662bd92c5ae065667fee7e11cff1e1f190.diff

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc added a comment. In D92721#2436917 , @mibintc wrote: > I'm going to make further changes to this patch, it's not working as desired. that was a false alarm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D68410: [AttrDocs] document always_inline

aaron.ballman added a comment. LGTM aside from the minor wording nit from @ojeda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 ___ cfe-commits mailing list cfe

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 309934. ckennelly added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clan

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 309936. ckennelly edited the summary of this revision. ckennelly added a comment. updating commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: cla

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2436639 , @hokein wrote: > thanks, I think this patch is good, feel free to land it (and sorry for the > delay). > > As @lebedev.ri commented, would be nice to mention the motivation of the > change (`make_shared_for_

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

aaron.ballman added a comment. I have some quick drive-by comments but still have to think about the test cases a bit more. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:74 +// the BlockStmt. It does this by checking the following: +//

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 309939. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/ContinuationIndenter.cpp clang/l

[PATCH] D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong requ

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_IN

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. You should add some frontend Sema tests for the attribute. The usual tests are: correct usage without diagnostics (as both a declaration attribute and a type attribute), applying

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong added a comment. Ping. @teemperor please take a look if you have some time. This is a really important patch which may influence some future directions regarding the ASTImporter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92209/new/ htt

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

teemperor added a comment. In D92209#2437416 , @martong wrote: > Ping. > @teemperor please take a look if you have some time. This is a really > important patch which may influence some future directions regarding the > ASTImporter. Apologies, last week

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

aaron.ballman added a comment. There are a couple of questions from the previous iteration of the review that aren't answered yet: - the diagnostic wording doesn't actually say what's wrong with the code or how to fix it; how should users silence the diagnostic if they've found a case where it

[PATCH] D92773: [clang][cli] Unify boolean marshalling

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Use lambdas with captures to replace th

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. Ugh, i really hate that inline comments aren't submitted upon uploading the new diff, it catches me off-guard each time... Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:40 "misc-new-delete-overloads"); +CheckFactories

[PATCH] D92774: [clang][cli] Add command line marshalling tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add more tests of the command line marshalling infrastructure. The new tests now make a "

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_IN

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces more flexible multiclas

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

eugenis accepted this revision. eugenis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92727/new/ https://reviews.llvm.org/D92727 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:979 +ContinuationIndent += Style.ContinuationIndentWidth; const FormatToken *PreviousNonComment = Current.getPreviousNonComment(); const FormatToken *NextNonComment = Previous.ge

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added a comment. Also how does this relate to the `AfterStruct` setting? bool AfterStruct Wrap struct definitions. true: struct foo { int x; }; false: struct foo { int x; }; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://re

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial

eugenis added a comment. Don't you want to similarly align down PoisonEnd? But if this is something that should never happen, as your comment rightly suggests, wouldn't it be better to add an assert()? The same in the case when PoisonSize < 0 - it should never happen. Repository: rG LLVM Git

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoIntToPtrCheck.cpp:26 + const auto *MatchedCast = Result.Nodes.getNodeAs("x"); + diag(MatchedCast->getBeginLoc(), "avoid integer to pointer casts"); +} lebedev.ri wrote: > aaron

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added a comment. What does `the behavior goes wrong` mean? why can't it be left aligned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91245/new/ https://reviews.llvm.org/D91245 ___ cfe-co

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[clang] fd14a27 - [Sema] Make more overload candidate types use iterator_ranges (NFC)

Author: Richard Sandiford Date: 2020-12-07T18:34:53Z New Revision: fd14a2753368bc13468d6207daccba1c45ce79e6 URL: https://github.com/llvm/llvm-project/commit/fd14a2753368bc13468d6207daccba1c45ce79e6 DIFF: https://github.com/llvm/llvm-project/commit/fd14a2753368bc13468d6207daccba1c45ce79e6.diff

[PATCH] D92222: [Sema] Make more overload candidate types use iterator_ranges (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd14a2753368: [Sema] Make more overload candidate types use iterator_ranges (NFC) (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jwakely added a comment. In D87974#2436169 , @BillyONeal wrote: > The name MSFT is already shipping in production is > `__builtin_zero_non_value_bits`. If gcc is already shipping another name in > production I think clang is stuck supporting both names,

[PATCH] D90238: Update to D31635

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2832 (!Left.is(TT_PointerOrReference) || - (Style.PointerAlignment != FormatStyle::PAS_Right && + (getTokenPointerAlignment(Left) != FormatStyle::PAS_Right && !Line.I

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. Entry 0 is the address that should be passed to the kernel (for the captured variable, that's why it is marked as TGT_TARGET_PARAM - target kernel argument), entries 1-3 are the actual mappings. Yes, I assume the frontend can fuse these entries in many cases, but it is

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

MyDeveloperDay added a comment. Looks almost there, just a few nits really Comment at: clang/docs/ClangFormatStyleOptions.rst:2316 +**ReferenceAlignment** (``ReferenceAlignmentStyle``) + Reference alignment style (overrides ``PointerAlignment`` for Did you g

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

MyDeveloperDay added a comment. @catskul I'm really sorry this disappeared into the ether because it was missing the project and any real reviewers, I tend to go back now and again and do a search for "Lost" clang format reviews and stumbled on this one, hopefully this will bring it to the fore

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

adamcz updated this revision to Diff 309958. adamcz marked 2 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92408/new/ https://reviews.llvm.org/D92408 Files: clang-tools-e

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

adamcz added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92408/new/ https://reviews.llvm.org/D92408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] f8d5b49 - Fix missing error for use of 128-bit integer inside SPIR64 device code.

Author: Jennifer Yu Date: 2020-12-07T10:42:32-08:00 New Revision: f8d5b49c786f5766aa89b59606bd4c4ae10b46f6 URL: https://github.com/llvm/llvm-project/commit/f8d5b49c786f5766aa89b59606bd4c4ae10b46f6 DIFF: https://github.com/llvm/llvm-project/commit/f8d5b49c786f5766aa89b59606bd4c4ae10b46f6.diff L

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

tra added a comment. `-E` by default prints preprocessed output to stdout. CUDA will print preprocessed output from all subcompilations. What does HIP do in this case? Printing out the bundle is probably not what the user will expect. IMO preprocessed output is frequently used as a debugging too

[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

MyDeveloperDay added a comment. I'm a little confused between BestFit and Compact I'm not a massive fan of changing unit tests, just saying. Comment at: clang/docs/ClangFormatStyleOptions.rst:1473 -**ConstructorInitializerAllOnOneLineOrOnePerLine** (``bool``) - If the const

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 309959. aorlov added a comment. Added test cases for explicit instantiations. > @Quuxplusone, > In particular, I'm very interested to know if P0692 is intended to have any > effect on the legality of https://godbolt.org/z/fqfo8q I've checked your particular

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > gulfem wrote: > > gulfem wrote: > > > aaron

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

dblaikie added inline comments. Herald added a subscriber: hoy. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1)

Re: [PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

From: David Blaikie via Phabricator Sent: Monday, December 7, 2020 11:08 AM To: Alexander Yermolovich ; llvm-comm...@lists.llvm.org Cc: Hongtao Yu ; jan_svob...@apple.com ; steve...@apple.com ; dany.grumb...@gmail.com ; Wenlei He ; dexonsm...@apple.com ; cfe-

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

Quuxplusone added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:172 + + // TODO. This can produce wrong detection in case of a later class + // declaration. Example: I don't know the purpose of this code, but this //seems// like a super import

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

cchen added a comment. Just tried this patch and found that below test abort inside `generateInfoCapture`. #include #define LEN 100 int buf[LEN]; int main() { int i; int *p = buf; for (i = 0; i < LEN; i++) { p[i] = 0; } #pragma omp target m

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2437676 , @cchen wrote: > Just tried this patch and found that below test abort inside > `generateInfoCapture`. > > #include > #define LEN 100 > int buf[LEN]; > > int main() > { > int i; > int *

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. @njames93: Any additional comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

aaron.ballman added a comment. Is there a way to add test coverage for this to demonstrate that we handle what YAML considers a Boolean and that we don't allow oddities? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm

[clang] 3ce78f5 - [analyzer] Ignore annotations if func is inlined.

Author: Yu Shan Date: 2020-12-07T11:28:11-08:00 New Revision: 3ce78f54edcfc881377a9e567715caf2f0be2abc URL: https://github.com/llvm/llvm-project/commit/3ce78f54edcfc881377a9e567715caf2f0be2abc DIFF: https://github.com/llvm/llvm-project/commit/3ce78f54edcfc881377a9e567715caf2f0be2abc.diff LOG:

[PATCH] D91902: [analyzer] Ignore annotations if func is inlined.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ce78f54edcf: [analyzer] Ignore annotations if func is inlined. (authored by aabbaabb, committed by haowei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 1c98f98 - Stop ExtractTypeForDeductionGuide from recursing on TypeSourceInfo

Author: Erich Keane Date: 2020-12-07T11:29:57-08:00 New Revision: 1c98f984105e552daa83ed8e92c61fba0e401410 URL: https://github.com/llvm/llvm-project/commit/1c98f984105e552daa83ed8e92c61fba0e401410 DIFF: https://github.com/llvm/llvm-project/commit/1c98f984105e552daa83ed8e92c61fba0e401410.diff L

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 309971. nickdesaulniers added a comment. s/MSDN/Microsoft Docs/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 Files: clang/include/clang/Basic/Attr.td cla

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

Quuxplusone added a comment. Peanut gallery says: It seems to me that your root problem here is that `co_yield` is not being recognized by the parser as a keyword, and so you're seeing e.g. `co_yield* p;` the same way you'd see `CoYield* p;`. But in that case, you should also be seeing `co_yield

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. @lebedev.ri would you mind re-reviewing when you have a chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 ___

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2366 +/// Matches C11 _Generic expression. +extern const internal::VariadicDynCastAllOfMatcher +genericSelectionExpr; Do we have a use case for adding this as an AS

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri updated this revision to Diff 309976. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressing review notes: - s/inttoptr/int-to-ptr/ - Adjust diagnostic to be more descriptive of the problem Repository: rG LLVM

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

nickdesaulniers added a comment. In D90271#2436080 , @SolarAquarion wrote: > You missed a change https://bugs.llvm.org/show_bug.cgi?id=48413 Discussed off thread; Arch Linux has patches on top of their distribution of LLVM. Repository: rG LLVM Githu

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

luismarques updated this revision to Diff 309981. luismarques added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91270/new/ https://reviews.llvm.org/D91270 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309983. dgoldman added a comment. Swap to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/un

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

njames93 updated this revision to Diff 309985. njames93 added a comment. Refactored based on changes to parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm.org/D92756 Files: clang-tools-extra/clang-tidy/ClangTid

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309987. dgoldman added a comment. Add protocol test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D92782: [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

bader created this revision. bader added reviewers: rjmccall, yaxunl. Herald added subscribers: ebevhan, t-tye, tpr, dstuttard, kzhuravl. bader requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo http

[clang] dc361d5 - [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

Author: Nathan James Date: 2020-12-07T20:20:08Z New Revision: dc361d5c2a2dd34839ff4cd48844cf1bf9a87c62 URL: https://github.com/llvm/llvm-project/commit/dc361d5c2a2dd34839ff4cd48844cf1bf9a87c62 DIFF: https://github.com/llvm/llvm-project/commit/dc361d5c2a2dd34839ff4cd48844cf1bf9a87c62.diff LOG:

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc361d5c2a2d: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D92480?vs=309730&id=309989#toc Repository: rG LLV

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I messed around with qualified name changes - lots of things internally rely upon the qualified names so that will be best for a separate change. I could potentially handle `DocumentSymbol` fixes in here though - LMK if you think it makes sense to move some of this log

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

luismarques updated this revision to Diff 309991. luismarques added a comment. Add float Complex case, for regression test completeness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 Files: clang/lib/Co

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks marked 6 inline comments as done. HazardyKnusperkeks added a comment. In D92257#2435906 , @lebedev.ri wrote: > In D92257#2435902 , @MyDeveloperDay > wrote: > >> In D92257#2435899

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks like GCC has changed the semantics here despite the backwards compatibility break - as much as I'd rather not break backwards compatibility it's probably best on balance to maintain

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4596 + IRFuncTy->getParamType(FirstIRArg)); +} + bader wrote: > bader wrote: > > rjmccall wrote: > > > This seems problematic; code like this

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

erichkeane added a comment. From my perspective I think this is right... I don't feel comfortable approving this however until someone from OpenCL/OpenMP takes a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.o

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4031 +else + CmdArgs.push_back("-gdwarf64"); + } Use `render` (see other `render` in the file) Comment at: clang/test/Driver/debug-options.c:379 +// +//

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

lebedev.ri added a comment. In D92257#2437918 , @HazardyKnusperkeks wrote: > In D92257#2435906 , @lebedev.ri > wrote: > >> In D92257#2435902 , @MyDeveloperDay >> wrote: >>

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc added a comment. There are many RuntimeCalls that are created in Clang, including _read_pipe, all the OpenMP runtime calls, etc. Shall they all have their calling conventions set from the ABIInfo? Currently those calls are being set to 0. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as not done. gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[clang] 98f76ad - Add new 'preferred_name' attribute.

Author: Richard Smith Date: 2020-12-07T12:53:07-08:00 New Revision: 98f76adf4e941738c0b9fe3b9965fa63603e9c89 URL: https://github.com/llvm/llvm-project/commit/98f76adf4e941738c0b9fe3b9965fa63603e9c89 DIFF: https://github.com/llvm/llvm-project/commit/98f76adf4e941738c0b9fe3b9965fa63603e9c89.diff

[PATCH] D91311: Add new 'preferred_name' attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98f76adf4e94: Add new 'preferred_name' attribute. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D91311?vs=307496&id=3099

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

cchen added a comment. Below test asserts inside `generateInfoForComponentList`: Assertion failed: (!IsPointer && "Unexpected base element with the pointer type."), function generateInfoForComponentList, file /Users/cchen/workspace/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp, line 775

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options.c:390 +// GDWARF64_OFF: error: invalid argument '-gdwarf64' only allowed with 'DWARFv3 or greater' +// GDWARF64_32ARCH: error: invalid argument '-gdwarf64' only allowed with '64 bit architecture' --

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:62-72 +static AMDGPUSubtarget::Generation initializeGen(const Triple &TT, + StringRef GPU) { + if (GPU.contains("generic")) { +return TT.get

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4029 + D.Diag(diag::err_drv_argument_only_allowed_with) + << A->getAsString(Args) << "elf output format"; +else "elf output format" -> "ELF platforms" ELF is usual

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 310003. bader added a comment. Move CodeGen crash fix to a separate review request: https://reviews.llvm.org/D92782 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 310006. aguinet marked 3 inline comments as done. aguinet added a comment. Multiple things: - remove clang-format tags - remove const usage - enhanced attribute documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. Thanks @aaron.ballman for the comments! I fixed all your comments in the new patch. I will upload a new one with the Sema tests! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 __

[clang] 3e1cb0d - [CodeGen][MSan] Don't use offsets of zero-sized fields

Author: Vitaly Buka Date: 2020-12-07T13:37:40-08:00 New Revision: 3e1cb0db8a79b19996fcea210b639fe513a5eaf3 URL: https://github.com/llvm/llvm-project/commit/3e1cb0db8a79b19996fcea210b639fe513a5eaf3 DIFF: https://github.com/llvm/llvm-project/commit/3e1cb0db8a79b19996fcea210b639fe513a5eaf3.diff L

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e1cb0db8a79: [CodeGen][MSan] Don't use offsets of zero-sized fields (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

lenary accepted this revision. lenary added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

lenary accepted this revision. lenary added a comment. LGTM! Please land these tonight so we can have them backported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91270/new/ https://reviews.llvm.org/D91270 ___

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

vitalybuka added a comment. In D92728#2437506 , @eugenis wrote: > Don't you want to similarly align down PoisonEnd? > > But if this is something that should never happen, as your comment rightly > suggests, wouldn't it be better to add an assert()? > The

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

fhahn added a comment. I think this also fixes https://bugs.llvm.org/show_bug.cgi?id=47397 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 ___ cfe-commits mailing

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra updated this revision to Diff 310019. tra added a comment. Updated to address the comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D92617 Files: clang/include/clang/Basic/DiagnosticDriverKinds

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan added a comment. Sorry. I accidentally missed this in my emails. Will commit these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 ___ cfe-commits ma

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. SmallVector with def

<    1   2   3   >