[clang] 9ae0a46 - ARCMigrate: Initialize fields in EditEntry inline, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:43:22-08:00 New Revision: 9ae0a46f2bbff5c0eb962c5a6225a2b469d1802f URL: https://github.com/llvm/llvm-project/commit/9ae0a46f2bbff5c0eb962c5a6225a2b469d1802f DIFF: https://github.com/llvm/llvm-project/commit/9ae0a46f2bbff5c0eb962c5a6225a2b469d1

[PATCH] D92597: ARCMigrate: Initialize fields in EditEntry inline, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae0a46f2bbf: ARCMigrate: Initialize fields in EditEntry inline, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92597/new/ http

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

amyk added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1427 + if (Target.getTriple().isPPC64() && + Target.hasFeature("paired-vector-memops")) { +if (Target.hasFeature("mma")) { Is it better to do `hasFeature()` over `PairedVectorMemops` a

[clang] b4f4fc6 - ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:45:59-08:00 New Revision: b4f4fc6872fbe4e296d3270d297a0e4afbda6670 URL: https://github.com/llvm/llvm-project/commit/b4f4fc6872fbe4e296d3270d297a0e4afbda6670 DIFF: https://github.com/llvm/llvm-project/commit/b4f4fc6872fbe4e296d3270d297a0e4afbda

[PATCH] D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f4fc6872fb: ASTImporter: Migrate to the FileEntryRef overload of SourceManager… (authored by dexonsmith). Repository: rG LLVM Github Monorepo C

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Just a minor comment but LGTM overall. Comment at: llvm/test/CodeGen/PowerPC/paired-vector-intrinsics.ll:15 + +; This test is to check that the paired vector intrinsics

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92661: [RFC] Fix TLS and Coroutine

lxfind added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + hoy wrote: > lxfind wrote: > > hoy wrote: > > > hoy

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[clang] 6333871 - Add diagnostic for for-range-declaration being specificed with thread_local

Author: shafik Date: 2020-12-04T15:06:35-08:00 New Revision: 6333871f85403d07abc62fdb6182f288ff60ccd8 URL: https://github.com/llvm/llvm-project/commit/6333871f85403d07abc62fdb6182f288ff60ccd8 DIFF: https://github.com/llvm/llvm-project/commit/6333871f85403d07abc62fdb6182f288ff60ccd8.diff LOG: A

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

This revision was automatically updated to reflect the committed changes. Closed by commit rG6333871f8540: Add diagnostic for for-range-declaration being specificed with thread_local (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

rengolin added inline comments. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocName<"M68k">; def m_mips_Features_Group : OptionGroup<"">, craig.topper wrote: > bruno wrot

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay updated this revision to Diff 309675. MaskRay marked 6 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Pre-committed test improvement in 190b4374c00a9cf090ea73f9eddf3d8f71b11ec8

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay added inline comments. Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:4-5 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared %s -o %dynamiclib1 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared %s -o %dynamiclib2 +// RUN: %clangxx_asan

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[clang] d126943 - Index: Remove unused internal header SimpleFormatContext.h, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T15:10:27-08:00 New Revision: d126943251d0cd77e572bced5ab6c23595acd468 URL: https://github.com/llvm/llvm-project/commit/d126943251d0cd77e572bced5ab6c23595acd468 DIFF: https://github.com/llvm/llvm-project/commit/d126943251d0cd77e572bced5ab6c23595ac

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92699: Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Add a `FileEntryRef` overload of `SourceManager::translateFile`, and migrate `ParseD

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:235-239 + for (const auto &Opt : Options) { +std::string Val = HNOption.General.lookup(Opt.first); +if (Val.empty()) + HNOption.General.insert({Opt.first,

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 309682. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebased, s/Inline/Inlining/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers added a comment. Sorry, I should not have waiting this long to update this patch... Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline";

[PATCH] D92704: [clangd] Publish config file errors over LSP

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We don't act as a language server for these files (e.g. don't get ope

[PATCH] D92704: [clangd] Publish config file errors over LSP

sammccall updated this revision to Diff 309688. sammccall added a comment. Handle diagnostics without a filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92704/new/ https://reviews.llvm.org/D92704 Files: clang-tools-extra/clangd/ClangdServe

[PATCH] D68410: [AttrDocs] document always_inline

jdoerfert added a comment. LGTM Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline"; nickdesaulniers wrote: > lebedev.ri wrote: > > jdoerfert wrote:

[clang] 03dcd57 - [clang] add a new `swift_attr` attribute

Author: Alex Lorenz Date: 2020-12-04T15:53:24-08:00 New Revision: 03dcd57ecf99b31021644b868cae422897d520f8 URL: https://github.com/llvm/llvm-project/commit/03dcd57ecf99b31021644b868cae422897d520f8 DIFF: https://github.com/llvm/llvm-project/commit/03dcd57ecf99b31021644b868cae422897d520f8.diff L

[clang] eddd1d1 - [clang] add a `swift_async_name` attribute

Author: Alex Lorenz Date: 2020-12-04T15:55:29-08:00 New Revision: eddd1d192bcaf11e449b34a3a569b85eb390e4f2 URL: https://github.com/llvm/llvm-project/commit/eddd1d192bcaf11e449b34a3a569b85eb390e4f2 DIFF: https://github.com/llvm/llvm-project/commit/eddd1d192bcaf11e449b34a3a569b85eb390e4f2.diff L

[clang] db226cd - [objc] diagnose protocol conformance in categories with direct members

Author: Alex Lorenz Date: 2020-12-04T15:55:34-08:00 New Revision: db226cdf4cf91f350267da1a5b95dda42dd23413 URL: https://github.com/llvm/llvm-project/commit/db226cdf4cf91f350267da1a5b95dda42dd23413 DIFF: https://github.com/llvm/llvm-project/commit/db226cdf4cf91f350267da1a5b95dda42dd23413.diff L

[PATCH] D92354: [clang] add a new `swift_attr` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG03dcd57ecf99: [clang] add a new `swift_attr` attribute (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm

[PATCH] D92355: [clang] add a `swift_async_name` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGeddd1d192bca: [clang] add a `swift_async_name` attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D92355?vs=309582&id=309690#toc Repository: rG LLVM Github Monorepo

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb226cdf4cf9: [objc] diagnose protocol conformance in categories with direct members (authored by arphaman). Repository: rG LLVM Github Monorepo

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[clang] 5e953a2 - [RISCV] Define preprocessor definitions for 'V' extension.

Author: Hsiangkai Wang Date: 2020-12-05T08:34:32+08:00 New Revision: 5e953a274b2ada5bfa54b3d765e391abb03f474f URL: https://github.com/llvm/llvm-project/commit/5e953a274b2ada5bfa54b3d765e391abb03f474f DIFF: https://github.com/llvm/llvm-project/commit/5e953a274b2ada5bfa54b3d765e391abb03f474f.diff

[PATCH] D92650: [RISCV] Define preprocessor definitions for 'V' extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e953a274b2a: [RISCV] Define preprocessor definitions for 'V' extension. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92650/new/ h

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

dblaikie added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: njames93 wrote: > dblaikie wrote: > > Are there many uses that rely on this? I don't think i

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/test/Driver/debug-options.c:364-366 +// GEMBED_2: warning: debug information option '-gembed-source' is not supported for target // NOGEMBED_5-NOT: "-gembed-source" +// NOGEMBED_2-NOT: warning: debug information option '-gemb

[PATCH] D92714: Make -fno-pic respect -fno-direct-access-external-data

MaskRay created this revision. MaskRay added reviewers: hjl.tools, rnk, tmsriram. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D92633 added -f[no-]direct-access-external-data to supersede -m[no-

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro created this revision. evandro added reviewers: Hsiang-Kai, craig.topper, rogfer01, frasercrmck. Herald added subscribers: dexonsmith, NickHung, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, e

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. Yes, here's my reply: https://bugs.llvm.org/show_bug.cgi?id=47161#c2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits ma

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. In D92024#2431452 , @Quuxplusone wrote: > The subject line says "access checking on specializations and > instantiations," but I don't see any tests for explicit instantiations here — > just specializations. In particular, I'm ver

<    1   2   3