[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2433999 , @tmsriram wrote: > In D92633#2433979 , @MaskRay wrote: > >> In D92633#2433108 , @tmsriram wrote: >> >>> You said : "The name -mpi

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. In D79773#2434126 , @JohelEGP wrote: > I was a bit late, but thanks for everything! No problem, sorry not for waiting, but let the games begin. P.S. I think I may have left a comment for you over in one of your bugs. not

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman. shafik requested review of this revision. Currently we have a diagnostic that catches the other storage class specifies for the range based for loop declaration but we miss the `thread_local` case. This changes adds a d

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

shafik added a comment. The problem with this approach is given: for (static thread_local int a : A()) {} it just issues one diagnostic and it points to `static` but I am not sure what the right approach to handling this case is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92671/n

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. LGTM. I checked it completely and the patch makes total sense to me. Comment at: clang/include/clang/Driver/Options.td:1866 def fno_pie : Flag<["-"], "fno-pie">, Group; +def fdirect_access_external_data : Flag<["-"], "fdirect-access-external-data">,

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

This revision was automatically updated to reflect the committed changes. Closed by commit rGca2888310b24: Don't use sysroot/include when sysroot is empty. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctionsAvailable`` is set to ``Yes``, ``y`` or non-zero and it is + ``AreS

[clang] ca28883 - Don't use sysroot/include when sysroot is empty.

Author: Hafiz Abid Qadeer Date: 2020-12-04T18:33:24Z New Revision: ca2888310b245d0532d989685a090ae373ee3f93 URL: https://github.com/llvm/llvm-project/commit/ca2888310b245d0532d989685a090ae373ee3f93 DIFF: https://github.com/llvm/llvm-project/commit/ca2888310b245d0532d989685a090ae373ee3f93.diff

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434166 , @tmsriram wrote: > LGTM. I checked it completely and the patch makes total sense to me. Thanks! The name bothers me a bit. There are two parts "direct-access" (direct access relocations like absolute relocati

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. In D92361#2433775 , @Quuxplusone wrote: > In D92361#2433190 , @rjmccall wrote: > >> There is no such thing as an object "teleporting" in C++. Objects are >> always observed in memory with

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

aaron.ballman added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:26 ExampleAttrInfo() { -// Can take an optional string argument (the check that the argument -// actually is a string happens in handleDeclAttribute). -OptArgs = 1; +// Can

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. Sorry just one more thing which is a bit concerning: When I do : $ clang -fPIC -frxternal-data-access foo.c You will omit the GOT but this object can go into a shared object and break the build as this does not apply to shared objects? Should we allow this at all f

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2434212 , @MaskRay wrote: > In D92633#2434166 , @tmsriram wrote: > >> LGTM. I checked it completely and the patch makes total sense to me. > > Thanks! The name bothers me a bit.

[PATCH] D92355: [clang] add a `swift_async_name` attribute

arphaman updated this revision to Diff 309582. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 Files: clang/incl

[PATCH] D92355: [clang] add a `swift_async_name` attribute

arphaman added a comment. In D92355#2429117 , @aaron.ballman wrote: > There's no information in either the attribute definition in Attr.td or in > the documentation as to what subject this attribute applies to. Added a subject list to the attribute.

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 309584. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/inclu

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:39 + + // Check if PrevS < Mut < NextS return MutS && I think this comment should be hoisted above to update the comment on line 32. ==

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra updated this revision to Diff 309585. tra added a comment. Simplified dwarf version clamping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D92617 Files: clang/include/clang/Driver/ToolChain.h clang/lib/

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3957 + RenderDebugEnablingArgs(Args, CmdArgs, DebugInfoKind, + std::min(DWARFVersion, TC.getMaxDwarfVersion()), DebuggerTuning); dbla

[clang] 5b267fb - ADT: Stop peeking inside AlignedCharArrayUnion, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T11:07:42-08:00 New Revision: 5b267fb7966157e0d79ea85cbc1d07f92f840d3c URL: https://github.com/llvm/llvm-project/commit/5b267fb7966157e0d79ea85cbc1d07f92f840d3c DIFF: https://github.com/llvm/llvm-project/commit/5b267fb7966157e0d79ea85cbc1d07f92f84

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434231 , @tmsriram wrote: > Sorry just one more thing which is a bit concerning: > > When I do : > > $ clang -fPIC -frxternal-data-access foo.c > > You will omit the GOT but this object can go into a shared object and b

[PATCH] D92673: [ThinLTO] Remove unused symbol declarations when possible

tejohnson created this revision. tejohnson added a reviewer: wmi. Herald added subscribers: wenlei, arphaman, steven_wu, hiraditya, inglorion, Prazek. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Follow on to D42816

[PATCH] D92658: [libTooling] Add `nodeAsString` stencil for formatting AST nodes for diagnostics.

ymandel updated this revision to Diff 309590. ymandel added a comment. updated name, comments and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92658/new/ https://reviews.llvm.org/D92658 Files: clang/include/clang/Tooling/Transformer/Sten

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 ___ c

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added a comment. Thanks @aaron.ballman to accept my change!!! Hi @jdoerfert, Thank you for your review. it seems you still has request change for for this. I did address your earlier comment in SPIR.h and upload the change. Is there anything else I need to change? Thanks. Jennifer CHA

[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.

tdl-g accepted this revision. tdl-g added a comment. This revision is now accepted and ready to land. Looks great, just one comment. Comment at: clang/unittests/Tooling/StencilTest.cpp:513 +TEST(StencilToStringTest, DescribeOp) { + auto S = describe("Id"); C

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2434267 , @MaskRay wrote: > In D92633#2434231 , @tmsriram wrote: > >> Sorry just one more thing which is a bit concerning: >> >> When I do : >> >> $ clang -fPIC -frxternal-data-a

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

tra reopened this revision. tra added a comment. This revision is now accepted and ready to land. Reopening the tracker for a better fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91807/new/ https://reviews.llvm.org/D91807

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/ExtraSemiCheck.cpp:49 + +void ExtraSemiCheck::registerMatchers(MatchFinder *Finder) { + if (FixerKind == ESFK_Switch) { Something that's not for you to solve, but for us to

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

tra updated this revision to Diff 309595. tra added a comment. Better fix for the early inclusion of Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91807/new/ https://reviews.llvm.org/D91807 Files: clang/lib/Headers/cuda_wrappers/new Index: cla

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

tra requested review of this revision. tra added a comment. @jlebar PTAL. The previous fix did not quite fix the problem. `__device__ operator new/delete` was still not defined, but the issue was not reported due to deferred diags if the functions were not used. Repository: rG LLVM Github Mo

[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.

ymandel added a comment. thanks! Comment at: clang/unittests/Tooling/StencilTest.cpp:513 +TEST(StencilToStringTest, DescribeOp) { + auto S = describe("Id"); tdl-g wrote: > Can you add a comment (or a more detailed test name) explaining what this > test case

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. > I think perhaps we are talking past each other and have reached the limits of > what this sub-thread can hope to achieve. I agree. I am sure that we (or at least you two) could talk about the semantics of "teleportation" and "destructively moving" objects for many m

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

nickdesaulniers added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/ExtraSemiCheck.h:37 + std::vector SuspectMacros; + enum ExtraSemiFixerKind FixerKind; + const std::string ExtraSemiFixerKindName; aaron.ballman wrote: > You can drop th

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

tra updated this revision to Diff 309598. tra added a comment. Removed forgotten pop_macro(__DEVICE__) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91807/new/ https://reviews.llvm.org/D91807 Files: clang/lib/Headers/cuda_wrappers/new Index: cl

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh created this revision. abidh added reviewers: mcarrasco, jroelofs. abidh added a project: clang. Herald added subscribers: s.egerton, PkmX, simoncook, kristof.beyls. abidh requested review of this revision. Herald added a subscriber: cfe-commits. Currently, Baremetal toolchain requires user

[PATCH] D92666: [clang-format] [NFC] keep clang-format tests clang-format clean

HazardyKnusperkeks added a comment. Why is the file mode changed? As far as I know this makes the file executable? (Disclaimer: I'm a primarly windows user.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92666/new/ https://reviews.llvm.org/D92666

[PATCH] D92678: ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Migrate ObjCMT.cpp from using `const FileEntry*` to `FileEntryRef`. This is one of t

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92602/new/ https://reviews.llvm.org/D92602 ___

[PATCH] D92678: ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef

dexonsmith added a comment. The prep commits are: - https://reviews.llvm.org/D92627 (add hashing support for FileEntryRef) - https://reviews.llvm.org/D92630 (use hash_combine in DenseMapInfo EditEntry) - https://reviews.llvm.org/D92676 (hash_value for Optional) Repository: rG LLVM Github Mono

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b5dc150b986: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D92512?vs=309071&id=309600#toc Repos

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. In D92361#2434376 , @zoecarver wrote: >> I think perhaps we are talking past each other and have reached the limits >> of what this sub-thread can hope to achieve. > > I agree. I am sure that we (or at least you two) could talk a

[PATCH] D92666: [clang-format] [NFC] keep clang-format tests clang-format clean

MyDeveloperDay updated this revision to Diff 309602. MyDeveloperDay added a comment. change the mode back CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92666/new/ https://reviews.llvm.org/D92666 Files: clang/unittests/Format/MacroExpanderTest.cpp Index: clang/unittests/Format/Macro

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

thakis added a comment. In D90871#2433804 , @erik.pilkington wrote: > In D90871#2433766 , @thakis wrote: > >> Looks like this breaks tests on Windows: >> http://45.33.8.238/win/29181/step_7.txt >> >> PTAL, and rev

[clang] 4326792 - [CUDA] Another attempt to fix early inclusion of from libstdc++

Author: Artem Belevich Date: 2020-12-04T12:03:35-08:00 New Revision: 43267929423bf768bbbcc65e47a07e37af7f4e22 URL: https://github.com/llvm/llvm-project/commit/43267929423bf768bbbcc65e47a07e37af7f4e22 DIFF: https://github.com/llvm/llvm-project/commit/43267929423bf768bbbcc65e47a07e37af7f4e22.diff

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43267929423b: [CUDA] Another attempt to fix early inclusion of from libstdc++ (authored by tra). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.

tdl-g added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:513 +TEST(StencilToStringTest, DescribeOp) { + auto S = describe("Id"); ymandel wrote: > tdl-g wrote: > > Can you add a comment (or a more detailed test name) explaining what this

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 marked 3 inline comments as done. njames93 added a subscriber: Charusso. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafe

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 updated this revision to Diff 309605. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 Files: clang-tools-extra/docs/clang-tidy/checks/bugprone-argument-

[clang] 88c21f8 - [clang-format] NFC update in the overall clang-formatted status

Author: mydeveloperday Date: 2020-12-04T20:10:10Z New Revision: 88c21f8488646b6809d46c197077cfb40b5ac15b URL: https://github.com/llvm/llvm-project/commit/88c21f8488646b6809d46c197077cfb40b5ac15b DIFF: https://github.com/llvm/llvm-project/commit/88c21f8488646b6809d46c197077cfb40b5ac15b.diff LOG

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman updated this revision to Diff 309611. dgoldman added a comment. - Rebase + refactor, sorry for the long delay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added inline comments. Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:4-5 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared %s -o %dynamiclib1 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared %s -o %dynamiclib2 +// RUN: %clangxx_a

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434337 , @tmsriram wrote: > In D92633#2434267 , @MaskRay wrote: > >> In D92633#2434231 , @tmsriram wrote: >> >>> Sorry just one more thing

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for this cleanup! Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctions

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I think there's still some more work to be done after this which might move some of this around: - DocumentSymbol support: Currently categories show up as (anonymous) or (see here

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added subscribers: scott.linder, JDevlieghere. dblaikie added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22 +// Make sure we do not see any dwarf version other than 2, regardless of what's used on the host side. +// CHECK-NOT: {{-dw

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:276 + // Never ignore these. +} else if (!Context.isCheckEnabled(Error.D

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

dblaikie added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: Are there many uses that rely on this? I don't think it's really worth all this infrastruct

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 309618. ychen added a comment. - fix rebase error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cl

[clang] d10f986 - ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T12:34:49-08:00 New Revision: d10f9863a5ac1cb681af07719650c44b48f289ce URL: https://github.com/llvm/llvm-project/commit/d10f9863a5ac1cb681af07719650c44b48f289ce DIFF: https://github.com/llvm/llvm-project/commit/d10f9863a5ac1cb681af07719650c44b48f2

[PATCH] D92516: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd10f9863a5ac: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC (authored by dexonsmith). Repository: rG LLVM Github Monore

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:105 + + if (!llvm::sys::fs::exists(SysRootDir)) +return std::string(); Why not always add

[PATCH] D92680: Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, JDevlieghere, arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Use `FileManager::getVirtualFileRef` to get the virtual file for stdin, and add an o

[PATCH] D92355: [clang] add a `swift_async_name` attribute

doug.gregor accepted this revision. doug.gregor added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92355: [clang] add a `swift_async_name` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list

[PATCH] D92354: [clang] add a new `swift_attr` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm.org/D92354 __

[clang] 650e04e - [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it.

Author: Sam McCall Date: 2020-12-04T21:54:55+01:00 New Revision: 650e04e179c9d355cd6d8f9a108d60c7969d24ca URL: https://github.com/llvm/llvm-project/commit/650e04e179c9d355cd6d8f9a108d60c7969d24ca DIFF: https://github.com/llvm/llvm-project/commit/650e04e179c9d355cd6d8f9a108d60c7969d24ca.diff LO

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

Quuxplusone added a comment. Spoilsport. ;) LGTM, fwiw. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92671/new/ https://reviews.llvm.org/D92671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D92646: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG650e04e179c9: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12752 Error = 4; break; } Incidentally, why is this case here to begin with? Loop variables can totally be `register`. (But I guess it's moot at this point; clearly no Clang

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: jfb, guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. The variables used in atomic construct should be captured in outer tas

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

sammccall updated this revision to Diff 309630. sammccall marked an inline comment as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92640/new/ https://reviews.llvm.org/D92640 Files: clang/

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92682/new/ https://reviews.llvm.org/D92682

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/include/clang/Tooling/CompilationDatabase.h:194 + static std::unique_ptr + loadFromBuffer(StringRef Path, StringRef Data, std::string &ErrorMsg); + usaxena95 wrote: >

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92439/new/ https://reviews.llvm.org/D92439 ___ cfe-commits mailing list cfe-commits

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

scott.linder added inline comments. Comment at: clang/test/Driver/debug-options.c:364-366 +// GEMBED_2: warning: debug information option '-gembed-source' is not supported for target // NOGEMBED_5-NOT: "-gembed-source" +// NOGEMBED_2-NOT: warning: debug information option '-

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall added a comment. The compilationdatabase changes won't be landed as part of this patch, they've been sent separately for review. I can try the git gymnastics to get them out of this patch, but if you don't mind ignoring them that's easier :-) There might be a sensible way to split thi

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D92671#2434154 , @shafik wrote: > The problem with this approach is given: > > for (static thread_local int a : A()) {} > > it

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2434511 , @MaskRay wrote: > In D92633#2434337 , @tmsriram wrote: > >> In D92633#2434267 , @MaskRay wrote: >> >>> In D92633#2434231

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh updated this revision to Diff 309637. abidh added a comment. Handled review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ https://reviews.llvm.org/D92677 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib/Driver/ToolChains/BareMetal.h clang/test

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh marked an inline comment as done. abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} jroelofs wrote: > Small string has an implicit conversion to std::string, so you can just

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:105 + + return std::string(SysRootDir); +} did `return SysRootDir;` not work? Why do you need the explicit std::string ctor call? CHANGES SINCE LAST ACTION https://reviews

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} abidh wrote: > jroelofs wrote: > > Small string has an implicit conversion to std::string, so you can just > > `return SysRoot

[PATCH] D92661: [RFC] Fix TLS and Coroutine

hoy added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + lxfind wrote: > hoy wrote: > > hoy wrote: > > > With t

[clang] d764ad7 - [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

Author: Alexey Bataev Date: 2020-12-04T13:08:54-08:00 New Revision: d764ad72e5fe7ae1cd9b345ad72f4447355a11b2 URL: https://github.com/llvm/llvm-project/commit/d764ad72e5fe7ae1cd9b345ad72f4447355a11b2 DIFF: https://github.com/llvm/llvm-project/commit/d764ad72e5fe7ae1cd9b345ad72f4447355a11b2.diff

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd764ad72e5fe: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434714 , @tmsriram wrote: > Correct me if I am wrong, but I do see that this behavior is touched. Line > 10 in -fdirect-access-external-data.c : > > // RUN: %clang -### -c -target aarch64 %s -fpic -fdirect-access-exter

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

Charusso added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctionsAvailable`` is set to ``Yes``, ``y`` or non-zero and it is + ``AreSafeFu

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2434766 , @MaskRay wrote: > In D92633#2434714 , @tmsriram wrote: > >> Correct me if I am wrong, but I do see that this behavior is touched. Line >> 10 in -fdirect-access-externa

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22 +// Make sure we do not see any dwarf version other than 2, regardless of what's used on the host side. +// CHECK-NOT: {{-dwarf-version=[^2]}} // CHECK: "-triple" "x86_64 -

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

bruno added a reviewer: bruno. bruno added inline comments. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocName<"M68k">; def m_mips_Features_Group : OptionGroup<"">, Look

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocName<"M68k">; def m_mips_Features_Group : OptionGroup<"">, bruno wrote: > Looks like th

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

bruno added a reviewer: bruno. bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 ___ cfe-commits

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 marked 6 inline comments as done and 2 inline comments as done. njames93 added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: dblaikie wrote: > A

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

scott.linder added inline comments. Comment at: clang/test/Driver/debug-options.c:364-366 +// GEMBED_2: warning: debug information option '-gembed-source' is not supported for target // NOGEMBED_5-NOT: "-gembed-source" +// NOGEMBED_2-NOT: warning: debug information option '-

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 removed a subscriber: Charusso. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctionsAvailable`` is set to ``Yes``, `

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 updated this revision to Diff 309661. njames93 added a comment. Update bugprone-not-null-terminated-result incorrect option name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 Files: clang-tools

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[clang] 1b023f5 - Frontend: Use translateLineCol instead of translateFileLineCol, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:37:48-08:00 New Revision: 1b023f54b61737552242868bdfc385487f1c3e74 URL: https://github.com/llvm/llvm-project/commit/1b023f54b61737552242868bdfc385487f1c3e74 DIFF: https://github.com/llvm/llvm-project/commit/1b023f54b61737552242868bdfc385487f1c

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

<    1   2   3   >