[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

hokein updated this revision to Diff 309469. hokein added a comment. address comment, simplify the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92573/new/ https://reviews.llvm.org/D92573 Files: clang/test/PCH/cxx17-deduction-guide-decl.cp

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

hokein added inline comments. Comment at: clang/test/PCH/cxx17-deduction-guide-decl.cpp:16 + +// Class template argument deduction +template adamcz wrote: > You can drop these 3 lines, they're not needed for the crash repro. Also, > c-tor doesn't have to be exp

[clang] 5b9fc44 - [clang] Add a C++17 deduction guide testcase.

Author: Haojian Wu Date: 2020-12-04T09:02:50+01:00 New Revision: 5b9fc44d8128717ef2f219b061c018abb85c717f URL: https://github.com/llvm/llvm-project/commit/5b9fc44d8128717ef2f219b061c018abb85c717f DIFF: https://github.com/llvm/llvm-project/commit/5b9fc44d8128717ef2f219b061c018abb85c717f.diff LO

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b9fc44d8128: [clang] Add a C++17 deduction guide testcase. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. There is no such thing as an object "teleporting" in C++. Objects are always observed in memory with a specific address. When an argument is passed in registers, its address can be observed to be different on both sides, and that is not permitted; there must be some

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus, steakhal, martong, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall updated this revision to Diff 309474. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 Files: clang-

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. Here is how it looks for that test file: F14534708: report-6ea17d.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 __

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:91 + // Whether a new CDB has been loaded but not broadcast yet. + bool Dirty = false; + // Last loaded CDB, meaningful if CachePopulated is set. kadircet wrote

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added a subscriber: kadircet. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Previously, loading one from a file meant allowing the libr

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong added a comment. It might be worth to extend StmtComparer as well with this Expr. I mean, probably two selections exprs should be considered equal if thei

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong added a comment. In D92600#2433263 , @martong wrote: > It might be worth to extend StmtComparer > > as well with

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. In D79773#2432088 , @miscco wrote: > As someone who has extensively worked with concepts I cannot stress how much > this would improve my live and I'd like to think that this will help even in its current form, but it nee

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

teemperor added a comment. Having the comparison code would be nice. The custom types in the associated types aren't compared by the generic code, so an overload like this in the `StmtComparer` class should be enough: bool IsStmtEquivalent(const GenericSelectionExpr *E1, const GenericSelecti

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. In D92245#2425817 , @emaste wrote: >> How do things go wrong on Darwin? I was under the impression that this was >> implemented in LLVM as strictly inline code, no runtime support required. > > That is my impression as w

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. NamedDecl::getName() asserts the name must be an ide

[clang] c17fdca - [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

Author: Martin Storsjö Date: 2020-12-04T11:34:12+02:00 New Revision: c17fdca1883ddee94c6b7e055428d4445ab13e42 URL: https://github.com/llvm/llvm-project/commit/c17fdca1883ddee94c6b7e055428d4445ab13e42 DIFF: https://github.com/llvm/llvm-project/commit/c17fdca1883ddee94c6b7e055428d4445ab13e42.diff

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

This revision was automatically updated to reflect the committed changes. Closed by commit rGc17fdca1883d: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

OikawaKirie added a comment. It is really a good idea! The operations that would not leave an event in the report are now clearly printed. But there are three arrows that confuse me in the example report: the assignment `x = 0` (x -> 0 -> x), the function call `dereference(x)` (x -> dereferen

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 updated this revision to Diff 309486. njames93 added a comment. Removed const qualifier on Providers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91925/new/ https://reviews.llvm.org/D91925 Files: clang-tools-extra/clangd/ConfigProvide

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Its close Comment at: clang/lib/Format/Format.cpp:751 /*AfterFunction=*/false, /*AfterName

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

njames93 updated this revision to Diff 309489. njames93 added a comment. Made this just focus on the destruction asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files: clang/lib/ASTMatchers/ASTMa

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:190-196 +// Use a custom deleter for the TrueMatcherInstance ManagedStatic. This prevents +// an assert firing when the refcount is nonzero while running its destructor. +struct DynMatcherI

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added a comment. For now without my patch current behavior is the following: Your examples listed below: asm("AA" : "DEF" : "GHI"); asm volatile( "AAA

[PATCH] D92646: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added a subscriber: kadircet. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This function doesn't seem to be used in-tree outside tests

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:949 + {R"cpp(// disallow rename on non-normal identifiers. + @interface Foo {} ---

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2433303 , @OikawaKirie wrote: > It is really a good idea! Thanks 😊 > The operations that would not leave an event in the report are now clearly > printed. > > But there are three arrows that confuse me in the exampl

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 309497. vsavchenko added a comment. Fix incorrect comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h cl

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:41 +const char *getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) +return "C"; Testing for specific C versions seems a bit wei

[PATCH] D92647: Refactor codes and tests to make it work in PCH builds

psionic12 created this revision. psionic12 added reviewers: aaron.ballman, john.brawn. psionic12 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The former codes won't work for cases which PCH involves  in a build workflow, this patch fixes

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

hokein updated this revision to Diff 309506. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92642/new/ https://reviews.llvm.org/D92642 Files: clang-tools-extra/clan

[clang-tools-extra] 445289a - [clangd] Fix an assertion violation in rename.

Author: Haojian Wu Date: 2020-12-04T12:23:26+01:00 New Revision: 445289aa63e1b82b9eea6497fb2d0443813a9d4e URL: https://github.com/llvm/llvm-project/commit/445289aa63e1b82b9eea6497fb2d0443813a9d4e DIFF: https://github.com/llvm/llvm-project/commit/445289aa63e1b82b9eea6497fb2d0443813a9d4e.diff LO

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG445289aa63e1: [clangd] Fix an assertion violation in rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92269: [TableGen] Eliminate the 'code' type

This revision was automatically updated to reflect the committed changes. Closed by commit rG415fab6f67b4: [TableGen] Eliminate the 'code' type (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://re

[PATCH] D92269: [TableGen] Eliminate the 'code' type

silvas added a comment. Wow, awesome work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor testing request. Comment at: clang/lib/AST/ASTTypeTraits.cpp:138 +return ASTNodeKind(NKI_##A##Attr); +#include "clang/Basic/AttrList.inc" + } ymandel wrote: > aaro

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 updated this revision to Diff 309512. njames93 added a comment. Made ManagedStatic code transparent to users for RefCounted objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files: clang/l

[PATCH] D92650: [RISCV] Define preprocessor definitions for 'V' extension.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, asb, luismarques, evandro. Herald added subscribers: frasercrmck, NickHung, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzh

[PATCH] D92650: [RISCV] Define preprocessor definitions for 'V' extension.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92650/new/ https://reviews.llvm.org/D92650 ___

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92384/new/ https://reviews.llvm.org/D92384 __

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 created this revision. njames93 added reviewers: Eugene.Zelenko, aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using bools instead of integers better

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 updated this revision to Diff 309519. njames93 added a comment. Whoops missed one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 Files: clang-tools-extra/docs/clang-tidy/checks/bugprone-argument

[clang] 0519e1d - [HIP] Fix bug in driver about wavefront size

Author: Yaxun (Sam) Liu Date: 2020-12-04T08:36:52-05:00 New Revision: 0519e1ddb3885d070f054ca30a7487f915f6f795 URL: https://github.com/llvm/llvm-project/commit/0519e1ddb3885d070f054ca30a7487f915f6f795 DIFF: https://github.com/llvm/llvm-project/commit/0519e1ddb3885d070f054ca30a7487f915f6f795.dif

[PATCH] D92628: [HIP] Fix bug in driver about wavefront size

This revision was automatically updated to reflect the committed changes. Closed by commit rG0519e1ddb388: [HIP] Fix bug in driver about wavefront size (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:276 + // Never ignore these. +} else if (!Context.isCheckEnabled(Error.DiagnosticName) && + Error.DiagLevel !

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

njames93 updated this revision to Diff 309521. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91885/new/ https://reviews.llvm.org/D91885 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-to

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 updated this revision to Diff 309524. njames93 added a comment. Remove unnecessary comment added in ASTMatchersInternal.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files: clang/lib/ASTMat

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

mitchell-stellar accepted this revision. mitchell-stellar added a comment. I am in favor of landing this and iterating. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing list cfe-

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] 507bbc4 - [AST][NFC] Silence GCC warning about broken strict aliasing rules

Author: Thomas Preud'homme Date: 2020-12-04T14:34:51Z New Revision: 507bbc45bba90fab3f1a2b42e94ae4fbebdd6498 URL: https://github.com/llvm/llvm-project/commit/507bbc45bba90fab3f1a2b42e94ae4fbebdd6498 DIFF: https://github.com/llvm/llvm-project/commit/507bbc45bba90fab3f1a2b42e94ae4fbebdd6498.diff

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

This revision was automatically updated to reflect the committed changes. Closed by commit rG507bbc45bba9: [AST][NFC] Silence GCC warning about broken strict aliasing rules (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92384/new

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

steakhal added a comment. In D90157#2361773 , @ASDenysPetrov wrote: > Who can confirm if this is correct or somewhere it needs fixes? Here is a > generated result of `evalCast` from the origin branch(before the patch): > > void foo(int* x, // &SymRegi

[PATCH] D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Compiler needs to convert some of the loop iteration variables/conditions t

[clang] 090dd64 - [Sema] Fold VLAs to constant arrays in a few more contexts

Author: Erik Pilkington Date: 2020-12-04T10:03:23-05:00 New Revision: 090dd647d98dc50a56a42fbba0f3f11b10a3a187 URL: https://github.com/llvm/llvm-project/commit/090dd647d98dc50a56a42fbba0f3f11b10a3a187 DIFF: https://github.com/llvm/llvm-project/commit/090dd647d98dc50a56a42fbba0f3f11b10a3a187.dif

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

This revision was automatically updated to reflect the committed changes. erik.pilkington marked 3 inline comments as done. Closed by commit rG090dd647d98d: [Sema] Fold VLAs to constant arrays in a few more contexts (authored by erik.pilkington). Herald added a project: clang. Changed prior to co

[PATCH] D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92655/new/ https://reviews.llvm.org/D92655 __

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 _

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 309534. Conanap marked 4 inline comments as done. Conanap added a comment. Removed braces for single lines CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

sylvestre.ledru added a comment. Thanks for doing that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92658: [libTooling] Add `formatNode` stencil for formatting AST nodes for diagnostics.

ymandel created this revision. ymandel added a reviewer: tdl-g. ymandel requested review of this revision. Herald added a project: clang. This new stencil combinator is intended for use in diagnostics and the like. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92658 Files:

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington updated this revision to Diff 309537. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 Files: clang/include/clang-c/Inde

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:718-719 + case NullabilityKind::NullableResult: +assert(!isContextSensitive && + "_Nullable_result isn't supported as context-sensitive keyword"); +return "_Nullable_result";

[clang] 2502f89 - [OPENMP]Fix PR48387: disable warning messages caused by internal conversions.

Author: Alexey Bataev Date: 2020-12-04T07:44:36-08:00 New Revision: 2502f899543151cf3d35c0fa0eef4ba681ad4e77 URL: https://github.com/llvm/llvm-project/commit/2502f899543151cf3d35c0fa0eef4ba681ad4e77 DIFF: https://github.com/llvm/llvm-project/commit/2502f899543151cf3d35c0fa0eef4ba681ad4e77.diff

[PATCH] D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2502f8995431: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/29181/step_7.txt PTAL, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.ll

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

Quuxplusone added a comment. In D92361#2433190 , @rjmccall wrote: > There is no such thing as an object "teleporting" in C++. Objects are always > observed in memory with a specific address. When an argument is passed in > registers, its address can be

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

PiotrFusik requested changes to this revision. PiotrFusik added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_su

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

usaxena95 added inline comments. Comment at: clang/include/clang/Tooling/CompilationDatabase.h:194 + static std::unique_ptr + loadFromBuffer(StringRef Path, StringRef Data, std::string &ErrorMsg); + `Path` is not meaningful for load from buffer. May be change n

[clang] 4fa0dbd - Fix a test failing on windows

Author: Erik Pilkington Date: 2020-12-04T11:20:17-05:00 New Revision: 4fa0dbd6885bc4a48ceecdbb0fca9638792762cf URL: https://github.com/llvm/llvm-project/commit/4fa0dbd6885bc4a48ceecdbb0fca9638792762cf DIFF: https://github.com/llvm/llvm-project/commit/4fa0dbd6885bc4a48ceecdbb0fca9638792762cf.dif

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a comment. In D90871#2433766 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/29181/step_7.txt > > PTAL, and revert while you investigate if it takes a while to fix. Thanks for letting me know, sh

[PATCH] D92658: [libTooling] Add `formatNode` stencil for formatting AST nodes for diagnostics.

ymandel updated this revision to Diff 309542. ymandel added a comment. renamed the combinator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92658/new/ https://reviews.llvm.org/D92658 Files: clang/include/clang/Tooling/Transformer/Stencil.h cla

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the new functionality! You may want to wait a bit before landing to see if @njames93 has any remaining comments. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D92661: [RFC] Fix TLS and Coroutine

lxfind created this revision. Herald added subscribers: hoy, modimo, wenlei, steven_wu, modocache, hiraditya, mgorny. lxfind requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, jdoerfert. Herald added projects: clang

[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

lxfind created this revision. Herald added subscribers: hoy, modimo, wenlei, modocache. lxfind requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to address https://bugs.llvm.org/show_bug.cgi?id=47833 A relevant discussion can al

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this is a good change but would point out that the diagnostic message is pretty confusing as-is. `u8"a"` is a string literal, so saying that a string literal is expected

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few minor NFC changes and a documentation request. Thank you for this! Comment at: clang/docs/LanguageExtensions.rst:623 +C++11 Attributes on

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

abidh added a comment. @jroelofs Do you have any comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 ___ cfe-commits mailing list cfe-commits@

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, jfb, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. When querying the CDB, we stat the u

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

doug.gregor added inline comments. Comment at: clang/test/SemaObjC/nullable-result.m:6 +@class NSError; + +@interface SomeClass Can you add a `__has_attribute` check for `_Nullable_result`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. @JohelEGP can you let me know if you plan to remove the "requested changes" you asked for back in July? I cannot commit with the revision until that is removed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 _

[PATCH] D92661: [RFC] Fix TLS and Coroutine

hoy added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + With the intrinsic, can TLS variable reference in the

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman updated this revision to Diff 309553. arphaman marked 2 inline comments as done. arphaman added a comment. Updated for review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm.org/D92354 Files: clang

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman added a comment. Thanks for taking a look. In D92354#2428604 , @erik.pilkington wrote: > Do we need to add APINotes support for this? Not at the moment, maybe in the future Comment at: clang/include/clang/Basic/Attr.td:2153

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit, thank you! Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11681 + if (isa(Target) != + (NonTag && isa(NonTag))) { +if (!NonTa

[PATCH] D92661: [RFC] Fix TLS and Coroutine

hoy added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + hoy wrote: > With the intrinsic, can TLS variable refe

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added inline comments. Comment at: clang/lib/Format/Format.cpp:893 /*BeforeLambdaBody=*/false, + /*BeforeStructInitialization=*/false, /*BeforeWhile=*/false,

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2433108 , @tmsriram wrote: > You said : "The name -mpie-copy-relocations is misleading [1] and does not > capture the idea that this option can actually apply to all of > -fno-pic,-fpie, ..." > > Could you please clarif

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the testing requests. Comment at: clang/lib/Basic/IdentifierTable.cpp:718-719 + case NullabilityKind::NullableResult: +assert(!isContextSensitive && + "_Nullable_result isn't sup

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2433979 , @MaskRay wrote: > In D92633#2433108 , @tmsriram wrote: > >> You said : "The name -mpie-copy-relocations is misleading [1] and does not >> capture the idea that this opt

[clang] 840e651 - [clang-format] Improve clang-formats handling of concepts

Author: mydeveloperday Date: 2020-12-04T17:45:50Z New Revision: 840e651dc6d7fe652667eb8b4d04ef4daf4769df URL: https://github.com/llvm/llvm-project/commit/840e651dc6d7fe652667eb8b4d04ef4daf4769df DIFF: https://github.com/llvm/llvm-project/commit/840e651dc6d7fe652667eb8b4d04ef4daf4769df.diff LOG

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG840e651dc6d7: [clang-format] Improve clang-formats handling of concepts (authored by MyDeveloperDay). Repository: rG LL

[PATCH] D92666: [clang-format] [NFC] keep clang-format tests clang-format clean

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, sammccall. MyDeveloperDay added a project: clang-format. MyDeveloperDay requested review of this revision. Herald added a project: clang. I use several of the clang-format clean directories as a test suite, this one had

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5940 +void Sema::ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Decl *D) { + FunctionDecl *FD = nullptr; + if (auto *UTemplDecl = dyn_cast(D)) You can also check if the decl is invalid

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 309565. ffrankies added a comment. Implemented changes requested by @aaron.ballman - using `hasAnyName()` instead of multiple `hasName()` calls in the matcher - switched to a combination of `hasAttr<>()` and `getAttr<>()` to remove need for casting and loo

[PATCH] D92661: [RFC] Fix TLS and Coroutine

lxfind added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + hoy wrote: > hoy wrote: > > With the intrinsic, can

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington updated this revision to Diff 309569. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 Files: clang/include/clang-c/Inde

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. I was a bit late, but thanks for everything! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington added inline comments. Comment at: clang/test/SemaObjC/nullable-result.m:6 +@class NSError; + +@interface SomeClass doug.gregor wrote: > Can you add a `__has_attribute` check for `_Nullable_result`? Hmm, it looks like __has_attribute doesn't suppo

  1   2   3   >