[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 308526. zoecarver added a comment. - Update wording in AttrDocs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/AttrDocs.td clang

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patch let clang emit a warning when no --offload-arch option is specified, which usually indicates that users forget to specify this option. https://reviews.llvm.org/D92363 Files: clang

[PATCH] D92016: [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls

shafik added a comment. Great catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92016/new/ https://reviews.llvm.org/D92016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 308536. weiwang added a comment. 1. Fix typo. 2. Minor order adjustment in testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. In D85808#2424588 , @tejohnson wrote: > lgtm with a couple of minor nits noted below that you can fix before > submitting Thanks for pointing them out. Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 93dc1b5 - [Remarks][2/2] Expand remarks hotness threshold option support in more tools

Author: Wei Wang Date: 2020-11-30T21:55:50-08:00 New Revision: 93dc1b5b8cb2f85d0d347f39e49a7150accd4e70 URL: https://github.com/llvm/llvm-project/commit/93dc1b5b8cb2f85d0d347f39e49a7150accd4e70 DIFF: https://github.com/llvm/llvm-project/commit/93dc1b5b8cb2f85d0d347f39e49a7150accd4e70.diff LOG:

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93dc1b5b8cb2: [Remarks][2/2] Expand remarks hotness threshold option support in more tools (authored by weiwang). Repository: rG LLVM Github Monor

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 308550. myhsu marked 5 inline comments as done. myhsu added a comment. - Rebased to latest changes - Addressed some of the feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 308551. myhsu marked 11 inline comments as done. myhsu added a comment. - Rebased to latest changes - Addressed some of the feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clan

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu added inline comments. Comment at: clang/include/clang/Driver/Options.td:3125 +foreach i = {0-4} in + def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group; bruno wrote: > rengolin wrote: > > Same question as @RKSimon had below: Shouldn't this cover all models

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6416 + if (D->hasAttr()) +return true; + I don't think we can just unconditionally check for the attribute. The rule for `trivial_abi` is that it overrides direct sources of non-tri

<    1   2   3