[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett, ormris. saudi requested review of this revision. clang-scan-deps contains some command line parsing and modifications. This patch

[PATCH] D92186: [clangd] AddUsing: do not crash on non-namespace using decls.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92186/new/ https://reviews.llvm.org/D92186 __

[clang-tools-extra] 9d87739 - [clangd] AddUsing: do not crash on non-namespace using decls.

Author: Adam Czachorowski Date: 2020-11-26T20:07:56+01:00 New Revision: 9d87739f664b5b454ff78a3016ab05a1987f0d7c URL: https://github.com/llvm/llvm-project/commit/9d87739f664b5b454ff78a3016ab05a1987f0d7c DIFF: https://github.com/llvm/llvm-project/commit/9d87739f664b5b454ff78a3016ab05a1987f0d7c.d

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

manojgupta added a comment. lgtm but not an expert in this area. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D92186: [clangd] AddUsing: do not crash on non-namespace using decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d87739f664b: [clangd] AddUsing: do not crash on non-namespace using decls. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92186/new/ h

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. After a recent discussion with Khronos on https://github.com/KhronosGroup/OpenCL-Docs/issues/500 and more thinking I start to realize that there is absolutely nothing new in OpenCL 3.0 features as it isn't a new concept at all. They use to be explained as optional cor

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

NeHuang requested changes to this revision. NeHuang added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9189 HasAnyUndefs, 0, !Subtarget.isLittleEndian()); + bool LE = Subtarget

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. TL;DR: clangd has some different concerns than clang, so we really need to approach this as a new feature with some design required (even if a mechanism already exists). The most promising ideas I can think of involve doing the loading at clangd startup based on some

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall updated this revision to Diff 307924. sammccall marked 3 inline comments as done. sammccall added a comment. Return shared_ptr instead of value from cache, to avoid copies. Remove unneeded qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS &TFS, + std::chrono::steady_clock::time_point FreshTime) const { njames93 wrote: > To save a copy, could this not return a c

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2415723 , @glaubitz wrote: > Yeah, @hvdijk has made multiple other improvements which should finally allow > the backend to be usable. > > We still disagree on the search paths for libraries and headers though if I > rem

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS &TFS, + std::chrono::steady_clock::time_point FreshTime) const { sammccall wrote: > njames93 wrote: > > To save a copy, could

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. WIP. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev planned changes to this revision. kbobyrev added a comment. This is not working properly yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-com

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307936. kbobyrev added a comment. Remove some logs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/Index.h clang-tools-extra

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:113 +OptionStack.push_back(std::move(*Config)); +if (!OptionStack.back().InheritParentConfig) + break; njames93 wrote: > sammccall wrote: > > njames93 w

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307942. kbobyrev added a comment. This is working now. However, the handshake is actually deferred for ProjectAwareIndex until the first request. I tried to invoke it via something like `Opts.StaticIdx->estimateMemoryUsage()` in `ClangdMain.cpp` but the probl

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307943. kbobyrev added a comment. Remove unused header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp cla

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo http

[PATCH] D92202: [clangd] Add symbol origin for remote index

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Makes it easier to diagnose remote index is

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 307947. xndcn added a comment. Thanks. Update commit to fix the last nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/HoverT

[clang-tools-extra] abfcb60 - [clangd] Add support for within-file rename of complicated fields

Author: Kirill Bobyrev Date: 2020-11-27T03:59:28+01:00 New Revision: abfcb606c2f86da6dbf25bc260e4d716bc87eaf0 URL: https://github.com/llvm/llvm-project/commit/abfcb606c2f86da6dbf25bc260e4d716bc87eaf0 DIFF: https://github.com/llvm/llvm-project/commit/abfcb606c2f86da6dbf25bc260e4d716bc87eaf0.diff

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGabfcb606c2f8: [clangd] Add support for within-file rename of complicated fields (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/n

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > clangd (and other clang tools) get deployed in environments where all access > to the filesystem goes through a llvm::vfs::Filesystem, and all filenames > referred to in the compile command are within that virtual filesystem rather > than the real one. > (Again, thi

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

nridge added a comment. > What I'm asking specifically is: this feature has a cost, how important is > supporting it? Are there codebases where these attributes are widely used, > and enforcement at development time is particularly valuable? FWIW, one of the codebases I work on uses a clang plu

[PATCH] D91656: [clang-tidy] add concurrency module

lebedev.ri added a comment. In D91656#2418790 , @segoon wrote: > - fix sort order Please always upload all patches with full context (`-U`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 __

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Please upload all patches with full context (`-U`) I'm guessing you'll need help committing this, in which case please specify `Author ` to be used for `git commit --author="<>"` T

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

curdeius accepted this revision. curdeius added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 ___ cfe-commits mailing list cfe-commits@lists.ll

<    1   2