[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, the order of elements in `IncomingLevel2` is not

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. i remember discussing this in the past, and having "negative" feelings about it. I couldn't find the discussion on the issues page tho, could you toss me the link if you can find it? (it might've been an offline discussion as well, sorry if that's the case for not dump

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo htt

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. NVM, found the summary https://github.com/clangd/clangd/issues/162#issuecomment-653981038 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 _

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, kadircet

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, nridge wr

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. Note, the call hierarchy feature is pretty significantly impaired without this. See the example of `Selection::createEach()` discussed in this comment . Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:79 auto IncomingLevel2 = incomingCalls(IncomingLevel1[0].from, Index.get()); - EXPECT_TH

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

nridge updated this revision to Diff 307262. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92009/new/ https://reviews.llvm.org/D92009 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/c

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6f47595bab: [clangd] Sort results of incomingCalls request by container name (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 5b6f475 - [clangd] Sort results of incomingCalls request by container name

Author: Nathan Ridge Date: 2020-11-24T03:29:02-05:00 New Revision: 5b6f47595bab686c6c3351fc1bd1f564add80dbf URL: https://github.com/llvm/llvm-project/commit/5b6f47595bab686c6c3351fc1bd1f564add80dbf DIFF: https://github.com/llvm/llvm-project/commit/5b6f47595bab686c6c3351fc1bd1f564add80dbf.diff

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. sdmitriev requested review of this revision. Use a different container that preserves existing elements on modification for storing temporary file names. Cur

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In some cases system includes extractions is not enough, we als

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. I'm not sure if this solution is elegant enough. I will be happy to hear advices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org/D92012

[PATCH] D91859: [clangd] Fix shared-lib builds

kadircet updated this revision to Diff 307281. kadircet added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Link protobuf and grpc++ publicly to generated targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. Thanks, @arichardson and @jrtc27 for your comments. I am definitely surprised to find that if you explicitly mark the call with the address space, this patch is not required. At first look, this RFC is not required any more but I need sometime to investigate further. If

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

psmith added a comment. Radio silence so far; I think no news is good news applies in this case. I'm happy to say no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein added a comment. I assume this fixes https://github.com/clangd/clangd/issues/582? can you check the static members in template classes etc? I think the AST is different. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:131 +// Clang AST does not store relev

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 307298. LuoYuanke retitled this revision from "[X86] Add x86_amx type for intel AMX. " to "[X86] Add x86_amx type for intel AMX.". LuoYuanke added a comment. Address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 307300. LuoYuanke added a comment. Address Craig's comments. Change dyn_cast to cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 307306. fpetrogalli added a comment. Rebase on top of D92020 . NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 Files: llvm/i

[PATCH] D83698: Port Target option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D8

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307308. jansvoboda11 added a comment. Undo moving of options (NFC) & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files: clang/include/clang/Driver/Opt

[PATCH] D91859: [clangd] Fix shared-lib builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGf726101b6240: [clangd] Fix shared-lib builds (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/ https://reviews.llvm.org/D9185

[clang-tools-extra] f726101 - [clangd] Fix shared-lib builds

Author: Kadir Cetinkaya Date: 2020-11-24T13:05:20+01:00 New Revision: f726101b6240a6740b3c0926af759da5e7336f8a URL: https://github.com/llvm/llvm-project/commit/f726101b6240a6740b3c0926af759da5e7336f8a DIFF: https://github.com/llvm/llvm-project/commit/f726101b6240a6740b3c0926af759da5e7336f8a.dif

[PATCH] D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx

JonChesterfield updated this revision to Diff 307215. JonChesterfield added a comment. Herald added subscribers: llvm-commits, libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, mravishankar, teijeong, frasercrmck, dexonsmith, awarzynski, rdzhabarov, ecnelises, tatianashp, wenle

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added inline comments. Comment at: llvm/lib/IR/DataLayout.cpp:819 + case Type::X86_AMXTyID: +return Align(64); default: Should be 512 bits? Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:79 +// --> +// %addr = alloc

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:164 +} +// %src = call x86_amx @llvm.x86.tileloadd64.internal(%row, %col, %addr, +// %stride); `%src` is not used here. Comment at: llvm

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307317. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve most actionable comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev planned changes to this revision. kbobyrev added a comment. template struct Foo { static T [[Var^iable]]; }; template <> int Foo::[[Variable^]] = 42; template <> bool Foo::[[Variable^]] = true; void foo() { int LocalInt = Foo::[[Variable^]]; bool Local

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. Hi @lenary, Do you any more comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91442/new/ https://reviews.llvm.org/D91442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; What about `llvm::iplist`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 3823665 - [docs] Try to make this bullet list in ThinLTO.rst actually be a bullet list

Author: Hans Wennborg Date: 2020-11-24T14:08:42+01:00 New Revision: 38236656ab4a4bea5e582f709929003abfa1ddcd URL: https://github.com/llvm/llvm-project/commit/38236656ab4a4bea5e582f709929003abfa1ddcd DIFF: https://github.com/llvm/llvm-project/commit/38236656ab4a4bea5e582f709929003abfa1ddcd.diff

[clang] cb08558 - [HIP] Fix regressions due to fp contract change

Author: Yaxun (Sam) Liu Date: 2020-11-24T08:10:06-05:00 New Revision: cb08558caa3bad69213b08e6361586491232c745 URL: https://github.com/llvm/llvm-project/commit/cb08558caa3bad69213b08e6361586491232c745 DIFF: https://github.com/llvm/llvm-project/commit/cb08558caa3bad69213b08e6361586491232c745.dif

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb08558caa3b: [HIP] Fix regressions due to fp contract change (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. Btw how about making some checks simpler. We could always define feature macros `__opencl_c_atomic_scope_device`, `__opencl_c_generic_address_space` for OpenCL 2.0 or C++ for OpenCL . Then everywhere we would only need to check feature macros instead of language vers

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a subscriber: azabaznov. Anastasia added a comment. I assume your change depends on some other changes that add the feature macro definitions. So I think we should link the other changes in at some point. CCing to @azabaznov here who is working on the features too. Repository:

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. In D92004#2412953 , @airlied wrote: > this file has never been clang-format clean, happy to make changes if > reviewer decides they are needed. This has not been considered a conventional clang source so to say, so the coding

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl marked 2 inline comments as done. yaxunl added a comment. ping Comment at: clang/lib/Sema/SemaExpr.cpp:357 + if (LangOpts.CUDAIsDevice) { +auto *FD = dyn_cast_or_null(CurContext); tra wrote: > This could use a comment about why we only check `D->H

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

azabaznov added a comment. Hi! Great to see the interest in OpenCL C 3.0! I'm being working already at a proper feature macros definition to unify both clang and header OpenCL C 3.0 related changes, here is the change:  https://reviews.llvm.org/D89869. So as this patch will be merged then the ch

[PATCH] D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16c0a9a6897: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a subscriber: svenvh. Anastasia added a comment. > It will need some decent review and maybe some testing by other CL users to > make sure I've haven't messed up when used with a fully featured CL 3.0 stack. Clang functionality is expected to be tested in llvm-project and with Op

[PATCH] D92024: [clang] Partially implement P0692R1 from C++20 (access checking on specializations)

aorlov created this revision. aorlov added reviewers: broadwaylamb, rsmith, saar.raz, doug.gregor. aorlov added projects: LLVM, clang. Herald added a subscriber: cfe-commits. aorlov requested review of this revision. Disable usual access checking rules to template argument names in a declaration

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > ro wrote: > > > > MaskRay wrote: > > > > > ro wrote: > >

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaron.ballman added a comment. In D91898#2413004 , @NoQ wrote: >> if the TCB-based functions are a small subset of the code then this >> attribute is better > > Yes, that's exactly the case. We want most functions to be untrusted by > default but also ha

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307327. kbobyrev added a comment. Added support for static templated fields. Ready for the review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files: clang

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 307329. fpetrogalli added a comment. Add comment to `DbgVariableIntrinsic::getFragmentSizeInBits()`. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 Files: ll

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits, thank you for the fix! Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions.cpp:346

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

spatel added a comment. In D88712#2412874 , @venkataramanan.kumar.llvm wrote: > In D88712#2412366 , @MaskRay wrote: > >> In D88712#2411841 , >> @venkataramanan.kumar.llvm w

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli added a comment. Hi @sdesmalen I have extracted D92020 to implement only the change of interface for `AllocaInst::getAllocationSizeInBits`. I wanted to extract also the interface change in `DbgVariableIntrinsic::getFragmentSizeInBits()` but such ch

[PATCH] D92028: Fix driver test from e16c0a9a689719

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. The test failed silently if lld wasn't built alongside clang. But the test uses -###, so the "invalid linker name in -fuse-ld=lld" diag didn't make clang fail, and something else happened to matc

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

erik2020 updated this revision to Diff 307338. erik2020 added a comment. Added doxygen comments to updated functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928 Files: clang/include/clang/Basic/OpenCL

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; ABataev wrote: > What about `llvm::iplist`? It can be changed to iplist as well, but w

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; sdmitriev wrote: > ABataev wrote: > > What about `llvm::iplist`? > It can be changed to

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:308 + if (C.Index.Background == Config::BackgroundPolicy::Auto) +C.Index.Background = Config::BackgroundPolicy::Skip; }); kadircet wrote: > sammc

[PATCH] D92028: Fix driver test from e16c0a9a689719

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/darwin-ld-demangle-lld.c:11 +// RUN: | FileCheck %s +// CHECK: "-demangle" nit: most tests have a blank line between the RUN

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

adamcz updated this revision to Diff 307347. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91966/new/ https://reviews.llvm.org/D91966 Files: clang-tools-e

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:268 + SpelledTokens->back()); + llvm::StringRef NameRef = SpelledRange.text(SM); + kadircet wrote: > what about savi

[PATCH] D91310: [AMDGPU] Add -mcode-object-version=n

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91310/new/ https://reviews.llvm.org/D91310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

gridaphobe updated this revision to Diff 307348. gridaphobe added a comment. Add a couple passing tests involving typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975 Files: clang-tools-extra/clang-t

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307349. njames93 added a comment. Small tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/cla

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. In D92004#2413603 , @Anastasia wrote: > @svenvh I imagine the testing functionality between the two headers will be > identical? Mostly, assuming you intend to test in the conventional way of feeding a .cl file to Clang. Althoug

[PATCH] D92033: [OpenCL] Move kernel arg type tests into one file

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. Keep all kernel parameter type diagnostic tests in `invalid-kernel-parameters.cl`. Repository: rG LLVM Github Monorepo

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

Anastasia added a comment. In D91531#2412532 , @azabaznov wrote: >> So if I understand it well you are suggesting to perform a check for every >> parsed macro definition that would identify whether the macro has a name >> matching what is provided in -cl

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2413688 , @spatel wrote: > In D88712#2412874 , > @venkataramanan.kumar.llvm wrote: > >> In D88712#2412366 , @MaskRay wro

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; ABataev wrote: > sdmitriev wrote: > > ABataev wrote: > > > What about `llvm::iplist`?

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:186 LANGOPT(PPCIEEELongDouble, 1, 0, "use IEEE 754 quadruple-precision for long double") +LANGOPT(EnableAIXExtendedAltivecABI, 1, 0, "__EXTABI__ predefined macro") CO

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92010/new/ https://reviews.llvm.org/D92010 ___ c

[clang] 5ce85e6 - Fix driver test from e16c0a9a689719

Author: Nico Weber Date: 2020-11-24T10:51:08-05:00 New Revision: 5ce85e66358a69e786093756c77fae2e140947c1 URL: https://github.com/llvm/llvm-project/commit/5ce85e66358a69e786093756c77fae2e140947c1 DIFF: https://github.com/llvm/llvm-project/commit/5ce85e66358a69e786093756c77fae2e140947c1.diff LO

[PATCH] D92028: Fix driver test from e16c0a9a689719

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce85e66358a: Fix driver test from e16c0a9a689719 (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D92028?vs=307335&id=307361#toc Repository: rG

[PATCH] D92033: [OpenCL] Move kernel arg type tests into one file

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92033/new/ https://reviews.llvm.org/D92033 ___

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked 5 inline comments as done. dougpuob added a comment. Hi @aaron.ballman and @Eugene.Zelenko, thank you for your suggestions. I will improve them and upload my diff later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ http

[clang-tools-extra] 9e83d0b - [clangd] Mention when CXXThis is implicit in exposed AST.

Author: Sam McCall Date: 2020-11-24T16:57:56+01:00 New Revision: 9e83d0bcdfe86fd13f2817c9f40c5ca0b08f1443 URL: https://github.com/llvm/llvm-project/commit/9e83d0bcdfe86fd13f2817c9f40c5ca0b08f1443 DIFF: https://github.com/llvm/llvm-project/commit/9e83d0bcdfe86fd13f2817c9f40c5ca0b08f1443.diff LO

[PATCH] D91868: [clangd] Mention when CXXThis is implicit in exposed AST.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG9e83d0bcdfe8: [clangd] Mention when CXXThis is implicit in exposed AST. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D91868?vs=3

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. New MachO LLD doesn't implement the old -macos_version_min (etc) flags, but it understands the modern platform_version flag. So make the clang driver pass that when using new MachO LLD. Also, wh

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/ToolChain.h:334 /// LLD's supported flags, error output, etc. - std::string GetLinkerPath(bool *LinkerIsLLD = nullptr) const; + //

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0ca81a6c35: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC] (authored by sdmitriev). Repository: rG LLVM Github

[clang] 1b0ca81 - [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

Author: Sergey Dmitriev Date: 2020-11-24T08:07:31-08:00 New Revision: 1b0ca81a6c358d2d52d4f84b7f42e620ead1ed26 URL: https://github.com/llvm/llvm-project/commit/1b0ca81a6c358d2d52d4f84b7f42e620ead1ed26 DIFF: https://github.com/llvm/llvm-project/commit/1b0ca81a6c358d2d52d4f84b7f42e620ead1ed26.dif

[clang] 9a8386d - clang: Pass -platform-version to new MachO LLD

Author: Nico Weber Date: 2020-11-24T11:16:03-05:00 New Revision: 9a8386dba889b038c23bfc89dd0ff3cf55bbf86a URL: https://github.com/llvm/llvm-project/commit/9a8386dba889b038c23bfc89dd0ff3cf55bbf86a DIFF: https://github.com/llvm/llvm-project/commit/9a8386dba889b038c23bfc89dd0ff3cf55bbf86a.diff LO

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8386dba889: clang: Pass -platform-version to new MachO LLD (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D92037?vs=307365&id=307369#toc Reposi

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

thakis marked an inline comment as done. thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92037/new/ https://reviews.llvm.org/D92037 ___ cfe-commits mailing list cfe-commits@

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added a comment. Adding another reviewer - @wmi can you take a look? This is a straightforward compile time fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/ https://reviews.llvm.org/D91676 __

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko created this revision. vsavchenko added reviewers: aaron.ballman, dexonsmith, rsmith, Bigcheese, rjmccall, NoQ, doug.gregor, ravikandhadai, dcoughlin. Herald added subscribers: cfe-commits, Charusso, mgorny. Herald added a project: clang. vsavchenko requested review of this revision. T

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:268 + SpelledTokens->back()); + llvm::S

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese accepted this revision. Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH);

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT |

[PATCH] D92041: Add hover info for `this` expr

xndcn created this revision. xndcn added reviewers: sammccall, kadircet. xndcn added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. xndcn requested review of this revision. How about add hover information for `this` expr? It

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

spatel added a comment. In D88712#2413877 , @venkataramanan.kumar.llvm wrote: > In D88712#2413688 , @spatel wrote: > >> In D88712#2412874 , >> @venkataramanan.kumar.llvm wr

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 ___

[clang] 44174b3 - [NFC][tests] Replace non-portable grep with FileCheck

Author: Hubert Tong Date: 2020-11-24T12:15:07-05:00 New Revision: 44174b3d518ed70482ff5df2879523a4e26f92cc URL: https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc DIFF: https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc.diff L

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; + ---

[PATCH] D91812: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e4c1cf29388: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends (authored by tejohnson). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall added a comment. @kbobyrev ping... I think we do actually want to land this, for use with `.clang-tidy` files after D91029 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88172/new/ https://reviews.llvm.or

[clang] 6e4c1cf - [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

Author: Teresa Johnson Date: 2020-11-24T09:35:07-08:00 New Revision: 6e4c1cf2938842ceefc2712f0007843369dd16ca URL: https://github.com/llvm/llvm-project/commit/6e4c1cf2938842ceefc2712f0007843369dd16ca DIFF: https://github.com/llvm/llvm-project/commit/6e4c1cf2938842ceefc2712f0007843369dd16ca.diff

[PATCH] D92041: Add hover info for `this` expr

kadircet added a comment. Thanks, this sounds like a sensible idea. I got a few suggestions for the implementation though. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExp

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; + -

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added a comment. OK this looks really great, thanks so much for persisting with this. Comments are mostly simple nits/simplifications, with the exception of `Order` which is a... slightly trickier simplification, but seems worth doing. Tomorrow I'll adapt our internal clang-tidy confi

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay added a comment. In D91760#2413294 , @psmith wrote: > Radio silence so far; I think no news is good news applies in this case. I'm > happy to say no objections. Thanks. I'll commit then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f96fef8 - [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2020-11-24T09:51:32-08:00 New Revision: f96fef89b5eca29f2dc41e97829c20bf742cdcd9 URL: https://github.com/llvm/llvm-project/commit/f96fef89b5eca29f2dc41e97829c20bf742cdcd9 DIFF: https://github.com/llvm/llvm-project/commit/f96fef89b5eca29f2dc41e97829c20bf742cdcd9.diff

  1   2   >