[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGbba96c996555: [clang][AVR] Improve avr-ld command line options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D88410?vs=294872&id=305792#toc Repository: rG LLVM Github Mon

[clang] bba96c9 - [clang][AVR] Improve avr-ld command line options

Author: Ben Shi Date: 2020-11-17T23:28:41+08:00 New Revision: bba96c99655579f5b94abb1e2d07bf2b4b497718 URL: https://github.com/llvm/llvm-project/commit/bba96c99655579f5b94abb1e2d07bf2b4b497718 DIFF: https://github.com/llvm/llvm-project/commit/bba96c99655579f5b94abb1e2d07bf2b4b497718.diff LOG:

Re: [PATCH] D72184: [BPF] support atomic instructions

On 11/17/20 3:23 AM, Brendan Jackman via Phabricator wrote: jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; yonghong-song wro

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

epastor added a comment. LGTM for llvm-ml. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added a comment. Can you mention this change in the release notes? Also, should we document it explicitly in the Language Extensions documentation, or do you think this is too tiny of a feature to warrant that? Comment at: clang/include/clang/Parse/Parser.h:2648

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/cxx0x-attributes.cpp:134 -[[]] using ns::i; // expected-error {{an attribute list cannot appear here}} +[[]] using ns::i; [[unknown]] using namespace ns; // expected-warning {{unknown attribute 'unknown' ignor

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305800. usaxena95 added a comment. Herald added a subscriber: wenlei. Type fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/Clan

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske updated this revision to Diff 305801. balazske added a comment. Improving tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91543/new/ https://reviews.llvm.org/D91543 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305802. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp clang-tools-extra/

[PATCH] D91627: [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91627/new/ https://reviews.llvm.org/D91627 ___

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske added a comment. This checker has multiple weaknesses. There are more cases when the warnings should not appear (probably if the argument of `sizeof` is a template parameter), or more than one warning is generated for a code construct. The test code could be further improved too (but t

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

tejohnson added a comment. I was reviewing the llvm/lib/* changes and note that the new checking is a mix of assert (debug or assert enabled compiler only) and fatal errors (both debug and release compilers). Is that intended? If these are not likely due to user input issues, then perhaps they

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousMemoryComparisonCheck.cpp:76 + "values|the members of the object}1 " + "manually") +<< PointeeQualifiedType << (PointeeType->isRecordType() ? 1 :

[clang] 36011bd - Rename API to not be constrained to template instantiations

Author: Stephen Kelly Date: 2020-11-17T16:28:59Z New Revision: 36011bdfb6486217c45f1b0c7739c1c356ad9592 URL: https://github.com/llvm/llvm-project/commit/36011bdfb6486217c45f1b0c7739c1c356ad9592 DIFF: https://github.com/llvm/llvm-project/commit/36011bdfb6486217c45f1b0c7739c1c356ad9592.diff LOG:

[clang] 34c0f3c - Move ASTMatchFinder definition so it can be accessed from other functions

Author: Stephen Kelly Date: 2020-11-17T16:29:00Z New Revision: 34c0f3cbf1ee025c2e85858b1eb0b0bf1755b569 URL: https://github.com/llvm/llvm-project/commit/34c0f3cbf1ee025c2e85858b1eb0b0bf1755b569 DIFF: https://github.com/llvm/llvm-project/commit/34c0f3cbf1ee025c2e85858b1eb0b0bf1755b569.diff LOG:

[clang] 019723f - Invert accessor for checking traversal mode

Author: Stephen Kelly Date: 2020-11-17T16:28:59Z New Revision: 019723fc295b692af31ced0d8e5c3c1736117de9 URL: https://github.com/llvm/llvm-project/commit/019723fc295b692af31ced0d8e5c3c1736117de9 DIFF: https://github.com/llvm/llvm-project/commit/019723fc295b692af31ced0d8e5c3c1736117de9.diff LOG:

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399753 , @jrtc27 wrote: > In D91442#2399750 , @abidh wrote: > >> In D91442#2399402 , @lenary wrote: >> >>> In D91442#2399341

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

aaron.ballman added a comment. In D91543#2400051 , @balazske wrote: > This checker has multiple weaknesses. There are more cases when the warnings > should not appear (probably if the argument of `sizeof` is a template > parameter), or more than one warn

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305808. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[clang] 4cadb66 - [AST] Update matchers to be traverse-aware

Author: Stephen Kelly Date: 2020-11-17T16:31:08Z New Revision: 4cadb66b490e3323f79a89120c3442456e4c24fa URL: https://github.com/llvm/llvm-project/commit/4cadb66b490e3323f79a89120c3442456e4c24fa DIFF: https://github.com/llvm/llvm-project/commit/4cadb66b490e3323f79a89120c3442456e4c24fa.diff LOG:

[clang] 246b428 - [AST] Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

Author: Stephen Kelly Date: 2020-11-17T16:30:07Z New Revision: 246b428fb3b5d58685064966bcea6592f8839b7e URL: https://github.com/llvm/llvm-project/commit/246b428fb3b5d58685064966bcea6592f8839b7e DIFF: https://github.com/llvm/llvm-project/commit/246b428fb3b5d58685064966bcea6592f8839b7e.diff LOG:

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG246b428fb3b5: [AST] Ignore implicit nodes in IgnoreUnlessSpelledInSource mode (authored by stephenkelly). Changed prior to commit: https://reviews

[PATCH] D90984: Update matchers to be traverse-aware

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cadb66b490e: [AST] Update matchers to be traverse-aware (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D90984?vs=3

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399772 , @lenary wrote: > I recall that there is also https://reviews.llvm.org/D68407 which iirc hoped > to address using `RISCVToolchain` with Compiler-rt and libunwind - presumably > it is not a complete solution, but

[PATCH] D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.

adamcz updated this revision to Diff 305818. adamcz added a comment. Added [clang] in commit description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91162/new/ https://reviews.llvm.org/D91162 Files: clang/lib/AST/ExprConstant.cpp clang/test/

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersRef

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. What about removing the existing AlwaysInlinerPass and replacing it with this one? Or is that something you were planning to do in a follow-up change? > open the opportunity to help the full inliner by performing additional > function passes after the mandatory inlinin

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

tejohnson added a comment. Largely LGTM, except that the clang changes are missing a corresponding test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-c

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305825. usaxena95 added a comment. Refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > yonghong-song wrote: > > jackmanb wrote: > > > jackmanb wrote: > > >

[PATCH] D91642: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions

joechrisellis created this revision. joechrisellis added a reviewer: fpetrogalli. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis requested review of this revision. These were previously missing

[PATCH] D91642: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. HI @joechrisellis - thank you. This LGTM. Please make sure to specify a link to the original patch on phabricator in the commit message before submitting. Repository: rG LLVM Gi

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305835. usaxena95 edited the summary of this revision. usaxena95 added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-ex

[clang] 6ef6bea - Comment out new test while I figure out what is wrong with it

Author: Stephen Kelly Date: 2020-11-17T17:48:48Z New Revision: 6ef6beaa570fffb75c75aa4c555b0f9d7e507929 URL: https://github.com/llvm/llvm-project/commit/6ef6beaa570fffb75c75aa4c555b0f9d7e507929 DIFF: https://github.com/llvm/llvm-project/commit/6ef6beaa570fffb75c75aa4c555b0f9d7e507929.diff LOG:

[PATCH] D91644: [OPENMP]Honor constantness of captured variables.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Fixes bug reported via Stackoverflow: https://stackoverflow.com/questions/6

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

fhahn added a comment. There's still one remaining issue. The backend will still crash when the resulting vector does not fit into the target's vector register directly. But that's the same as with `ext_vector_type` I think. The snippet below should produce the same `asm` call as a `float x 3 x

[clang] 1d7abcf - [AArch64][SVE] Add tests for VLST -> VLAT lax conversions

Author: Joe Ellis Date: 2020-11-17T18:03:42Z New Revision: 1d7abcf99e3d8f9ac7e24be5758da7cfef656400 URL: https://github.com/llvm/llvm-project/commit/1d7abcf99e3d8f9ac7e24be5758da7cfef656400 DIFF: https://github.com/llvm/llvm-project/commit/1d7abcf99e3d8f9ac7e24be5758da7cfef656400.diff LOG: [AA

[PATCH] D91642: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d7abcf99e3d: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions (authored by joechrisellis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2398654 , @ikudrin wrote: > It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the > patch by accident and should be removed. It's weird. The file gets automatically added whenever I commit the file

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers kadircet wrote: > njames93 wrote: > > Would it be wise to speci

[clang] ef1a416 - [Transformer] Split ForStmt test into two

Author: Stephen Kelly Date: 2020-11-17T18:16:10Z New Revision: ef1a4169e8c7f6cf76e704827f4567b9a1b9b0e1 URL: https://github.com/llvm/llvm-project/commit/ef1a4169e8c7f6cf76e704827f4567b9a1b9b0e1 DIFF: https://github.com/llvm/llvm-project/commit/ef1a4169e8c7f6cf76e704827f4567b9a1b9b0e1.diff LOG:

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

thakis added a comment. (usual procedure is to revert while investigating test failures instead of commenting out the tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982

[clang] 0333567 - [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks.

Author: Alexey Bataev Date: 2020-11-17T10:21:12-08:00 New Revision: 0333567c47c0d496bba146cd4f7b65a8ef8ba113 URL: https://github.com/llvm/llvm-project/commit/0333567c47c0d496bba146cd4f7b65a8ef8ba113 DIFF: https://github.com/llvm/llvm-project/commit/0333567c47c0d496bba146cd4f7b65a8ef8ba113.diff

[PATCH] D91627: [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0333567c47c0: [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks. (authored by ABataev). Repository: rG LLVM Github Monorep

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

tra added a reviewer: jlebar. tra added a comment. In D91590#2398842 , @hliao wrote: > This's an experimental or demo-only patch in my spare time on eliminating > private memory usage in https://godbolt.org/z/EPPn6h. The attachment > F14026286: sample.ta

[PATCH] D78903: [Driver] Add option -fproc-stat-report

tschuett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D71341: [VE,#4] Target vector intrinsics

simoll abandoned this revision. simoll added a comment. Herald added subscribers: dang, sstefan1. Herald added a reviewer: libc++. Herald added projects: libc++abi, libunwind. Herald added a reviewer: libc++abi. Herald added a reviewer: libunwind. A good share of VE vector intrinsics have been ups

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

Mordante added a comment. Thanks for the patch! No further comments regarding the patch, except the items Aaron already mentioned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits maili

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

faisalv created this revision. faisalv added reviewers: aaron.ballman, wchilders, bruno, rnk, BRevzin, thakis. faisalv added a project: clang. faisalv requested review of this revision. Currently clang warns on 'assigning' to an enum bit-field that can not accommodate all its enumerators - but no

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire updated this revision to Diff 305863. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersReference.html Index: clang/docs/LibASTMatc

[PATCH] D91580: [Frontend] Add flag to allow PCM generation despite compiler errors

akyrtzi added a comment. I'd like if we only had to use one flag (`-fallow-pcm-with-compiler-errors`) and have it handle both modules and PCH. Could you make the flag also work for PCH and/or add a test that verifies it works? You may only have to change Opts.AllowPCHWithCompilerErrors = Args

[PATCH] D91428: Add support for multiple program address spaces

arsenm added a comment. While the IR definitely should support mixing functions with different address spaces, I don't see the point of encoding multiple of these in the datalayout Comment at: llvm/include/llvm/IR/DataLayout.h:125-129 + /// Vector of address spaces that can c

[PATCH] D91428: Add support for multiple program address spaces

tlively added a comment. @arsenm, Are you suggesting that we just relax the verification rules to allow calling function pointers to arbitrary address spaces without needing any changes to the data layout string? That seems fine to me, but the data layout string solution does allow targets to o

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:8726 +else if (!lhptee->isWideCharType() && + lhptee->hasSignedIntegerRepresentation()) ltrans = S.Context.getCorrespondingUnsignedType(ltrans); I'm wondering whether the

[PATCH] D91656: [clang-tidy] add concurrent module

segoon created this revision. segoon added a reviewer: njames93. Herald added subscribers: cfe-commits, lxfind, arphaman, modocache, xazax.hun, mgorny. Herald added a project: clang. segoon requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2400207 , @aeubanks wrote: > What about removing the existing AlwaysInlinerPass and replacing it with this > one? Or is that something you were planning to do in a follow-up change? That's the plan, yes. >> open the op

[PATCH] D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.

hokein added a comment. oops, this reminds me of the patch https://reviews.llvm.org/D84637 (I should have landed it, sorry), that patch should fix a general recovery-expr crash inside constexpr function body. I think the crash test should be fixed by that (let me check tomorrow). Repository:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

rsmith added a comment. Do `[[deprecated]]` and `[[maybe_unused]]` now work for //using-declarator//s? If so, a test for that would be useful. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:714 - // C++11 attributes are not allowed on a using-declaration, but GNU ones - // a

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson added a comment. Thanks, generally this seems to be good cleanup. Question on one of the changes below though. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Mat

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

leonardchan added a comment. Hi. I suspect it might be this patch or D90984 that might be leading to the test failure we're seeing on our arm64 builders FAIL: Clang-Unit :: AST/./ASTTests/Traverse.IgnoreUnlessSpelledInSourceImplicit (15871 of 26886) **

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Relation.h:31 +/// { Subject = A, Predicate = BaseOf, Object = B }. +/// - "A::Foo is overriden by B::Foo" is represented

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. In D91311#2398526 , @rsmith wrote: > [...] Thanks for your detailed explanation. I did not understand the philosophy of the attribute, and it's now clear to me that it shouldn't be tied to the typedef, indeed. > There's another

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:118 static void removeElseAndBrackets(DiagnosticBuilder &Diag, ASTContext &Context, - const Stmt *Else, SourceLocation ElseLoc) { +

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

aaron.ballman added a comment. Thank you for working on this! Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:10 +bool tryToExtinguish(bool&); +bool tryToExtinguishByVal(bool &); void tryPutFireOut(); Did you mea

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added a comment. In D91630#2400731 , @rsmith wrote: > Do `[[deprecated]]` and `[[maybe_unused]]` now work for > //using-declarator//s? If so, a test for that would be useful. I think the answer is yes and no, respectively (at least in terms

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Matches[1] != "lto") +MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default"));

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

grokos added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks planned changes to this revision. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Matches[1] != "lto") +MPM.addPass(buildO0Def

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 305891. weiwang added a comment. update test case for clang option pass-through Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/CodeG

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 305895. yonghong-song added a comment. use the same register for dst and val for fetch-add, fetch-sub and xchg instructions. for fetch-sub, if it is deemed later using different registers for dst/val is preferred, I can make the change then. Reposito

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

stefanp added a comment. In D91279#2390160 , @shchenz wrote: > Using dform with offset 0 can save one register r0/X0, this is benefit for > register allocation? But adding it in `PPCPreEmitPeephole` pass which is > after register allocation will make the

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 marked 8 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-else-after-return.cpp:313 +#endif +} aaron.ballman wrote: > We should probably add some tests for more pathological case

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 updated this revision to Diff 305897. njames93 marked an inline comment as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91485/new/ https://reviews.llvm.org/D91485 Files: clang-tools-ext

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 updated this revision to Diff 305898. njames93 added a comment. Whoops missed one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91485/new/ https://reviews.llvm.org/D91485 Files: clang-tools-extra/clang-tidy/readability/ElseAfterReturnC

[PATCH] D91656: [clang-tidy] add concurrent module

njames93 added a comment. You have messed up the revisions, this should be the parent, D90944 should be the child. Thats why the build bot can't apply the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/

[PATCH] D91656: [clang-tidy] add concurrent module

lebedev.ri added a comment. I'm not a native english speaker, but i think the module name be `concurrency`, not `concurrent`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___

[PATCH] D91311: Add new 'preferred_name' attribute.

dblaikie added a comment. In D91311#2400775 , @ldionne wrote: > In D91311#2398526 , @rsmith wrote: > >> [...] > > Thanks for your detailed explanation. I did not understand the philosophy of > the attribute, and it

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks updated this revision to Diff 305900. aeubanks added a comment. make build(Thin)LTODefaultPipeline handle O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Ok, it seems like the general opinion here is that libc++ should be changed in some way and not ctor homing. I don't know who'd be responsible for changing the libc++ code, though. Maybe I should file a bug for libc++? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added subscribers: david_stone, mattcalabrese, mpark. ldionne added a comment. In D91311#2400917 , @dblaikie wrote: > How would that work for users - they would get error messages from the > compiler using type names that don't exist in the source

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

ldionne added a comment. Sorry, I read this last week and probably forgot to reply. I think the right thing to do is to fix the UB, which appears to mean fixing libc++. However, can you take a look at whether defining these macros help? // Fix undefined behavior in how __tree stores its end

[PATCH] D91659: Allow anonymous enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

shivanshu3 created this revision. shivanshu3 added reviewers: zahen, tiagoma, rnk, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. shivanshu3 requested review of this revision. Goal: Clang should be able to parse the following code with '-fms-compatibility' because MS

[PATCH] D13673: Add initial support for the MUSL C library.

ldionne added a comment. In D13673#2394187 , @jroelofs wrote: > More context: https://www.openwall.com/lists/musl/2013/03/29/13 Thanks for the context. This is a very puristic point of view from the musl author.. not very useful. There are things that ar

[PATCH] D91660: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global struct.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. The compiler should treat array subscript with base pointer as a first poin

[PATCH] D91660: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global struct.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91660/new/ https://reviews.llvm.org/D91660 ___

[PATCH] D91311: Add new 'preferred_name' attribute.

dblaikie added a comment. In D91311#2400926 , @ldionne wrote: > In D91311#2400917 , @dblaikie wrote: > >> How would that work for users - they would get error messages from the >> compiler using type names that don

[clang] a72f11e - Fix a pair of tests that would fail on a win32 box

Author: Erich Keane Date: 2020-11-17T14:28:52-08:00 New Revision: a72f11ee20fec2df5611c49ec5ec2ce32ab8eb4c URL: https://github.com/llvm/llvm-project/commit/a72f11ee20fec2df5611c49ec5ec2ce32ab8eb4c DIFF: https://github.com/llvm/llvm-project/commit/a72f11ee20fec2df5611c49ec5ec2ce32ab8eb4c.diff L

[clang] 8e923ec - Fix assertions and bad warnings on extremely wide bit-fields.

Author: Richard Smith Date: 2020-11-17T14:36:51-08:00 New Revision: 8e923ec2a803d54154aaa0079c1cfcf146b7a22f URL: https://github.com/llvm/llvm-project/commit/8e923ec2a803d54154aaa0079c1cfcf146b7a22f DIFF: https://github.com/llvm/llvm-project/commit/8e923ec2a803d54154aaa0079c1cfcf146b7a22f.diff

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16443-16446 + const unsigned BitsNeeded = + IsSignedEnum + ? std::max(ED->getNumPositiveBits() + 1, ED->getNumNegativeBits()) + : ED->getNumPositiveBits(); -

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. In D91567#2398637 , @mtrofin wrote: > In D91567#2398623 , @dblaikie wrote: > >> In D91567#2398461 , @mtrofin wrote: >> >>> In D91567#2398440

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); Isn't the `

[PATCH] D87928: Provide -fsource-dir flag in Clang

dexonsmith added a comment. In D87928#2396448 , @phosek wrote: > `-fsource-dir` is only used for coverage mapping and macros. Oh, interesting; it would be nice to consistently make all paths relative paths. > Here `out/default` is the working directory s

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); arichardson w

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

jlebar added a comment. I am legit excited about this if we could figure out how to make it work, but I don't have anything to add beyond what tra said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91590/new/ https://reviews.llvm.org/D91590

[PATCH] D91664: Add a less ambiguous macro for Android version.

danalbert created this revision. danalbert added reviewers: enh, srhines, jiyong. Herald added a project: clang. danalbert requested review of this revision. Android has a handful of API levels relevant to developers described here: https://developer.android.com/studio/build#module-level. `__ANDRO

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2401021 , @dblaikie wrote: > In D91567#2398637 , @mtrofin wrote: > >> In D91567#2398623 , @dblaikie wrote: >> >>> In D91567#2398461

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

kuhar added a comment. Found some cosmetics, but I'm not familiar enough with the NPM to do a full review. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:99 struct CFG { struct BBGuard final : public CallbackVH { BBGuard(const BasicBlock *BB) :

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. In D67112#2398577 , @rsmith wrote: > Looks fine as far as it goes, but it looks like we're also missing a cast in > function pointer initialization via function conversion: > [...] > > |-VarDecl 0x105143e8 col:8 p 'void (*

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); jdoerfert wrote:

<    1   2   3   >