[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev updated this revision to Diff 305047. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91337/new/ https://reviews.llvm.org/D91337 Files: clang-tools

[PATCH] D91368: Frontend: Split out addVFSOverlays from createVFSFromCompilerInvocation, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91368/new/ https://reviews.llvm.org/D91368 ___ cfe-commits mailing list cfe

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

jansvoboda11 added a comment. Getting rid of the duplication is definitely nice. I left one inline question about the terminology used. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal; def

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91366/new/ https://reviews.llvm.org/D91366 ___ cfe-commits mailing list cfe

[PATCH] D91295: Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

jansvoboda11 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91295/new/ https://reviews.llvm.org/D91295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

kadircet added a comment. oops, this is actually a problem of the test. it is providing an invalid encoding :/ sent out https://reviews.llvm.org/D91405 to fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91258/new/ https://reviews.llvm

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. 5th byte of a varint can't be bigger than 0

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added a comment. In D89031#2391248 , @SjoerdMeijer wrote: > In D89031#2391160 , @david-arm wrote: > >> Hi @SjoerdMeijer I think that given we now support scalable vectors we >> thought it made sense to b

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet updated this revision to Diff 305055. kadircet added a comment. - Also fix the high byte Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91405/new/ https://reviews.llvm.org/D91405 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

asavonic added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common sdmitriev wrote: > bader wrote:

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 __

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh updated this revision to Diff 305058. svenvh added a comment. Add test case for OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91348/new/ https://reviews.llvm.org/D91348 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/corou

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2388214 , @glaubitz wrote: > I think it should be good for merging now. I addressed all remarks. I'm still > convinced that "workaround" is the proper term though. Quite the contrary: the comment you cited // FIXME: This

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393312 , @glaubitz wrote: > Ping. It would be nice to get this finally merged so that the testsuite noise > finally goes down on the sparc64 Linux worker. Please be a little more patient: one ping a week is considered appro

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. Any comments for this one? Is this good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

rengolin accepted this revision. rengolin added a comment. Hi @fpetrogalli, the document is so dense that it took me a while to check the macros and I was still wrong. Either I'm losing my skill to read Arm documents or folks are getting worse at writing them. Giving this is a change that only

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393319 , @ro wrote: > In D90524#2388214 , @glaubitz wrote: > >> I think it should be good for merging now. I addressed all remarks. I'm >> still convinced that "workaround" is t

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393320 , @ro wrote: > In D90524#2393312 , @glaubitz wrote: > >> Ping. It would be nice to get this finally merged so that the testsuite >> noise finally goes down on the sparc64

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

t.p.northover added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:1066 if (getTriple().getArch() == llvm::Triple::x86_64 || - getTriple().isAArch64() || getTriple().isRISCV()) + (getTriple().isAArch64() && getTriple().isArch64Bit()) || + getTriple(

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

t.p.northover updated this revision to Diff 305064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91147/new/ https://reviews.llvm.org/D91147 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/frame-pointer-elim.c llvm/include/llvm/ADT/Triple.h llvm/lib/BinaryFormat/MachO.cpp

[PATCH] D91337: [clangd] Add missing tests to rename feature

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:618 + + // Templated method instantiation. + R"cpp( hokein wrote: > nit: we have

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

sammccall added a comment. In D91258#2392646 , @eugenis wrote: > Hi Sam, > > this patch is failing on the ubsan bot with: > > [ RUN ] SerializationTest.NoCrashOnBadArraySize > > /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang-tools-extra/

[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev updated this revision to Diff 305070. kbobyrev added a comment. Move the rest of templated cases to appropriate location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91337/new/ https://reviews.llvm.org/D91337 Files: clang-tools-extra/

[PATCH] D90507: Adding DWARF64 clang flag

jansvoboda11 added a comment. Hi @ayermolo, do you think this might be triggered by D82756 ? (my only upstream patch ATM) Comment at: clang/test/Driver/debug-options.c:377 // NO_DEBUG_UNUSED_TYPES: "-debug-info-kind={{limited|line-tables-only

[clang-tools-extra] a115248 - [clangd] Add missing tests to rename feature

Author: Kirill Bobyrev Date: 2020-11-13T12:27:40+01:00 New Revision: a1152482826c9a80977871aa46e131ac803c5f44 URL: https://github.com/llvm/llvm-project/commit/a1152482826c9a80977871aa46e131ac803c5f44 DIFF: https://github.com/llvm/llvm-project/commit/a1152482826c9a80977871aa46e131ac803c5f44.diff

[PATCH] D91405: [clangd] Assert on varint encoding

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:90 B = consume8(); + assert((B & ~More) < (1 << (32 - Shift)) && "Invalid varint encoding"); Val |= (B & ~More) << Shift; I'm fine with an assert, but

[PATCH] D91337: [clangd] Add missing tests to rename feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1152482826c: [clangd] Add missing tests to rename feature (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

sammccall added a comment. Very nice, thanks for doing this! Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:1 +# If this test fails it means there has been a backward incompatilbe change to +# serialization format. Please bump the version

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet updated this revision to Diff 305094. kadircet marked an inline comment as done. kadircet added a comment. - Increase width of `B` to prevent integer promotion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91405/new/ https://reviews.llvm.

[PATCH] D91405: [clangd] Assert on varint encoding

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:94 B = consume8(); + assert((B & ~More) < (1 << (32 - Shift)) && "Invalid varint encoding"); Val |= (B & ~More) << Shift; hmm, actually it's also inva

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305096. kadircet added a comment. - Update comments - Query for Bar - Only run with zlib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files: clang-tools-extra/cla

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:15 +# indexing sample.cpp would yield non-trivial values for those. +# RUN: dexp %/S/Inputs/sample.idx -c="find B" | grep Bar + as discussed of

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305100. kadircet added a comment. - Drop comment markers - Make failure print the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files: clang-tools-extra/clangd

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro resigned from this revision. ro added a comment. In D90524#2393353 , @glaubitz wrote: > In D90524#2393319 , @ro wrote: > >> In D90524#2388214 , @glaubitz wrote: >> >>> I t

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

OikawaKirie created this revision. OikawaKirie added reviewers: serge-sans-paille, ahmedcharles, niravd, echristo, maskray0, pcc, tejohnson, espindola, courbet, andreadb, epastor, enderby, lhames, whchung, ftynse. OikawaKirie added projects: LLVM, clang, MLIR. Herald added subscribers: llvm-commi

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

ro abandoned this revision. ro added a comment. Herald added a subscriber: pengfei. Superceded by D90524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85582/new/ https://reviews.llvm.org/D85582 __

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393366 , @glaubitz wrote: > In D90524#2393320 , @ro wrote: > >> In D90524#2393312 , @glaubitz wrote: >> >>> Ping. It would be nice to get this

[clang] d2d59d2 - Reland [clang][cli] Port ObjCMTAction to new option parsing system

Author: Jan Svoboda Date: 2020-11-13T13:42:54+01:00 New Revision: d2d59d2be9852b620b982c7304de5d9eaca35404 URL: https://github.com/llvm/llvm-project/commit/d2d59d2be9852b620b982c7304de5d9eaca35404 DIFF: https://github.com/llvm/llvm-project/commit/d2d59d2be9852b620b982c7304de5d9eaca35404.diff L

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. > ! In D90524#2393635 , @ro wrote: > > I had an extremely hard time researching the history of directory layouts for > my patch D85582 . Do as you like, I'm out > of this. Please feel free to re

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 added a comment. Thank you for the heads-up. It seems like Clang 5 didn't like the usage of `static constexpr` member via an instance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 _

[clang] 7ad6c84 - [clang] Fix an assertion crash in delayed access check.

Author: Haojian Wu Date: 2020-11-13T14:02:57+01:00 New Revision: 7ad6c8414ce2c229129c93281835eb9457cf0bfb URL: https://github.com/llvm/llvm-project/commit/7ad6c8414ce2c229129c93281835eb9457cf0bfb DIFF: https://github.com/llvm/llvm-project/commit/7ad6c8414ce2c229129c93281835eb9457cf0bfb.diff LO

[PATCH] D91380: [clang] Fix an assertion crash in delayed access check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ad6c8414ce2: [clang] Fix an assertion crash in delayed access check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305106. kadircet added a comment. - Drop subshell usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files: clang-tools-extra/clangd/test/index-serialization/Inpu

[PATCH] D91311: Add new 'preferred_name' attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. The attribute parts LGTM, but I did have a question about the libc++ parts. Comment at: clang/include/clang/Basic/Attr.td:2367 +def PreferredName : InheritableAttr { + let Spellings = [Clang<"preferred_name">

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet updated this revision to Diff 305108. kadircet added a comment. - Only assert on the 5th byte, prior bytes can have any value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91405/new/ https://reviews.llvm.org/D91405 Files: clang-tools-e

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

fhahn created this revision. fhahn added reviewers: thegameg, paquette, jdoerfert, rjmccall. Herald added subscribers: cfe-commits, dexonsmith, jfb, hiraditya. Herald added projects: clang, LLVM. fhahn requested review of this revision. This patch updates Clang's IRGen to add !annotation nodes wit

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393651 , @glaubitz wrote: > > Please feel free to reach out to the corresponding debian-$ARCH mailing list > for such questions. Debian-specific layouts are not > necessarily obvious at first glance to people not very fa

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393746 , @ro wrote: > In D90524#2393651 , @glaubitz wrote: > >> > > > >> Please feel free to reach out to the corresponding debian-$ARCH mailing list >> for such questions. Deb

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393747 , @glaubitz wrote: > > No worries. I'm glad someone is taking care of the Solaris parts and > appreciate fixes from other parties. My pleasure: hopefully our work will also be for the benefit of the other party.

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common asavonic wrote: > sdmitriev wrote:

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + psionic12 wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > The number of underlines here looks off -- can you verify it's c

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1762 }; +using FDK = FunctionDefinitionKind; rsmith wrote: > I don't think it's OK to have an initialism like this in the `clang` > namespace scope -- generally-speaking, the

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

sammccall added a comment. In D90750#2378987 , @kadircet wrote: > The index has the following query semantics: Rehashing offline conversation: - These heuristics mostly amount to guessing which high-level operation is being performed. It's a non-obvious

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

aaron.ballman added subscribers: jeroen.dobbelaere, jdoerfert, hfinkel. aaron.ballman added a comment. In D91055#2382356 , @lebedev.ri wrote: > CC'ing @rsmith regarding the suggestion/question of also having a clang > diagnostic for this. I'm not Richard

[PATCH] D91311: Add new 'preferred_name' attribute.

Quuxplusone added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { Why does this attribute go on the class template? Shouldn't it be an attribute on the typedef, so that you don't have to repeat yours

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

aaron.ballman added a comment. In D90282#2393019 , @smhc wrote: > In D90282#2391360 , @aaron.ballman > wrote: > >> In D90282#2391005 , @njames93 wrote: >> >>> Should this be

[PATCH] D91421: Fix temporary file name on Windows

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Bound arch may contain ':', which is invalid in Windows file names. This patch fixes that. https://reviews.llvm.org/D91421 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-windows-

[PATCH] D91421: Fix temporary file name on Windows

yaxunl updated this revision to Diff 305127. yaxunl added a comment. add end of line to test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91421/new/ https://reviews.llvm.org/D91421 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-windows-filename.hip Index: clang/test/Dr

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

sammccall added a comment. This looks really sensible to me! Nice you managed to reuse Memoize, there's very little ugly caching/locking left. Comment at: clang-tools-extra/clangd/index/ProjectAware.cpp:81 +return IndexForProject.get( +External.Location, [Server =

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

asavonic added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common bader wrote: > asavonic wrote: >

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 305136. ZarkoCA retitled this revision from "[AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs. " to "[AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. ". ZarkoCA edited the summar

[PATCH] D91428: Add support for multiple program address spaces

pmatos created this revision. pmatos added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jdoerfert, hiraditya, dschuff. Herald added projects: clang, LLVM. pmatos requested review of this revision. Herald added a subscriber: aheejin. Allows for multiple pro

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

svenvh created this revision. svenvh added reviewers: Anastasia, mantognini. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. opencl-c.h disables all extensions at its end, but opencl-c-base.h does not, and that causes any inclusion of onl

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. This is WIP - there a still a few test failures but I am happy to start getting comments on this. This is in preparation for implementation of reference types for the WebAssembly backend that requires functions to be able to live in multiple address spaces. Repository

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:532 Options.EmitCallSiteInfo = CodeGenOpts.EmitCallSiteInfo; + Options.AIXExtendedAltivecABI = CodeGenOpts.AIXExtendedAltivecABI; Options.ValueTrackingVar

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

sfertile added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* bitcast (i32

[clang-tools-extra] 6e7dd1e - [clangd] Assert on varint encoding

Author: Kadir Cetinkaya Date: 2020-11-13T17:01:07+01:00 New Revision: 6e7dd1e3e1170080b76b5dcc5716bdd974343233 URL: https://github.com/llvm/llvm-project/commit/6e7dd1e3e1170080b76b5dcc5716bdd974343233 DIFF: https://github.com/llvm/llvm-project/commit/6e7dd1e3e1170080b76b5dcc5716bdd974343233.dif

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91429/new/ https://reviews.llvm.org/D91429 __

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 305150. ZarkoCA added a comment. Rebased and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/lib/Target/PowerPC/PPCCallingConv.td ll

[PATCH] D91405: [clangd] Assert on varint encoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e7dd1e3e117: [clangd] Assert on varint encoding (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:184 if (TM.isPPC64()) { -if (Subtarget.hasAltivec()) +if (Subtarget.hasAltivec()) { + if (Subtarget.isAIXABI() && !TM.getAIXExtendedAlt

[PATCH] D13673: Add initial support for the MUSL C library.

ldionne added a comment. Herald added subscribers: krytarowski, mgorny. @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd like to get rid of the CMake option -- this isn't the sort of property that we want to set explicitly at configure time, it's the sort of property

[clang-tools-extra] 8741a76 - [clangd] Ensure we test for compatibility of serialized index format

Author: Kadir Cetinkaya Date: 2020-11-13T17:06:23+01:00 New Revision: 8741a76f5dd11ba65fadfd3182da4d365ac15352 URL: https://github.com/llvm/llvm-project/commit/8741a76f5dd11ba65fadfd3182da4d365ac15352 DIFF: https://github.com/llvm/llvm-project/commit/8741a76f5dd11ba65fadfd3182da4d365ac15352.dif

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8741a76f5dd1: [clangd] Ensure we test for compatibility of serialized index format (authored by kadircet). Repository: rG LLVM Github Monorepo CH

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

mantognini added a comment. LGMT as it reduces the divergence in compilation flows. I let @Anastasia, or someone else more familiar with the codebase, give the final approval though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91429/new/ https:/

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao updated this revision to Diff 305154. hliao added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add a note in the AMDGPU usage document on the assumption made here. - Revise the test in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227 + Optional getAssumedAddrSpace(const Value *V) const { +return getTLI()->getTargetMachine().getAssumedAddrSpace(V); hliao wrote: > arsenm wrote: > > We already have a -1

[PATCH] D90507: Adding DWARF64 clang flag

wenlei added a comment. This change covers non-LTO cases. For LTO, I think we would need to pass it from driver to LTO. Something like this: tools::addLTOOptions -> lld -> lto::Config (Config->TargetOptions->MCTargetOptions) ->LTO Backend. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal; def err_fe_pch_file_modified : Error< +"file '%0' has been modified since the " jansvob

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L updated this revision to Diff 305160. Xiangling_L added a comment. Remove the `if` condition and tweak the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 305165. bader added a comment. Remove support for `sycl_constant` address space attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/Ba

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 305167. bader added a comment. Upload full patch after removing `sycl_constant` address space attribute support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files:

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. In D13673#2394064 , @ldionne wrote: > @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd > like to get rid of the CMake option -- this isn't the sort of property that > we want to set explicitly at conf

[clang] 46ca880 - clang: Don't assert on no_unique_address fields in @encode()

Author: Nico Weber Date: 2020-11-13T11:39:10-05:00 New Revision: 46ca880fcae24693d381ca05c16c704675545433 URL: https://github.com/llvm/llvm-project/commit/46ca880fcae24693d381ca05c16c704675545433 DIFF: https://github.com/llvm/llvm-project/commit/46ca880fcae24693d381ca05c16c704675545433.diff LO

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

This revision was automatically updated to reflect the committed changes. Closed by commit rG46ca880fcae2: clang: Don't assert on no_unique_address fields in @encode() (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17141 + Visit(ACO->getTrueExpr()->IgnoreParenImpCasts()) || + Visit(ACO->getFalseExpr()->IgnoreParenImpCasts()); + } It looks like this short-circuits and the fa

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. More context: https://www.openwall.com/lists/musl/2013/03/29/13 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13673/new/ https://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 ___ cfe-commits mailing list cf

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

dexonsmith created this revision. dexonsmith added a reviewer: jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. All three diagnostics have a select between "PCH", "module", and "AST" in the text. The most generic of these is "AST", so rename them fro

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

avieira created this revision. Herald added subscribers: cfe-commits, danielkiss, jfb, kristof.beyls. Herald added a project: clang. avieira requested review of this revision. Hi all, This patch implements the definition of __ARM_FEATURE_ATOMICS and fixes the missing definition of __ARM_FEATURE_

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith updated this revision to Diff 305184. dexonsmith added a comment. Rename to use `ast_` to match https://reviews.llvm.org/D91436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91367/new/ https://reviews.llvm.org/D91367 Files: clang/include/clang/Basic/DiagnosticSerializatio

[clang-tools-extra] 8dc2aa0 - [clangd] Canonicalize LLVM_ENABLE_ZLIB

Author: Kadir Cetinkaya Date: 2020-11-13T18:20:37+01:00 New Revision: 8dc2aa0e412171dad5cdc1aa60a92ddcd3800202 URL: https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202 DIFF: https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202.dif

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 305193. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: jdoerfert. Add support for C++11-style attributes on using-declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

NeHuang added a comment. Please clang-format the patch to pass pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-commits mailing list cfe-

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a reviewer: efriedma. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. This broke the bots: http://lab.llvm.org:8011/#/builders/109/builds/2682 File "/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/tools/extra/clangd/test/lit.site.cfg.py", line 35 config.have_zlib = ^ SyntaxError: invalid syntax Repo

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. should be fixed with  https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202. please let me know if it doesn't work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.l

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:417 + + // should prefer D-form if LXVX / STXVX uses a ZERO or ZERO8 + if (MI.getOpcode() == PPC::LXVX || MI.getOpcode() == PPC::STXVX) { amyk wrote: > Ple

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. In D91330#2394415 , @kadircet wrote: > Looks like it is already green at > http://lab.llvm.org:8011/#/builders/109/builds/2693 Yep, I'm seeing the same, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. Looks like it is already green at http://lab.llvm.org:8011/#/builders/109/builds/2693 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 _

  1   2   >